From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH igt 1/2] lib: Add simple sysfs accessors
Date: Thu, 26 May 2016 17:36:09 +0300
Message-ID: <20160526143609.GT4329@intel.com>
References: <1464272070-23893-1-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id EA17B6E732
 for <intel-gfx@lists.freedesktop.org>; Thu, 26 May 2016 14:38:06 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <1464272070-23893-1-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBNYXkgMjYsIDIwMTYgYXQgMDM6MTQ6MjlQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IGlndF9zeXNmc19zZXQoKSBmb3Igc2V0dGluZyBhbiBhdHRyaWJ1dGUgdmlhIHN5c2Zz
LCBpZ3Rfc3lzZnNfZ2V0KCkgZm9yCj4gcmVhZGluZy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJp
cyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgbGliL01ha2VmaWxl
LnNvdXJjZXMgfCAgIDIgKwo+ICBsaWIvaWd0X3N5c2ZzLmMgICAgICB8IDE0NSArKysrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgbGliL2lndF9zeXNm
cy5oICAgICAgfCAgMzMgKysrKysrKysrKysrCj4gIDMgZmlsZXMgY2hhbmdlZCwgMTgwIGluc2Vy
dGlvbnMoKykKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGxpYi9pZ3Rfc3lzZnMuYwo+ICBjcmVhdGUg
bW9kZSAxMDA2NDQgbGliL2lndF9zeXNmcy5oCj4gCj4gZGlmZiAtLWdpdCBhL2xpYi9NYWtlZmls
ZS5zb3VyY2VzIGIvbGliL01ha2VmaWxlLnNvdXJjZXMKPiBpbmRleCAxMzE2ZmQyLi5mNTBmZjRk
IDEwMDY0NAo+IC0tLSBhL2xpYi9NYWtlZmlsZS5zb3VyY2VzCj4gKysrIGIvbGliL01ha2VmaWxl
LnNvdXJjZXMKPiBAQCAtMTYsNiArMTYsOCBAQCBsaWJpbnRlbF90b29sc19sYV9TT1VSQ0VTID0g
CVwKPiAgCWlndF9ndC5oCQlcCj4gIAlpZ3Rfc3RhdHMuYwkJXAo+ICAJaWd0X3N0YXRzLmgJCVwK
PiArCWlndF9zeXNmcy5jCQlcCj4gKwlpZ3Rfc3lzZnMuaAkJXAo+ICAJaW5zdGRvbmUuYwkJXAo+
ICAJaW5zdGRvbmUuaAkJXAo+ICAJaW50ZWxfYmF0Y2hidWZmZXIuYwlcCj4gZGlmZiAtLWdpdCBh
L2xpYi9pZ3Rfc3lzZnMuYyBiL2xpYi9pZ3Rfc3lzZnMuYwo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0
Cj4gaW5kZXggMDAwMDAwMC4uNGRkNjA4OQo+IC0tLSAvZGV2L251bGwKPiArKysgYi9saWIvaWd0
X3N5c2ZzLmMKPiBAQCAtMCwwICsxLDE0NSBAQAo+ICsvKgo+ICsgKiBDb3B5cmlnaHQgwqkgMjAx
NiBJbnRlbCBDb3Jwb3JhdGlvbgo+ICsgKgo+ICsgKiBQZXJtaXNzaW9uIGlzIGhlcmVieSBncmFu
dGVkLCBmcmVlIG9mIGNoYXJnZSwgdG8gYW55IHBlcnNvbiBvYnRhaW5pbmcgYQo+ICsgKiBjb3B5
IG9mIHRoaXMgc29mdHdhcmUgYW5kIGFzc29jaWF0ZWQgZG9jdW1lbnRhdGlvbiBmaWxlcyAodGhl
ICJTb2Z0d2FyZSIpLAo+ICsgKiB0byBkZWFsIGluIHRoZSBTb2Z0d2FyZSB3aXRob3V0IHJlc3Ry
aWN0aW9uLCBpbmNsdWRpbmcgd2l0aG91dCBsaW1pdGF0aW9uCj4gKyAqIHRoZSByaWdodHMgdG8g
dXNlLCBjb3B5LCBtb2RpZnksIG1lcmdlLCBwdWJsaXNoLCBkaXN0cmlidXRlLCBzdWJsaWNlbnNl
LAo+ICsgKiBhbmQvb3Igc2VsbCBjb3BpZXMgb2YgdGhlIFNvZnR3YXJlLCBhbmQgdG8gcGVybWl0
IHBlcnNvbnMgdG8gd2hvbSB0aGUKPiArICogU29mdHdhcmUgaXMgZnVybmlzaGVkIHRvIGRvIHNv
LCBzdWJqZWN0IHRvIHRoZSBmb2xsb3dpbmcgY29uZGl0aW9uczoKPiArICoKPiArICogVGhlIGFi
b3ZlIGNvcHlyaWdodCBub3RpY2UgYW5kIHRoaXMgcGVybWlzc2lvbiBub3RpY2UgKGluY2x1ZGlu
ZyB0aGUgbmV4dAo+ICsgKiBwYXJhZ3JhcGgpIHNoYWxsIGJlIGluY2x1ZGVkIGluIGFsbCBjb3Bp
ZXMgb3Igc3Vic3RhbnRpYWwgcG9ydGlvbnMgb2YgdGhlCj4gKyAqIFNvZnR3YXJlLgo+ICsgKgo+
ICsgKiBUSEUgU09GVFdBUkUgSVMgUFJPVklERUQgIkFTIElTIiwgV0lUSE9VVCBXQVJSQU5UWSBP
RiBBTlkgS0lORCwgRVhQUkVTUyBPUgo+ICsgKiBJTVBMSUVELCBJTkNMVURJTkcgQlVUIE5PVCBM
SU1JVEVEIFRPIFRIRSBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSwKPiArICogRklUTkVT
UyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQU5EIE5PTklORlJJTkdFTUVOVC4gIElOIE5PIEVW
RU5UIFNIQUxMCj4gKyAqIFRIRSBBVVRIT1JTIE9SIENPUFlSSUdIVCBIT0xERVJTIEJFIExJQUJM
RSBGT1IgQU5ZIENMQUlNLCBEQU1BR0VTIE9SIE9USEVSCj4gKyAqIExJQUJJTElUWSwgV0hFVEhF
UiBJTiBBTiBBQ1RJT04gT0YgQ09OVFJBQ1QsIFRPUlQgT1IgT1RIRVJXSVNFLCBBUklTSU5HCj4g
KyAqIEZST00sIE9VVCBPRiBPUiBJTiBDT05ORUNUSU9OIFdJVEggVEhFIFNPRlRXQVJFIE9SIFRI
RSBVU0UgT1IgT1RIRVIgREVBTElOR1MKPiArICogSU4gVEhFIFNPRlRXQVJFLgo+ICsgKgo+ICsg
Ki8KPiArCj4gKyNpbmNsdWRlIDxpbnR0eXBlcy5oPgo+ICsjaW5jbHVkZSA8c3lzL3N0YXQuaD4K
PiArI2luY2x1ZGUgPHN5cy9tb3VudC5oPgo+ICsjaW5jbHVkZSA8ZXJybm8uaD4KPiArI2luY2x1
ZGUgPHN0ZGlvLmg+Cj4gKyNpbmNsdWRlIDxzdGRsaWIuaD4KPiArI2luY2x1ZGUgPGxpbWl0cy5o
Pgo+ICsjaW5jbHVkZSA8c3RyaW5nLmg+Cj4gKyNpbmNsdWRlIDxmY250bC5oPgo+ICsjaW5jbHVk
ZSA8dW5pc3RkLmg+Cj4gKyNpbmNsdWRlIDxpOTE1X2RybS5oPgo+ICsKPiArI2luY2x1ZGUgImln
dF9zeXNmcy5oIgo+ICsKPiArdHlwZWRlZiBzdHJ1Y3Qgewo+ICsJaW50IGRpcjsKPiArfSBpZ3Rf
c3lzZnNfdDsKPiArCj4gK3N0YXRpYyBpbnQgX19pZ3Rfc3lzZnNfaW5pdCh2b2lkKQo+ICt7Cj4g
KwljaGFyIHBhdGhbMTAyNF07Cj4gKwlzdHJ1Y3Qgc3RhdCBzdDsKCgo+ICsKPiArCWZvciAoaW50
IG4gPSAwOyBuIDwgMTY7IG4rKykgewo+ICsJCWludCBsZW4gPSBzcHJpbnRmKHBhdGgsICIvc3lz
L2NsYXNzL2RybS9jYXJkJWQiLCBuKTsKPiArCQlzcHJpbnRmKHBhdGggKyBsZW4sICIvZXJyb3Ii
KTsKClRoYXQncyBnb2ludCB0byBsaW1pdCB0aGlzIHRvIGk5MTUuIEkgd2FzIHRoaW5raW5nIHdl
IGNvdWxkIHBhc3MKdGhlIGRybV9mZCBoZXJlIHRvIGZpbmQgdGhlIGNvcnJlY3QgbWlub3IgZm9y
IGl0LgoKTWF5YmUgZHJtR2V0RGV2aWNlTmFtZUZyb21GZCgpIGlzIHRoZSByaWdodCB0aGluZyBm
b3IgdGhhdD8KCj4gKwkJaWYgKHN0YXQocGF0aCwgJnN0KSA9PSAwKSB7Cj4gKwkJCXBhdGhbbGVu
XSA9ICdcMCc7Cj4gKwkJCXJldHVybiBvcGVuKHBhdGgsIE9fUkRPTkxZKTsKPiArCQl9Cj4gKwl9
Cj4gKwo+ICsJcmV0dXJuIC0xOwo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50IF9faWd0X3N5c2ZzX3Np
bmdsZXRvbih2b2lkKQo+ICt7Cj4gKwlzdGF0aWMgaW50IHN5c2ZzID0gLTE7Cj4gKwo+ICsJaWYg
KHN5c2ZzID09IC0xKQo+ICsJCXN5c2ZzID0gX19pZ3Rfc3lzZnNfaW5pdCgpOwo+ICsKPiArCXJl
dHVybiBzeXNmczsKPiArfQo+ICsKPiArLyoqCj4gKyAqIGlndF9zeXNmc19zZXQ6Cj4gKyAqIEBm
aWxlbmFtZTogbmFtZSBvZiB0aGUgc3lzZnMgbm9kZSB0byBvcGVuCj4gKyAqIEB2YWx1ZTogdGhl
IHN0cmluZyB0byB3cml0ZQo+ICsgKgo+ICsgKiBUaGlzIHdyaXRlcyB0aGUgdmFsdWUgdG8gdGhl
IHN5c2ZzIGZpbGUuCj4gKyAqCj4gKyAqIFJldHVybnM6Cj4gKyAqIFRydWUgb24gc3VjY2Vzcywg
ZmFsc2Ugb24gZmFpbHVyZS4KPiArICovCj4gK2Jvb2wgaWd0X3N5c2ZzX3NldChjb25zdCBjaGFy
ICpmaWxlbmFtZSwgY29uc3QgY2hhciAqdmFsdWUpCj4gK3sKPiArCWludCBzeXNmcyA9IF9faWd0
X3N5c2ZzX3NpbmdsZXRvbigpOwo+ICsJaW50IGZkLCBsZW4sIHJldDsKPiArCj4gKwlpZiAoc3lz
ZnMgPCAwKQo+ICsJCXJldHVybiBmYWxzZTsKPiArCj4gKwlmZCA9IG9wZW5hdChzeXNmcywgZmls
ZW5hbWUsIE9fV1JPTkxZKTsKPiArCWlmIChmZCA8IDApCj4gKwkJcmV0dXJuIGZhbHNlOwo+ICsK
PiArCWxlbiA9IHN0cmxlbih2YWx1ZSk7Cj4gKwlyZXQgPSB3cml0ZShmZCwgdmFsdWUsIGxlbik7
CgpFSU5UUj8KCj4gKwljbG9zZShmZCk7Cj4gKwo+ICsJcmV0dXJuIGxlbiA9PSByZXQ7Cj4gK30K
PiArCj4gKy8qKgo+ICsgKiBpZ3Rfc3lzZnNfZ2V0Ogo+ICsgKiBAZmlsZW5hbWU6IG5hbWUgb2Yg
dGhlIHN5c2ZzIG5vZGUgdG8gb3Blbgo+ICsgKgo+ICsgKiBUaGlzIHJlYWRzIHRoZSB2YWx1ZSBm
cm9tIHRoZSBzeXNmcyBmaWxlLgo+ICsgKgo+ICsgKiBSZXR1cm5zOgo+ICsgKiBBIG51bC10ZXJt
aW5hdGVkIHN0cmluZywgbXVzdCBiZSBmcmVlZCBieSBjYWxsZXIgYWZ0ZXIgdXNlLCBvciBOVUxM
Cj4gKyAqIG9uIGZhaWx1cmUuCj4gKyAqLwo+ICtjaGFyICppZ3Rfc3lzZnNfZ2V0KGNvbnN0IGNo
YXIgKmZpbGVuYW1lKQo+ICt7Cj4gKwlpbnQgc3lzZnMgPSBfX2lndF9zeXNmc19zaW5nbGV0b24o
KTsKPiArCWNoYXIgKmJ1ZjsKPiArCWludCBsZW4sIG9mZnNldCwgcmVtOwo+ICsJaW50IHJldCwg
ZmQ7Cj4gKwo+ICsJaWYgKHN5c2ZzIDwgMCkKPiArCQlyZXR1cm4gTlVMTDsKPiArCj4gKwlmZCA9
IG9wZW5hdChzeXNmcywgZmlsZW5hbWUsIE9fV1JPTkxZKTsKPiArCWlmIChmZCA8IDApCj4gKwkJ
cmV0dXJuIE5VTEw7Cj4gKwo+ICsJb2Zmc2V0ID0gMDsKPiArCWxlbiA9IDY0Owo+ICsJcmVtID0g
IGxlbiAtIG9mZnNldCAtIDE7Cj4gKwlidWYgPSBtYWxsb2MobGVuKTsKPiArCWlmICghYnVmKQo+
ICsJCXJldHVybiBOVUxMOwo+ICsKPiArCXdoaWxlICgocmV0ID0gcmVhZChmZCwgYnVmICsgb2Zm
c2V0LCByZW0pKSA9PSByZW0pIHsKCkVJTlRSPwoKPiArCQljaGFyICpuZXdidWY7Cj4gKwo+ICsJ
CWxlbiAqPSAyOwo+ICsJCW9mZnNldCArPSByZXQ7Cj4gKwo+ICsJCW5ld2J1ZiA9IHJlYWxsb2Mo
YnVmLCBsZW4pOwo+ICsJCWlmICghbmV3YnVmKQo+ICsJCQlicmVhazsKPiArCj4gKwkJcmVtID0g
bGVuIC0gb2Zmc2V0IC0gMTsKPiArCX0KPiArCj4gKwlidWZbb2Zmc2V0XSA9ICcwJzsKPiArCXJl
dHVybiBidWY7Cj4gK30KPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9zeXNmcy5oIGIvbGliL2lndF9z
eXNmcy5oCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwLi40OGMyMThkCj4g
LS0tIC9kZXYvbnVsbAo+ICsrKyBiL2xpYi9pZ3Rfc3lzZnMuaAo+IEBAIC0wLDAgKzEsMzMgQEAK
PiArLyoKPiArICogQ29weXJpZ2h0IMKpIDIwMTYgSW50ZWwgQ29ycG9yYXRpb24KPiArICoKPiAr
ICogUGVybWlzc2lvbiBpcyBoZXJlYnkgZ3JhbnRlZCwgZnJlZSBvZiBjaGFyZ2UsIHRvIGFueSBw
ZXJzb24gb2J0YWluaW5nIGEKPiArICogY29weSBvZiB0aGlzIHNvZnR3YXJlIGFuZCBhc3NvY2lh
dGVkIGRvY3VtZW50YXRpb24gZmlsZXMgKHRoZSAiU29mdHdhcmUiKSwKPiArICogdG8gZGVhbCBp
biB0aGUgU29mdHdhcmUgd2l0aG91dCByZXN0cmljdGlvbiwgaW5jbHVkaW5nIHdpdGhvdXQgbGlt
aXRhdGlvbgo+ICsgKiB0aGUgcmlnaHRzIHRvIHVzZSwgY29weSwgbW9kaWZ5LCBtZXJnZSwgcHVi
bGlzaCwgZGlzdHJpYnV0ZSwgc3VibGljZW5zZSwKPiArICogYW5kL29yIHNlbGwgY29waWVzIG9m
IHRoZSBTb2Z0d2FyZSwgYW5kIHRvIHBlcm1pdCBwZXJzb25zIHRvIHdob20gdGhlCj4gKyAqIFNv
ZnR3YXJlIGlzIGZ1cm5pc2hlZCB0byBkbyBzbywgc3ViamVjdCB0byB0aGUgZm9sbG93aW5nIGNv
bmRpdGlvbnM6Cj4gKyAqCj4gKyAqIFRoZSBhYm92ZSBjb3B5cmlnaHQgbm90aWNlIGFuZCB0aGlz
IHBlcm1pc3Npb24gbm90aWNlIChpbmNsdWRpbmcgdGhlIG5leHQKPiArICogcGFyYWdyYXBoKSBz
aGFsbCBiZSBpbmNsdWRlZCBpbiBhbGwgY29waWVzIG9yIHN1YnN0YW50aWFsIHBvcnRpb25zIG9m
IHRoZQo+ICsgKiBTb2Z0d2FyZS4KPiArICoKPiArICogVEhFIFNPRlRXQVJFIElTIFBST1ZJREVE
ICJBUyBJUyIsIFdJVEhPVVQgV0FSUkFOVFkgT0YgQU5ZIEtJTkQsIEVYUFJFU1MgT1IKPiArICog
SU1QTElFRCwgSU5DTFVESU5HIEJVVCBOT1QgTElNSVRFRCBUTyBUSEUgV0FSUkFOVElFUyBPRiBN
RVJDSEFOVEFCSUxJVFksCj4gKyAqIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFO
RCBOT05JTkZSSU5HRU1FTlQuICBJTiBOTyBFVkVOVCBTSEFMTAo+ICsgKiBUSEUgQVVUSE9SUyBP
UiBDT1BZUklHSFQgSE9MREVSUyBCRSBMSUFCTEUgRk9SIEFOWSBDTEFJTSwgREFNQUdFUyBPUiBP
VEhFUgo+ICsgKiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQU4gQUNUSU9OIE9GIENPTlRSQUNULCBU
T1JUIE9SIE9USEVSV0lTRSwgQVJJU0lORwo+ICsgKiBGUk9NLCBPVVQgT0YgT1IgSU4gQ09OTkVD
VElPTiBXSVRIIFRIRSBTT0ZUV0FSRSBPUiBUSEUgVVNFIE9SIE9USEVSIERFQUxJTkdTCj4gKyAq
IElOIFRIRSBTT0ZUV0FSRS4KPiArICoKPiArICovCj4gKwo+ICsjaWZuZGVmIF9fSUdUX1NZU0ZT
X0hfXwo+ICsjZGVmaW5lIF9fSUdUX1NZU0ZTX0hfXwo+ICsKPiArI2luY2x1ZGUgPHN0ZGJvb2wu
aD4KPiArCj4gK2Jvb2wgaWd0X3N5c2ZzX3NldChjb25zdCBjaGFyICpmaWxlbmFtZSwgY29uc3Qg
Y2hhciAqdmFsdWUpOwo+ICtjaGFyICppZ3Rfc3lzZnNfZ2V0KGNvbnN0IGNoYXIgKmZpbGVuYW1l
KTsKPiArCj4gKyNlbmRpZiAvKiBfX0lHVF9TWVNGU19IX18gKi8KPiAtLSAKPiAyLjguMQo+IAo+
IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwt
Z2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRw
czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0g
ClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz
dGluZm8vaW50ZWwtZ2Z4Cg==