From: Marius Vlad <marius.c.vlad@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org, joonas.lahtinen@linux.intel.com,
tvrtko.ursulin@linux.intel.com, mika.kuoppala@linux.intel.com,
daniel@ffwll.ch, daniela.doras-prodan@intel.com
Subject: Re: [PATCH i-g-t v2 1/8] tests/gem_exec_flush: Remove tests from BAT.
Date: Mon, 30 May 2016 13:44:52 +0300 [thread overview]
Message-ID: <20160530104452.GA21300@mcvlad-wk.rb.intel.com> (raw)
In-Reply-To: <20160527163715.GD26630@nuc-i3427.alporthouse.com>
[-- Attachment #1.1: Type: text/plain, Size: 1224 bytes --]
The explanation is the same as in the previous series: the GEM tests are
taking too long. Either I sack them under nightly runs or decrease the
runtime. As new tests are added, it will take too long to provide
meaningful output from BAT. There are platforms that reach the timeout
(of 15minutes), and the slowest platform is the one that provides the
runtime for the entire CI system (as we wait and collect the results
from all of them).
Not being able to complete under a 5min makes BAT useless and more than
once you mention that even at their current runtime some GEM tests have
to have a higher runtime to trigger relevant bugs, which in your own
words it makes sense to have them run for (some) extended period of
time. Even though running once per night has some disadvantage if the
tests are reliable if won't be that hard to catch the regression(s).
On Fri, May 27, 2016 at 05:37:15PM +0100, Chris Wilson wrote:
> On Fri, May 27, 2016 at 07:27:46PM +0300, Marius Vlad wrote:
>
> You are lacking an explanation. Please tell me what this test is about
> and why it is not suitable criteria for a basic acceptance test.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-05-30 10:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 16:27 [PATCH i-g-t v2 1/8] tests/gem_exec_flush: Remove tests from BAT Marius Vlad
2016-05-27 16:27 ` [PATCH i-g-t v2 2/8] tests/gem_ctx_switch: Remove test " Marius Vlad
2016-05-27 16:39 ` Chris Wilson
2016-05-27 16:27 ` [PATCH i-g-t v2 3/8] tests/gem_exec_nop: " Marius Vlad
2016-05-27 16:39 ` Chris Wilson
2016-05-31 12:01 ` Tvrtko Ursulin
2016-05-27 16:27 ` [PATCH i-g-t v2 4/8] tests/gem_close_race: Remove basic-threads " Marius Vlad
2016-05-27 16:39 ` Chris Wilson
2016-05-31 12:02 ` Tvrtko Ursulin
2016-05-27 16:27 ` [PATCH i-g-t v2 5/8] tests/gem_sync: Remove basic tests Marius Vlad
2016-05-27 16:40 ` Chris Wilson
2016-05-31 12:04 ` Tvrtko Ursulin
2016-05-27 16:27 ` [PATCH i-g-t v2 6/8] tests/gem_storedw_loop: Remove from BAT Marius Vlad
2016-05-31 12:05 ` Tvrtko Ursulin
2016-05-31 12:18 ` Chris Wilson
2016-05-27 16:27 ` [PATCH i-g-t v2 7/8] tests/gem_tile_pread_basic: Remove gem_tiled_pread_basic " Marius Vlad
2016-05-27 16:27 ` [PATCH i-g-t 8/8] tests/gem_exec_suspend: Remove hibernate " Marius Vlad
2016-05-27 16:38 ` Chris Wilson
2016-05-27 16:37 ` [PATCH i-g-t v2 1/8] tests/gem_exec_flush: Remove tests " Chris Wilson
2016-05-30 10:44 ` Marius Vlad [this message]
2016-05-30 10:50 ` Chris Wilson
2016-05-30 13:58 ` Marius Vlad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160530104452.GA21300@mcvlad-wk.rb.intel.com \
--to=marius.c.vlad@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=daniela.doras-prodan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=mika.kuoppala@linux.intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox