From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/8] drm/i915: Give crtcs and planes actual names (v5)
Date: Mon, 30 May 2016 17:47:07 +0300 [thread overview]
Message-ID: <20160530144706.GL4329@intel.com> (raw)
In-Reply-To: <20160527202145.GA18799@nuc-i3427.alporthouse.com>
On Fri, May 27, 2016 at 09:21:45PM +0100, Chris Wilson wrote:
> On Fri, May 27, 2016 at 08:59:18PM +0300, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > This is the remainder (the i915 specific parts) of my earlier
> > {crtc,plane}->name series [1]. I think at least one i915 specific patch
> > was already merged, and I think I added one or two new ones at some
> > point.
>
> Making the message more informative is always appreciated, and I
> couldn't spot anything blatantly wrong,
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> > I'm not so sure about the last patch. It was somewhat useful in narrowing
> > down some underrun locations and whatnot for me, but normally it might
> > be just noise. So I'm happy to keep it in my private stash for a rainy day
> > if people are fed up with dmesg spam.
>
> If you have a compelling usecase, it's not the worst thing we've ever
> done. If there's no rush, we should try to leverage ftrace, or something
> similar, rather than roll our own partial solution.
I've pushed everything but the last patch to dinq. Thanks for the
review.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-05-30 14:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 17:59 [PATCH 0/8] drm/i915: Give crtcs and planes actual names (v5) ville.syrjala
2016-05-27 17:59 ` [PATCH v2 1/8] drm/i915: Use crtc->name in debug messages ville.syrjala
2016-05-27 17:59 ` [PATCH v2 2/8] drm/i915: Use plane->name in debug prints ville.syrjala
2016-05-27 17:59 ` [PATCH v5 3/8] drm/i915: Set crtc->name to "pipe A", "pipe B", etc ville.syrjala
2016-05-27 17:59 ` [PATCH 4/8] drm/i915: Don't leak primary/cursor planes on crtc init failure ville.syrjala
2016-05-27 17:59 ` [PATCH v3 5/8] drm/i915: Give meaningful names to all the planes ville.syrjala
2016-05-27 17:59 ` [PATCH v3 6/8] drm/i915: Give encoders useful names ville.syrjala
2016-05-27 17:59 ` [PATCH 7/8] drm/i915: kill STANDARD/CURSOR plane screams ville.syrjala
2016-05-27 17:59 ` [PATCH v2 8/8] drm/i915: Add debug prints for encoder modeset hooks ville.syrjala
2016-05-27 18:38 ` Chris Wilson
2016-05-27 20:21 ` [PATCH 0/8] drm/i915: Give crtcs and planes actual names (v5) Chris Wilson
2016-05-30 14:47 ` Ville Syrjälä [this message]
2016-05-28 5:34 ` ✓ Ro.CI.BAT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160530144706.GL4329@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox