From: Daniel Vetter <daniel@ffwll.ch>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 01/10] drm: Initialize a linear gamma table by default
Date: Tue, 31 May 2016 15:24:48 +0200 [thread overview]
Message-ID: <20160531132448.GE7231@phenom.ffwll.local> (raw)
In-Reply-To: <0fcdb04d-da39-6345-d2de-21afbf8d0e92@linux.intel.com>
On Tue, May 31, 2016 at 03:05:32PM +0200, Maarten Lankhorst wrote:
> Op 30-03-16 om 11:51 schreef Daniel Vetter:
> > Code stolen from gma500.
> It would be useful to mention why this is done. :)
>
> But even with this patch it seems the legacy gamma in gamma_get is not very reliable.
> A failed call to gamma_set could leave wrong values in crtc->gamma_store either by calling the ioctl with lut.blue set to NULL, or call gamma_set and interrupt with a signal.
> For atomic color management get_gamma won't be accurate at all if mixed with new color management.
Hm, it's just some safety code I found laying around, and figured that
looks like a good idea. You think it's worth it with some improved commit
message added?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-05-31 13:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 9:51 [PATCH 00/10] legacy gamma code cleanup Daniel Vetter
2016-03-30 9:51 ` [PATCH 01/10] drm: Initialize a linear gamma table by default Daniel Vetter
2016-05-31 13:05 ` Maarten Lankhorst
2016-05-31 13:24 ` Daniel Vetter [this message]
2016-05-31 13:30 ` Maarten Lankhorst
2016-03-30 9:51 ` [PATCH 02/10] drm/fb-helper: Remove dead code in setcolreg Daniel Vetter
2016-05-31 13:09 ` Maarten Lankhorst
2016-05-31 13:25 ` Daniel Vetter
2016-03-30 9:51 ` [PATCH 03/10] drm/armada: Drop fb gamma_set/get functions Daniel Vetter
2016-03-30 11:09 ` Russell King - ARM Linux
2016-03-30 11:19 ` Daniel Vetter
2016-03-30 12:56 ` Russell King - ARM Linux
2016-03-30 15:29 ` Daniel Vetter
2016-03-30 9:51 ` [PATCH 04/10] drm/bochs: Drop fake gamma support Daniel Vetter
2016-04-01 8:37 ` Gerd Hoffmann
2016-03-30 9:51 ` [PATCH 05/10] drm/cirrus: Drop redundnant gamma size check Daniel Vetter
2016-05-31 13:11 ` Maarten Lankhorst
2016-03-30 9:51 ` [PATCH 06/10] drm/msm: Nuke dummy gamma_set/get functions Daniel Vetter
2016-05-31 13:18 ` Maarten Lankhorst
2016-03-30 9:51 ` [PATCH 07/10] drm/virtio: Drop dummy gamma table support Daniel Vetter
2016-04-01 8:38 ` Gerd Hoffmann
2016-04-12 11:14 ` Daniel Vetter
2016-04-12 13:58 ` Emil Velikov
2016-04-12 14:27 ` Julia Lawall
2016-03-30 9:51 ` [PATCH 08/10] drm/imx: Don't set a gamma table size Daniel Vetter
2016-03-30 13:36 ` Philipp Zabel
2016-03-30 9:51 ` [PATCH 09/10] drm/qxl: " Daniel Vetter
2016-05-31 13:17 ` Maarten Lankhorst
2016-05-31 13:27 ` Daniel Vetter
2016-03-30 9:51 ` [PATCH 10/10] drm/tegra: " Daniel Vetter
2016-03-30 12:39 ` Thierry Reding
2016-03-30 15:31 ` Daniel Vetter
2016-03-31 10:33 ` Thierry Reding
2016-03-31 7:15 ` ✗ Fi.CI.BAT: failure for legacy gamma code cleanup Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531132448.GE7231@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox