Re: [PATCH 01/10] drm: Initialize a linear gamma table by default

Daniel Vetter
2016-05-31T13:24:48Z

On Tue, May 31, 2016 at 03:05:32PM +0200, Maarten Lankhorst wrote:
> Op 30-03-16 om 11:51 schreef Daniel Vetter:
> > Code stolen from gma500.
> It would be useful to mention why this is done. :)
>
> But even with this patch it seems the legacy gamma in gamma_get is not very reliable.
> A failed call to gamma_set could leave wrong values in crtc->gamma_store either by calling the ioctl with lut.blue set to NULL, or call gamma_set and interrupt with a signal.
> For atomic color management get_gamma won't be accurate at all if mixed with new color management.

Hm, it's just some safety code I found laying around, and figured that
looks like a good idea. You think it's worth it with some improved commit
message added?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation