From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Silence "unexpected child device config size" for VBT on 845g
Date: Wed, 1 Jun 2016 20:16:49 +0300 [thread overview]
Message-ID: <20160601171649.GH4329@intel.com> (raw)
In-Reply-To: <1464800923-6054-1-git-send-email-chris@chris-wilson.co.uk>
On Wed, Jun 01, 2016 at 06:08:43PM +0100, Chris Wilson wrote:
> My old 845g complains that the child_device_size inside its VBT,
> version 110, is incorrect. Let's fiddle with the version matching such
> that it works with this VBT (i.e. treat BIOS v110 as having the same size
> as v108).
>
> Fixes [drm:intel_bios_init] *ERROR* Unexpected child device config
> size 27 (expected 33 for VBT version 110)
>
> Whether this is correct, no one knows - but it works for this particular
> machine.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Matches how I "fixed" my 830 and 855.
Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_bios.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index 624e755e451f..e04e03b2da84 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -1206,7 +1206,7 @@ parse_device_mapping(struct drm_i915_private *dev_priv,
> }
> if (bdb->version < 106) {
> expected_size = 22;
> - } else if (bdb->version < 109) {
> + } else if (bdb->version < 111) {
> expected_size = 27;
> } else if (bdb->version < 195) {
> BUILD_BUG_ON(sizeof(struct old_child_dev_config) != 33);
> --
> 2.8.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-06-01 17:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 17:08 [PATCH] drm/i915: Silence "unexpected child device config size" for VBT on 845g Chris Wilson
2016-06-01 17:16 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601171649.GH4329@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox