From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 01/20] drm/atomic: Fix remaining places where !funcs->best_encoder is valid Date: Fri, 3 Jun 2016 21:01:51 +0200 Message-ID: <20160603190151.GD7231@phenom.ffwll.local> References: <1464877907-27723-1-git-send-email-boris.brezillon@free-electrons.com> <1464877907-27723-2-git-send-email-boris.brezillon@free-electrons.com> <8671722.LHaiaBNqfE@avalon> <20160603093743.000ef95b@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20160603093743.000ef95b@bbrezillon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Boris Brezillon Cc: Krzysztof Kozlowski , Heiko Stuebner , David Airlie , dri-devel , "open list:VIRTIO CORE, NET..." , Eric Anholt , Thierry Re ding , Laurent Pinchart , Benjamin Gaignard , Daniel Vetter , Alexandre Courbot , linux-samsung-soc , Joonyoung Shim , Alexey Brodkin , Kyungmin Park , "open list:ARM/Rockchip SoC..." , Chen-Yu Tsai , Kukjin Kim , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Stephen List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKdW4gMDMsIDIwMTYgYXQgMDk6Mzc6NDNBTSArMDIwMCwgQm9yaXMgQnJlemlsbG9u IHdyb3RlOgo+IE9uIFRodSwgMiBKdW4gMjAxNiAyMzo1NzowMiArMDIwMAo+IERhbmllbCBWZXR0 ZXIgPGRhbmllbEBmZndsbC5jaD4gd3JvdGU6Cj4gCj4gPiBPbiBUaHUsIEp1biAyLCAyMDE2IGF0 IDExOjA1IFBNLCBMYXVyZW50IFBpbmNoYXJ0Cj4gPiA8bGF1cmVudC5waW5jaGFydEBpZGVhc29u Ym9hcmQuY29tPiB3cm90ZToKPiA+ID4gSGkgQm9yaXMsCj4gPiA+Cj4gPiA+IFRoYW5rIHlvdSBm b3IgdGhlIHBhdGNoLgo+ID4gPgo+ID4gPiBPbiBUaHVyc2RheSAwMiBKdW4gMjAxNiAxNjozMToy OCBCb3JpcyBCcmV6aWxsb24gd3JvdGU6ICAKPiA+ID4+IEFkYXB0IGRybV9waWNrX2NydGNzKCkg YW5kIHVwZGF0ZV9jb25uZWN0b3Jfcm91dGluZygpIHRvIGZhbGxiYWNrIHRvCj4gPiA+PiBkcm1f YXRvbWljX2hlbHBlcl9iZXN0X2VuY29kZXIoKSBpZiBmdW5jcy0+YmVzdF9lbmNvZGVyKCkgaXMg TlVMTCBzbwo+ID4gPj4gdGhhdCBEUk0gZHJpdmVycyBjYW4gbGVhdmUgdGhpcyBob29rIHVuYXNz aWduZWQgaWYgdGhleSBrbm93IHRoZXkgd2FudAo+ID4gPj4gdG8gdXNlIGRybV9hdG9taWNfaGVs cGVyX2Jlc3RfZW5jb2RlcigpLiAgCj4gPiA+Cj4gPiA+IENvdWxkIHlvdSBwbGVhc2UgdXBkYXRl IGluY2x1ZGUvZHJtL2RybV9tb2Rlc2V0X2hlbHBlcl92dGFibGVzLmggdG8gZG9jdW1lbnQKPiA+ ID4gdGhpcyBuZXcgYmVoYXZpb3VyID8gIAo+ID4gCj4gPiBUaGFua3MgZm9yIHJlbWluZGluZyBt ZS4gUGxlYXNlIHVwZGF0ZSBob29rcyBmb3IgYm90aAo+ID4gYXRvbWljX2Jlc3RfZW5jb2RlciBh bmQgYmVzdF9lbmNvZGVyLiBBbHNvIG1lbnRpb24gdGhhdCBpdCdzIG9ubHkKPiA+IG9wdGlvbmFs IGZvciBhdG9taWMgZHJpdmVycy4gVGhlcmUncyBsb3RzIG9mIGV4YW1wbGVzIGluIHRoYXQgZmls ZSBmb3IKPiA+IHRoZSB3b3JkaW5nIHVzdWFsbHkgdXNlZC4KPiAKPiBIbSwgSSBoYXZlbid0IGNo YW5nZWQgYW55dGhpbmcgZm9yIHRoZSAtPmF0b21pY19iZXN0X2VuY29kZXIoKSBob29rLCBvcgo+ IGFtIEkgbWlzc2luZyBzb21ldGhpbmc/CgpCZWZvcmUgeW91IG5lZWRlZCBhdG9taWNfYmVzdF9l bmNvZGVyIG9yIGJlc3RfZW5jb2RlciAod2VsbCB0aGF0J3MgdGhlCmlkZWEgYXQgbGVhc3QpLCBu b3cgYm90aCBhcmUgb3B0aW9uYWwuIEtlcm5lbGRvYyBuZWVkcyB0byBiZSBhZGp1c3RlZCBpbgpi b3RoIHBsYWNlcyB0byBtYXRjaCBuZXcgcmVhbGl0eSBhZnRlciB5b3VyIHBhdGNoLgotRGFuaWVs Cgo+IAo+ID4gCj4gPiA+IFRoZSBvbmx5IGRyYXdiYWNrIEkgc2VlIGluIHRoaXMgcGF0Y2ggaXMg dGhlIGFkZGl0aW9uYWwgb2JqZWN0IGxvb2t1cAo+ID4gPiBwZXJmb3JtZWQgYnkgZHJtX2F0b21p Y19oZWxwZXJfYmVzdF9lbmNvZGVyKCkgYXQgcnVudGltZS4gSSB3b25kZXIgaWYgd2UgY291bGQK PiA+ID4gc29tZWhvdyBjYWNoZSB0aGUgaW5mb3JtYXRpb24sIGFzIHRoZSBhc3NpZ25tZW50IGNh bid0IGNoYW5nZSB3aGVuIHRoZXJlJ3MgYQo+ID4gPiAxOjEgY29ycmVzcG9uZGVuY2UgYmV0d2Vl biBlbmNvZGVycyBhbmQgY29ubmVjdG9ycy4gIAo+ID4gCj4gPiBkcm1fZW5jb2Rlcl9maW5kIGlz IGFuIGlkciBsb29rdXAuIFRoYXQgc2hvdWxkIGJlIHBsZW50eSBmYXN0LAo+ID4gZXNwZWNpYWxs eSBmb3IgbW9kZXNldCBjb2RlLiBVc3VhbGx5IHdoYXQncyB0b28gZXhwZW5zaXZlIGV2ZW4gZm9y Cj4gPiBtb2Rlc2V0IGNvZGUgaXMgbGluZWFyIGxpc3Qgd2Fsa3MuIEJ1dCBDaHJpcyBqdXN0IHN1 Ym1pdHRlZCBwYXRjaGVzIHRvCj4gPiBjb252ZXJ0IG1vc3Qgb2YgdGhlbSBpbnRvIHNpbXBsZSBs b29rdXBzLgo+ID4gLURhbmllbAo+ID4gCj4gPiA+Pj4gU2lnbmVkLW9mZi1ieTogQm9yaXMgQnJl emlsbG9uIDxib3Jpcy5icmV6aWxsb25AZnJlZS1lbGVjdHJvbnMuY29tPiAgCj4gPiA+PiAtLS0K PiA+ID4+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyB8ICA0ICsrKy0KPiA+ ID4+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jICAgICB8IDEzICsrKysrKysrKysr Ky0KPiA+ID4+ICAyIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z KC0pCj4gPiA+Pgo+ID4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWlj X2hlbHBlci5jCj4gPiA+PiBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIGlu ZGV4IGY2YTMzNTAuLjg0OWQwMjkgMTAwNjQ0Cj4gPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v ZHJtX2F0b21pY19oZWxwZXIuYwo+ID4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9t aWNfaGVscGVyLmMKPiA+ID4+IEBAIC0zMDAsOCArMzAwLDEwIEBAIHVwZGF0ZV9jb25uZWN0b3Jf cm91dGluZyhzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZQo+ID4gPj4gKnN0YXRlLCBpZiAoZnVuY3Mt PmF0b21pY19iZXN0X2VuY29kZXIpCj4gPiA+PiAgICAgICAgICAgICAgIG5ld19lbmNvZGVyID0g ZnVuY3MtPmF0b21pY19iZXN0X2VuY29kZXIoY29ubmVjdG9yLAo+ID4gPj4gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbm5lY3Rvcl9zdGF0 ZSk7Cj4gPiA+PiAtICAgICBlbHNlCj4gPiA+PiArICAgICBlbHNlIGlmIChmdW5jcy0+YmVzdF9l bmNvZGVyKQo+ID4gPj4gICAgICAgICAgICAgICBuZXdfZW5jb2RlciA9IGZ1bmNzLT5iZXN0X2Vu Y29kZXIoY29ubmVjdG9yKTsKPiA+ID4+ICsgICAgIGVsc2UKPiA+ID4+ICsgICAgICAgICAgICAg bmV3X2VuY29kZXIgPSBkcm1fYXRvbWljX2hlbHBlcl9iZXN0X2VuY29kZXIoY29ubmVjdG9yKTsK PiA+ID4+Cj4gPiA+PiAgICAgICBpZiAoIW5ld19lbmNvZGVyKSB7Cj4gPiA+PiAgICAgICAgICAg ICAgIERSTV9ERUJVR19BVE9NSUMoIk5vIHN1aXRhYmxlIGVuY29kZXIgZm91bmQgZm9yIFtDT05O RUNUT1I6JWQ6JXNdXG4iLAo+ID4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f ZmJfaGVscGVyLmMKPiA+ID4+IGIvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYyBpbmRl eCA3YzJlYjc1Li5kNDQzODlhIDEwMDY0NAo+ID4gPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9mYl9oZWxwZXIuYwo+ID4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIu Ywo+ID4gPj4gQEAgLTIwMDAsNyArMjAwMCwxOCBAQCBzdGF0aWMgaW50IGRybV9waWNrX2NydGNz KHN0cnVjdCBkcm1fZmJfaGVscGVyCj4gPiA+PiAqZmJfaGVscGVyLCBteV9zY29yZSsrOwo+ID4g Pj4KPiA+ID4+ICAgICAgIGNvbm5lY3Rvcl9mdW5jcyA9IGNvbm5lY3Rvci0+aGVscGVyX3ByaXZh dGU7Cj4gPiA+PiAtICAgICBlbmNvZGVyID0gY29ubmVjdG9yX2Z1bmNzLT5iZXN0X2VuY29kZXIo Y29ubmVjdG9yKTsKPiA+ID4+ICsKPiA+ID4+ICsgICAgIC8qCj4gPiA+PiArICAgICAgKiBJZiB0 aGUgRFJNIGRldmljZSBpbXBsZW1lbnRzIGF0b21pYyBob29rcyBhbmQgLT5iZXN0X2VuY29kZXIo KSBpcwo+ID4gPj4gKyAgICAgICogTlVMTCB3ZSBmYWxsYmFjayB0byB0aGUgZGVmYXVsdCBkcm1f YXRvbWljX2hlbHBlcl9iZXN0X2VuY29kZXIoKQo+ID4gPj4gKyAgICAgICogaGVscGVyLgo+ID4g Pj4gKyAgICAgICovCj4gPiA+PiArICAgICBpZiAoZmJfaGVscGVyLT5kZXYtPm1vZGVfY29uZmln LmZ1bmNzLT5hdG9taWNfY29tbWl0ICYmCj4gPiA+PiArICAgICAgICAgIWNvbm5lY3Rvcl9mdW5j cy0+YmVzdF9lbmNvZGVyKQo+ID4gPj4gKyAgICAgICAgICAgICBlbmNvZGVyID0gZHJtX2F0b21p Y19oZWxwZXJfYmVzdF9lbmNvZGVyKGNvbm5lY3Rvcik7Cj4gPiA+PiArICAgICBlbHNlCj4gPiA+ PiArICAgICAgICAgICAgIGVuY29kZXIgPSBjb25uZWN0b3JfZnVuY3MtPmJlc3RfZW5jb2Rlcihj b25uZWN0b3IpOwo+ID4gPj4gKwo+ID4gPj4gICAgICAgaWYgKCFlbmNvZGVyKQo+ID4gPj4gICAg ICAgICAgICAgICBnb3RvIG91dDsgIAo+ID4gPgo+ID4gPiAtLQo+ID4gPiBSZWdhcmRzLAo+ID4g Pgo+ID4gPiBMYXVyZW50IFBpbmNoYXJ0Cj4gPiA+ICAKPiA+IAo+ID4gCj4gPiAKPiAKPiAKPiAK PiAtLSAKPiBCb3JpcyBCcmV6aWxsb24sIEZyZWUgRWxlY3Ryb25zCj4gRW1iZWRkZWQgTGludXgg YW5kIEtlcm5lbCBlbmdpbmVlcmluZwo+IGh0dHA6Ly9mcmVlLWVsZWN0cm9ucy5jb20KCi0tIApE YW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8v YmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpGcmVlZHJlbm8gbWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVlZHJl bm8K