From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: [PATCH v2 3/9] drm/fb-helper: Improve code readability Date: Tue, 7 Jun 2016 17:26:19 +0200 Message-ID: <20160607152625.9511-4-thierry.reding@gmail.com> References: <20160607152625.9511-1-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160607152625.9511-1-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Xinliang Liu , Chen Feng , intel-gfx@lists.freedesktop.org, Seung-Woo Kim , dri-devel@lists.freedesktop.org, Kyungmin Park , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= List-Id: intel-gfx@lists.freedesktop.org RnJvbTogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KCkFkZCBhIGNvdXBsZSBv ZiB0ZW1wb3JhcnkgdmFyaWFibGVzIGFuZCB1c2Ugc2hvcnRlciBuYW1lcyBmb3IgZXhpc3RpbmcK dmFyaWFibGVzIGluIGRybV9mYl9oZWxwZXJfYWRkX29uZV9jb25uZWN0b3IoKSBmb3IgYmV0dGVy IHJlYWRhYmlsaXR5LgoKU2lnbmVkLW9mZi1ieTogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZp ZGlhLmNvbT4KLS0tCiBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIHwgMjYgKysrKysr KysrKysrKysrKy0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAx MCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBl ci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwppbmRleCAzMDE2NDRkMTIwMTMu LjlhZmQ0MjA4NTk2ZiAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIu YworKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCkBAIC05NSwzMiArOTUsMzgg QEAgc3RhdGljIExJU1RfSEVBRChrZXJuZWxfZmJfaGVscGVyX2xpc3QpOwogICogbW1hcCBwYWdl IHdyaXRlcy4KICAqLwogCi1pbnQgZHJtX2ZiX2hlbHBlcl9hZGRfb25lX2Nvbm5lY3RvcihzdHJ1 Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyLCBzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVj dG9yKQoraW50IGRybV9mYl9oZWxwZXJfYWRkX29uZV9jb25uZWN0b3Ioc3RydWN0IGRybV9mYl9o ZWxwZXIgKmZiX2hlbHBlciwKKwkJCQkgICAgc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3Rv cikKIHsKIAlzdHJ1Y3QgZHJtX2ZiX2hlbHBlcl9jb25uZWN0b3IgKip0ZW1wOwotCXN0cnVjdCBk cm1fZmJfaGVscGVyX2Nvbm5lY3RvciAqZmJfaGVscGVyX2Nvbm5lY3RvcjsKKwlzdHJ1Y3QgZHJt X2ZiX2hlbHBlcl9jb25uZWN0b3IgKmNvbm47CisJdW5zaWduZWQgaW50IGNvdW50OwogCiAJaWYg KCFkcm1fZmJkZXZfZW11bGF0aW9uKQogCQlyZXR1cm4gMDsKIAogCVdBUk5fT04oIW11dGV4X2lz X2xvY2tlZCgmZmJfaGVscGVyLT5kZXYtPm1vZGVfY29uZmlnLm11dGV4KSk7Ci0JaWYgKGZiX2hl bHBlci0+Y29ubmVjdG9yX2NvdW50ICsgMSA+IGZiX2hlbHBlci0+Y29ubmVjdG9yX2luZm9fYWxs b2NfY291bnQpIHsKLQkJdGVtcCA9IGtyZWFsbG9jKGZiX2hlbHBlci0+Y29ubmVjdG9yX2luZm8s IHNpemVvZihzdHJ1Y3QgZHJtX2ZiX2hlbHBlcl9jb25uZWN0b3IgKikgKiAoZmJfaGVscGVyLT5j b25uZWN0b3JfY291bnQgKyAxKSwgR0ZQX0tFUk5FTCk7CisKKwljb3VudCA9IGZiX2hlbHBlci0+ Y29ubmVjdG9yX2NvdW50ICsgMTsKKworCWlmIChjb3VudCA+IGZiX2hlbHBlci0+Y29ubmVjdG9y X2luZm9fYWxsb2NfY291bnQpIHsKKwkJc2l6ZV90IHNpemUgPSBjb3VudCAqIHNpemVvZihjb25u KTsKKworCQl0ZW1wID0ga3JlYWxsb2MoZmJfaGVscGVyLT5jb25uZWN0b3JfaW5mbywgc2l6ZSwg R0ZQX0tFUk5FTCk7CiAJCWlmICghdGVtcCkKIAkJCXJldHVybiAtRU5PTUVNOwogCi0JCWZiX2hl bHBlci0+Y29ubmVjdG9yX2luZm9fYWxsb2NfY291bnQgPSBmYl9oZWxwZXItPmNvbm5lY3Rvcl9j b3VudCArIDE7CisJCWZiX2hlbHBlci0+Y29ubmVjdG9yX2luZm9fYWxsb2NfY291bnQgPSBjb3Vu dDsKIAkJZmJfaGVscGVyLT5jb25uZWN0b3JfaW5mbyA9IHRlbXA7CiAJfQogCi0KLQlmYl9oZWxw ZXJfY29ubmVjdG9yID0ga3phbGxvYyhzaXplb2Yoc3RydWN0IGRybV9mYl9oZWxwZXJfY29ubmVj dG9yKSwgR0ZQX0tFUk5FTCk7Ci0JaWYgKCFmYl9oZWxwZXJfY29ubmVjdG9yKQorCWNvbm4gPSBr emFsbG9jKHNpemVvZigqY29ubiksIEdGUF9LRVJORUwpOworCWlmICghY29ubikKIAkJcmV0dXJu IC1FTk9NRU07CiAKIAlkcm1fY29ubmVjdG9yX3JlZmVyZW5jZShjb25uZWN0b3IpOwotCWZiX2hl bHBlcl9jb25uZWN0b3ItPmNvbm5lY3RvciA9IGNvbm5lY3RvcjsKLQlmYl9oZWxwZXItPmNvbm5l Y3Rvcl9pbmZvW2ZiX2hlbHBlci0+Y29ubmVjdG9yX2NvdW50KytdID0gZmJfaGVscGVyX2Nvbm5l Y3RvcjsKKwljb25uLT5jb25uZWN0b3IgPSBjb25uZWN0b3I7CisJZmJfaGVscGVyLT5jb25uZWN0 b3JfaW5mb1tmYl9oZWxwZXItPmNvbm5lY3Rvcl9jb3VudCsrXSA9IGNvbm47CiAJcmV0dXJuIDA7 CiB9CiBFWFBPUlRfU1lNQk9MKGRybV9mYl9oZWxwZXJfYWRkX29uZV9jb25uZWN0b3IpOwotLSAK Mi44LjMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=