From: Matt Roper <matthew.d.roper@intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915/gen9: Drop invalid WARN() during data rate calculation
Date: Fri, 17 Jun 2016 14:25:11 -0700 [thread overview]
Message-ID: <20160617212511.GH14404@intel.com> (raw)
In-Reply-To: <ca09962a-4d65-3ef7-3202-e48a2a32ad0d@linux.intel.com>
On Mon, Jun 13, 2016 at 11:33:50AM +0200, Maarten Lankhorst wrote:
> Op 10-06-16 om 00:14 schreef Matt Roper:
> > It's possible to have a non-zero plane mask and still wind up with a
> > total data rate of zero. There are two cases where this can happen:
> >
> > * planes are active (from the KMS point of view), but are
> > all fully clipped (positioned offscreen)
> > * the only active plane on a CRTC is the cursor (which is handled
> > independently and not counted into the general data rate computations
> >
> > These are both valid display setups (although unusual), so we need to
> > drop the WARN().
> Is there a testcase that triggers this warn? Something for
> kms_universal_planes perhaps?
I do have the start of a new IGT testcase that generates hundreds of
random display configurations (for the purposes of searching for
watermark corner cases); that test triggers this WARN(), but I haven't
posted it yet.
But having extra subtests in the universal plane test sounds good too;
thanks!
Matt
>
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Testcase: kms_universal_planes.cursor-only-pipe-* (will reply here as a patch)
--
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-06-17 21:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 22:14 [PATCH 0/3] SKL watermark fixes for !fbcon Matt Roper
2016-06-09 22:14 ` [PATCH 1/3] drm/i915/gen9: Initialize intel_state->active_crtcs during WM sanitization Matt Roper
2016-06-13 8:59 ` Maarten Lankhorst
2016-06-13 9:02 ` Maarten Lankhorst
2016-06-13 14:49 ` Daniel Vetter
2016-06-17 21:00 ` Matt Roper
2016-06-20 12:44 ` Daniel Vetter
2016-06-09 22:14 ` [PATCH 2/3] drm/i915/gen9: Compute data rates for all planes on first commit Matt Roper
2016-06-13 9:04 ` Maarten Lankhorst
2016-06-13 14:50 ` Daniel Vetter
2016-06-17 21:03 ` Matt Roper
2016-06-20 12:47 ` Daniel Vetter
2016-06-09 22:14 ` [PATCH 3/3] drm/i915/gen9: Drop invalid WARN() during data rate calculation Matt Roper
2016-06-13 9:33 ` Maarten Lankhorst
2016-06-13 9:38 ` [PATCH i-g-t] kms_universal_plane: Add testcase for when no plane is visible on the crtc Maarten Lankhorst
2016-06-17 21:25 ` Matt Roper [this message]
2016-06-10 6:24 ` ✗ Ro.CI.BAT: failure for SKL watermark fixes for !fbcon Patchwork
2016-06-10 14:20 ` Matt Roper
2016-06-10 7:28 ` [PATCH 0/3] " Jani Nikula
2016-06-10 14:17 ` Matt Roper
2016-06-10 8:48 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160617212511.GH14404@intel.com \
--to=matthew.d.roper@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox