From: Daniel Vetter <daniel@ffwll.ch>
To: Dave Gordon <david.s.gordon@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/guc: don't ever forward VBlank to the GuC
Date: Mon, 20 Jun 2016 14:58:02 +0200 [thread overview]
Message-ID: <20160620125802.GD23520@phenom.ffwll.local> (raw)
In-Reply-To: <1466418211-3459-1-git-send-email-david.s.gordon@intel.com>
On Mon, Jun 20, 2016 at 11:23:31AM +0100, Dave Gordon wrote:
> If a context waiting for VBlank were switched out, the GuC would
> have to receive the VBlank interrupt so that it could resubmit
> the context. However, we don't use the GuC internal scheduler,
> and we always set the CTX_CTRL_INHIBIT_SYN_CTX_SWITCH bit in the
> RING_CONTEXT_CONTROL register, so this case cannot arise.
>
> Consequently, the GuC doesn't need to see VBlanks, and we may be
> waking it up unnecessarily by sending them. So let's not ...
>
> Signed-off-by: Dave Gordon <david.s.gordon@intel.com>
Missing v2, and commit message should mention why we shut vblanks down
entirely for the guc. With that fixed:
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
I'm soonish on vacations, so pls ask Tvrkto or someone else to push.
-Daniel
> ---
> drivers/gpu/drm/i915/intel_guc_loader.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_guc_loader.c b/drivers/gpu/drm/i915/intel_guc_loader.c
> index 8fe96a2..5d989d2 100644
> --- a/drivers/gpu/drm/i915/intel_guc_loader.c
> +++ b/drivers/gpu/drm/i915/intel_guc_loader.c
> @@ -105,8 +105,8 @@ static void direct_interrupts_to_guc(struct drm_i915_private *dev_priv)
> int irqs;
> u32 tmp;
>
> - /* tell all command streamers to forward interrupts and vblank to GuC */
> - irqs = _MASKED_FIELD(GFX_FORWARD_VBLANK_MASK, GFX_FORWARD_VBLANK_ALWAYS);
> + /* tell all command streamers to forward interrupts (but not vblank) to GuC */
> + irqs = _MASKED_FIELD(GFX_FORWARD_VBLANK_MASK, GFX_FORWARD_VBLANK_NEVER);
> irqs |= _MASKED_BIT_ENABLE(GFX_INTERRUPT_STEERING);
> for_each_engine(engine, dev_priv)
> I915_WRITE(RING_MODE_GEN7(engine), irqs);
> --
> 1.9.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-06-20 12:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 13:42 [PATCH] drm/i915/guc: make forwarding of VBlanks conditional Dave Gordon
2016-06-17 13:51 ` Ville Syrjälä
2016-06-17 14:14 ` Daniel Vetter
2016-06-17 15:00 ` Ville Syrjälä
2016-06-20 10:23 ` [PATCH] drm/i915/guc: don't ever forward VBlank to the GuC Dave Gordon
2016-06-20 12:58 ` Daniel Vetter [this message]
2016-06-20 12:57 ` [PATCH] drm/i915/guc: make forwarding of VBlanks conditional Daniel Vetter
2016-06-17 14:37 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-06-20 10:41 ` ✓ Ro.CI.BAT: success for drm/i915/guc: make forwarding of VBlanks conditional (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620125802.GD23520@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=david.s.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox