From: Daniel Vetter <daniel@ffwll.ch>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Thomas Hellstrom <thellstrom@vmware.com>,
DRI Development <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 13/16] drm: Refactor drop/set master code a bit
Date: Mon, 20 Jun 2016 23:07:35 +0200 [thread overview]
Message-ID: <20160620210735.GN23520@phenom.ffwll.local> (raw)
In-Reply-To: <CACvgo50xfOn3Ki6VYVLK+PGoCXpgsQVwrd=YA0UwcWVRtaadsw@mail.gmail.com>
On Sat, Jun 18, 2016 at 12:47:21AM +0100, Emil Velikov wrote:
> On 18 June 2016 at 00:00, Emil Velikov <emil.l.velikov@gmail.com> wrote:
>
> >> @@ -134,24 +152,21 @@ static int drm_new_set_master(struct drm_device *dev, struct drm_file *fpriv)
> >>
> >> /* take another reference for the copy in the local file priv */
> >> old_master = fpriv->master;
> >> - fpriv->master = drm_master_get(dev->master);
> >> + fpriv->master = drm_master_create(dev);
> To avoid the leak just drop the fpriv->minor->dev->master =
> drm_master_create() a few lines above (+ the associated comment/error
> handling drm_master_put(fpriv->minor->dev->master))
>
> >> + if (!fpriv->master)
> >> + return -ENOMEM;
> >>
> ... and restore the old_master before the return "fpriv->master = old_master;"
>
> With that and the other minor comments the series is
> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
This one is a real mess, I've redone it but don't feel like I can just add
your r-b. I'll resend again.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-06-20 21:07 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 7:33 [PATCH 00/16] More drm master and SET_UNIQUE cleanups Daniel Vetter
2016-06-17 7:33 ` [PATCH 01/16] drm: Only do the hw.lock cleanup in master_relase for !MODESET Daniel Vetter
2016-06-17 7:33 ` [PATCH 02/16] drm: Move authmagic cleanup into drm_master_release Daniel Vetter
2016-06-17 7:33 ` [PATCH 03/16] drm: Protect authmagic with master_mutex Daniel Vetter
2016-06-17 7:33 ` [PATCH 04/16] drm: Mark authmagic ioctls as unlocked Daniel Vetter
2016-06-17 7:33 ` [PATCH 05/16] drm: Mark set/drop master ioctl " Daniel Vetter
2016-06-17 7:33 ` [PATCH 06/16] drm: Move master pointer from drm_minor to drm_device Daniel Vetter
2016-06-17 7:51 ` Chris Wilson
2016-06-17 7:33 ` [PATCH 07/16] drm: Clean up drm_crtc.h Daniel Vetter
2016-06-17 7:53 ` [Intel-gfx] " Chris Wilson
2016-06-20 20:18 ` Daniel Vetter
2016-06-17 7:33 ` [PATCH 08/16] drm: Use dev->name as fallback for dev->unique Daniel Vetter
2016-06-17 22:25 ` Emil Velikov
2016-06-17 7:33 ` [PATCH 09/16] drm/vgem: Stop calling drm_drv_set_unique Daniel Vetter
2016-06-20 11:42 ` Chris Wilson
2016-06-20 12:51 ` Daniel Vetter
2016-06-17 7:33 ` [PATCH 10/16] drm: Don't call drm_dev_set_unique from platform drivers Daniel Vetter
2016-06-17 11:12 ` Laurent Pinchart
2016-06-19 19:44 ` Maxime Ripard
2016-06-20 12:03 ` Philipp Zabel
2016-06-17 7:33 ` [PATCH 11/16] drm: Nuke SET_UNIQUE ioctl Daniel Vetter
2016-06-17 22:35 ` Emil Velikov
2016-06-17 7:33 ` [PATCH 12/16] drm: Lobotomize set_busid nonsense for !pci drivers Daniel Vetter
2016-06-20 14:27 ` Emil Velikov
2016-06-17 7:33 ` [PATCH 13/16] drm: Refactor drop/set master code a bit Daniel Vetter
2016-06-17 7:55 ` Chris Wilson
2016-06-17 23:00 ` Emil Velikov
2016-06-17 23:47 ` Emil Velikov
2016-06-20 21:07 ` Daniel Vetter [this message]
2016-06-17 7:33 ` [PATCH 14/16] drm: Extract drm_is_current_master Daniel Vetter
2016-06-17 7:57 ` Chris Wilson
2016-06-17 7:33 ` [PATCH 15/16] drm: Clear up master tracking booleans Daniel Vetter
2016-06-17 7:57 ` Chris Wilson
2016-06-17 23:25 ` Emil Velikov
2016-06-17 7:33 ` [PATCH 16/16] drm: document drm_auth.c Daniel Vetter
2016-06-17 7:59 ` Chris Wilson
2016-06-17 23:46 ` Emil Velikov
2016-06-20 21:17 ` Daniel Vetter
2016-06-20 22:36 ` Emil Velikov
2016-06-17 8:23 ` ✗ Ro.CI.BAT: failure for More drm master and SET_UNIQUE cleanups Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620210735.GN23520@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox