From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Vlad Subject: Re: [RFC i-g-t v3 08/13] lib/stubs: Add stubs for intel_bufmgr. Date: Tue, 21 Jun 2016 15:50:19 +0300 Message-ID: <20160621125019.GA9887@mcvlad-wk.rb.intel.com> References: <1465984270-13918-1-git-send-email-robert.foss@collabora.com> <1465984270-13918-9-git-send-email-robert.foss@collabora.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1957210522==" Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 484F56E6CE for ; Tue, 21 Jun 2016 12:46:56 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Emil Velikov Cc: daniel.stone@collabora.com, tomeu.vizoso@collabora.com, Daniel Vetter , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org --===============1957210522== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/9DWx/yDrRhgMJTb" Content-Disposition: inline --/9DWx/yDrRhgMJTb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 20, 2016 at 03:52:35PM +0100, Emil Velikov wrote: > Hi Rob, >=20 > A couple of nitpicks and a case of missing git add :-) >=20 > On 15 June 2016 at 10:51, wrote: >=20 > > +if HAVE_LIBDRM_INTEL > > +else > > + libintel_tools_la_SOURCES +=3D \ > > + stubs/drm/intel_bufmgr.c \ > > + stubs/drm/intel_bufmgr.h > > +endif > > + > I believe I mentioned if before - please use the following construct >=20 > if !HAVE_LIBDRM_INTEL > libintel_tools_la_SOURCES +=3D \ > stubs/drm/intel_bufmgr.c \ > stubs/drm/intel_bufmgr.h > endif >=20 > > AM_CPPFLAGS =3D -I$(top_srcdir) > > AM_CFLAGS =3D $(CWARNFLAGS) $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(LIBUNW= IND_CFLAGS) $(DEBUG_CFLAGS) \ > > -DIGT_SRCDIR=3D\""$(abs_top_srcdir)/tests"\" \ > > diff --git a/lib/stubs/drm/README b/lib/stubs/drm/README > > new file mode 100644 > > index 0000000..dec6a1d > > --- /dev/null > > +++ b/lib/stubs/drm/README > > @@ -0,0 +1,4 @@ > > +intel_bufmgr.h is a copy the file provided in libdrm (intel/intel_bufm= gr.h). > > + > s/copy the file provided in/local copy of the file provided by/ >=20 > Sadly that's not the case atm. There's a fair few changes in the local 'c= opy'. > Perhaps you forgot to git add ? >=20 > > +Before releasing i-g-t a current copy of intel_bufmgr.h should be copi= ed into > > +this directory of i-g-t. Auch, but synchronizing this wouldn't be a nightmare? I mean stubs might be added/removed in the future. >=20 > Thinking about it... I'm not sure that the release manager will find > this note here :-\ >=20 > Daniel V, Marius, do you guys have a tick-off list somewhere where > this could be added ? README and NEWS. Don't know of any other. >=20 > Regards, > Emil --/9DWx/yDrRhgMJTb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXaTgLAAoJELmLWIAQzyE+gkkH/1zenv1Lk51hJQrEpfia5be9 RTRKitHHfG7jp46ClEYCW1SA8USvSvOWWS9ANFnyy+beVw+kRphy5Rj/EYACT0xp yI9MSX26ua/3mQghvU48EC9u4eTySXuHQeYSmG+TKHcWdyJYajq62PpPHmzHuaI3 1h1j6j8XumcvMJMlMUf/rjB7O0IS1MfPnAyEzi6NVOiOh1t9Cu8U7NQWJauNZovh 58IFr5ye2F5mZUaq1t+8VOKs3Bg5COhybDy1+SkwDW05FpDLqldkvHPke0r30PZF Wg6dOF4dJob1e2b7gWziy4p1N6NKFSdjzkQ5GjXvQ+SE+9WDpqq3wu5sWemNmW4= =HPQj -----END PGP SIGNATURE----- --/9DWx/yDrRhgMJTb-- --===============1957210522== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============1957210522==--