From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v3 3/3] drm/i915: Group all the PPS init steps to one place Date: Wed, 22 Jun 2016 15:30:50 +0300 Message-ID: <20160622123050.GB4329@intel.com> References: <1466499109-20240-1-git-send-email-imre.deak@intel.com> <1466499109-20240-4-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id AA8BE6E7E0 for ; Wed, 22 Jun 2016 12:30:53 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1466499109-20240-4-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKdW4gMjEsIDIwMTYgYXQgMTE6NTE6NDlBTSArMDMwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IE1vdmUgdGhlIGVhcmx5IFBQUyBpbml0aWFsaXphdGlvbiBjYWxscyBuZXh0IHRvIHRoZSBy ZXN0IG9mIFBQUwo+IGluaXRpYWxpemF0aW9uIHN0ZXBzLiBUaGlzIGFsbG93cyB1cyB0byBmb3Jn byBhIGR1cGxpY2F0ZWQgY2FsbCB0bwo+IGludGVsX2RwX2luaXRfcGFuZWxfcG93ZXJfc2VxdWVu Y2VyX3JlZ2lzdGVycygpIG9uIFZMVi9DSFYuCj4gCj4gVGhpcyB3aWxsIHN3YXAgdGhlIG9yZGVy IG9mIERQIEFVWCByZWdpc3RyYXRpb24gd3J0LiBQUFMgaW5pdGlhbGl6YXRpb24uCj4gVGhlcmUg aXMgYW4gZXhpc3RpbmcgcmFjZSBoZXJlIGluIGNhc2Ugb2YgYSB1c2VyIHNwYWNlIGFjY2VzcyB2 aWEgdGhlCj4gRFBBVVggZGV2aWNlIG5vZGUgYWZ0ZXIgRFAgQVVYIHJlZ2lzdHJhdGlvbiBhbmQg YmVmb3JlIGNhbGxpbmcKPiBpbnRlbF9kcF9pbml0X3BhbmVsX3Bvd2VyX3NlcXVlbmNlcl9yZWdp c3RlcnMoKSwgYnV0IHRoaXMgY2hhbmdlIHdvbid0Cj4gbWFrZSB0aGlzIHdvcnNlLiBUaGUgZml4 IGZvciB0aGlzIGlzIHRvIHNlcGFyYXRlIERQIEFVWCBpbml0aWFsaXphdGlvbgo+IGFuZCByZWdp c3RyYXRpb24sIHRoYXQncyBhIHNlcGFyYXRlIHdvcmsgYWxyZWFkeSB1bmRlcndheS4KPiAKPiBU aGUgb3JkZXIgb2YgTVNUIHdydC4gUFBTIGluaXQgYXMgd2VsbCBhcyB0aGUgb3JkZXIgb2YKPiBp bnRlbF9kcF9pbml0X3BhbmVsX3Bvd2VyX3NlcXVlbmNlcl9yZWdpc3RlcnMoKSB3cnQuCj4gaW50 ZWxfZWRwX3BhbmVsX3ZkZF9zYW5pdGl6ZSgpIGFsc28gc3dhcCwgd2hpY2ggaXMgb2ssIHRoZXJl IGFyZSBubwo+IGRlcGVuZGVuY2llcyBiZXR3ZWVuIHRoZXNlIHN0ZXBzLgo+IAo+IFN1Z2dlc3Rl ZCBieSBWaWxsZS4KPiAKPiBDQzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5j b20+CgpsZ3RtCgpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMg fCA0NiArKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUg Y2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgMjIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcC5jCj4gaW5kZXggMjc3Yjc0YS4uZDE1NjA0ZDIgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RwLmMKPiBAQCAtNTMzMiw4ICs1MzMyLDE4IEBAIHN0YXRpYyBib29sIGludGVsX2Vk cF9pbml0X2Nvbm5lY3RvcihzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLAo+ICAJfQo+ICAKPiAg CXBwc19sb2NrKGludGVsX2RwKTsKPiArCj4gKwlpbnRlbF9kcF9pbml0X3BhbmVsX3Bvd2VyX3Rp bWVzdGFtcHMoaW50ZWxfZHApOwo+ICsKPiArCWlmIChJU19WQUxMRVlWSUVXKGRldikgfHwgSVNf Q0hFUlJZVklFVyhkZXYpKSB7Cj4gKwkJdmx2X2luaXRpYWxfcG93ZXJfc2VxdWVuY2VyX3NldHVw KGludGVsX2RwKTsKPiArCX0gZWxzZSB7Cj4gKwkJaW50ZWxfZHBfaW5pdF9wYW5lbF9wb3dlcl9z ZXF1ZW5jZXIoZGV2LCBpbnRlbF9kcCk7Cj4gKwkJaW50ZWxfZHBfaW5pdF9wYW5lbF9wb3dlcl9z ZXF1ZW5jZXJfcmVnaXN0ZXJzKGRldiwgaW50ZWxfZHApOwo+ICsJfQo+ICsKPiAgCWludGVsX2Vk cF9wYW5lbF92ZGRfc2FuaXRpemUoaW50ZWxfZHApOwo+IC0JaW50ZWxfZHBfaW5pdF9wYW5lbF9w b3dlcl9zZXF1ZW5jZXJfcmVnaXN0ZXJzKGRldiwgaW50ZWxfZHApOwo+ICsKPiAgCXBwc191bmxv Y2soaW50ZWxfZHApOwo+ICAKPiAgCS8qIENhY2hlIERQQ0QgYW5kIEVESUQgZm9yIGVkcC4gKi8K PiBAQCAtNTM0Nyw3ICs1MzU3LDcgQEAgc3RhdGljIGJvb2wgaW50ZWxfZWRwX2luaXRfY29ubmVj dG9yKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gIAl9IGVsc2Ugewo+ICAJCS8qIGlmIHRo aXMgZmFpbHMsIHByZXN1bWUgdGhlIGRldmljZSBpcyBhIGdob3N0ICovCj4gIAkJRFJNX0lORk8o ImZhaWxlZCB0byByZXRyaWV2ZSBsaW5rIGluZm8sIGRpc2FibGluZyBlRFBcbiIpOwo+IC0JCXJl dHVybiBmYWxzZTsKPiArCQlnb3RvIG91dF92ZGRfb2ZmOwo+ICAJfQo+ICAKPiAgCW11dGV4X2xv Y2soJmRldi0+bW9kZV9jb25maWcubXV0ZXgpOwo+IEBAIC01NDE3LDYgKzU0MjcsMTggQEAgc3Rh dGljIGJvb2wgaW50ZWxfZWRwX2luaXRfY29ubmVjdG9yKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxf ZHAsCj4gIAlpbnRlbF9wYW5lbF9zZXR1cF9iYWNrbGlnaHQoY29ubmVjdG9yLCBwaXBlKTsKPiAg Cj4gIAlyZXR1cm4gdHJ1ZTsKPiArCj4gK291dF92ZGRfb2ZmOgo+ICsJY2FuY2VsX2RlbGF5ZWRf d29ya19zeW5jKCZpbnRlbF9kcC0+cGFuZWxfdmRkX3dvcmspOwo+ICsJLyoKPiArCSAqIHZkZCBt aWdodCBzdGlsbCBiZSBlbmFibGVkIGRvIHRvIHRoZSBkZWxheWVkIHZkZCBvZmYuCj4gKwkgKiBN YWtlIHN1cmUgdmRkIGlzIGFjdHVhbGx5IHR1cm5lZCBvZmYgaGVyZS4KPiArCSAqLwo+ICsJcHBz X2xvY2soaW50ZWxfZHApOwo+ICsJZWRwX3BhbmVsX3ZkZF9vZmZfc3luYyhpbnRlbF9kcCk7Cj4g KwlwcHNfdW5sb2NrKGludGVsX2RwKTsKPiArCj4gKwlyZXR1cm4gZmFsc2U7Cj4gIH0KPiAgCj4g IGJvb2wKPiBAQCAtNTUyMiwxNiArNTU0NCw2IEBAIGludGVsX2RwX2luaXRfY29ubmVjdG9yKHN0 cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0LAo+ICAJCUJVRygpOwo+ICAJ fQo+ICAKPiAtCWlmIChpc19lZHAoaW50ZWxfZHApKSB7Cj4gLQkJcHBzX2xvY2soaW50ZWxfZHAp Owo+IC0JCWludGVsX2RwX2luaXRfcGFuZWxfcG93ZXJfdGltZXN0YW1wcyhpbnRlbF9kcCk7Cj4g LQkJaWYgKElTX1ZBTExFWVZJRVcoZGV2KSB8fCBJU19DSEVSUllWSUVXKGRldikpCj4gLQkJCXZs dl9pbml0aWFsX3Bvd2VyX3NlcXVlbmNlcl9zZXR1cChpbnRlbF9kcCk7Cj4gLQkJZWxzZQo+IC0J CQlpbnRlbF9kcF9pbml0X3BhbmVsX3Bvd2VyX3NlcXVlbmNlcihkZXYsIGludGVsX2RwKTsKPiAt CQlwcHNfdW5sb2NrKGludGVsX2RwKTsKPiAtCX0KPiAtCj4gIAlyZXQgPSBpbnRlbF9kcF9hdXhf aW5pdChpbnRlbF9kcCwgaW50ZWxfY29ubmVjdG9yKTsKPiAgCWlmIChyZXQpCj4gIAkJZ290byBm YWlsOwo+IEBAIC01NTY0LDE2ICs1NTc2LDYgQEAgaW50ZWxfZHBfaW5pdF9jb25uZWN0b3Ioc3Ry dWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQsCj4gIAlyZXR1cm4gdHJ1ZTsK PiAgCj4gIGZhaWw6Cj4gLQlpZiAoaXNfZWRwKGludGVsX2RwKSkgewo+IC0JCWNhbmNlbF9kZWxh eWVkX3dvcmtfc3luYygmaW50ZWxfZHAtPnBhbmVsX3ZkZF93b3JrKTsKPiAtCQkvKgo+IC0JCSAq IHZkZCBtaWdodCBzdGlsbCBiZSBlbmFibGVkIGRvIHRvIHRoZSBkZWxheWVkIHZkZCBvZmYuCj4g LQkJICogTWFrZSBzdXJlIHZkZCBpcyBhY3R1YWxseSB0dXJuZWQgb2ZmIGhlcmUuCj4gLQkJICov Cj4gLQkJcHBzX2xvY2soaW50ZWxfZHApOwo+IC0JCWVkcF9wYW5lbF92ZGRfb2ZmX3N5bmMoaW50 ZWxfZHApOwo+IC0JCXBwc191bmxvY2soaW50ZWxfZHApOwo+IC0JfQo+ICAJZHJtX2Nvbm5lY3Rv cl91bnJlZ2lzdGVyKGNvbm5lY3Rvcik7Cj4gIAlkcm1fY29ubmVjdG9yX2NsZWFudXAoY29ubmVj dG9yKTsKPiAgCj4gLS0gCj4gMi41LjAKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=