From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7
 merge window
Date: Tue, 12 Jul 2016 12:08:17 +0200
Message-ID: <20160712100817.GV23520@phenom.ffwll.local>
References: <20160617072826.GI23520@phenom.ffwll.local>
 <87vb18uef2.fsf@intel.com>
 <1466204815.2199.2.camel@HansenPartnership.com>
 <1466373202.2280.3.camel@HansenPartnership.com>
 <1466686369.6831.1.camel@snewbury.org.uk>
 <87r3bohxh6.fsf@intel.com>
 <1466687652.6831.8.camel@snewbury.org.uk>
 <20160624105930.GA27113@nuc-i3427.alporthouse.com>
 <1466768897.1924.1.camel@snewbury.org.uk>
 <20160624124206.GB7856@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20160624124206.GB7856@nuc-i3427.alporthouse.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Chris Wilson <chris@chris-wilson.co.uk>, Steven Newbury <steve@snewbury.org.uk>, intel-gfx <intel-gfx@lists.freedesktop.org>, linux-kernel <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, James Bottomley <James.Bottomley@HansenPartnership.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Jun 24, 2016 at 01:42:06PM +0100, Chris Wilson wrote:
> On Fri, Jun 24, 2016 at 12:48:17PM +0100, Steven Newbury wrote:
> > On Fri, 2016-06-24 at 11:59 +0100, Chris Wilson wrote:
> > > On Thu, Jun 23, 2016 at 02:14:12PM +0100, Steven Newbury wrote:
> > > > On Thu, 2016-06-23 at 15:59 +0300, Jani Nikula wrote:
> > > > > On Thu, 23 Jun 2016, Steven Newbury <steve@snewbury.org.uk>
> > > > > wrote:
> > > > > > I'm seeing this on my IvyBridge. =A0I'll try reverting the =
commit
> > > > > > here
> > > > > > too, to see if it's the same issue.
> > > > >=20
> > > > > IvyBridge doesn't have low vswing for eDP. If reverting helps=
,
> > > > > it's a
> > > > > different failure mode.
> > > > >=20
> > > > It must be something else then. =A0Actually, in my case linus/m=
aster
> > > > is
> > > > okay. =A0I saw the subject and though it must be the same issue=
=2E =A0I'm
> > > > seeing it with drm-intel nightly/next branches. =A0Shall I try =
to
> > > > bisect
> > > > it? =A0Symptoms are similar, although I would describe it more =
like
> > > > flashes of a different buffer across parts of the screen.
> > >=20
> > > Try reverting ee042aa40b66d18d465206845b0752c6a617ba3f instead.
> > > -Chris
> > >=20
> >=20
> > Yes, thanks, that "fixed" it. =A0So atomic commits not working prop=
erly
> > on IVB?
>=20
> Not yet it seems. Something seems to be off in the timing, but has so
> far eluded capture.

=46yi we reverted this for now to fix things up:

commit 527b6abe5fd2d24fba69e9564a2d608e1796ca8d
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Fri Jun 24 13:44:03 2016 +0100

    Revert "drm/i915: Use atomic commits for legacy page_flips"

Kudos to Chris for handling this in my absence.
-Daniel
--=20
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch