From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 2/2] drm/i915: refactor eb_get_batch()
Date: Wed, 13 Jul 2016 14:38:16 +0200
Message-ID: <20160713123816.GM23520@phenom.ffwll.local>
References: <1467299569-10920-1-git-send-email-david.s.gordon@intel.com>
 <1467299569-10920-2-git-send-email-david.s.gordon@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com
 [IPv6:2a00:1450:400c:c09::244])
 by gabe.freedesktop.org (Postfix) with ESMTPS id AEE566E6C6
 for <intel-gfx@lists.freedesktop.org>; Wed, 13 Jul 2016 12:38:20 +0000 (UTC)
Received: by mail-wm0-x244.google.com with SMTP id o80so5741832wme.0
 for <intel-gfx@lists.freedesktop.org>; Wed, 13 Jul 2016 05:38:20 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1467299569-10920-2-git-send-email-david.s.gordon@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dave Gordon <david.s.gordon@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBKdW4gMzAsIDIwMTYgYXQgMDQ6MTI6NDlQTSArMDEwMCwgRGF2ZSBHb3Jkb24gd3Jv
dGU6Cj4gUHJlY3Vyc29yIGZvciBmaXggdG8gc2VjdXJlIGJhdGNoIGV4ZWN1dGlvbi4gV2Ugd2ls
bCBuZWVkIHRvIGJlIGFibGUgdG8KPiByZXRyaWV2ZSB0aGUgYmF0Y2ggVk1BIChhcyB3ZWxsIGFz
IHRoZSBiYXRjaCBpdHNlbGYpIGZyb20gdGhlIGViIGxpc3QsCj4gc28gdGhpcyBwYXRjaCBleHRy
YWN0cyB0aGF0IHBhcnQgb2YgZWJfZ2V0X2JhdGNoKCkgaW50byBhIHNlcGFyYXRlCj4gZnVuY3Rp
b24sIGFuZCBtb3ZlcyBib3RoIHBhcnRzIHRvIGEgbW9yZSBsb2dpY2FsIHBsYWNlIGluIHRoZSBm
aWxlLCBuZWFyCj4gd2hlcmUgdGhlIGViIGxpc3QgaXMgY3JlYXRlZC4KPiAKPiBBbHNvLCBpdCBt
YXkgbm90IGJlIG9idmlvdXMsIGJ1dCB0aGUgY3VycmVudCBleGVjYnVmZmVyMiBpb2N0bCBpbnRl
cmZhY2UKPiByZXF1aXJlcyB0aGF0IHRoZSBidWZmZXIgb2JqZWN0IGNvbnRhaW5pbmcgdGhlIGJh
dGNoLXRvLWJlLWV4ZWN1dGVkIGJlCj4gdGhlIExBU1QgZW50cnkgaW4gdGhlIGV4ZWMyX2xpc3Rb
XSBhcnJheSAoSSBleHBlY3RlZCBpdCB0byBiZSB0aGUgZmlyc3QhKS4KPiAKPiBUbyBjbGFyaWZ5
IHRoaXMsIHdlIGNhbiByZXBsYWNlIHRoZSByYXRoZXIgb2JzY3VyZSBjb25zdHJ1Y3QKPiAJImxp
c3RfZW50cnkoZWItPnZtYXMucHJldiwgLi4uKSIKPiBpbiB0aGUgb2xkIHZlcnNpb24gb2YgZWJf
Z2V0X2JhdGNoKCkgd2l0aCB0aGUgZXF1aXZhbGVudCBidXQgbW9yZSBleHBsaWNpdAo+IAkibGlz
dF9sYXN0X2VudHJ5KCZlYi0+dm1hcywuLi4pIgo+IGluIHRoZSBuZXcgZWJfZ2V0X2JhdGNoX3Zt
YSgpIGFuZCBvZiBjb3Vyc2UgYWRkIGFuIGV4cGxhbmF0b3J5IGNvbW1lbnQuCj4gCj4gU2lnbmVk
LW9mZi1ieTogRGF2ZSBHb3Jkb24gPGRhdmlkLnMuZ29yZG9uQGludGVsLmNvbT4KCkkgaGF2ZSBu
byBjb250ZXh0IG9uIHRoZSBzZWN1cmUgYmF0Y2ggZml4IHlvdSdyZSB0YWxraW5nIGFib3V0LCBi
dXQgdGhpcwpoZXJlIG1ha2VzIHNlbnNlIGFzIGFuIGluZGVwZW5kZW50IGNsZWFudXAuCgpSZXZp
ZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KCj4gLS0tCj4g
IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYyB8IDQ5ICsrKysrKysr
KysrKysrKysrKy0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygr
KSwgMjAgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4
ZWNidWZmZXIuYwo+IGluZGV4IDYwOGZkYzQuLmVlYThiMWYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZXhlY2J1ZmZlci5jCj4gKysrIGIvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaTkxNV9nZW1fZXhlY2J1ZmZlci5jCj4gQEAgLTE4Niw2ICsxODYsMzUgQEAgc3Ry
dWN0IGViX3ZtYXMgewo+ICAJcmV0dXJuIHJldDsKPiAgfQo+ICAKPiArc3RhdGljIGlubGluZSBz
dHJ1Y3QgaTkxNV92bWEgKgo+ICtlYl9nZXRfYmF0Y2hfdm1hKHN0cnVjdCBlYl92bWFzICplYikK
PiArewo+ICsJLyogVGhlIGJhdGNoIGlzIGFsd2F5cyB0aGUgTEFTVCBpdGVtIGluIHRoZSBWTUEg
bGlzdCAqLwo+ICsJc3RydWN0IGk5MTVfdm1hICp2bWEgPSBsaXN0X2xhc3RfZW50cnkoJmViLT52
bWFzLCB0eXBlb2YoKnZtYSksIGV4ZWNfbGlzdCk7Cj4gKwo+ICsJcmV0dXJuIHZtYTsKPiArfQo+
ICsKPiArc3RhdGljIHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICoKPiArZWJfZ2V0X2JhdGNo
KHN0cnVjdCBlYl92bWFzICplYikKPiArewo+ICsJc3RydWN0IGk5MTVfdm1hICp2bWEgPSBlYl9n
ZXRfYmF0Y2hfdm1hKGViKTsKPiArCj4gKwkvKgo+ICsJICogU05BIGlzIGRvaW5nIGZhbmN5IHRy
aWNrcyB3aXRoIGNvbXByZXNzaW5nIGJhdGNoIGJ1ZmZlcnMsIHdoaWNoIGxlYWRzCj4gKwkgKiB0
byBuZWdhdGl2ZSByZWxvY2F0aW9uIGRlbHRhcy4gVXN1YWxseSB0aGF0IHdvcmtzIG91dCBvayBz
aW5jZSB0aGUKPiArCSAqIHJlbG9jYXRlIGFkZHJlc3MgaXMgc3RpbGwgcG9zaXRpdmUsIGV4Y2Vw
dCB3aGVuIHRoZSBiYXRjaCBpcyBwbGFjZWQKPiArCSAqIHZlcnkgbG93IGluIHRoZSBHVFQuIEVu
c3VyZSB0aGlzIGRvZXNuJ3QgaGFwcGVuLgo+ICsJICoKPiArCSAqIE5vdGUgdGhhdCBhY3R1YWwg
aGFuZ3MgaGF2ZSBvbmx5IGJlZW4gb2JzZXJ2ZWQgb24gZ2VuNywgYnV0IGZvcgo+ICsJICogcGFy
YW5vaWEgZG8gaXQgZXZlcnl3aGVyZS4KPiArCSAqLwo+ICsJaWYgKCh2bWEtPmV4ZWNfZW50cnkt
PmZsYWdzICYgRVhFQ19PQkpFQ1RfUElOTkVEKSA9PSAwKQo+ICsJCXZtYS0+ZXhlY19lbnRyeS0+
ZmxhZ3MgfD0gX19FWEVDX09CSkVDVF9ORUVEU19CSUFTOwo+ICsKPiArCXJldHVybiB2bWEtPm9i
ajsKPiArfQo+ICsKPiAgc3RhdGljIHN0cnVjdCBpOTE1X3ZtYSAqZWJfZ2V0X3ZtYShzdHJ1Y3Qg
ZWJfdm1hcyAqZWIsIHVuc2lnbmVkIGxvbmcgaGFuZGxlKQo+ICB7Cj4gIAlpZiAoZWItPmFuZCA8
IDApIHsKPiBAQCAtMTM0MSwyNiArMTM3MCw2IEBAIHN0YXRpYyBib29sIG9ubHlfbWFwcGFibGVf
Zm9yX3JlbG9jKHVuc2lnbmVkIGludCBmbGFncykKPiAgCXJldHVybiBmaWxlX3ByaXYtPmJzZF9y
aW5nOwo+ICB9Cj4gIAo+IC1zdGF0aWMgc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKgo+IC1l
Yl9nZXRfYmF0Y2goc3RydWN0IGViX3ZtYXMgKmViKQo+IC17Cj4gLQlzdHJ1Y3QgaTkxNV92bWEg
KnZtYSA9IGxpc3RfZW50cnkoZWItPnZtYXMucHJldiwgdHlwZW9mKCp2bWEpLCBleGVjX2xpc3Qp
Owo+IC0KPiAtCS8qCj4gLQkgKiBTTkEgaXMgZG9pbmcgZmFuY3kgdHJpY2tzIHdpdGggY29tcHJl
c3NpbmcgYmF0Y2ggYnVmZmVycywgd2hpY2ggbGVhZHMKPiAtCSAqIHRvIG5lZ2F0aXZlIHJlbG9j
YXRpb24gZGVsdGFzLiBVc3VhbGx5IHRoYXQgd29ya3Mgb3V0IG9rIHNpbmNlIHRoZQo+IC0JICog
cmVsb2NhdGUgYWRkcmVzcyBpcyBzdGlsbCBwb3NpdGl2ZSwgZXhjZXB0IHdoZW4gdGhlIGJhdGNo
IGlzIHBsYWNlZAo+IC0JICogdmVyeSBsb3cgaW4gdGhlIEdUVC4gRW5zdXJlIHRoaXMgZG9lc24n
dCBoYXBwZW4uCj4gLQkgKgo+IC0JICogTm90ZSB0aGF0IGFjdHVhbCBoYW5ncyBoYXZlIG9ubHkg
YmVlbiBvYnNlcnZlZCBvbiBnZW43LCBidXQgZm9yCj4gLQkgKiBwYXJhbm9pYSBkbyBpdCBldmVy
eXdoZXJlLgo+IC0JICovCj4gLQlpZiAoKHZtYS0+ZXhlY19lbnRyeS0+ZmxhZ3MgJiBFWEVDX09C
SkVDVF9QSU5ORUQpID09IDApCj4gLQkJdm1hLT5leGVjX2VudHJ5LT5mbGFncyB8PSBfX0VYRUNf
T0JKRUNUX05FRURTX0JJQVM7Cj4gLQo+IC0JcmV0dXJuIHZtYS0+b2JqOwo+IC19Cj4gLQo+ICAj
ZGVmaW5lIEk5MTVfVVNFUl9SSU5HUyAoNCkKPiAgCj4gIHN0YXRpYyBjb25zdCBlbnVtIGludGVs
X2VuZ2luZV9pZCB1c2VyX3JpbmdfbWFwW0k5MTVfVVNFUl9SSU5HUyArIDFdID0gewo+IC0tIAo+
IDEuOS4xCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w
Lm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50
ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9y
YXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz
dGluZm8vaW50ZWwtZ2Z4Cg==