From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matt Roper <matthew.d.roper@intel.com>
Subject: Re: [PATCH v3] drm/i915/skl: Add support for the SAGV,
 fix underrun hangs
Date: Wed, 13 Jul 2016 11:08:46 -0700
Message-ID: <20160713180846.GJ18143@intel.com>
References: <1468344963-6282-1-git-send-email-cpaul@redhat.com>
 <20160712182139.GH18143@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20160712182139.GH18143@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Lyude <cpaul@redhat.com>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, "open list:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...),
 linux-kernel@vger.kernel.org (open list)" <dri-devel@lists.freedesktop.org>, Daniel Vetter <daniel.vetter@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCBKdWwgMTIsIDIwMTYgYXQgMTE6MjE6MzlBTSAtMDcwMCwgTWF0dCBSb3BlciB3cm90
ZToKPiBPbiBUdWUsIEp1bCAxMiwgMjAxNiBhdCAwMTozNjowM1BNIC0wNDAwLCBMeXVkZSB3cm90
ZToKPiA+IFNpbmNlIHRoZSB3YXRlcm1hcmsgY2FsY3VsYXRpb25zIGZvciBTa3lsYWtlIGFyZSBz
dGlsbCBicm9rZW4sIHdlJ3JlIGFwdAo+ID4gdG8gaGl0dGluZyB1bmRlcnJ1bnMgdmVyeSBlYXNp
bHkgdW5kZXIgbXVsdGktbW9uaXRvciBjb25maWd1cmF0aW9ucy4KPiA+IFdoaWxlIGl0IHdvdWxk
IGJlIGxvdmVseSBpZiB0aGlzIHdhcyBmaXhlZCwgaXQncyBub3QuIEFub3RoZXIgcHJvYmxlbQo+
ID4gdGhhdCdzIGJlZW4gY29taW5nIGZyb20gdGhpcyBob3dldmVyLCBpcyB0aGUgbXlzdGVyaW91
cyBpc3N1ZSBvZgo+ID4gdW5kZXJydW5zIGNhdXNpbmcgZnVsbCBzeXN0ZW0gaGFuZ3MuIEFuIGVh
c3kgd2F5IHRvIHJlcHJvZHVjZSB0aGlzIHdpdGgKPiA+IGEgc2t5bGFrZSBzeXN0ZW06Cj4gPiAK
PiA+IC0gR2V0IGEgbGFwdG9wIHdpdGggYSBza3lsYWtlIEdQVSwgYW5kIGhvb2sgdXAgdHdvIGV4
dGVybmFsIG1vbml0b3JzIHRvCj4gPiAgIGl0Cj4gPiAtIE1vdmUgdGhlIGN1cnNvciBmcm9tIHRo
ZSBidWlsdC1pbiBMQ0QgdG8gb25lIG9mIHRoZSBleHRlcm5hbCBkaXNwbGF5cwo+ID4gICBhcyBx
dWlja2x5IGFzIHlvdSBjYW4KPiA+IC0gWW91J2xsIGdldCBhIGZldyBwaXBlIHVuZGVycnVucywg
YW5kIGV2ZW50dWFsbHkgdGhlIGVudGlyZSBzeXN0ZW0gd2lsbAo+ID4gICBqdXN0IGZyZWV6ZS4K
PiA+IAo+ID4gQWZ0ZXIgZG9pbmcgYSBsb3Qgb2YgaW52ZXN0aWdhdGlvbiBhbmQgcmVhZGluZyB0
aHJvdWdoIHRoZSBic3BlYywgSQo+ID4gZm91bmQgdGhlIGV4aXN0ZW5jZSBvZiB0aGUgU0FHViwg
d2hpY2ggaXMgcmVzcG9uc2libGUgZm9yIGFkanVzdGluZyB0aGUKPiA+IHN5c3RlbSBhZ2VudCB2
b2x0YWdlIGFuZCBjbG9jayBmcmVxdWVuY2llcyBkZXBlbmRpbmcgb24gaG93IG11Y2ggcG93ZXIK
PiA+IHdlIG5lZWQuIEFjY29yZGluZyB0byB0aGUgYnNwZWM6Cj4gPiAKPiA+ICJUaGUgZGlzcGxh
eSBlbmdpbmUgYWNjZXNzIHRvIHN5c3RlbSBtZW1vcnkgaXMgYmxvY2tlZCBkdXJpbmcgdGhlCj4g
PiAgYWRqdXN0bWVudCB0aW1lLiBTQUdWIGRlZmF1bHRzIHRvIGVuYWJsZWQuIFNvZnR3YXJlIG11
c3QgdXNlIHRoZQo+ID4gIEdULWRyaXZlciBwY29kZSBtYWlsYm94IHRvIGRpc2FibGUgU0FHViB3
aGVuIHRoZSBkaXNwbGF5IGVuZ2luZSBpcyBub3QKPiA+ICBhYmxlIHRvIHRvbGVyYXRlIHRoZSBi
bG9ja2luZyB0aW1lLiIKPiA+IAo+ID4gVGhlIHJlc3Qgb2YgdGhlIGJzcGVjIGdvZXMgb24gdG8g
ZXhwbGFpbiB0aGF0IHNvZnR3YXJlIGNhbiBzaW1wbHkgbGVhdmUKPiA+IHRoZSBTQUdWIGVuYWJs
ZWQsIGFuZCBkaXNhYmxlIGl0IHdoZW4gd2UgdXNlIGludGVybGFjZWQgcGlwZXMvaGF2ZSBtb3Jl
Cj4gPiB0aGVuIG9uZSBwaXBlIGFjdGl2ZS4KPiA+IAo+ID4gU3VyZSBlbm91Z2gsIHdpdGggdGhp
cyBwYXRjaHNldCB0aGUgc3lzdGVtIGhhbmdzIHJlc3VsdGluZyBmcm9tIHBpcGUKPiA+IHVuZGVy
cnVucyBvbiBTa3lsYWtlIGhhdmUgY29tcGxldGVseSB2YW5pc2hlZCBvbiBteSBUNDYwcy4gQWRk
aXRpb25hbGx5LAo+ID4gdGhlIGJzcGVjIG1lbnRpb25zIHR1cm5pbmcgb2ZmIHRoZSBTQUdWCXdp
dGggbW9yZSB0aGVuIG9uZSBwaXBlIGVuYWJsZWQKPiA+IGFzIGEgd29ya2Fyb3VuZCBmb3IgZGlz
cGxheSB1bmRlcnJ1bnMuIFdoaWxlIHRoaXMgcGF0Y2ggZG9lc24ndCBlbnRpcmVseQo+ID4gZml4
IHRoYXQsIGl0IGxvb2tzIGxpa2UgaXQgZG9lcyBpbXByb3ZlIHRoZSBzaXR1YXRpb24gYSBsaXR0
bGUgYml0IHNvCj4gPiBpdCdzIGxpa2VseSB0aGlzIGlzIGdvaW5nIHRvIGJlIHJlcXVpcmVkIHRv
IG1ha2Ugd2F0ZXJtYXJrcyBvbiBTa3lsYWtlCj4gPiBmdWxseSBmdW5jdGlvbmFsLgo+ID4gCj4g
PiBDaGFuZ2VzIHNpbmNlIHYyOgo+ID4gIC0gUmVhbGx5IGFwcGx5IG1pbm9yIHN0eWxlIG5pdHBp
Y2tzIHRvIHBhdGNoIHRoaXMgdGltZQo+ID4gQ2hhbmdlcyBzaW5jZSB2MToKPiA+ICAtIEFkZGVk
IGNvbW1lbnRzIGFib3V0IHRoaXMgcHJvYmFibHkgYmVpbmcgb25lIG9mIHRoZSByZXF1aXJlbWVu
dHMgdG8KPiA+ICAgIGZpeGluZyBTa3lsYWtlJ3Mgd2F0ZXJtYXJrIGlzc3Vlcwo+ID4gIC0gTWlu
b3Igc3R5bGUgbml0cGlja3MgZnJvbSBNYXR0IFJvcGVyCj4gPiAgLSBEaXNhYmxlIHRoZXNlIGZ1
bmN0aW9ucyBvbiBCcm94dG9uLCBzaW5jZSBpdCBkb2Vzbid0IGhhdmUgYW4gU0FHVgo+ID4gCj4g
PiBDYzogTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KPiA+IENjOiBEYW5p
ZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ID4gQ2M6IFZpbGxlIFN5cmrDpGzD
pCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBMeXVk
ZSA8Y3BhdWxAcmVkaGF0LmNvbT4KPiAKPiBJIGRvbid0IGhhdmUgYSBTS0wgdG8gdHJ5IHRoaXMg
b3V0IG9uIChvbmx5IEJYVCBoZXJlKSwgYnV0IHRoaXMgbWF0Y2hlcwo+IG15IGludGVycHJldGF0
aW9uIG9mIHRoZSBjdXJyZW50IGJzcGVjIHRleHQsIHNvCj4gCj4gUmV2aWV3ZWQtYnk6IE1hdHQg
Um9wZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRlbC5jb20+Cj4gCj4gSSB0aGluayB0aGlzIGFsc28g
YXBwbGllcyB0bwo+IAo+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3No
b3dfYnVnLmNnaT9pZD05NDYyNQo+IAo+IEFuZCBtYXliZSBhICtjYyBzdGFibGU/Cj4gCgpPb3Bz
LCBvbmUgbW9yZSBtaW5vciBpc3N1ZSBiZWxvdyB0aGF0IEkgbWlzc2VkIHRoZSBmaXJzdCB0aW1l
IGFyb3VuZC4KCi4uLgo+ID4gKwkvKiBic3BlYyBzYXlzIHRvIGtlZXAgcmV0cnlpbmcgZm9yIGF0
IGxlYXN0IDEgbXMgKi8KPiA+ICsJdGltZW91dCA9IGppZmZpZXMgKyBtc2Vjc190b19qaWZmaWVz
KDEpOwo+ID4gKwlkbyB7Cj4gPiArCQlyZXQgPSBzYW5keWJyaWRnZV9wY29kZV93cml0ZShkZXZf
cHJpdiwgR0VOOV9QQ09ERV9TQUdWX0NPTlRST0wsCj4gPiArCQkJCQkgICAgICBHRU45X1NBR1Zf
RElTQUJMRSk7Cj4gPiArCQlpZiAocmV0KSB7Cj4gPiArCQkJRFJNX0VSUk9SKCJGYWlsZWQgdG8g
ZGlzYWJsZSB0aGUgU0FHVlxuIik7Cj4gPiArCQkJZ290byBvdXQ7Cj4gPiArCQl9Cj4gPiArCj4g
PiArCQlyZXQgPSBzYW5keWJyaWRnZV9wY29kZV9yZWFkKGRldl9wcml2LCBHRU45X1BDT0RFX1NB
R1ZfQ09OVFJPTCwKPiA+ICsJCQkJCSAgICAgJnRlbXApOwo+ID4gKwkJaWYgKHJldCkgewo+ID4g
KwkJCURSTV9FUlJPUigiRmFpbGVkIHRvIGNoZWNrIHRoZSBzdGF0dXMgb2YgdGhlIFNBR1ZcbiIp
Owo+ID4gKwkJCWdvdG8gb3V0Owo+ID4gKwkJfQo+ID4gKwl9IHdoaWxlICghKHRlbXAgJiAweDEp
ICYmIGppZmZpZXMgPCB0aW1lb3V0KTsKCldlIHNob3VsZG4ndCBjb21wYXJlIGppZmZpZXMgZGly
ZWN0bHkgaGVyZSBkdWUgdG8gd3JhcGFyb3VuZDsgeW91IGNhbgp1c2UgdGltZV9iZWZvcmUoKSB0
byBoYW5kbGUgdGhhdCBzYWZlbHkuCgoKTWF0dAoKPiA+ICsKPiA+ICsJaWYgKHRlbXAgJiAweDEp
IHsKPiA+ICsJCWRldl9wcml2LT5za2xfc2Fndl9lbmFibGVkID0gZmFsc2U7Cj4gPiArCX0gZWxz
ZSB7Cj4gPiArCQlyZXQgPSAtMTsKPiA+ICsJCURSTV9FUlJPUigiUmVxdWVzdCB0byBkaXNhYmxl
IFNBR1YgdGltZWQgb3V0XG4iKTsKPiA+ICsJfQo+ID4gKwo+ID4gK291dDoKPiA+ICsJbXV0ZXhf
dW5sb2NrKCZkZXZfcHJpdi0+cnBzLmh3X2xvY2spOwo+ID4gKwlyZXR1cm4gcmV0Owo+ID4gK30K
PiA+ICsKPiA+ICtzdGF0aWMgdm9pZAo+ID4gIHNrbF9kZGJfZ2V0X3BpcGVfYWxsb2NhdGlvbl9s
aW1pdHMoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ICAJCQkJICAgY29uc3Qgc3RydWN0IGlu
dGVsX2NydGNfc3RhdGUgKmNzdGF0ZSwKPiA+ICAJCQkJICAgc3RydWN0IHNrbF9kZGJfZW50cnkg
KmFsbG9jLCAvKiBvdXQgKi8KPiA+IEBAIC0zNjg2LDYgKzM3ODksMTEgQEAgc3RhdGljIHZvaWQg
c2tsX3dyaXRlX3dtX3ZhbHVlcyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4g
PiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSAmZGV2X3ByaXYtPmRybTsKPiA+ICAJc3RydWN0
IGludGVsX2NydGMgKmNydGM7Cj4gPiAgCj4gPiArCWlmIChkZXZfcHJpdi0+YWN0aXZlX2NydGNz
ID09IDEpCj4gPiArCQlza2xfZW5hYmxlX3NhZ3YoZGV2X3ByaXYpOwo+ID4gKwllbHNlCj4gPiAr
CQlza2xfZGlzYWJsZV9zYWd2KGRldl9wcml2KTsKPiA+ICsKPiA+ICAJZm9yX2VhY2hfaW50ZWxf
Y3J0YyhkZXYsIGNydGMpIHsKPiA+ICAJCWludCBpLCBsZXZlbCwgbWF4X2xldmVsID0gaWxrX3dt
X21heF9sZXZlbChkZXYpOwo+ID4gIAkJZW51bSBwaXBlIHBpcGUgPSBjcnRjLT5waXBlOwo+ID4g
QEAgLTQyMjgsNiArNDMzNiw4IEBAIHZvaWQgc2tsX3dtX2dldF9od19zdGF0ZShzdHJ1Y3QgZHJt
X2RldmljZSAqZGV2KQo+ID4gIAkJLyogRWFzeS9jb21tb24gY2FzZTsganVzdCBzYW5pdGl6ZSBE
REIgbm93IGlmIGV2ZXJ5dGhpbmcgb2ZmICovCj4gPiAgCQltZW1zZXQoZGRiLCAwLCBzaXplb2Yo
KmRkYikpOwo+ID4gIAl9Cj4gPiArCj4gPiArCXNrbF9zYWd2X2dldF9od19zdGF0ZShkZXZfcHJp
dik7Cj4gPiAgfQo+ID4gIAo+ID4gIHN0YXRpYyB2b2lkIGlsa19waXBlX3dtX2dldF9od19zdGF0
ZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gPiAtLSAKPiA+IDIuNy40Cj4gPiAKPiAKPiAtLSAK
PiBNYXR0IFJvcGVyCj4gR3JhcGhpY3MgU29mdHdhcmUgRW5naW5lZXIKPiBJb1RHIFBsYXRmb3Jt
IEVuYWJsaW5nICYgRGV2ZWxvcG1lbnQKPiBJbnRlbCBDb3Jwb3JhdGlvbgo+ICg5MTYpIDM1Ni0y
Nzk1Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJ
bnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+
IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4
CgotLSAKTWF0dCBSb3BlcgpHcmFwaGljcyBTb2Z0d2FyZSBFbmdpbmVlcgpJb1RHIFBsYXRmb3Jt
IEVuYWJsaW5nICYgRGV2ZWxvcG1lbnQKSW50ZWwgQ29ycG9yYXRpb24KKDkxNikgMzU2LTI3OTUK
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4
IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==