From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v3] drm/i915/skl: Add support for the SAGV,
 fix underrun hangs
Date: Wed, 13 Jul 2016 21:12:09 +0300
Message-ID: <20160713181209.GC4329@intel.com>
References: <1468344963-6282-1-git-send-email-cpaul@redhat.com>
 <20160712182139.GH18143@intel.com>
 <20160713180846.GJ18143@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20160713180846.GJ18143@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, "open list:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...),
 linux-kernel@vger.kernel.org (open list)" <dri-devel@lists.freedesktop.org>, Daniel Vetter <daniel.vetter@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCBKdWwgMTMsIDIwMTYgYXQgMTE6MDg6NDZBTSAtMDcwMCwgTWF0dCBSb3BlciB3cm90
ZToKPiBPbiBUdWUsIEp1bCAxMiwgMjAxNiBhdCAxMToyMTozOUFNIC0wNzAwLCBNYXR0IFJvcGVy
IHdyb3RlOgo+ID4gT24gVHVlLCBKdWwgMTIsIDIwMTYgYXQgMDE6MzY6MDNQTSAtMDQwMCwgTHl1
ZGUgd3JvdGU6Cj4gPiA+IFNpbmNlIHRoZSB3YXRlcm1hcmsgY2FsY3VsYXRpb25zIGZvciBTa3ls
YWtlIGFyZSBzdGlsbCBicm9rZW4sIHdlJ3JlIGFwdAo+ID4gPiB0byBoaXR0aW5nIHVuZGVycnVu
cyB2ZXJ5IGVhc2lseSB1bmRlciBtdWx0aS1tb25pdG9yIGNvbmZpZ3VyYXRpb25zLgo+ID4gPiBX
aGlsZSBpdCB3b3VsZCBiZSBsb3ZlbHkgaWYgdGhpcyB3YXMgZml4ZWQsIGl0J3Mgbm90LiBBbm90
aGVyIHByb2JsZW0KPiA+ID4gdGhhdCdzIGJlZW4gY29taW5nIGZyb20gdGhpcyBob3dldmVyLCBp
cyB0aGUgbXlzdGVyaW91cyBpc3N1ZSBvZgo+ID4gPiB1bmRlcnJ1bnMgY2F1c2luZyBmdWxsIHN5
c3RlbSBoYW5ncy4gQW4gZWFzeSB3YXkgdG8gcmVwcm9kdWNlIHRoaXMgd2l0aAo+ID4gPiBhIHNr
eWxha2Ugc3lzdGVtOgo+ID4gPiAKPiA+ID4gLSBHZXQgYSBsYXB0b3Agd2l0aCBhIHNreWxha2Ug
R1BVLCBhbmQgaG9vayB1cCB0d28gZXh0ZXJuYWwgbW9uaXRvcnMgdG8KPiA+ID4gICBpdAo+ID4g
PiAtIE1vdmUgdGhlIGN1cnNvciBmcm9tIHRoZSBidWlsdC1pbiBMQ0QgdG8gb25lIG9mIHRoZSBl
eHRlcm5hbCBkaXNwbGF5cwo+ID4gPiAgIGFzIHF1aWNrbHkgYXMgeW91IGNhbgo+ID4gPiAtIFlv
dSdsbCBnZXQgYSBmZXcgcGlwZSB1bmRlcnJ1bnMsIGFuZCBldmVudHVhbGx5IHRoZSBlbnRpcmUg
c3lzdGVtIHdpbGwKPiA+ID4gICBqdXN0IGZyZWV6ZS4KPiA+ID4gCj4gPiA+IEFmdGVyIGRvaW5n
IGEgbG90IG9mIGludmVzdGlnYXRpb24gYW5kIHJlYWRpbmcgdGhyb3VnaCB0aGUgYnNwZWMsIEkK
PiA+ID4gZm91bmQgdGhlIGV4aXN0ZW5jZSBvZiB0aGUgU0FHViwgd2hpY2ggaXMgcmVzcG9uc2li
bGUgZm9yIGFkanVzdGluZyB0aGUKPiA+ID4gc3lzdGVtIGFnZW50IHZvbHRhZ2UgYW5kIGNsb2Nr
IGZyZXF1ZW5jaWVzIGRlcGVuZGluZyBvbiBob3cgbXVjaCBwb3dlcgo+ID4gPiB3ZSBuZWVkLiBB
Y2NvcmRpbmcgdG8gdGhlIGJzcGVjOgo+ID4gPiAKPiA+ID4gIlRoZSBkaXNwbGF5IGVuZ2luZSBh
Y2Nlc3MgdG8gc3lzdGVtIG1lbW9yeSBpcyBibG9ja2VkIGR1cmluZyB0aGUKPiA+ID4gIGFkanVz
dG1lbnQgdGltZS4gU0FHViBkZWZhdWx0cyB0byBlbmFibGVkLiBTb2Z0d2FyZSBtdXN0IHVzZSB0
aGUKPiA+ID4gIEdULWRyaXZlciBwY29kZSBtYWlsYm94IHRvIGRpc2FibGUgU0FHViB3aGVuIHRo
ZSBkaXNwbGF5IGVuZ2luZSBpcyBub3QKPiA+ID4gIGFibGUgdG8gdG9sZXJhdGUgdGhlIGJsb2Nr
aW5nIHRpbWUuIgo+ID4gPiAKPiA+ID4gVGhlIHJlc3Qgb2YgdGhlIGJzcGVjIGdvZXMgb24gdG8g
ZXhwbGFpbiB0aGF0IHNvZnR3YXJlIGNhbiBzaW1wbHkgbGVhdmUKPiA+ID4gdGhlIFNBR1YgZW5h
YmxlZCwgYW5kIGRpc2FibGUgaXQgd2hlbiB3ZSB1c2UgaW50ZXJsYWNlZCBwaXBlcy9oYXZlIG1v
cmUKPiA+ID4gdGhlbiBvbmUgcGlwZSBhY3RpdmUuCj4gPiA+IAo+ID4gPiBTdXJlIGVub3VnaCwg
d2l0aCB0aGlzIHBhdGNoc2V0IHRoZSBzeXN0ZW0gaGFuZ3MgcmVzdWx0aW5nIGZyb20gcGlwZQo+
ID4gPiB1bmRlcnJ1bnMgb24gU2t5bGFrZSBoYXZlIGNvbXBsZXRlbHkgdmFuaXNoZWQgb24gbXkg
VDQ2MHMuIEFkZGl0aW9uYWxseSwKPiA+ID4gdGhlIGJzcGVjIG1lbnRpb25zIHR1cm5pbmcgb2Zm
IHRoZSBTQUdWCXdpdGggbW9yZSB0aGVuIG9uZSBwaXBlIGVuYWJsZWQKPiA+ID4gYXMgYSB3b3Jr
YXJvdW5kIGZvciBkaXNwbGF5IHVuZGVycnVucy4gV2hpbGUgdGhpcyBwYXRjaCBkb2Vzbid0IGVu
dGlyZWx5Cj4gPiA+IGZpeCB0aGF0LCBpdCBsb29rcyBsaWtlIGl0IGRvZXMgaW1wcm92ZSB0aGUg
c2l0dWF0aW9uIGEgbGl0dGxlIGJpdCBzbwo+ID4gPiBpdCdzIGxpa2VseSB0aGlzIGlzIGdvaW5n
IHRvIGJlIHJlcXVpcmVkIHRvIG1ha2Ugd2F0ZXJtYXJrcyBvbiBTa3lsYWtlCj4gPiA+IGZ1bGx5
IGZ1bmN0aW9uYWwuCj4gPiA+IAo+ID4gPiBDaGFuZ2VzIHNpbmNlIHYyOgo+ID4gPiAgLSBSZWFs
bHkgYXBwbHkgbWlub3Igc3R5bGUgbml0cGlja3MgdG8gcGF0Y2ggdGhpcyB0aW1lCj4gPiA+IENo
YW5nZXMgc2luY2UgdjE6Cj4gPiA+ICAtIEFkZGVkIGNvbW1lbnRzIGFib3V0IHRoaXMgcHJvYmFi
bHkgYmVpbmcgb25lIG9mIHRoZSByZXF1aXJlbWVudHMgdG8KPiA+ID4gICAgZml4aW5nIFNreWxh
a2UncyB3YXRlcm1hcmsgaXNzdWVzCj4gPiA+ICAtIE1pbm9yIHN0eWxlIG5pdHBpY2tzIGZyb20g
TWF0dCBSb3Blcgo+ID4gPiAgLSBEaXNhYmxlIHRoZXNlIGZ1bmN0aW9ucyBvbiBCcm94dG9uLCBz
aW5jZSBpdCBkb2Vzbid0IGhhdmUgYW4gU0FHVgo+ID4gPiAKPiA+ID4gQ2M6IE1hdHQgUm9wZXIg
PG1hdHRoZXcuZC5yb3BlckBpbnRlbC5jb20+Cj4gPiA+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5p
ZWwudmV0dGVyQGZmd2xsLmNoPgo+ID4gPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq
YWxhQGxpbnV4LmludGVsLmNvbT4KPiA+ID4gU2lnbmVkLW9mZi1ieTogTHl1ZGUgPGNwYXVsQHJl
ZGhhdC5jb20+Cj4gPiAKPiA+IEkgZG9uJ3QgaGF2ZSBhIFNLTCB0byB0cnkgdGhpcyBvdXQgb24g
KG9ubHkgQlhUIGhlcmUpLCBidXQgdGhpcyBtYXRjaGVzCj4gPiBteSBpbnRlcnByZXRhdGlvbiBv
ZiB0aGUgY3VycmVudCBic3BlYyB0ZXh0LCBzbwo+ID4gCj4gPiBSZXZpZXdlZC1ieTogTWF0dCBS
b3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KPiA+IAo+ID4gSSB0aGluayB0aGlzIGFs
c28gYXBwbGllcyB0bwo+ID4gCj4gPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9w
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ2MjUKPiA+IAo+ID4gQW5kIG1heWJlIGEgK2NjIHN0YWJs
ZT8KPiA+IAo+IAo+IE9vcHMsIG9uZSBtb3JlIG1pbm9yIGlzc3VlIGJlbG93IHRoYXQgSSBtaXNz
ZWQgdGhlIGZpcnN0IHRpbWUgYXJvdW5kLgo+IAo+IC4uLgo+ID4gPiArCS8qIGJzcGVjIHNheXMg
dG8ga2VlcCByZXRyeWluZyBmb3IgYXQgbGVhc3QgMSBtcyAqLwo+ID4gPiArCXRpbWVvdXQgPSBq
aWZmaWVzICsgbXNlY3NfdG9famlmZmllcygxKTsKPiA+ID4gKwlkbyB7Cj4gPiA+ICsJCXJldCA9
IHNhbmR5YnJpZGdlX3Bjb2RlX3dyaXRlKGRldl9wcml2LCBHRU45X1BDT0RFX1NBR1ZfQ09OVFJP
TCwKPiA+ID4gKwkJCQkJICAgICAgR0VOOV9TQUdWX0RJU0FCTEUpOwo+ID4gPiArCQlpZiAocmV0
KSB7Cj4gPiA+ICsJCQlEUk1fRVJST1IoIkZhaWxlZCB0byBkaXNhYmxlIHRoZSBTQUdWXG4iKTsK
PiA+ID4gKwkJCWdvdG8gb3V0Owo+ID4gPiArCQl9Cj4gPiA+ICsKPiA+ID4gKwkJcmV0ID0gc2Fu
ZHlicmlkZ2VfcGNvZGVfcmVhZChkZXZfcHJpdiwgR0VOOV9QQ09ERV9TQUdWX0NPTlRST0wsCj4g
PiA+ICsJCQkJCSAgICAgJnRlbXApOwo+ID4gPiArCQlpZiAocmV0KSB7Cj4gPiA+ICsJCQlEUk1f
RVJST1IoIkZhaWxlZCB0byBjaGVjayB0aGUgc3RhdHVzIG9mIHRoZSBTQUdWXG4iKTsKPiA+ID4g
KwkJCWdvdG8gb3V0Owo+ID4gPiArCQl9Cj4gPiA+ICsJfSB3aGlsZSAoISh0ZW1wICYgMHgxKSAm
JiBqaWZmaWVzIDwgdGltZW91dCk7Cj4gCj4gV2Ugc2hvdWxkbid0IGNvbXBhcmUgamlmZmllcyBk
aXJlY3RseSBoZXJlIGR1ZSB0byB3cmFwYXJvdW5kOyB5b3UgY2FuCj4gdXNlIHRpbWVfYmVmb3Jl
KCkgdG8gaGFuZGxlIHRoYXQgc2FmZWx5LgoKV2UgaGF2ZSB3YWl0X2ZvcigpL193YWl0X2Zvcigp
IGZvciBwb2xsaW5nIHN0dWZmLgoKPiAKPiAKPiBNYXR0Cj4gCj4gPiA+ICsKPiA+ID4gKwlpZiAo
dGVtcCAmIDB4MSkgewo+ID4gPiArCQlkZXZfcHJpdi0+c2tsX3NhZ3ZfZW5hYmxlZCA9IGZhbHNl
Owo+ID4gPiArCX0gZWxzZSB7Cj4gPiA+ICsJCXJldCA9IC0xOwo+ID4gPiArCQlEUk1fRVJST1Io
IlJlcXVlc3QgdG8gZGlzYWJsZSBTQUdWIHRpbWVkIG91dFxuIik7Cj4gPiA+ICsJfQo+ID4gPiAr
Cj4gPiA+ICtvdXQ6Cj4gPiA+ICsJbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+cnBzLmh3X2xvY2sp
Owo+ID4gPiArCXJldHVybiByZXQ7Cj4gPiA+ICt9Cj4gPiA+ICsKPiA+ID4gK3N0YXRpYyB2b2lk
Cj4gPiA+ICBza2xfZGRiX2dldF9waXBlX2FsbG9jYXRpb25fbGltaXRzKHN0cnVjdCBkcm1fZGV2
aWNlICpkZXYsCj4gPiA+ICAJCQkJICAgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNz
dGF0ZSwKPiA+ID4gIAkJCQkgICBzdHJ1Y3Qgc2tsX2RkYl9lbnRyeSAqYWxsb2MsIC8qIG91dCAq
Lwo+ID4gPiBAQCAtMzY4Niw2ICszNzg5LDExIEBAIHN0YXRpYyB2b2lkIHNrbF93cml0ZV93bV92
YWx1ZXMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gPiAgCXN0cnVjdCBk
cm1fZGV2aWNlICpkZXYgPSAmZGV2X3ByaXYtPmRybTsKPiA+ID4gIAlzdHJ1Y3QgaW50ZWxfY3J0
YyAqY3J0YzsKPiA+ID4gIAo+ID4gPiArCWlmIChkZXZfcHJpdi0+YWN0aXZlX2NydGNzID09IDEp
Cj4gPiA+ICsJCXNrbF9lbmFibGVfc2FndihkZXZfcHJpdik7Cj4gPiA+ICsJZWxzZQo+ID4gPiAr
CQlza2xfZGlzYWJsZV9zYWd2KGRldl9wcml2KTsKPiA+ID4gKwo+ID4gPiAgCWZvcl9lYWNoX2lu
dGVsX2NydGMoZGV2LCBjcnRjKSB7Cj4gPiA+ICAJCWludCBpLCBsZXZlbCwgbWF4X2xldmVsID0g
aWxrX3dtX21heF9sZXZlbChkZXYpOwo+ID4gPiAgCQllbnVtIHBpcGUgcGlwZSA9IGNydGMtPnBp
cGU7Cj4gPiA+IEBAIC00MjI4LDYgKzQzMzYsOCBAQCB2b2lkIHNrbF93bV9nZXRfaHdfc3RhdGUo
c3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+ID4gIAkJLyogRWFzeS9jb21tb24gY2FzZTsganVz
dCBzYW5pdGl6ZSBEREIgbm93IGlmIGV2ZXJ5dGhpbmcgb2ZmICovCj4gPiA+ICAJCW1lbXNldChk
ZGIsIDAsIHNpemVvZigqZGRiKSk7Cj4gPiA+ICAJfQo+ID4gPiArCj4gPiA+ICsJc2tsX3NhZ3Zf
Z2V0X2h3X3N0YXRlKGRldl9wcml2KTsKPiA+ID4gIH0KPiA+ID4gIAo+ID4gPiAgc3RhdGljIHZv
aWQgaWxrX3BpcGVfd21fZ2V0X2h3X3N0YXRlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiA+ID4g
LS0gCj4gPiA+IDIuNy40Cj4gPiA+IAo+ID4gCj4gPiAtLSAKPiA+IE1hdHQgUm9wZXIKPiA+IEdy
YXBoaWNzIFNvZnR3YXJlIEVuZ2luZWVyCj4gPiBJb1RHIFBsYXRmb3JtIEVuYWJsaW5nICYgRGV2
ZWxvcG1lbnQKPiA+IEludGVsIENvcnBvcmF0aW9uCj4gPiAoOTE2KSAzNTYtMjc5NQo+ID4gX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IEludGVsLWdm
eCBtYWlsaW5nIGxpc3QKPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0
dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4g
Cj4gLS0gCj4gTWF0dCBSb3Blcgo+IEdyYXBoaWNzIFNvZnR3YXJlIEVuZ2luZWVyCj4gSW9URyBQ
bGF0Zm9ybSBFbmFibGluZyAmIERldmVsb3BtZW50Cj4gSW50ZWwgQ29ycG9yYXRpb24KPiAoOTE2
KSAzNTYtMjc5NQo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv
cC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu
dGVsLWdmeAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl
bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn
L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==