From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [PATCH v3] drm/i915/skl: Add support for the SAGV, fix underrun hangs Date: Wed, 13 Jul 2016 11:17:52 -0700 Message-ID: <20160713181752.GK18143@intel.com> References: <1468344963-6282-1-git-send-email-cpaul@redhat.com> <20160712182139.GH18143@intel.com> <20160713180846.GJ18143@intel.com> <20160713181209.GC4329@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20160713181209.GC4329@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, "open list:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...), linux-kernel@vger.kernel.org (open list)" , Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKdWwgMTMsIDIwMTYgYXQgMDk6MTI6MDlQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFdlZCwgSnVsIDEzLCAyMDE2IGF0IDExOjA4OjQ2QU0gLTA3MDAsIE1hdHQg Um9wZXIgd3JvdGU6Cj4gPiBPbiBUdWUsIEp1bCAxMiwgMjAxNiBhdCAxMToyMTozOUFNIC0wNzAw LCBNYXR0IFJvcGVyIHdyb3RlOgo+ID4gPiBPbiBUdWUsIEp1bCAxMiwgMjAxNiBhdCAwMTozNjow M1BNIC0wNDAwLCBMeXVkZSB3cm90ZToKPiA+ID4gPiBTaW5jZSB0aGUgd2F0ZXJtYXJrIGNhbGN1 bGF0aW9ucyBmb3IgU2t5bGFrZSBhcmUgc3RpbGwgYnJva2VuLCB3ZSdyZSBhcHQKPiA+ID4gPiB0 byBoaXR0aW5nIHVuZGVycnVucyB2ZXJ5IGVhc2lseSB1bmRlciBtdWx0aS1tb25pdG9yIGNvbmZp Z3VyYXRpb25zLgo+ID4gPiA+IFdoaWxlIGl0IHdvdWxkIGJlIGxvdmVseSBpZiB0aGlzIHdhcyBm aXhlZCwgaXQncyBub3QuIEFub3RoZXIgcHJvYmxlbQo+ID4gPiA+IHRoYXQncyBiZWVuIGNvbWlu ZyBmcm9tIHRoaXMgaG93ZXZlciwgaXMgdGhlIG15c3RlcmlvdXMgaXNzdWUgb2YKPiA+ID4gPiB1 bmRlcnJ1bnMgY2F1c2luZyBmdWxsIHN5c3RlbSBoYW5ncy4gQW4gZWFzeSB3YXkgdG8gcmVwcm9k dWNlIHRoaXMgd2l0aAo+ID4gPiA+IGEgc2t5bGFrZSBzeXN0ZW06Cj4gPiA+ID4gCj4gPiA+ID4g LSBHZXQgYSBsYXB0b3Agd2l0aCBhIHNreWxha2UgR1BVLCBhbmQgaG9vayB1cCB0d28gZXh0ZXJu YWwgbW9uaXRvcnMgdG8KPiA+ID4gPiAgIGl0Cj4gPiA+ID4gLSBNb3ZlIHRoZSBjdXJzb3IgZnJv bSB0aGUgYnVpbHQtaW4gTENEIHRvIG9uZSBvZiB0aGUgZXh0ZXJuYWwgZGlzcGxheXMKPiA+ID4g PiAgIGFzIHF1aWNrbHkgYXMgeW91IGNhbgo+ID4gPiA+IC0gWW91J2xsIGdldCBhIGZldyBwaXBl IHVuZGVycnVucywgYW5kIGV2ZW50dWFsbHkgdGhlIGVudGlyZSBzeXN0ZW0gd2lsbAo+ID4gPiA+ ICAganVzdCBmcmVlemUuCj4gPiA+ID4gCj4gPiA+ID4gQWZ0ZXIgZG9pbmcgYSBsb3Qgb2YgaW52 ZXN0aWdhdGlvbiBhbmQgcmVhZGluZyB0aHJvdWdoIHRoZSBic3BlYywgSQo+ID4gPiA+IGZvdW5k IHRoZSBleGlzdGVuY2Ugb2YgdGhlIFNBR1YsIHdoaWNoIGlzIHJlc3BvbnNpYmxlIGZvciBhZGp1 c3RpbmcgdGhlCj4gPiA+ID4gc3lzdGVtIGFnZW50IHZvbHRhZ2UgYW5kIGNsb2NrIGZyZXF1ZW5j aWVzIGRlcGVuZGluZyBvbiBob3cgbXVjaCBwb3dlcgo+ID4gPiA+IHdlIG5lZWQuIEFjY29yZGlu ZyB0byB0aGUgYnNwZWM6Cj4gPiA+ID4gCj4gPiA+ID4gIlRoZSBkaXNwbGF5IGVuZ2luZSBhY2Nl c3MgdG8gc3lzdGVtIG1lbW9yeSBpcyBibG9ja2VkIGR1cmluZyB0aGUKPiA+ID4gPiAgYWRqdXN0 bWVudCB0aW1lLiBTQUdWIGRlZmF1bHRzIHRvIGVuYWJsZWQuIFNvZnR3YXJlIG11c3QgdXNlIHRo ZQo+ID4gPiA+ICBHVC1kcml2ZXIgcGNvZGUgbWFpbGJveCB0byBkaXNhYmxlIFNBR1Ygd2hlbiB0 aGUgZGlzcGxheSBlbmdpbmUgaXMgbm90Cj4gPiA+ID4gIGFibGUgdG8gdG9sZXJhdGUgdGhlIGJs b2NraW5nIHRpbWUuIgo+ID4gPiA+IAo+ID4gPiA+IFRoZSByZXN0IG9mIHRoZSBic3BlYyBnb2Vz IG9uIHRvIGV4cGxhaW4gdGhhdCBzb2Z0d2FyZSBjYW4gc2ltcGx5IGxlYXZlCj4gPiA+ID4gdGhl IFNBR1YgZW5hYmxlZCwgYW5kIGRpc2FibGUgaXQgd2hlbiB3ZSB1c2UgaW50ZXJsYWNlZCBwaXBl cy9oYXZlIG1vcmUKPiA+ID4gPiB0aGVuIG9uZSBwaXBlIGFjdGl2ZS4KPiA+ID4gPiAKPiA+ID4g PiBTdXJlIGVub3VnaCwgd2l0aCB0aGlzIHBhdGNoc2V0IHRoZSBzeXN0ZW0gaGFuZ3MgcmVzdWx0 aW5nIGZyb20gcGlwZQo+ID4gPiA+IHVuZGVycnVucyBvbiBTa3lsYWtlIGhhdmUgY29tcGxldGVs eSB2YW5pc2hlZCBvbiBteSBUNDYwcy4gQWRkaXRpb25hbGx5LAo+ID4gPiA+IHRoZSBic3BlYyBt ZW50aW9ucyB0dXJuaW5nIG9mZiB0aGUgU0FHVgl3aXRoIG1vcmUgdGhlbiBvbmUgcGlwZSBlbmFi bGVkCj4gPiA+ID4gYXMgYSB3b3JrYXJvdW5kIGZvciBkaXNwbGF5IHVuZGVycnVucy4gV2hpbGUg dGhpcyBwYXRjaCBkb2Vzbid0IGVudGlyZWx5Cj4gPiA+ID4gZml4IHRoYXQsIGl0IGxvb2tzIGxp a2UgaXQgZG9lcyBpbXByb3ZlIHRoZSBzaXR1YXRpb24gYSBsaXR0bGUgYml0IHNvCj4gPiA+ID4g aXQncyBsaWtlbHkgdGhpcyBpcyBnb2luZyB0byBiZSByZXF1aXJlZCB0byBtYWtlIHdhdGVybWFy a3Mgb24gU2t5bGFrZQo+ID4gPiA+IGZ1bGx5IGZ1bmN0aW9uYWwuCj4gPiA+ID4gCj4gPiA+ID4g Q2hhbmdlcyBzaW5jZSB2MjoKPiA+ID4gPiAgLSBSZWFsbHkgYXBwbHkgbWlub3Igc3R5bGUgbml0 cGlja3MgdG8gcGF0Y2ggdGhpcyB0aW1lCj4gPiA+ID4gQ2hhbmdlcyBzaW5jZSB2MToKPiA+ID4g PiAgLSBBZGRlZCBjb21tZW50cyBhYm91dCB0aGlzIHByb2JhYmx5IGJlaW5nIG9uZSBvZiB0aGUg cmVxdWlyZW1lbnRzIHRvCj4gPiA+ID4gICAgZml4aW5nIFNreWxha2UncyB3YXRlcm1hcmsgaXNz dWVzCj4gPiA+ID4gIC0gTWlub3Igc3R5bGUgbml0cGlja3MgZnJvbSBNYXR0IFJvcGVyCj4gPiA+ ID4gIC0gRGlzYWJsZSB0aGVzZSBmdW5jdGlvbnMgb24gQnJveHRvbiwgc2luY2UgaXQgZG9lc24n dCBoYXZlIGFuIFNBR1YKPiA+ID4gPiAKPiA+ID4gPiBDYzogTWF0dCBSb3BlciA8bWF0dGhldy5k LnJvcGVyQGludGVsLmNvbT4KPiA+ID4gPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRl ckBmZndsbC5jaD4KPiA+ID4gPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBMeXVkZSA8Y3BhdWxAcmVkaGF0 LmNvbT4KPiA+ID4gCj4gPiA+IEkgZG9uJ3QgaGF2ZSBhIFNLTCB0byB0cnkgdGhpcyBvdXQgb24g KG9ubHkgQlhUIGhlcmUpLCBidXQgdGhpcyBtYXRjaGVzCj4gPiA+IG15IGludGVycHJldGF0aW9u IG9mIHRoZSBjdXJyZW50IGJzcGVjIHRleHQsIHNvCj4gPiA+IAo+ID4gPiBSZXZpZXdlZC1ieTog TWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KPiA+ID4gCj4gPiA+IEkgdGhp bmsgdGhpcyBhbHNvIGFwcGxpZXMgdG8KPiA+ID4gCj4gPiA+IEJ1Z3ppbGxhOiBodHRwczovL2J1 Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD05NDYyNQo+ID4gPiAKPiA+ID4gQW5k IG1heWJlIGEgK2NjIHN0YWJsZT8KPiA+ID4gCj4gPiAKPiA+IE9vcHMsIG9uZSBtb3JlIG1pbm9y IGlzc3VlIGJlbG93IHRoYXQgSSBtaXNzZWQgdGhlIGZpcnN0IHRpbWUgYXJvdW5kLgo+ID4gCj4g PiAuLi4KPiA+ID4gPiArCS8qIGJzcGVjIHNheXMgdG8ga2VlcCByZXRyeWluZyBmb3IgYXQgbGVh c3QgMSBtcyAqLwo+ID4gPiA+ICsJdGltZW91dCA9IGppZmZpZXMgKyBtc2Vjc190b19qaWZmaWVz KDEpOwo+ID4gPiA+ICsJZG8gewo+ID4gPiA+ICsJCXJldCA9IHNhbmR5YnJpZGdlX3Bjb2RlX3dy aXRlKGRldl9wcml2LCBHRU45X1BDT0RFX1NBR1ZfQ09OVFJPTCwKPiA+ID4gPiArCQkJCQkgICAg ICBHRU45X1NBR1ZfRElTQUJMRSk7Cj4gPiA+ID4gKwkJaWYgKHJldCkgewo+ID4gPiA+ICsJCQlE Uk1fRVJST1IoIkZhaWxlZCB0byBkaXNhYmxlIHRoZSBTQUdWXG4iKTsKPiA+ID4gPiArCQkJZ290 byBvdXQ7Cj4gPiA+ID4gKwkJfQo+ID4gPiA+ICsKPiA+ID4gPiArCQlyZXQgPSBzYW5keWJyaWRn ZV9wY29kZV9yZWFkKGRldl9wcml2LCBHRU45X1BDT0RFX1NBR1ZfQ09OVFJPTCwKPiA+ID4gPiAr CQkJCQkgICAgICZ0ZW1wKTsKPiA+ID4gPiArCQlpZiAocmV0KSB7Cj4gPiA+ID4gKwkJCURSTV9F UlJPUigiRmFpbGVkIHRvIGNoZWNrIHRoZSBzdGF0dXMgb2YgdGhlIFNBR1ZcbiIpOwo+ID4gPiA+ ICsJCQlnb3RvIG91dDsKPiA+ID4gPiArCQl9Cj4gPiA+ID4gKwl9IHdoaWxlICghKHRlbXAgJiAw eDEpICYmIGppZmZpZXMgPCB0aW1lb3V0KTsKPiA+IAo+ID4gV2Ugc2hvdWxkbid0IGNvbXBhcmUg amlmZmllcyBkaXJlY3RseSBoZXJlIGR1ZSB0byB3cmFwYXJvdW5kOyB5b3UgY2FuCj4gPiB1c2Ug dGltZV9iZWZvcmUoKSB0byBoYW5kbGUgdGhhdCBzYWZlbHkuCj4gCj4gV2UgaGF2ZSB3YWl0X2Zv cigpL193YWl0X2ZvcigpIGZvciBwb2xsaW5nIHN0dWZmLgoKVGhvc2UganVzdCBibG9jayB1bnRp bCBhIGNvbmRpdGlvbiBiZWNvbWVzIHRydWUsIHJpZ2h0PyAgSW4gdGhpcyBjYXNlIG15CnVuZGVy c3RhbmRpbmcgZnJvbSB0aGUgYnNwZWMgaXMgdGhhdCB3ZSBuZWVkIHRvIGtlZXAgcmUtd3JpdGlu ZyB0aGUgU0FHVgpkaXNhYmxlIHVudGlsIGl0IHN0aWNrcy4KCgpNYXR0Cgo+IAo+ID4gCj4gPiAK PiA+IE1hdHQKPiA+IAo+ID4gPiA+ICsKPiA+ID4gPiArCWlmICh0ZW1wICYgMHgxKSB7Cj4gPiA+ ID4gKwkJZGV2X3ByaXYtPnNrbF9zYWd2X2VuYWJsZWQgPSBmYWxzZTsKPiA+ID4gPiArCX0gZWxz ZSB7Cj4gPiA+ID4gKwkJcmV0ID0gLTE7Cj4gPiA+ID4gKwkJRFJNX0VSUk9SKCJSZXF1ZXN0IHRv IGRpc2FibGUgU0FHViB0aW1lZCBvdXRcbiIpOwo+ID4gPiA+ICsJfQo+ID4gPiA+ICsKPiA+ID4g PiArb3V0Ogo+ID4gPiA+ICsJbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+cnBzLmh3X2xvY2spOwo+ ID4gPiA+ICsJcmV0dXJuIHJldDsKPiA+ID4gPiArfQo+ID4gPiA+ICsKPiA+ID4gPiArc3RhdGlj IHZvaWQKPiA+ID4gPiAgc2tsX2RkYl9nZXRfcGlwZV9hbGxvY2F0aW9uX2xpbWl0cyhzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2LAo+ID4gPiA+ICAJCQkJICAgY29uc3Qgc3RydWN0IGludGVsX2NydGNf c3RhdGUgKmNzdGF0ZSwKPiA+ID4gPiAgCQkJCSAgIHN0cnVjdCBza2xfZGRiX2VudHJ5ICphbGxv YywgLyogb3V0ICovCj4gPiA+ID4gQEAgLTM2ODYsNiArMzc4OSwxMSBAQCBzdGF0aWMgdm9pZCBz a2xfd3JpdGVfd21fdmFsdWVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ ID4gPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSAmZGV2X3ByaXYtPmRybTsKPiA+ID4gPiAg CXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjOwo+ID4gPiA+ICAKPiA+ID4gPiArCWlmIChkZXZfcHJp di0+YWN0aXZlX2NydGNzID09IDEpCj4gPiA+ID4gKwkJc2tsX2VuYWJsZV9zYWd2KGRldl9wcml2 KTsKPiA+ID4gPiArCWVsc2UKPiA+ID4gPiArCQlza2xfZGlzYWJsZV9zYWd2KGRldl9wcml2KTsK PiA+ID4gPiArCj4gPiA+ID4gIAlmb3JfZWFjaF9pbnRlbF9jcnRjKGRldiwgY3J0Yykgewo+ID4g PiA+ICAJCWludCBpLCBsZXZlbCwgbWF4X2xldmVsID0gaWxrX3dtX21heF9sZXZlbChkZXYpOwo+ ID4gPiA+ICAJCWVudW0gcGlwZSBwaXBlID0gY3J0Yy0+cGlwZTsKPiA+ID4gPiBAQCAtNDIyOCw2 ICs0MzM2LDggQEAgdm9pZCBza2xfd21fZ2V0X2h3X3N0YXRlKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYpCj4gPiA+ID4gIAkJLyogRWFzeS9jb21tb24gY2FzZTsganVzdCBzYW5pdGl6ZSBEREIgbm93 IGlmIGV2ZXJ5dGhpbmcgb2ZmICovCj4gPiA+ID4gIAkJbWVtc2V0KGRkYiwgMCwgc2l6ZW9mKCpk ZGIpKTsKPiA+ID4gPiAgCX0KPiA+ID4gPiArCj4gPiA+ID4gKwlza2xfc2Fndl9nZXRfaHdfc3Rh dGUoZGV2X3ByaXYpOwo+ID4gPiA+ICB9Cj4gPiA+ID4gIAo+ID4gPiA+ICBzdGF0aWMgdm9pZCBp bGtfcGlwZV93bV9nZXRfaHdfc3RhdGUoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ID4gPiA+IC0t IAo+ID4gPiA+IDIuNy40Cj4gPiA+ID4gCj4gPiA+IAo+ID4gPiAtLSAKPiA+ID4gTWF0dCBSb3Bl cgo+ID4gPiBHcmFwaGljcyBTb2Z0d2FyZSBFbmdpbmVlcgo+ID4gPiBJb1RHIFBsYXRmb3JtIEVu YWJsaW5nICYgRGV2ZWxvcG1lbnQKPiA+ID4gSW50ZWwgQ29ycG9yYXRpb24KPiA+ID4gKDkxNikg MzU2LTI3OTUKPiA+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiA+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gPiBJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCj4gPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gPiAKPiA+IC0tIAo+ID4gTWF0dCBSb3Blcgo+ID4gR3Jh cGhpY3MgU29mdHdhcmUgRW5naW5lZXIKPiA+IElvVEcgUGxhdGZvcm0gRW5hYmxpbmcgJiBEZXZl bG9wbWVudAo+ID4gSW50ZWwgQ29ycG9yYXRpb24KPiA+ICg5MTYpIDM1Ni0yNzk1Cj4gPiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKPiAK PiAtLSAKPiBWaWxsZSBTeXJqw6Rsw6QKPiBJbnRlbCBPVEMKCi0tIApNYXR0IFJvcGVyCkdyYXBo aWNzIFNvZnR3YXJlIEVuZ2luZWVyCklvVEcgUGxhdGZvcm0gRW5hYmxpbmcgJiBEZXZlbG9wbWVu dApJbnRlbCBDb3Jwb3JhdGlvbgooOTE2KSAzNTYtMjc5NQpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK