Re: [PATCH] drm/i915: Ignore panel type from OpRegion on SKL

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Jul 12, 2016 at 03:00:37PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Dell XPS 13 9350 apparently doesn't like it when we use the panel type
> from OpRegion. The OpRegion panel type (0) tells us to use use low
> vswing for eDP, whereas the VBT panel type (2) tells us to use normal
> vswing. The problem is that low vswing results in some display flickers.
> Since no one seems to know how this stuff is supposed to be handled,
> let's just ignore the OpRegion panel type on SKL for now.
> 
> Reported-by: James Bottomley <James.Bottomley@HansenPartnership.com>
> Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
> Cc: drm-intel-fixes@lists.freedesktop.org
> References: https://lists.freedesktop.org/archives/intel-gfx/2016-June/098826.html
> Fixes: a05628195a0d ("drm/i915: Get panel_type from OpRegion panel details")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_opregion.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
> index c27d5eb063d0..259760f12d16 100644
> --- a/drivers/gpu/drm/i915/intel_opregion.c
> +++ b/drivers/gpu/drm/i915/intel_opregion.c
> @@ -1072,5 +1072,16 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv)
>  		return -ENODEV;
>  	}
>  
> +	/*
> +	 * FIXME On Dell XPS 13 9350 the OpRegion panel type (0) gives us
> +	 * low vswing for eDP, whereas the VBT panel type (2) gives us normal
> +	 * vswing instead. Low vswing results in some display flickers, so
> +	 * let's simply ignore the OpRegion panel type on SKL for now.
> +	 */
> +	if (IS_SKYLAKE(dev_priv)) {
> +		DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret);

I did s/ret/ret - 1/ here to make the debug output correct, and pushed
the patch to dinq. Thanks for the review.

> +		return -ENODEV;
> +	}
> +
>  	return ret - 1;
>  }
> -- 
> 2.7.4

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx