From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/i915/fbdev: Check for the framebuffer before use Date: Thu, 14 Jul 2016 16:49:02 +0200 Message-ID: <20160714144902.GI17101@phenom.ffwll.local> References: <1468431285-28264-1-git-send-email-chris@chris-wilson.co.uk> <1468431285-28264-2-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id A33B16E8CA for ; Thu, 14 Jul 2016 14:49:07 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id x83so9364261wma.3 for ; Thu, 14 Jul 2016 07:49:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1468431285-28264-2-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, thierry.reding@gmail.com, Mika Kuoppala List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKdWwgMTMsIDIwMTYgYXQgMDY6MzQ6NDVQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IElmIHRoZSBmYmRldiBwcm9iaW5nIGZhaWxzLCBhbmQgaW4gb3VyIGVycm9yIHBhdGgg d2UgZmFpbCB0byBjbGVhciB0aGUKPiBkZXZfcHJpdi0+ZmJkZXYsIHRoZW4gd2UgY2FuIHRyeSBh bmQgdXNlIGEgZGFuZ2xpbmcgZmJkZXYgcG9pbnRlciwgYW5kCj4gaW4gcGFydGljdWxhciBhIE5V TEwgZmIuIFRoaXMgY291bGQgYWxzbyBoYXBwZW4gaW4gcGF0aG9sb2dpY2FsIGNhc2VzCj4gd2hl cmUgd2UgdHJ5IHRvIG9wZXJhdGUgb24gdGhlIGZiZGV2IHByaW9yIHRvIGl0IGJlaW5nIHByb2Jl ZC4KPiAKPiBSZXBvcnRlZC1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0 QGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNo cmlzLXdpbHNvbi5jby51az4KPiBDYzogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hv cnN0QGxpbnV4LmludGVsLmNvbT4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBm ZndsbC5jaD4KPiBDYzogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBpbnRlbC5jb20+CgpU aGllcnJ5IFJlZGRpbmcgaGFzIGEgcGF0Y2ggc2VyaWVzIGluIGZsaWdodCBmb3IgZ2VuZXJpYyBk ZWxheWVkIGZiZGV2CnNldHVwLCB3aGV0aGVyIGl0J3MgZGVsYXllZCB0byBkdWUgYXN5bmMgaW5p dCBvciBiZWNhdXNlIHRoZXJlJ3Mgbm90aGluZwp5ZXQgY29ubmVjdGVkICh3aGljaCBzb21lIG9m IHRoZSBlbWJlZGRlZCBkcml2ZXJzIGhhY2sgdG9nZXRoZXIpLiBXaXRoCnRob3NlIHBhdGNoZXMg bW9zdCBvZiB0aGVzZSBjaGVja3Mgc2hvdWxkIGJlY29tZSB1bmVjZXNzYXJ5IGFnYWluLgoKQWRk aW5nIFRoaWVycnkgc28gaGUncyBhd2FyZSB0aGF0IHRoZXJlJ3MgbW9yZSB0byBkbyB3aGVuIHJl YmFzaW5nLCBhbmQgc28KaGUga25vd3Mgd2hlcmUgaGUgY2FuIGZpbmQgcmV2aWV3ZXJzIDstKQoK UmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMgfCAyNSArKysrKysrKysrKy0t LS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAxNCBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJk ZXYuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMKPiBpbmRleCBlZjE3ZDg4 YTFiYzcuLjIzMTI5ZGNmYmE5ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9mYmRldi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJkZXYuYwo+ IEBAIC03ODIsNyArNzgyLDcgQEAgdm9pZCBpbnRlbF9mYmRldl9zZXRfc3VzcGVuZChzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2LCBpbnQgc3RhdGUsIGJvb2wgc3luY2hyb25vdXMKPiAgCXN0cnVjdCBp bnRlbF9mYmRldiAqaWZiZGV2ID0gZGV2X3ByaXYtPmZiZGV2Owo+ICAJc3RydWN0IGZiX2luZm8g KmluZm87Cj4gIAo+IC0JaWYgKCFpZmJkZXYpCj4gKwlpZiAoIWlmYmRldiB8fCAhaWZiZGV2LT5m YikKPiAgCQlyZXR1cm47Cj4gIAo+ICAJaW5mbyA9IGlmYmRldi0+aGVscGVyLmZiZGV2Owo+IEBA IC04MjcsMzEgKzgyNywyOCBAQCB2b2lkIGludGVsX2ZiZGV2X3NldF9zdXNwZW5kKHN0cnVjdCBk cm1fZGV2aWNlICpkZXYsIGludCBzdGF0ZSwgYm9vbCBzeW5jaHJvbm91cwo+ICAKPiAgdm9pZCBp bnRlbF9mYmRldl9vdXRwdXRfcG9sbF9jaGFuZ2VkKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4g IHsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsK PiAtCWlmIChkZXZfcHJpdi0+ZmJkZXYpCj4gLQkJZHJtX2ZiX2hlbHBlcl9ob3RwbHVnX2V2ZW50 KCZkZXZfcHJpdi0+ZmJkZXYtPmhlbHBlcik7Cj4gKwlzdHJ1Y3QgaW50ZWxfZmJkZXYgKmlmYmRl diA9IHRvX2k5MTUoZGV2KS0+ZmJkZXY7Cj4gKwo+ICsJaWYgKGlmYmRldiAmJiBpZmJkZXYtPmZi KQo+ICsJCWRybV9mYl9oZWxwZXJfaG90cGx1Z19ldmVudCgmaWZiZGV2LT5oZWxwZXIpOwo+ICB9 Cj4gIAo+ICB2b2lkIGludGVsX2ZiZGV2X3Jlc3RvcmVfbW9kZShzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2KQo+ICB7Cj4gLQlpbnQgcmV0Owo+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2ID0gdG9faTkxNShkZXYpOwo+IC0Jc3RydWN0IGludGVsX2ZiZGV2ICppZmJkZXYgPSBkZXZf cHJpdi0+ZmJkZXY7Cj4gLQlzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyOwo+ICsJc3Ry dWN0IGludGVsX2ZiZGV2ICppZmJkZXYgPSB0b19pOTE1KGRldiktPmZiZGV2Owo+ICAKPiAgCWlm ICghaWZiZGV2KQo+ICAJCXJldHVybjsKPiAgCj4gIAlpbnRlbF9mYmRldl9zeW5jKGlmYmRldik7 Cj4gKwlpZiAoIWlmYmRldi0+ZmIpCj4gKwkJcmV0dXJuOwo+ICAKPiAtCWZiX2hlbHBlciA9ICZp ZmJkZXYtPmhlbHBlcjsKPiAtCj4gLQlyZXQgPSBkcm1fZmJfaGVscGVyX3Jlc3RvcmVfZmJkZXZf bW9kZV91bmxvY2tlZChmYl9oZWxwZXIpOwo+IC0JaWYgKHJldCkgewo+ICsJaWYgKGRybV9mYl9o ZWxwZXJfcmVzdG9yZV9mYmRldl9tb2RlX3VubG9ja2VkKCZpZmJkZXYtPmhlbHBlcikpIHsKPiAg CQlEUk1fREVCVUcoImZhaWxlZCB0byByZXN0b3JlIGNydGMgbW9kZVxuIik7Cj4gIAl9IGVsc2Ug ewo+IC0JCW11dGV4X2xvY2soJmZiX2hlbHBlci0+ZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICsJCW11 dGV4X2xvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiAgCQlpbnRlbF9mYl9vYmpfaW52YWxpZGF0 ZShpZmJkZXYtPmZiLT5vYmosIE9SSUdJTl9HVFQpOwo+IC0JCW11dGV4X3VubG9jaygmZmJfaGVs cGVyLT5kZXYtPnN0cnVjdF9tdXRleCk7Cj4gKwkJbXV0ZXhfdW5sb2NrKCZkZXYtPnN0cnVjdF9t dXRleCk7Cj4gIAl9Cj4gIH0KPiAtLSAKPiAyLjguMQo+IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29m dHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=