* [PATCH] drm/i915/guc: Revert "drm/i915/guc: enable GuC loading & submission by default"
@ 2016-07-18 23:27 Rodrigo Vivi
2016-07-19 5:23 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-07-19 6:40 ` [PATCH] " Daniel Vetter
0 siblings, 2 replies; 3+ messages in thread
From: Rodrigo Vivi @ 2016-07-18 23:27 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Stable, Rodrigo Vivi
This reverts commit 041824ee25cfc535ba2d9a22c217df735ea2471e.
We have latency issues that might impact the performance: #96606.
and hangs and loading issues on resume after S4: #96526.
This is also blocking a platform milestone so let's disable
this for now while we make sure we don't have any more loading
issue, or related basic hangs and it pass BAT for real in all
platofmrs.
In case BAT is wrong let's first fix BAT before re-enable it here.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96606
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96526
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Dave Gordon <david.s.gordon@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Stable <stable@vger.kernel.org>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Christophe Prigent <christophe.prigent@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/i915/i915_params.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index 8b13bfa..b6e404c 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -54,8 +54,8 @@ struct i915_params i915 __read_mostly = {
.verbose_state_checks = 1,
.nuclear_pageflip = 0,
.edp_vswing = 0,
- .enable_guc_loading = -1,
- .enable_guc_submission = -1,
+ .enable_guc_loading = 0,
+ .enable_guc_submission = 0,
.guc_log_level = -1,
.enable_dp_mst = true,
.inject_load_failure = 0,
@@ -203,12 +203,12 @@ MODULE_PARM_DESC(edp_vswing,
module_param_named_unsafe(enable_guc_loading, i915.enable_guc_loading, int, 0400);
MODULE_PARM_DESC(enable_guc_loading,
"Enable GuC firmware loading "
- "(-1=auto [default], 0=never, 1=if available, 2=required)");
+ "(-1=auto, 0=never [default], 1=if available, 2=required)");
module_param_named_unsafe(enable_guc_submission, i915.enable_guc_submission, int, 0400);
MODULE_PARM_DESC(enable_guc_submission,
"Enable GuC submission "
- "(-1=auto [default], 0=never, 1=if available, 2=required)");
+ "(-1=auto, 0=never [default], 1=if available, 2=required)");
module_param_named(guc_log_level, i915.guc_log_level, int, 0400);
MODULE_PARM_DESC(guc_log_level,
--
2.5.5
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread* ✗ Ro.CI.BAT: failure for drm/i915/guc: Revert "drm/i915/guc: enable GuC loading & submission by default"
2016-07-18 23:27 [PATCH] drm/i915/guc: Revert "drm/i915/guc: enable GuC loading & submission by default" Rodrigo Vivi
@ 2016-07-19 5:23 ` Patchwork
2016-07-19 6:40 ` [PATCH] " Daniel Vetter
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2016-07-19 5:23 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/guc: Revert "drm/i915/guc: enable GuC loading & submission by default"
URL : https://patchwork.freedesktop.org/series/10005/
State : failure
== Summary ==
Series 10005v1 drm/i915/guc: Revert "drm/i915/guc: enable GuC loading & submission by default"
http://patchwork.freedesktop.org/api/1.0/series/10005/revisions/1/mbox
Test drv_module_reload_basic:
dmesg-warn -> PASS (ro-skl3-i5-6260u)
Test gem_sync:
Subgroup basic-store-each:
pass -> DMESG-FAIL (ro-bdw-i7-5600u)
fi-hsw-i7-4770k total:243 pass:210 dwarn:0 dfail:0 fail:13 skip:20
fi-kbl-qkkr total:243 pass:175 dwarn:28 dfail:1 fail:11 skip:28
fi-skl-i5-6260u total:243 pass:219 dwarn:0 dfail:0 fail:12 skip:12
fi-skl-i7-6700k total:243 pass:205 dwarn:0 dfail:0 fail:12 skip:26
fi-snb-i7-2600 total:243 pass:190 dwarn:0 dfail:0 fail:13 skip:40
ro-bdw-i5-5250u total:243 pass:214 dwarn:4 dfail:0 fail:12 skip:13
ro-bdw-i7-5557U total:243 pass:215 dwarn:0 dfail:0 fail:12 skip:16
ro-bdw-i7-5600u total:243 pass:199 dwarn:0 dfail:1 fail:11 skip:32
ro-bsw-n3050 total:218 pass:173 dwarn:0 dfail:0 fail:2 skip:42
ro-byt-n2820 total:243 pass:191 dwarn:0 dfail:0 fail:14 skip:38
ro-hsw-i3-4010u total:243 pass:206 dwarn:0 dfail:0 fail:13 skip:24
ro-hsw-i7-4770r total:243 pass:206 dwarn:0 dfail:0 fail:13 skip:24
ro-ilk-i7-620lm total:243 pass:166 dwarn:0 dfail:0 fail:14 skip:63
ro-ilk1-i5-650 total:238 pass:166 dwarn:0 dfail:0 fail:14 skip:58
ro-ivb-i7-3770 total:243 pass:197 dwarn:0 dfail:0 fail:13 skip:33
ro-skl3-i5-6260u total:243 pass:219 dwarn:0 dfail:0 fail:12 skip:12
ro-snb-i7-2620M total:243 pass:188 dwarn:0 dfail:0 fail:13 skip:42
fi-bsw-n3050 failed to connect after reboot
Results at /archive/results/CI_IGT_test/RO_Patchwork_1522/
3e14755 drm-intel-nightly: 2016y-07m-18d-14h-26m-21s UTC integration manifest
edff3ac drm/i915/guc: Revert "drm/i915/guc: enable GuC loading & submission by default"
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/i915/guc: Revert "drm/i915/guc: enable GuC loading & submission by default"
2016-07-18 23:27 [PATCH] drm/i915/guc: Revert "drm/i915/guc: enable GuC loading & submission by default" Rodrigo Vivi
2016-07-19 5:23 ` ✗ Ro.CI.BAT: failure for " Patchwork
@ 2016-07-19 6:40 ` Daniel Vetter
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2016-07-19 6:40 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: Jani Nikula, intel-gfx, Stable
On Mon, Jul 18, 2016 at 04:27:57PM -0700, Rodrigo Vivi wrote:
> This reverts commit 041824ee25cfc535ba2d9a22c217df735ea2471e.
>
> We have latency issues that might impact the performance: #96606.
> and hangs and loading issues on resume after S4: #96526.
>
> This is also blocking a platform milestone so let's disable
> this for now while we make sure we don't have any more loading
> issue, or related basic hangs and it pass BAT for real in all
> platofmrs.
>
> In case BAT is wrong let's first fix BAT before re-enable it here.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96606
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96526
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Dave Gordon <david.s.gordon@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Stable <stable@vger.kernel.org>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Christophe Prigent <christophe.prigent@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reverts win, even against silly CI.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/i915_params.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index 8b13bfa..b6e404c 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -54,8 +54,8 @@ struct i915_params i915 __read_mostly = {
> .verbose_state_checks = 1,
> .nuclear_pageflip = 0,
> .edp_vswing = 0,
> - .enable_guc_loading = -1,
> - .enable_guc_submission = -1,
> + .enable_guc_loading = 0,
> + .enable_guc_submission = 0,
> .guc_log_level = -1,
> .enable_dp_mst = true,
> .inject_load_failure = 0,
> @@ -203,12 +203,12 @@ MODULE_PARM_DESC(edp_vswing,
> module_param_named_unsafe(enable_guc_loading, i915.enable_guc_loading, int, 0400);
> MODULE_PARM_DESC(enable_guc_loading,
> "Enable GuC firmware loading "
> - "(-1=auto [default], 0=never, 1=if available, 2=required)");
> + "(-1=auto, 0=never [default], 1=if available, 2=required)");
>
> module_param_named_unsafe(enable_guc_submission, i915.enable_guc_submission, int, 0400);
> MODULE_PARM_DESC(enable_guc_submission,
> "Enable GuC submission "
> - "(-1=auto [default], 0=never, 1=if available, 2=required)");
> + "(-1=auto, 0=never [default], 1=if available, 2=required)");
>
> module_param_named(guc_log_level, i915.guc_log_level, int, 0400);
> MODULE_PARM_DESC(guc_log_level,
> --
> 2.5.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-19 6:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-18 23:27 [PATCH] drm/i915/guc: Revert "drm/i915/guc: enable GuC loading & submission by default" Rodrigo Vivi
2016-07-19 5:23 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-07-19 6:40 ` [PATCH] " Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox