From: Daniel Vetter <daniel@ffwll.ch>
To: Jeff Mahoney <jeffm@suse.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] i915: fix build error with -Werror
Date: Tue, 19 Jul 2016 09:05:13 +0200 [thread overview]
Message-ID: <20160719070513.GJ17101@phenom.ffwll.local> (raw)
In-Reply-To: <d88f5c04-80f3-860e-c2c7-283a65fb0b81@suse.com>
On Mon, Jul 04, 2016 at 11:30:06AM -0400, Jeff Mahoney wrote:
> This fixes the following build error with -Werror and gcc 6.1:
>
> drivers/gpu/drm/i915/i915_debugfs.c:2103:6: error: suggest explicit braces to avoid ambiguous 'else' [-Werror=parentheses]
>
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
This doesn't apply on -next any more ... Is this still an issue on latest
kernels?
-Daniel
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2100,9 +2100,10 @@ static int i915_dump_lrc(struct seq_file
> return ret;
>
> list_for_each_entry(ctx, &dev_priv->context_list, link)
> - if (ctx != dev_priv->kernel_context)
> + if (ctx != dev_priv->kernel_context) {
> for_each_engine(engine, dev_priv)
> i915_dump_lrc_obj(m, ctx, engine);
> + }
>
> mutex_unlock(&dev->struct_mutex);
>
>
>
> --
> Jeff Mahoney
> SUSE Labs
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-07-19 7:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 14:29 [PATCH] i915: fix build error with -Werror Jeff Mahoney
2016-07-04 15:29 ` Jeff Mahoney
2016-07-04 15:30 ` [PATCH v2] " Jeff Mahoney
2016-07-19 7:05 ` Daniel Vetter [this message]
2016-07-19 14:18 ` Dave Gordon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160719070513.GJ17101@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jeffm@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox