From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel@ffwll.ch>,
intel-gfx@lists.freedesktop.org,
Ankitprasad Sharma <ankitprasad.r.sharma@intel.com>
Subject: Re: [PATCH] drm/i915: Handle ENOSPC after failing to insert a mappable node
Date: Tue, 19 Jul 2016 16:33:07 +0200 [thread overview]
Message-ID: <20160719143307.GS17101@phenom.ffwll.local> (raw)
In-Reply-To: <20160719082834.GB17604@nuc-i3427.alporthouse.com>
On Tue, Jul 19, 2016 at 09:28:34AM +0100, Chris Wilson wrote:
> On Tue, Jul 19, 2016 at 08:55:55AM +0200, Daniel Vetter wrote:
> > On Sat, Jul 16, 2016 at 06:42:36PM +0100, Chris Wilson wrote:
> > > Even after adding individual page support for GTT mmaping, we can still
> > > fail to find any space within the mappable region, and
> > > drm_mm_insert_node() will then report ENOSPC. We have to then handle
> > > this error by using the shmem access to the pages.
> > >
> > > Fixes: b50a53715f09 ("drm/i915: Support for pread/pwrite ... objects")
> > > Testcase: igt/gem_concurrent_blit
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Ankitprasad Sharma <ankitprasad.r.sharma@intel.com>
> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com
> >
> > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Thanks for the review, pushed.
>
> Ideas for how we can stress this a bit directly than
> gem_concurrent_blit?
>
> We need to have many threads all pinning and then hitting the slow path
> in the read (thus allowing another thread to come in and fail to claim
> some aperture space for itself). Tricksy.
>
> Hmm, how about fault-injection under I915_DEBUG?
I think fault injection is the only feasible way for such a fallback for a
fallback case. We need to entirely exhaust mmap gtt afaics at aleast.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-07-19 14:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-16 17:42 [PATCH] drm/i915: Handle ENOSPC after failing to insert a mappable node Chris Wilson
2016-07-17 5:22 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-07-19 6:55 ` [PATCH] " Daniel Vetter
2016-07-19 7:09 ` Chris Wilson
2016-07-19 8:28 ` Chris Wilson
2016-07-19 14:33 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160719143307.GS17101@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ankitprasad.r.sharma@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox