From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915/vlv: Fix off-by-1 error in
 calculating num_levels.
Date: Tue, 19 Jul 2016 19:21:32 +0300
Message-ID: <20160719162132.GO4329@intel.com>
References: <1466685388-16504-1-git-send-email-chix.ding@intel.com>
 <d73f9def-caec-25ca-16cb-226549467e93@linux.intel.com>
 <20160719152542.GN4329@intel.com>
 <20160719155049.GL17604@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTP id F1CCE6E6B6
 for <intel-gfx@lists.freedesktop.org>; Tue, 19 Jul 2016 16:21:36 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20160719155049.GL17604@nuc-i3427.alporthouse.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, yetundex.adebisi@intel.com, isg-gms@eclists.intel.com, Chi Ding <chix.ding@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCBKdWwgMTksIDIwMTYgYXQgMDQ6NTA6NDlQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IE9uIFR1ZSwgSnVsIDE5LCAyMDE2IGF0IDA2OjI1OjQyUE0gKzAzMDAsIFZpbGxlIFN5
cmrDpGzDpCB3cm90ZToKPiA+IE9uIFR1ZSwgSnVsIDE5LCAyMDE2IGF0IDA1OjE0OjIzUE0gKzAy
MDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+ID4gPiBudW1fbGV2ZWxzIHNob3VsZCBiZSBs
ZXZlbCsxLCBub3QgbGV2ZWwsIGVsc2UgbnVtX2xldmVscyAtIDEgYmVjb21lcwo+ID4gPiBuZWdh
dGl2ZS4gVGhpcyByZXN1bHRlZCBpbiBib2d1cyB3YXRlcm1hcmtzIGJlaW5nIHdyaXR0ZW4gdG8g
dGhlIGZpcnN0Cj4gPiA+IDI1NSBsZXZlbHMgbGlrZSBiZWxvdzoKPiA+ID4gCj4gPiA+IFtkcm1d
IFNldHRpbmcgRklGTyB3YXRlcm1hcmtzIC0gQzogcGxhbmU9MCwgY3Vyc29yPTAsIHNwcml0ZTA9
MCwgc3ByaXRlMT0wLCBTUjogcGxhbmU9MCwgY3Vyc29yPTAgbGV2ZWw9MjU1IGN4c3I9MAo+ID4g
PiBbZHJtOmNodl9zZXRfbWVtb3J5X2R2ZnMgW2k5MTVdXSAqRVJST1IqIHRpbWVkIG91dCB3YWl0
aW5nIGZvciBQdW5pdCBERFIgRFZGUyByZXF1ZXN0Cj4gPiA+IFtkcm06aW50ZWxfY3B1X2ZpZm9f
dW5kZXJydW5faXJxX2hhbmRsZXIgW2k5MTVdXSAqRVJST1IqIENQVSBwaXBlIEMgRklGTyB1bmRl
cnJ1bgo+ID4gPiBbZHJtOmNodl9zZXRfbWVtb3J5X2R2ZnMgW2k5MTVdXSAqRVJST1IqIHRpbWVk
IG91dCB3YWl0aW5nIGZvciBQdW5pdCBERFIgRFZGUyByZXF1ZXN0Cj4gPiA+IAo+ID4gPiBUZXN0
Y2FzZToga21zX2F0b21pY190cmFuc2l0aW9uCj4gPiA+IEZpeGVzOiAyNjJjZDJlMTU0YzIgKCJk
cm0vaTkxNTogQ0hWIEREUiBEVkZTIHN1cHBvcnQgYW5kIGFub3RoZXIgd2F0ZXJtYXJrIHJld3Jp
dGUiKQo+ID4gPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwo+ID4gPiBDYzogVmlsbGUgU3ly
asOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+ID4gU2lnbmVkLW9mZi1i
eTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4K
PiA+ID4gLS0tCj4gPiA+IFVyZ2VudCBmaXggZm9yIHdhdGVybWFyayBzdXBwb3J0LiBUaGlzIGlz
IGRlZmluaXRlbHkgYSBwcmUtcmVxdWlzaXRlIGZvciB0aGlzIHNlcmllcy4KPiA+ID4gV2l0aCB0
aGlzIEkndmUgbm90aWNlZCB0aGF0IHBhdGNoICJbUkZDIDMvOF0gZHJtL2k5MTUvdmx2OiBNb3Zl
IGZpZm9fc2l6ZSBmcm9tCj4gPiA+IGludGVsX3BsYW5lX3dtX3BhcmFtZXRlcnMgdG8gdmx2X3dt
X3N0YXRlIiBpbnRyb2R1Y2VzIGEgcmVncmVzc2lvbiB3aXRoIGludmFsaWQgRklGTyBzcGxpdC4K
PiA+ID4gCj4gPiA+IEkgbmVlZCB0byBmaW5kIG91dCB3aGF0J3MgZ29pbmcgd3JvbmcgaW4gdGhh
dCBwYXRjaCBiZWZvcmUgdGhpcyBzZXJpZXMgY2FuIGJlIGFwcGxpZWQuCj4gPiA+IAo+ID4gPiAg
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyB8IDIgKy0KPiA+ID4gIDEgZmlsZSBjaGFu
Z2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdp
dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9wbS5jCj4gPiA+IGluZGV4IDM3NmM2MGI5ODUxNS4uOGRlZmRjYzU0NTI5IDEwMDY0
NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gPiA+ICsrKyBi
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiA+ID4gQEAgLTExNDgsNyArMTE0OCw3
IEBAIHN0YXRpYyB2b2lkIHZsdl9jb21wdXRlX3dtKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+
ID4gPiAgCQkJfQo+ID4gPiAgCQl9Cj4gPiA+ICAKPiA+ID4gLQkJd21fc3RhdGUtPm51bV9sZXZl
bHMgPSBsZXZlbDsKPiA+ID4gKwkJd21fc3RhdGUtPm51bV9sZXZlbHMgPSBsZXZlbCArIDE7Cj4g
PiAKPiA+IE5vcGUuIFRoZSBsb29wIGFib3ZlIGJyZWFrcyB3aGVuIHRoZSBjdXJyZW50IGxldmVs
IGlzIGJhZCwgaGVuY2UgbGV2ZWwtMQo+ID4gaXMgYWN0dWFsbHkgdGhlIGhpZ2hlciB1c2FibGUg
bGV2ZWwuCj4gCj4gV2l0aG91dCBrbm93aW5nIHRoZSBsaW1pdHMgb2YgcGxhbmUtPndtLmZpZm9f
c2l6ZSwgaXQgbG9va3MgbGlrZSBpdCBjYW4KPiBicmVhayBvbiBsZXZlbCA9PSAwIHRob3VnaC4K
CkhtbS4gVGhhdCBzaG91bGRuJ3QgYmUgcG9zc2libGUuIFNvIGxvb2tzIGxpa2UgYSBidWcgc251
Y2sgaW4uCgo+IE1pZ2h0IGFzIHdlbGwgc2V0IHRoYXQgaGFjayB0byBwYXJhbm9pZCBsZXZlbHM6
Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgYi9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gaW5kZXggNjMwYjExNjk4OGY2Li5lOGMyODc0
Yjg2MjkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ICsr
KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiBAQCAtMTEyNCwxMSArMTEyNCwx
MyBAQCBzdGF0aWMgdm9pZCB2bHZfY29tcHV0ZV93bShzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykK
PiAgICAgICAgICAgICAgICAgLyogbm9ybWFsIHdhdGVybWFya3MgKi8KPiAgICAgICAgICAgICAg
ICAgZm9yIChsZXZlbCA9IDA7IGxldmVsIDwgd21fc3RhdGUtPm51bV9sZXZlbHM7IGxldmVsKysp
IHsKPiAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgd20gPSB2bHZfY29tcHV0ZV93bV9sZXZl
bChwbGFuZSwgY3J0Yywgc3RhdGUsIGxldmVsKTsKPiAtICAgICAgICAgICAgICAgICAgICAgICBp
bnQgbWF4X3dtID0gcGxhbmUtPmJhc2UudHlwZSA9PSBEUk1fUExBTkVfVFlQRV9DVVJTT1IgPyA2
MyA6IDUxMTsKPiAtCj4gICAgICAgICAgICAgICAgICAgICAgICAgLyogaGFjayAqLwo+IC0gICAg
ICAgICAgICAgICAgICAgICAgIGlmIChXQVJOX09OKGxldmVsID09IDAgJiYgd20gPiBtYXhfd20p
KQo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgd20gPSBtYXhfd207CgpBY3R1YWxs
eSB0aGlzIHNob3VsZCBqdXN0IGJlIAoKaWYgKFdBUk5fT04obGV2ZWwgPT0gMCAmJiB3bSA+IGZp
Zm9fc2l6ZSkpCgl3bSA9IGZpZm9fc2l6ZTsKCmFzc3VtaW5nIHdlIHdhbnQgdG8ga2VlcCB0aGUg
aGFjayBhcm91bmQgZm9yIG5vdy4KCkV2ZW50dWFsbHkgd2UnbGwgd2FudCB0byBtYWtlIGl0IGp1
c3QgcmV0dXJuIGFuIGVycm9yIHRob3VnaC4KCj4gKyAgICAgICAgICAgICAgICAgICAgICAgaWYg
KGxldmVsID09IDApIHsKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCBwbGFu
ZV93bSA9IHBsYW5lLT5iYXNlLnR5cGUgPT0gRFJNX1BMQU5FX1RZUEVfQ1VSU09SID8gNjMgOiA1
MTE7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgbWF4X3dtID0gbWluKHBs
YW5lLT53bS5maWZvX3NpemUsIHBsYW5lX3dtKTsKPiArICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIGlmIChXQVJOX09OKHdtID4gbWF4X3dtKSkKPiArICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgd20gPSBtYXhfd207Cj4gKyAgICAgICAgICAgICAgICAgICAgICAg
fQo+ICAKPiAgICAgICAgICAgICAgICAgICAgICAgICBpZiAod20gPiBwbGFuZS0+d20uZmlmb19z
aXplKQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gCj4gLS0gCj4g
Q2hyaXMgV2lsc29uLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRyZQoKLS0gClZp
bGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl
ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu
Zm8vaW50ZWwtZ2Z4Cg==