From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 5/7] drm/i915: Use & instead if == to check for rotations Date: Wed, 20 Jul 2016 17:14:46 +0300 Message-ID: <20160720141446.GT4329@intel.com> References: <1469020693-24356-1-git-send-email-ville.syrjala@linux.intel.com> <1469020693-24356-6-git-send-email-ville.syrjala@linux.intel.com> <1469023260.11191.13.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1469023260.11191.13.camel@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joonas Lahtinen Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKdWwgMjAsIDIwMTYgYXQgMDU6MDE6MDBQTSArMDMwMCwgSm9vbmFzIExhaHRpbmVu IHdyb3RlOgo+IE9uIGtlLCAyMDE2LTA3LTIwIGF0IDE2OjE4ICswMzAwLCB2aWxsZS5zeXJqYWxh QGxpbnV4LmludGVsLmNvbSB3cm90ZToKPiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUu c3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAKPiA+IFVzaW5nID09IHRvIGNoZWNrIGZvciAx ODAgZGVncmVlIHJvdGF0aW9uIG9ubHkgd29ya3MgYXMgbG9uZyBhcyB0aGUKPiA+IHJlZmxlY3Rp b24gYml0cyBhcmVuJ3Qgc2V0LiBUaGF0IHdpbGwgY2hhbmdlIHNvb24gZW5vdWdoIGZvciBDSFYs IHNvCj4gPiBsZXQncyBzdG9wIGRvaW5nIHRoaW5ncyB0aGUgd3Jvbmcgd2F5Lgo+ID4gCj4gPiBT aWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IFJldmlld2VkLWJ5OiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBs aW51eC5pbnRlbC5jb20+Cj4gCj4gUmVhZGluZyB0aHJvdWdoIHRoZSBwYXRjaCBtYWtlcyBtZSB3 YW5uYSBkbyB0aGUgY2hhbmdlOwo+IAo+ICNkZWZpbmUgRFJNX1JPVEFURV8xODAgQklUKHgpCj4g Cj4gZXZlbiBtb3JlLiBNYXliZSB3aXRoIGNvY2NpbmVsbGUuCgpZZWFoLCB0aGF0IG9uZSBpcyBh bm5veWluZy4gT25lIHByb2JsZW0gaXMgdGhlIHdheSB0aGUgYml0cyBhcmUKc3BlY2lmaWVkIGZv ciBiaXRtYXNrIHByb3BlcnRpZXMgKGFzIHNoaWZ0cyksIHNvIHdlIHN0aWxsIG5lZWQgdGhlCm5h bWVzIGZvciB0aGUgc2hpZnRzIHRvbyA6KAoKPiAKPiBSZWdhcmRzLCBKb29uYXMKPiAKPiA+IC0t LQo+ID4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA5ICsrKysrLS0t LQo+ID4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuY8KgwqB8IDYgKysrLS0t Cj4gPiDCoDIgZmlsZXMgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+ ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBpbmRleCA5M2VjYjI1 OWM1Y2UuLjc5YzFhOGI4OWQxZCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCj4gPiBAQCAtMjY4OCw3ICsyNjg4LDcgQEAgc3RhdGljIHZvaWQgaTl4eF91cGRhdGVf cHJpbWFyeV9wbGFuZShzdHJ1Y3QgZHJtX3BsYW5lICpwcmltYXJ5LAo+ID4gwqAJCWludGVsX2Ny dGMtPmRzcGFkZHJfb2Zmc2V0ID0gbGluZWFyX29mZnNldDsKPiA+IMKgCX0KPiA+IMKgCj4gPiAt CWlmIChyb3RhdGlvbiA9PSBCSVQoRFJNX1JPVEFURV8xODApKSB7Cj4gPiArCWlmIChyb3RhdGlv biAmIEJJVChEUk1fUk9UQVRFXzE4MCkpIHsKPiA+IMKgCQlkc3BjbnRyIHw9IERJU1BQTEFORV9S T1RBVEVfMTgwOwo+ID4gwqAKPiA+IMKgCQl4ICs9IChjcnRjX3N0YXRlLT5waXBlX3NyY193IC0g MSk7Cj4gPiBAQCAtMjc5MSw3ICsyNzkxLDggQEAgc3RhdGljIHZvaWQgaXJvbmxha2VfdXBkYXRl X3ByaW1hcnlfcGxhbmUoc3RydWN0IGRybV9wbGFuZSAqcHJpbWFyeSwKPiA+IMKgCQlpbnRlbF9j b21wdXRlX3RpbGVfb2Zmc2V0KCZ4LCAmeSwgZmIsIDAsCj4gPiDCoAkJCQkJwqDCoGZiLT5waXRj aGVzWzBdLCByb3RhdGlvbik7Cj4gPiDCoAlsaW5lYXJfb2Zmc2V0IC09IGludGVsX2NydGMtPmRz cGFkZHJfb2Zmc2V0Owo+ID4gLQlpZiAocm90YXRpb24gPT0gQklUKERSTV9ST1RBVEVfMTgwKSkg ewo+ID4gKwo+ID4gKwlpZiAocm90YXRpb24gJiBCSVQoRFJNX1JPVEFURV8xODApKSB7Cj4gPiDC oAkJZHNwY250ciB8PSBESVNQUExBTkVfUk9UQVRFXzE4MDsKPiA+IMKgCj4gPiDCoAkJaWYgKCFJ U19IQVNXRUxMKGRldikgJiYgIUlTX0JST0FEV0VMTChkZXYpKSB7Cj4gPiBAQCAtMTAyNjMsNyAr MTAyNjQsNyBAQCBzdGF0aWMgdm9pZCBpOXh4X3VwZGF0ZV9jdXJzb3Ioc3RydWN0IGRybV9jcnRj ICpjcnRjLCB1MzIgYmFzZSwKPiA+IMKgCQlpZiAoSEFTX0RESShkZXYpKQo+ID4gwqAJCQljbnRs IHw9IENVUlNPUl9QSVBFX0NTQ19FTkFCTEU7Cj4gPiDCoAo+ID4gLQkJaWYgKHBsYW5lX3N0YXRl LT5iYXNlLnJvdGF0aW9uID09IEJJVChEUk1fUk9UQVRFXzE4MCkpCj4gPiArCQlpZiAocGxhbmVf c3RhdGUtPmJhc2Uucm90YXRpb24gJiBCSVQoRFJNX1JPVEFURV8xODApKQo+ID4gwqAJCQljbnRs IHw9IENVUlNPUl9ST1RBVEVfMTgwOwo+ID4gwqAJfQo+ID4gwqAKPiA+IEBAIC0xMDMwOSw3ICsx MDMxMCw3IEBAIHN0YXRpYyB2b2lkIGludGVsX2NydGNfdXBkYXRlX2N1cnNvcihzdHJ1Y3QgZHJt X2NydGMgKmNydGMsCj4gPiDCoAo+ID4gwqAJCS8qIElMSysgZG8gdGhpcyBhdXRvbWFnaWNhbGx5 ICovCj4gPiDCoAkJaWYgKEhBU19HTUNIX0RJU1BMQVkoZGV2KSAmJgo+ID4gLQkJwqDCoMKgwqBw bGFuZV9zdGF0ZS0+YmFzZS5yb3RhdGlvbiA9PSBCSVQoRFJNX1JPVEFURV8xODApKSB7Cj4gPiAr CQnCoMKgwqDCoHBsYW5lX3N0YXRlLT5iYXNlLnJvdGF0aW9uICYgQklUKERSTV9ST1RBVEVfMTgw KSkgewo+ID4gwqAJCQliYXNlICs9IChwbGFuZV9zdGF0ZS0+YmFzZS5jcnRjX2ggKgo+ID4gwqAJ CQkJwqBwbGFuZV9zdGF0ZS0+YmFzZS5jcnRjX3cgLSAxKSAqIDQ7Cj4gPiDCoAkJfQo+ID4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiA+IGluZGV4IGJjNDFjMWJiYTA0Yy4uNmI4MTVk NTdkNzVhIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRl LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4gPiBAQCAt NDQ0LDcgKzQ0NCw3IEBAIHZsdl91cGRhdGVfcGxhbmUoc3RydWN0IGRybV9wbGFuZSAqZHBsYW5l LAo+ID4gwqAJCQkJCQnCoMKgwqBmYi0+cGl0Y2hlc1swXSwgcm90YXRpb24pOwo+ID4gwqAJbGlu ZWFyX29mZnNldCAtPSBzcHJzdXJmX29mZnNldDsKPiA+IMKgCj4gPiAtCWlmIChyb3RhdGlvbiA9 PSBCSVQoRFJNX1JPVEFURV8xODApKSB7Cj4gPiArCWlmIChyb3RhdGlvbiAmIEJJVChEUk1fUk9U QVRFXzE4MCkpIHsKPiA+IMKgCQlzcHJjdGwgfD0gU1BfUk9UQVRFXzE4MDsKPiA+IMKgCj4gPiDC oAkJeCArPSBzcmNfdzsKPiA+IEBAIC01NzcsNyArNTc3LDcgQEAgaXZiX3VwZGF0ZV9wbGFuZShz dHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiA+IMKgCQkJCQkJwqDCoMKgZmItPnBpdGNoZXNbMF0s IHJvdGF0aW9uKTsKPiA+IMKgCWxpbmVhcl9vZmZzZXQgLT0gc3Byc3VyZl9vZmZzZXQ7Cj4gPiDC oAo+ID4gLQlpZiAocm90YXRpb24gPT0gQklUKERSTV9ST1RBVEVfMTgwKSkgewo+ID4gKwlpZiAo cm90YXRpb24gJiBCSVQoRFJNX1JPVEFURV8xODApKSB7Cj4gPiDCoAkJc3ByY3RsIHw9IFNQUklU RV9ST1RBVEVfMTgwOwo+ID4gwqAKPiA+IMKgCQkvKiBIU1cgYW5kIEJEVyBkb2VzIHRoaXMgYXV0 b21hZ2ljYWxseSBpbiBoYXJkd2FyZSAqLwo+ID4gQEAgLTcxNCw3ICs3MTQsNyBAQCBpbGtfdXBk YXRlX3BsYW5lKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ID4gwqAJCQkJCQnCoMKgwqBmYi0+ cGl0Y2hlc1swXSwgcm90YXRpb24pOwo+ID4gwqAJbGluZWFyX29mZnNldCAtPSBkdnNzdXJmX29m ZnNldDsKPiA+IMKgCj4gPiAtCWlmIChyb3RhdGlvbiA9PSBCSVQoRFJNX1JPVEFURV8xODApKSB7 Cj4gPiArCWlmIChyb3RhdGlvbiAmIEJJVChEUk1fUk9UQVRFXzE4MCkpIHsKPiA+IMKgCQlkdnNj bnRyIHw9IERWU19ST1RBVEVfMTgwOwo+ID4gwqAKPiA+IMKgCQl4ICs9IHNyY193Owo+IC0tIAo+ IEpvb25hcyBMYWh0aW5lbgo+IE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCj4gSW50ZWwg Q29ycG9yYXRpb24KCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=