From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915/vlv: Fix off-by-1 error in
 calculating num_levels.
Date: Mon, 25 Jul 2016 14:51:07 +0300
Message-ID: <20160725115107.GC4329@intel.com>
References: <1466685388-16504-1-git-send-email-chix.ding@intel.com>
 <d73f9def-caec-25ca-16cb-226549467e93@linux.intel.com>
 <20160719152542.GN4329@intel.com>
 <20160719155049.GL17604@nuc-i3427.alporthouse.com>
 <20160719162132.GO4329@intel.com>
 <12173c41-da78-99df-dec6-33b41deab9db@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id 16DA96E1AA
 for <intel-gfx@lists.freedesktop.org>; Mon, 25 Jul 2016 11:51:10 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <12173c41-da78-99df-dec6-33b41deab9db@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: yetundex.adebisi@intel.com, isg-gms@eclists.intel.com, intel-gfx@lists.freedesktop.org, Chi Ding <chix.ding@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCBKdWwgMjUsIDIwMTYgYXQgMDE6MzI6NDVQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y
c3Qgd3JvdGU6Cj4gSGV5LAo+IAo+IE9wIDE5LTA3LTE2IG9tIDE4OjIxIHNjaHJlZWYgVmlsbGUg
U3lyasOkbMOkOgo+ID4gT24gVHVlLCBKdWwgMTksIDIwMTYgYXQgMDQ6NTA6NDlQTSArMDEwMCwg
Q2hyaXMgV2lsc29uIHdyb3RlOgo+ID4+IE9uIFR1ZSwgSnVsIDE5LCAyMDE2IGF0IDA2OjI1OjQy
UE0gKzAzMDAsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPiA+Pj4gT24gVHVlLCBKdWwgMTksIDIw
MTYgYXQgMDU6MTQ6MjNQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4gPj4+PiBu
dW1fbGV2ZWxzIHNob3VsZCBiZSBsZXZlbCsxLCBub3QgbGV2ZWwsIGVsc2UgbnVtX2xldmVscyAt
IDEgYmVjb21lcwo+ID4+Pj4gbmVnYXRpdmUuIFRoaXMgcmVzdWx0ZWQgaW4gYm9ndXMgd2F0ZXJt
YXJrcyBiZWluZyB3cml0dGVuIHRvIHRoZSBmaXJzdAo+ID4+Pj4gMjU1IGxldmVscyBsaWtlIGJl
bG93Ogo+ID4+Pj4KPiA+Pj4+IFtkcm1dIFNldHRpbmcgRklGTyB3YXRlcm1hcmtzIC0gQzogcGxh
bmU9MCwgY3Vyc29yPTAsIHNwcml0ZTA9MCwgc3ByaXRlMT0wLCBTUjogcGxhbmU9MCwgY3Vyc29y
PTAgbGV2ZWw9MjU1IGN4c3I9MAo+ID4+Pj4gW2RybTpjaHZfc2V0X21lbW9yeV9kdmZzIFtpOTE1
XV0gKkVSUk9SKiB0aW1lZCBvdXQgd2FpdGluZyBmb3IgUHVuaXQgRERSIERWRlMgcmVxdWVzdAo+
ID4+Pj4gW2RybTppbnRlbF9jcHVfZmlmb191bmRlcnJ1bl9pcnFfaGFuZGxlciBbaTkxNV1dICpF
UlJPUiogQ1BVIHBpcGUgQyBGSUZPIHVuZGVycnVuCj4gPj4+PiBbZHJtOmNodl9zZXRfbWVtb3J5
X2R2ZnMgW2k5MTVdXSAqRVJST1IqIHRpbWVkIG91dCB3YWl0aW5nIGZvciBQdW5pdCBERFIgRFZG
UyByZXF1ZXN0Cj4gPj4+Pgo+ID4+Pj4gVGVzdGNhc2U6IGttc19hdG9taWNfdHJhbnNpdGlvbgo+
ID4+Pj4gRml4ZXM6IDI2MmNkMmUxNTRjMiAoImRybS9pOTE1OiBDSFYgRERSIERWRlMgc3VwcG9y
dCBhbmQgYW5vdGhlciB3YXRlcm1hcmsgcmV3cml0ZSIpCj4gPj4+PiBDYzogc3RhYmxlQHZnZXIu
a2VybmVsLm9yZwo+ID4+Pj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51
eC5pbnRlbC5jb20+Cj4gPj4+PiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFh
cnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+ID4+Pj4gLS0tCj4gPj4+PiBVcmdlbnQg
Zml4IGZvciB3YXRlcm1hcmsgc3VwcG9ydC4gVGhpcyBpcyBkZWZpbml0ZWx5IGEgcHJlLXJlcXVp
c2l0ZSBmb3IgdGhpcyBzZXJpZXMuCj4gPj4+PiBXaXRoIHRoaXMgSSd2ZSBub3RpY2VkIHRoYXQg
cGF0Y2ggIltSRkMgMy84XSBkcm0vaTkxNS92bHY6IE1vdmUgZmlmb19zaXplIGZyb20KPiA+Pj4+
IGludGVsX3BsYW5lX3dtX3BhcmFtZXRlcnMgdG8gdmx2X3dtX3N0YXRlIiBpbnRyb2R1Y2VzIGEg
cmVncmVzc2lvbiB3aXRoIGludmFsaWQgRklGTyBzcGxpdC4KPiA+Pj4+Cj4gPj4+PiBJIG5lZWQg
dG8gZmluZCBvdXQgd2hhdCdzIGdvaW5nIHdyb25nIGluIHRoYXQgcGF0Y2ggYmVmb3JlIHRoaXMg
c2VyaWVzIGNhbiBiZSBhcHBsaWVkLgo+ID4+Pj4KPiA+Pj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9wbS5jIHwgMiArLQo+ID4+Pj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigr
KSwgMSBkZWxldGlvbigtKQo+ID4+Pj4KPiA+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF9wbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4+
Pj4gaW5kZXggMzc2YzYwYjk4NTE1Li44ZGVmZGNjNTQ1MjkgMTAwNjQ0Cj4gPj4+PiAtLS0gYS9k
cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gPj4+PiArKysgYi9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF9wbS5jCj4gPj4+PiBAQCAtMTE0OCw3ICsxMTQ4LDcgQEAgc3RhdGljIHZv
aWQgdmx2X2NvbXB1dGVfd20oc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gPj4+PiAgCQkJfQo+
ID4+Pj4gIAkJfQo+ID4+Pj4gIAo+ID4+Pj4gLQkJd21fc3RhdGUtPm51bV9sZXZlbHMgPSBsZXZl
bDsKPiA+Pj4+ICsJCXdtX3N0YXRlLT5udW1fbGV2ZWxzID0gbGV2ZWwgKyAxOwo+ID4+PiBOb3Bl
LiBUaGUgbG9vcCBhYm92ZSBicmVha3Mgd2hlbiB0aGUgY3VycmVudCBsZXZlbCBpcyBiYWQsIGhl
bmNlIGxldmVsLTEKPiA+Pj4gaXMgYWN0dWFsbHkgdGhlIGhpZ2hlciB1c2FibGUgbGV2ZWwuCj4g
Pj4gV2l0aG91dCBrbm93aW5nIHRoZSBsaW1pdHMgb2YgcGxhbmUtPndtLmZpZm9fc2l6ZSwgaXQg
bG9va3MgbGlrZSBpdCBjYW4KPiA+PiBicmVhayBvbiBsZXZlbCA9PSAwIHRob3VnaC4KPiA+IEht
bS4gVGhhdCBzaG91bGRuJ3QgYmUgcG9zc2libGUuIFNvIGxvb2tzIGxpa2UgYSBidWcgc251Y2sg
aW4uCj4gPgo+ID4+IE1pZ2h0IGFzIHdlbGwgc2V0IHRoYXQgaGFjayB0byBwYXJhbm9pZCBsZXZl
bHM6Cj4gPj4KPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0u
YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiA+PiBpbmRleCA2MzBiMTE2OTg4
ZjYuLmU4YzI4NzRiODYyOSAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9wbS5jCj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4+
IEBAIC0xMTI0LDExICsxMTI0LDEzIEBAIHN0YXRpYyB2b2lkIHZsdl9jb21wdXRlX3dtKHN0cnVj
dCBpbnRlbF9jcnRjICpjcnRjKQo+ID4+ICAgICAgICAgICAgICAgICAvKiBub3JtYWwgd2F0ZXJt
YXJrcyAqLwo+ID4+ICAgICAgICAgICAgICAgICBmb3IgKGxldmVsID0gMDsgbGV2ZWwgPCB3bV9z
dGF0ZS0+bnVtX2xldmVsczsgbGV2ZWwrKykgewkKPiA+PiAgICAgICAgICAgICAgICAgICAgICAg
ICBpbnQgd20gPSB2bHZfY29tcHV0ZV93bV9sZXZlbChwbGFuZSwgY3J0Yywgc3RhdGUsIGxldmVs
KTsKPiA+PiAtICAgICAgICAgICAgICAgICAgICAgICBpbnQgbWF4X3dtID0gcGxhbmUtPmJhc2Uu
dHlwZSA9PSBEUk1fUExBTkVfVFlQRV9DVVJTT1IgPyA2MyA6IDUxMTsKPiA+PiAtCj4gPj4gICAg
ICAgICAgICAgICAgICAgICAgICAgLyogaGFjayAqLwo+ID4+IC0gICAgICAgICAgICAgICAgICAg
ICAgIGlmIChXQVJOX09OKGxldmVsID09IDAgJiYgd20gPiBtYXhfd20pKQo+ID4+IC0gICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgd20gPSBtYXhfd207Cj4gPiBBY3R1YWxseSB0aGlzIHNo
b3VsZCBqdXN0IGJlIAo+ID4KPiA+IGlmIChXQVJOX09OKGxldmVsID09IDAgJiYgd20gPiBmaWZv
X3NpemUpKQo+ID4gCXdtID0gZmlmb19zaXplOwo+ID4KPiA+IGFzc3VtaW5nIHdlIHdhbnQgdG8g
a2VlcCB0aGUgaGFjayBhcm91bmQgZm9yIG5vdy4KPiA+Cj4gPiBFdmVudHVhbGx5IHdlJ2xsIHdh
bnQgdG8gbWFrZSBpdCBqdXN0IHJldHVybiBhbiBlcnJvciB0aG91Z2guCj4gWWVzLCB0aGF0J3Mg
d2hhdCBJIGNhbWUgdXAgd2l0aC4KPiAKPiBCdXQgd2Ugc3RpbGwgbmVlZCB0byBjbGFtcCBmdXJ0
aGVyLCBwcm9iYWJseSB0byBwbGFuZS0+d20uZmlmb19zaXplLgo+IEhvd2V2ZXIgc3JfZmlmb19z
aXplIGlzIGFsc28gY2xhbXBlZCB0byA1MTEgYmVjYXVzZSBvZiB0aGUgbGV2ZWwgY2FsY3VsYXRp
b25zIGhlcmUuCj4gCj4gQmVsb3cgaXQgc2V0cyBzcltsZXZlbF0ucGxhbmUgPSBtaW4oc3JfZmlm
b19zaXplLCB3bVtsZXZlbF0ucGxhbmUpLAo+IHdoaWNoIHNlZW1zIHdlaXJkLiBIb3cgY2FuIHRo
aXMgZXZlciBlbmQgdXAgYmVpbmcgc29tZXRoaW5nIG90aGVyIHRoYW4gd21bbGV2ZWxdLnBsYW5l
PwoKVGhlcmUgYXJlIHRocmVlIHBsYW5lcy4gQ0hWIHdhcyBzdXBwb3NlZCB0byBoYXZlIG1heGZp
Zm8gd2l0aCB1cCB0byAyIGFjdGl2ZQpwbGFuZXMuIEJ1dCBJJ20gbm90IHN1cmUgdGhhdCBmZWF0
dXJlIG1hZGUgaXQgaW4uIEkgbmV2ZXIgZ290IGFyb3VuZAp0ZXN0aW5nIGl0LgoKPiBCZWNhdXNl
IHNyX2ZpZm9fc2l6ZSA+PSBtYXhfd20gaXMgYWx3YXlzIHRydWUuCj4gCj4gSSBndWVzcyB2bHZf
aW52ZXJ0X3dtcyB3aWxsIGludmVydCBpdCwgYnV0IHdlIGNvdWxkIHNpbXBseSBvbmx5IHNldCBp
dCB0aGVyZSB0aGVuLCBvciByZW1vdmUgdGhlIG1pbigpLi4KPiAKPiB+TWFhcnRlbgoKLS0gClZp
bGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl
ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu
Zm8vaW50ZWwtZ2Z4Cg==