From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915/vlv: Fix off-by-1 error in
 calculating num_levels.
Date: Mon, 25 Jul 2016 16:42:02 +0300
Message-ID: <20160725134202.GD4329@intel.com>
References: <1466685388-16504-1-git-send-email-chix.ding@intel.com>
 <d73f9def-caec-25ca-16cb-226549467e93@linux.intel.com>
 <20160719152542.GN4329@intel.com>
 <20160719155049.GL17604@nuc-i3427.alporthouse.com>
 <20160719162132.GO4329@intel.com>
 <12173c41-da78-99df-dec6-33b41deab9db@linux.intel.com>
 <20160725115107.GC4329@intel.com>
 <77076f1b-a757-eccf-fbae-d6638318f3df@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id B15F06E0A9
 for <intel-gfx@lists.freedesktop.org>; Mon, 25 Jul 2016 13:42:09 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <77076f1b-a757-eccf-fbae-d6638318f3df@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: yetundex.adebisi@intel.com, isg-gms@eclists.intel.com, intel-gfx@lists.freedesktop.org, Chi Ding <chix.ding@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCBKdWwgMjUsIDIwMTYgYXQgMDI6NDY6MDFQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y
c3Qgd3JvdGU6Cj4gT3AgMjUtMDctMTYgb20gMTM6NTEgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6
Cj4gPiBPbiBNb24sIEp1bCAyNSwgMjAxNiBhdCAwMTozMjo0NVBNICswMjAwLCBNYWFydGVuIExh
bmtob3JzdCB3cm90ZToKPiA+PiBIZXksCj4gPj4KPiA+PiBPcCAxOS0wNy0xNiBvbSAxODoyMSBz
Y2hyZWVmIFZpbGxlIFN5cmrDpGzDpDoKPiA+Pj4gT24gVHVlLCBKdWwgMTksIDIwMTYgYXQgMDQ6
NTA6NDlQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+ID4+Pj4gT24gVHVlLCBKdWwgMTks
IDIwMTYgYXQgMDY6MjU6NDJQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+ID4+Pj4+
IE9uIFR1ZSwgSnVsIDE5LCAyMDE2IGF0IDA1OjE0OjIzUE0gKzAyMDAsIE1hYXJ0ZW4gTGFua2hv
cnN0IHdyb3RlOgo+ID4+Pj4+PiBudW1fbGV2ZWxzIHNob3VsZCBiZSBsZXZlbCsxLCBub3QgbGV2
ZWwsIGVsc2UgbnVtX2xldmVscyAtIDEgYmVjb21lcwo+ID4+Pj4+PiBuZWdhdGl2ZS4gVGhpcyBy
ZXN1bHRlZCBpbiBib2d1cyB3YXRlcm1hcmtzIGJlaW5nIHdyaXR0ZW4gdG8gdGhlIGZpcnN0Cj4g
Pj4+Pj4+IDI1NSBsZXZlbHMgbGlrZSBiZWxvdzoKPiA+Pj4+Pj4KPiA+Pj4+Pj4gW2RybV0gU2V0
dGluZyBGSUZPIHdhdGVybWFya3MgLSBDOiBwbGFuZT0wLCBjdXJzb3I9MCwgc3ByaXRlMD0wLCBz
cHJpdGUxPTAsIFNSOiBwbGFuZT0wLCBjdXJzb3I9MCBsZXZlbD0yNTUgY3hzcj0wCj4gPj4+Pj4+
IFtkcm06Y2h2X3NldF9tZW1vcnlfZHZmcyBbaTkxNV1dICpFUlJPUiogdGltZWQgb3V0IHdhaXRp
bmcgZm9yIFB1bml0IEREUiBEVkZTIHJlcXVlc3QKPiA+Pj4+Pj4gW2RybTppbnRlbF9jcHVfZmlm
b191bmRlcnJ1bl9pcnFfaGFuZGxlciBbaTkxNV1dICpFUlJPUiogQ1BVIHBpcGUgQyBGSUZPIHVu
ZGVycnVuCj4gPj4+Pj4+IFtkcm06Y2h2X3NldF9tZW1vcnlfZHZmcyBbaTkxNV1dICpFUlJPUiog
dGltZWQgb3V0IHdhaXRpbmcgZm9yIFB1bml0IEREUiBEVkZTIHJlcXVlc3QKPiA+Pj4+Pj4KPiA+
Pj4+Pj4gVGVzdGNhc2U6IGttc19hdG9taWNfdHJhbnNpdGlvbgo+ID4+Pj4+PiBGaXhlczogMjYy
Y2QyZTE1NGMyICgiZHJtL2k5MTU6IENIViBERFIgRFZGUyBzdXBwb3J0IGFuZCBhbm90aGVyIHdh
dGVybWFyayByZXdyaXRlIikKPiA+Pj4+Pj4gQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcKPiA+
Pj4+Pj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+
Cj4gPj4+Pj4+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmto
b3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPj4+Pj4+IC0tLQo+ID4+Pj4+PiBVcmdlbnQgZml4IGZv
ciB3YXRlcm1hcmsgc3VwcG9ydC4gVGhpcyBpcyBkZWZpbml0ZWx5IGEgcHJlLXJlcXVpc2l0ZSBm
b3IgdGhpcyBzZXJpZXMuCj4gPj4+Pj4+IFdpdGggdGhpcyBJJ3ZlIG5vdGljZWQgdGhhdCBwYXRj
aCAiW1JGQyAzLzhdIGRybS9pOTE1L3ZsdjogTW92ZSBmaWZvX3NpemUgZnJvbQo+ID4+Pj4+PiBp
bnRlbF9wbGFuZV93bV9wYXJhbWV0ZXJzIHRvIHZsdl93bV9zdGF0ZSIgaW50cm9kdWNlcyBhIHJl
Z3Jlc3Npb24gd2l0aCBpbnZhbGlkIEZJRk8gc3BsaXQuCj4gPj4+Pj4+Cj4gPj4+Pj4+IEkgbmVl
ZCB0byBmaW5kIG91dCB3aGF0J3MgZ29pbmcgd3JvbmcgaW4gdGhhdCBwYXRjaCBiZWZvcmUgdGhp
cyBzZXJpZXMgY2FuIGJlIGFwcGxpZWQuCj4gPj4+Pj4+Cj4gPj4+Pj4+ICBkcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF9wbS5jIHwgMiArLQo+ID4+Pj4+PiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5z
ZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gPj4+Pj4+Cj4gPj4+Pj4+IGRpZmYgLS1naXQgYS9k
cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfcG0uYwo+ID4+Pj4+PiBpbmRleCAzNzZjNjBiOTg1MTUuLjhkZWZkY2M1NDUyOSAxMDA2NDQK
PiA+Pj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4+Pj4+PiAr
KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gPj4+Pj4+IEBAIC0xMTQ4LDcg
KzExNDgsNyBAQCBzdGF0aWMgdm9pZCB2bHZfY29tcHV0ZV93bShzdHJ1Y3QgaW50ZWxfY3J0YyAq
Y3J0YykKPiA+Pj4+Pj4gIAkJCX0KPiA+Pj4+Pj4gIAkJfQo+ID4+Pj4+PiAgCj4gPj4+Pj4+IC0J
CXdtX3N0YXRlLT5udW1fbGV2ZWxzID0gbGV2ZWw7Cj4gPj4+Pj4+ICsJCXdtX3N0YXRlLT5udW1f
bGV2ZWxzID0gbGV2ZWwgKyAxOwo+ID4+Pj4+IE5vcGUuIFRoZSBsb29wIGFib3ZlIGJyZWFrcyB3
aGVuIHRoZSBjdXJyZW50IGxldmVsIGlzIGJhZCwgaGVuY2UgbGV2ZWwtMQo+ID4+Pj4+IGlzIGFj
dHVhbGx5IHRoZSBoaWdoZXIgdXNhYmxlIGxldmVsLgo+ID4+Pj4gV2l0aG91dCBrbm93aW5nIHRo
ZSBsaW1pdHMgb2YgcGxhbmUtPndtLmZpZm9fc2l6ZSwgaXQgbG9va3MgbGlrZSBpdCBjYW4KPiA+
Pj4+IGJyZWFrIG9uIGxldmVsID09IDAgdGhvdWdoLgo+ID4+PiBIbW0uIFRoYXQgc2hvdWxkbid0
IGJlIHBvc3NpYmxlLiBTbyBsb29rcyBsaWtlIGEgYnVnIHNudWNrIGluLgo+ID4+Pgo+ID4+Pj4g
TWlnaHQgYXMgd2VsbCBzZXQgdGhhdCBoYWNrIHRvIHBhcmFub2lkIGxldmVsczoKPiA+Pj4+Cj4g
Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyBiL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiA+Pj4+IGluZGV4IDYzMGIxMTY5ODhmNi4uZThj
Mjg3NGI4NjI5IDEwMDY0NAo+ID4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
cG0uYwo+ID4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4+Pj4g
QEAgLTExMjQsMTEgKzExMjQsMTMgQEAgc3RhdGljIHZvaWQgdmx2X2NvbXB1dGVfd20oc3RydWN0
IGludGVsX2NydGMgKmNydGMpCj4gPj4+PiAgICAgICAgICAgICAgICAgLyogbm9ybWFsIHdhdGVy
bWFya3MgKi8KPiA+Pj4+ICAgICAgICAgICAgICAgICBmb3IgKGxldmVsID0gMDsgbGV2ZWwgPCB3
bV9zdGF0ZS0+bnVtX2xldmVsczsgbGV2ZWwrKykgewkKPiA+Pj4+ICAgICAgICAgICAgICAgICAg
ICAgICAgIGludCB3bSA9IHZsdl9jb21wdXRlX3dtX2xldmVsKHBsYW5lLCBjcnRjLCBzdGF0ZSwg
bGV2ZWwpOwo+ID4+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgaW50IG1heF93bSA9IHBsYW5l
LT5iYXNlLnR5cGUgPT0gRFJNX1BMQU5FX1RZUEVfQ1VSU09SID8gNjMgOiA1MTE7Cj4gPj4+PiAt
Cj4gPj4+PiAgICAgICAgICAgICAgICAgICAgICAgICAvKiBoYWNrICovCj4gPj4+PiAtICAgICAg
ICAgICAgICAgICAgICAgICBpZiAoV0FSTl9PTihsZXZlbCA9PSAwICYmIHdtID4gbWF4X3dtKSkK
PiA+Pj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgd20gPSBtYXhfd207Cj4gPj4+
IEFjdHVhbGx5IHRoaXMgc2hvdWxkIGp1c3QgYmUgCj4gPj4+Cj4gPj4+IGlmIChXQVJOX09OKGxl
dmVsID09IDAgJiYgd20gPiBmaWZvX3NpemUpKQo+ID4+PiAJd20gPSBmaWZvX3NpemU7Cj4gPj4+
Cj4gPj4+IGFzc3VtaW5nIHdlIHdhbnQgdG8ga2VlcCB0aGUgaGFjayBhcm91bmQgZm9yIG5vdy4K
PiA+Pj4KPiA+Pj4gRXZlbnR1YWxseSB3ZSdsbCB3YW50IHRvIG1ha2UgaXQganVzdCByZXR1cm4g
YW4gZXJyb3IgdGhvdWdoLgo+ID4+IFllcywgdGhhdCdzIHdoYXQgSSBjYW1lIHVwIHdpdGguCj4g
Pj4KPiA+PiBCdXQgd2Ugc3RpbGwgbmVlZCB0byBjbGFtcCBmdXJ0aGVyLCBwcm9iYWJseSB0byBw
bGFuZS0+d20uZmlmb19zaXplLgo+ID4+IEhvd2V2ZXIgc3JfZmlmb19zaXplIGlzIGFsc28gY2xh
bXBlZCB0byA1MTEgYmVjYXVzZSBvZiB0aGUgbGV2ZWwgY2FsY3VsYXRpb25zIGhlcmUuCj4gPj4K
PiA+PiBCZWxvdyBpdCBzZXRzIHNyW2xldmVsXS5wbGFuZSA9IG1pbihzcl9maWZvX3NpemUsIHdt
W2xldmVsXS5wbGFuZSksCj4gPj4gd2hpY2ggc2VlbXMgd2VpcmQuIEhvdyBjYW4gdGhpcyBldmVy
IGVuZCB1cCBiZWluZyBzb21ldGhpbmcgb3RoZXIgdGhhbiB3bVtsZXZlbF0ucGxhbmU/Cj4gPiBU
aGVyZSBhcmUgdGhyZWUgcGxhbmVzLiBDSFYgd2FzIHN1cHBvc2VkIHRvIGhhdmUgbWF4ZmlmbyB3
aXRoIHVwIHRvIDIgYWN0aXZlCj4gPiBwbGFuZXMuIEJ1dCBJJ20gbm90IHN1cmUgdGhhdCBmZWF0
dXJlIG1hZGUgaXQgaW4uIEkgbmV2ZXIgZ290IGFyb3VuZAo+ID4gdGVzdGluZyBpdC4KPiBJIGRv
bid0IGtub3csIHdlIG9ubHkgZW5hYmxlIGl0IHdpdGggYSBzaW5nbGUgcGxhbmUsIHBsdXMgY3Vy
c29yLiBJIGRvbid0IHNlZSB3aGVyZSB0aGUgb3RoZXIKPiBwbGFuZSB3bSdzIHdvdWxkIGZpdCBp
bj8KClRoZSBGSUZPIHdvdWxkIGJlIHNwbGl0IDE6MSB3aGVuIHR3byBwbGFuZXMgYXJlIGVuYWJs
ZWQuIEJ1dCBhcyBzdGF0ZWQsIEkKbmV2ZXIgYWN0dWFsbHkgdHJpZWQgaXQsIHNvIEkgbmV2ZXIg
ZW5hYmxlZCBpdC4KCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK
SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w
Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=