From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 01/12] drm/i915: Ignore initial lid state for eDP
Date: Thu, 28 Jul 2016 19:01:29 +0300 [thread overview]
Message-ID: <20160728160129.GQ4329@intel.com> (raw)
In-Reply-To: <20160728154707.GI7626@nuc-i3427.alporthouse.com>
On Thu, Jul 28, 2016 at 04:47:07PM +0100, Chris Wilson wrote:
> On Thu, Jul 28, 2016 at 05:50:37PM +0300, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Currently we try to check the lid status to see whether eDP is connected
> > or not. However we ignore the result anyway, and we have no lid notifier
> > to fire off uevents, so let's just ignore the lid stuff for eDP
> > entirely.
>
> You mean the OpRegion no longer contains lid_state? I don't see it being
> disabled... The lid notifier is from acpi/button.c. I haven't looked at
> why the result would be ignored, but you haven't convinced me why eDP is
> special.
We don't register a lid notifier for eDP. So if the initial detect would
happen with lid closed we'd mark eDP as disconnected, and when the lid
gets opened we won't even notice, and thus the connector never becomes
connected.
IIRC on my ILK the lid state in OpRegion didn't work anyway. But I
should probably double check.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-07-28 16:01 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 14:50 [PATCH 00/12] drm/i915: Move DP link retraining to hotplug work etc ville.syrjala
2016-07-28 14:50 ` [PATCH 01/12] drm/i915: Ignore initial lid state for eDP ville.syrjala
2016-07-28 15:47 ` Chris Wilson
2016-07-28 16:01 ` Ville Syrjälä [this message]
2016-07-28 16:36 ` Chris Wilson
2016-07-28 16:48 ` Ville Syrjälä
2016-07-28 14:50 ` [PATCH 02/12] drm/i915: Read PSR caps/intermediate freqs/etc. only once on eDP ville.syrjala
2016-07-28 17:30 ` Chris Wilson
2016-07-28 17:45 ` Ville Syrjälä
2016-07-29 13:52 ` [PATCH v3 " ville.syrjala
2016-07-28 14:50 ` [PATCH 03/12] drm/i915: Avoid mixing up SST and MST in DDI setup ville.syrjala
2016-07-29 9:16 ` Daniel Vetter
2016-07-29 9:55 ` Ville Syrjälä
2016-08-02 14:20 ` Daniel Vetter
2016-08-01 9:24 ` Maarten Lankhorst
2016-07-28 14:50 ` [PATCH 04/12] drm/i915: Reject mixing MST and SST/HDMI on the same digital port ville.syrjala
2016-07-29 9:19 ` Daniel Vetter
2016-07-29 11:28 ` Ville Syrjälä
2016-08-02 14:22 ` Daniel Vetter
2016-08-01 9:28 ` Maarten Lankhorst
2016-07-28 14:50 ` [PATCH 05/12] drm/i915: Track active streams also for DP SST ville.syrjala
2016-07-29 9:22 ` Daniel Vetter
2016-07-29 11:36 ` Ville Syrjälä
2016-07-29 18:36 ` Jim Bride
2016-08-02 14:28 ` Daniel Vetter
2016-07-28 14:50 ` [PATCH 06/12] drm/i915: Allow MST sinks to work even if drm_probe_ddc() fails ville.syrjala
2016-07-29 9:29 ` Daniel Vetter
2016-07-29 11:41 ` Ville Syrjälä
2016-07-29 13:51 ` [PATCH v2 " ville.syrjala
2016-07-28 14:50 ` [PATCH 07/12] drm/i915: Move DP link retraining into intel_dp_detect() ville.syrjala
2016-07-28 19:48 ` Manasi Navare
2016-07-28 20:15 ` Ville Syrjälä
2016-07-29 0:36 ` Manasi Navare
2016-07-29 9:52 ` Ville Syrjälä
2016-07-29 21:42 ` Manasi Navare
2016-07-29 21:45 ` Manasi Navare
2016-08-01 10:03 ` Ville Syrjälä
2016-07-29 20:37 ` Jim Bride
2016-07-28 14:50 ` [PATCH 08/12] drm/i915: Skip dpcd/edid read unless there was a long hpd ville.syrjala
2016-07-28 15:38 ` Chris Wilson
2016-07-28 15:44 ` Ville Syrjälä
2016-07-28 14:50 ` [PATCH 09/12] drm/i915: Remove useless rate_to_index() usage ville.syrjala
2016-07-29 9:33 ` Daniel Vetter
2016-07-28 14:50 ` [PATCH 10/12] drm/i915: Allow rate_to_index() to return non-exact matches ville.syrjala
2016-07-29 9:35 ` Daniel Vetter
2016-07-29 11:43 ` Ville Syrjälä
2016-07-28 14:50 ` [PATCH 11/12] drm/i915: Don't try to ack sink irqs when there are none ville.syrjala
2016-07-29 9:38 ` Daniel Vetter
2016-07-28 14:50 ` [RFC][PATCH 12/12] drm/i915: Add encoder .sync_state() hook ville.syrjala
2016-07-29 9:42 ` Daniel Vetter
2016-07-28 15:39 ` ✗ Ro.CI.BAT: failure for drm/i915: Move DP link retraining to hotplug work etc Patchwork
2016-07-29 14:27 ` ✗ Ro.CI.BAT: failure for drm/i915: Move DP link retraining to hotplug work etc. (rev3) Patchwork
2016-08-04 12:35 ` Ville Syrjälä
2016-08-04 13:08 ` [PATCH 00/12] drm/i915: Move DP link retraining to hotplug work etc Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160728160129.GQ4329@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox