From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 03/12] drm/i915: Avoid mixing up SST and MST in DDI setup Date: Fri, 29 Jul 2016 11:16:19 +0200 Message-ID: <20160729091619.GX6232@phenom.ffwll.local> References: <1469717448-4297-1-git-send-email-ville.syrjala@linux.intel.com> <1469717448-4297-4-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8F4206E95C for ; Fri, 29 Jul 2016 09:16:33 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id o80so14802528wme.0 for ; Fri, 29 Jul 2016 02:16:33 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1469717448-4297-4-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdWwgMjgsIDIwMTYgYXQgMDU6NTA6MzlQTSArMDMwMCwgdmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBUaGUgTVNUIHZzLiBTU1Qgc2VsZWN0aW9uIHNob3Vs ZCBkZXBlbmQgcHVyZWx5IG9uIHRoZSBjaG9pY2Ugb2YgdGhlCj4gY29ubmVjdG9yL2VuY29kZXIu IFNvIGRvbid0IHRyeSB0byBkZXRlcm1pbmUgdGhlIGNvcnJlY3QgRERJIG1vZGUKPiBiYXNlZCBv biB0aGUgaW50ZWxfZHAtPmlzX21zdCwgd2hpY2ggc2ltcGx5IHRlbGxzIHVzIHdoZXRoZXIgdGhl IHNpbmsKPiBpcyBpbiBNU1QgbW9kZSBvciBub3QuIEluc3RlYWQgZGVyaXZlIHRoZSBpbmZvcm1h dGlvbiBmcm9tIHRoZSBlbmNvZGVyCj4gdHlwZS4gU2luY2UgdGhlIGxpbmsgdHJhaW5pbmcgY29k ZSBkZWFscyBpbiBub24tZmFrZSBlbmNvZGVycywgd2UnbGwKPiBhbHNvIG5lZWQgdG8ga2VlcCBh IHNlY29uZCBjb3B5IG9mIHRoYXQgaW5mb3JtYXRpb24gYXJvdW5kLCB3aGljaCB3ZSdsbAo+IG5v dyBkZXNpZ25hdGUgYXMgJ2xpbmtfbXN0Jy4KPiAKPiBDYzogTWFhcnRlbiBMYW5raG9yc3QgPG1h YXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBT eXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKSG0sIEkgdGhpbmsgaXQn ZCBiZSBuaWNlIGlmIHdlIGNvdWxkIHNob3ZlbCBhbGwgdGhpcyBzdHVmZiBpbnRvIHRoZSBjcnRj CnN0YXRlIEkgdGhpbmssIGluc3RlYWQgb2Ygbm9vZGxpbmcgaXQgb3V0IG9mIHNvbWV3aGVyZSBl bHNlLiBCdXQgc2luY2Ugd2UKYWx3YXlzIHVwZGF0ZSBpdCBpbiBwcmVfZW5hYmxlIGhvb2tzIGl0 IHNob3VsZCBiZSBhbGwgZmluZSBldmVuIHdpdGgKVEVTVF9PTkxZIGF0b21pYy4KCkkgZGlncmVz cywgY2hhbmdlIGxvb2tzIGdvb2QuCgpSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVs LnZldHRlckBmZndsbC5jaD4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rk aS5jIHwgMjEgKysrLS0tLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2RwLmMgIHwgIDEgKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCB8ICAx ICsKPiAgMyBmaWxlcyBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDE4IGRlbGV0aW9ucygtKQo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gaW5kZXggZGQxZDZmZTEyMjk3Li4zYjNhMGE4 MDg0NzcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+IEBAIC0xMTExLDcgKzExMTEs NiBAQCB2b2lkIGludGVsX2RkaV9lbmFibGVfdHJhbnNjb2Rlcl9mdW5jKHN0cnVjdCBkcm1fY3J0 YyAqY3J0YykKPiAgewo+ICAJc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMgPSB0b19pbnRl bF9jcnRjKGNydGMpOwo+ICAJc3RydWN0IGludGVsX2VuY29kZXIgKmludGVsX2VuY29kZXIgPSBp bnRlbF9kZGlfZ2V0X2NydGNfZW5jb2RlcihjcnRjKTsKPiAtCXN0cnVjdCBkcm1fZW5jb2RlciAq ZW5jb2RlciA9ICZpbnRlbF9lbmNvZGVyLT5iYXNlOwo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRl diA9IGNydGMtPmRldjsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRv X2k5MTUoZGV2KTsKPiAgCWVudW0gcGlwZSBwaXBlID0gaW50ZWxfY3J0Yy0+cGlwZTsKPiBAQCAt MTE3NywyOSArMTE3NiwxNSBAQCB2b2lkIGludGVsX2RkaV9lbmFibGVfdHJhbnNjb2Rlcl9mdW5j KHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiAgCQkJdGVtcCB8PSBUUkFOU19ERElfTU9ERV9TRUxF Q1RfSERNSTsKPiAgCQllbHNlCj4gIAkJCXRlbXAgfD0gVFJBTlNfRERJX01PREVfU0VMRUNUX0RW STsKPiAtCj4gIAl9IGVsc2UgaWYgKHR5cGUgPT0gSU5URUxfT1VUUFVUX0FOQUxPRykgewo+ICAJ CXRlbXAgfD0gVFJBTlNfRERJX01PREVfU0VMRUNUX0ZESTsKPiAgCQl0ZW1wIHw9IChpbnRlbF9j cnRjLT5jb25maWctPmZkaV9sYW5lcyAtIDEpIDw8IDE7Cj4gLQo+ICAJfSBlbHNlIGlmICh0eXBl ID09IElOVEVMX09VVFBVVF9EUCB8fAo+ICAJCSAgIHR5cGUgPT0gSU5URUxfT1VUUFVUX0VEUCkg ewo+IC0JCXN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAgPSBlbmNfdG9faW50ZWxfZHAoZW5jb2Rl cik7Cj4gLQo+IC0JCWlmIChpbnRlbF9kcC0+aXNfbXN0KSB7Cj4gLQkJCXRlbXAgfD0gVFJBTlNf RERJX01PREVfU0VMRUNUX0RQX01TVDsKPiAtCQl9IGVsc2UKPiAtCQkJdGVtcCB8PSBUUkFOU19E RElfTU9ERV9TRUxFQ1RfRFBfU1NUOwo+IC0KPiArCQl0ZW1wIHw9IFRSQU5TX0RESV9NT0RFX1NF TEVDVF9EUF9TU1Q7Cj4gIAkJdGVtcCB8PSBERElfUE9SVF9XSURUSChpbnRlbF9jcnRjLT5jb25m aWctPmxhbmVfY291bnQpOwo+ICAJfSBlbHNlIGlmICh0eXBlID09IElOVEVMX09VVFBVVF9EUF9N U1QpIHsKPiAtCQlzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwID0gJmVuY190b19tc3QoZW5jb2Rl ciktPnByaW1hcnktPmRwOwo+IC0KPiAtCQlpZiAoaW50ZWxfZHAtPmlzX21zdCkgewo+IC0JCQl0 ZW1wIHw9IFRSQU5TX0RESV9NT0RFX1NFTEVDVF9EUF9NU1Q7Cj4gLQkJfSBlbHNlCj4gLQkJCXRl bXAgfD0gVFJBTlNfRERJX01PREVfU0VMRUNUX0RQX1NTVDsKPiAtCj4gKwkJdGVtcCB8PSBUUkFO U19ERElfTU9ERV9TRUxFQ1RfRFBfTVNUOwo+ICAJCXRlbXAgfD0gRERJX1BPUlRfV0lEVEgoaW50 ZWxfY3J0Yy0+Y29uZmlnLT5sYW5lX2NvdW50KTsKPiAgCX0gZWxzZSB7Cj4gIAkJV0FSTigxLCAi SW52YWxpZCBlbmNvZGVyIHR5cGUgJWQgZm9yIHBpcGUgJWNcbiIsCj4gQEAgLTIxMDUsNyArMjA5 MCw3IEBAIHZvaWQgaW50ZWxfZGRpX3ByZXBhcmVfbGlua19yZXRyYWluKHN0cnVjdCBpbnRlbF9k cCAqaW50ZWxfZHApCj4gIAo+ICAJdmFsID0gRFBfVFBfQ1RMX0VOQUJMRSB8Cj4gIAkgICAgICBE UF9UUF9DVExfTElOS19UUkFJTl9QQVQxIHwgRFBfVFBfQ1RMX1NDUkFNQkxFX0RJU0FCTEU7Cj4g LQlpZiAoaW50ZWxfZHAtPmlzX21zdCkKPiArCWlmIChpbnRlbF9kcC0+bGlua19tc3QpCj4gIAkJ dmFsIHw9IERQX1RQX0NUTF9NT0RFX01TVDsKPiAgCWVsc2Ugewo+ICAJCXZhbCB8PSBEUF9UUF9D VExfTU9ERV9TU1Q7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gaW5kZXggOGMzOGUzNDgzOTg5 Li4wMDk2YzY1MWMyMWYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBAQCAtMTY1MSw2 ICsxNjUxLDcgQEAgdm9pZCBpbnRlbF9kcF9zZXRfbGlua19wYXJhbXMoc3RydWN0IGludGVsX2Rw ICppbnRlbF9kcCwKPiAgewo+ICAJaW50ZWxfZHAtPmxpbmtfcmF0ZSA9IHBpcGVfY29uZmlnLT5w b3J0X2Nsb2NrOwo+ICAJaW50ZWxfZHAtPmxhbmVfY291bnQgPSBwaXBlX2NvbmZpZy0+bGFuZV9j b3VudDsKPiArCWludGVsX2RwLT5saW5rX21zdCA9IGludGVsX2NydGNfaGFzX3R5cGUocGlwZV9j b25maWcsIElOVEVMX09VVFBVVF9EUF9NU1QpOwo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZCBpbnRl bF9kcF9wcmVwYXJlKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyKQo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rydi5oCj4gaW5kZXggZTc0ZDg1MTg2OGM1Li43MGQ3ZjMzZDY3NDcgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IEBAIC04NTIsNiArODUyLDcgQEAgc3RydWN0IGludGVs X2RwIHsKPiAgCWludCBsaW5rX3JhdGU7Cj4gIAl1aW50OF90IGxhbmVfY291bnQ7Cj4gIAl1aW50 OF90IHNpbmtfY291bnQ7Cj4gKwlib29sIGxpbmtfbXN0Owo+ICAJYm9vbCBoYXNfYXVkaW87Cj4g IAlib29sIGRldGVjdF9kb25lOwo+ICAJZW51bSBoZG1pX2ZvcmNlX2F1ZGlvIGZvcmNlX2F1ZGlv Owo+IC0tIAo+IDIuNy40Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50 ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==