From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 03/12] drm/i915: Avoid mixing up SST and MST in DDI setup Date: Fri, 29 Jul 2016 12:55:20 +0300 Message-ID: <20160729095520.GX4329@intel.com> References: <1469717448-4297-1-git-send-email-ville.syrjala@linux.intel.com> <1469717448-4297-4-git-send-email-ville.syrjala@linux.intel.com> <20160729091619.GX6232@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id C721A6E984 for ; Fri, 29 Jul 2016 09:55:23 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160729091619.GX6232@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKdWwgMjksIDIwMTYgYXQgMTE6MTY6MTlBTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUaHUsIEp1bCAyOCwgMjAxNiBhdCAwNTo1MDozOVBNICswMzAwLCB2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToKPiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8 dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAKPiA+IFRoZSBNU1QgdnMuIFNTVCBz ZWxlY3Rpb24gc2hvdWxkIGRlcGVuZCBwdXJlbHkgb24gdGhlIGNob2ljZSBvZiB0aGUKPiA+IGNv bm5lY3Rvci9lbmNvZGVyLiBTbyBkb24ndCB0cnkgdG8gZGV0ZXJtaW5lIHRoZSBjb3JyZWN0IERE SSBtb2RlCj4gPiBiYXNlZCBvbiB0aGUgaW50ZWxfZHAtPmlzX21zdCwgd2hpY2ggc2ltcGx5IHRl bGxzIHVzIHdoZXRoZXIgdGhlIHNpbmsKPiA+IGlzIGluIE1TVCBtb2RlIG9yIG5vdC4gSW5zdGVh ZCBkZXJpdmUgdGhlIGluZm9ybWF0aW9uIGZyb20gdGhlIGVuY29kZXIKPiA+IHR5cGUuIFNpbmNl IHRoZSBsaW5rIHRyYWluaW5nIGNvZGUgZGVhbHMgaW4gbm9uLWZha2UgZW5jb2RlcnMsIHdlJ2xs Cj4gPiBhbHNvIG5lZWQgdG8ga2VlcCBhIHNlY29uZCBjb3B5IG9mIHRoYXQgaW5mb3JtYXRpb24g YXJvdW5kLCB3aGljaCB3ZSdsbAo+ID4gbm93IGRlc2lnbmF0ZSBhcyAnbGlua19tc3QnLgo+ID4g Cj4gPiBDYzogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVs LmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+Cj4gCj4gSG0sIEkgdGhpbmsgaXQnZCBiZSBuaWNlIGlmIHdlIGNvdWxk IHNob3ZlbCBhbGwgdGhpcyBzdHVmZiBpbnRvIHRoZSBjcnRjCj4gc3RhdGUgSSB0aGluaywgaW5z dGVhZCBvZiBub29kbGluZyBpdCBvdXQgb2Ygc29tZXdoZXJlIGVsc2UuCgpZb3UgbWVhbiBzdHVm ZmluZyBhIHByZS1jb21wdXRlZCAocGFydGlhbD8pIHJlZ2lzdGVyIHZhbHVlIGluIHRoZQpjcnRj IHN0YXRlPyBUaGF0IGNvdWxkIHdvcmsgdG9vLgoKPiBCdXQgc2luY2Ugd2UKPiBhbHdheXMgdXBk YXRlIGl0IGluIHByZV9lbmFibGUgaG9va3MgaXQgc2hvdWxkIGJlIGFsbCBmaW5lIGV2ZW4gd2l0 aAo+IFRFU1RfT05MWSBhdG9taWMuCj4gCj4gSSBkaWdyZXNzLCBjaGFuZ2UgbG9va3MgZ29vZC4K PiAKPiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4K PiAKPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIHwgMjEgKysr LS0tLS0tLS0tLS0tLS0tLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyAg fCAgMSArCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggfCAgMSArCj4gPiAg MyBmaWxlcyBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDE4IGRlbGV0aW9ucygtKQo+ID4gCj4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4gaW5kZXggZGQxZDZmZTEyMjk3Li4zYjNhMGE4 MDg0NzcgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+IEBAIC0xMTExLDcg KzExMTEsNiBAQCB2b2lkIGludGVsX2RkaV9lbmFibGVfdHJhbnNjb2Rlcl9mdW5jKHN0cnVjdCBk cm1fY3J0YyAqY3J0YykKPiA+ICB7Cj4gPiAgCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRj ID0gdG9faW50ZWxfY3J0YyhjcnRjKTsKPiA+ICAJc3RydWN0IGludGVsX2VuY29kZXIgKmludGVs X2VuY29kZXIgPSBpbnRlbF9kZGlfZ2V0X2NydGNfZW5jb2RlcihjcnRjKTsKPiA+IC0Jc3RydWN0 IGRybV9lbmNvZGVyICplbmNvZGVyID0gJmludGVsX2VuY29kZXItPmJhc2U7Cj4gPiAgCXN0cnVj dCBkcm1fZGV2aWNlICpkZXYgPSBjcnRjLT5kZXY7Cj4gPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiA+ICAJZW51bSBwaXBlIHBpcGUgPSBpbnRl bF9jcnRjLT5waXBlOwo+ID4gQEAgLTExNzcsMjkgKzExNzYsMTUgQEAgdm9pZCBpbnRlbF9kZGlf ZW5hYmxlX3RyYW5zY29kZXJfZnVuYyhzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gPiAgCQkJdGVt cCB8PSBUUkFOU19ERElfTU9ERV9TRUxFQ1RfSERNSTsKPiA+ICAJCWVsc2UKPiA+ICAJCQl0ZW1w IHw9IFRSQU5TX0RESV9NT0RFX1NFTEVDVF9EVkk7Cj4gPiAtCj4gPiAgCX0gZWxzZSBpZiAodHlw ZSA9PSBJTlRFTF9PVVRQVVRfQU5BTE9HKSB7Cj4gPiAgCQl0ZW1wIHw9IFRSQU5TX0RESV9NT0RF X1NFTEVDVF9GREk7Cj4gPiAgCQl0ZW1wIHw9IChpbnRlbF9jcnRjLT5jb25maWctPmZkaV9sYW5l cyAtIDEpIDw8IDE7Cj4gPiAtCj4gPiAgCX0gZWxzZSBpZiAodHlwZSA9PSBJTlRFTF9PVVRQVVRf RFAgfHwKPiA+ICAJCSAgIHR5cGUgPT0gSU5URUxfT1VUUFVUX0VEUCkgewo+ID4gLQkJc3RydWN0 IGludGVsX2RwICppbnRlbF9kcCA9IGVuY190b19pbnRlbF9kcChlbmNvZGVyKTsKPiA+IC0KPiA+ IC0JCWlmIChpbnRlbF9kcC0+aXNfbXN0KSB7Cj4gPiAtCQkJdGVtcCB8PSBUUkFOU19ERElfTU9E RV9TRUxFQ1RfRFBfTVNUOwo+ID4gLQkJfSBlbHNlCj4gPiAtCQkJdGVtcCB8PSBUUkFOU19ERElf TU9ERV9TRUxFQ1RfRFBfU1NUOwo+ID4gLQo+ID4gKwkJdGVtcCB8PSBUUkFOU19ERElfTU9ERV9T RUxFQ1RfRFBfU1NUOwo+ID4gIAkJdGVtcCB8PSBERElfUE9SVF9XSURUSChpbnRlbF9jcnRjLT5j b25maWctPmxhbmVfY291bnQpOwo+ID4gIAl9IGVsc2UgaWYgKHR5cGUgPT0gSU5URUxfT1VUUFVU X0RQX01TVCkgewo+ID4gLQkJc3RydWN0IGludGVsX2RwICppbnRlbF9kcCA9ICZlbmNfdG9fbXN0 KGVuY29kZXIpLT5wcmltYXJ5LT5kcDsKPiA+IC0KPiA+IC0JCWlmIChpbnRlbF9kcC0+aXNfbXN0 KSB7Cj4gPiAtCQkJdGVtcCB8PSBUUkFOU19ERElfTU9ERV9TRUxFQ1RfRFBfTVNUOwo+ID4gLQkJ fSBlbHNlCj4gPiAtCQkJdGVtcCB8PSBUUkFOU19ERElfTU9ERV9TRUxFQ1RfRFBfU1NUOwo+ID4g LQo+ID4gKwkJdGVtcCB8PSBUUkFOU19ERElfTU9ERV9TRUxFQ1RfRFBfTVNUOwo+ID4gIAkJdGVt cCB8PSBERElfUE9SVF9XSURUSChpbnRlbF9jcnRjLT5jb25maWctPmxhbmVfY291bnQpOwo+ID4g IAl9IGVsc2Ugewo+ID4gIAkJV0FSTigxLCAiSW52YWxpZCBlbmNvZGVyIHR5cGUgJWQgZm9yIHBp cGUgJWNcbiIsCj4gPiBAQCAtMjEwNSw3ICsyMDkwLDcgQEAgdm9pZCBpbnRlbF9kZGlfcHJlcGFy ZV9saW5rX3JldHJhaW4oc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiA+ICAKPiA+ICAJdmFs ID0gRFBfVFBfQ1RMX0VOQUJMRSB8Cj4gPiAgCSAgICAgIERQX1RQX0NUTF9MSU5LX1RSQUlOX1BB VDEgfCBEUF9UUF9DVExfU0NSQU1CTEVfRElTQUJMRTsKPiA+IC0JaWYgKGludGVsX2RwLT5pc19t c3QpCj4gPiArCWlmIChpbnRlbF9kcC0+bGlua19tc3QpCj4gPiAgCQl2YWwgfD0gRFBfVFBfQ1RM X01PREVfTVNUOwo+ID4gIAllbHNlIHsKPiA+ICAJCXZhbCB8PSBEUF9UUF9DVExfTU9ERV9TU1Q7 Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+IGluZGV4IDhjMzhlMzQ4Mzk4OS4uMDA5NmM2 NTFjMjFmIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gQEAgLTE2NTEsNiAr MTY1MSw3IEBAIHZvaWQgaW50ZWxfZHBfc2V0X2xpbmtfcGFyYW1zKHN0cnVjdCBpbnRlbF9kcCAq aW50ZWxfZHAsCj4gPiAgewo+ID4gIAlpbnRlbF9kcC0+bGlua19yYXRlID0gcGlwZV9jb25maWct PnBvcnRfY2xvY2s7Cj4gPiAgCWludGVsX2RwLT5sYW5lX2NvdW50ID0gcGlwZV9jb25maWctPmxh bmVfY291bnQ7Cj4gPiArCWludGVsX2RwLT5saW5rX21zdCA9IGludGVsX2NydGNfaGFzX3R5cGUo cGlwZV9jb25maWcsIElOVEVMX09VVFBVVF9EUF9NU1QpOwo+ID4gIH0KPiA+ICAKPiA+ICBzdGF0 aWMgdm9pZCBpbnRlbF9kcF9wcmVwYXJlKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyKQo+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiA+IGluZGV4IGU3NGQ4NTE4NjhjNS4uNzBkN2Yz M2Q2NzQ3IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgK PiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gPiBAQCAtODUyLDYg Kzg1Miw3IEBAIHN0cnVjdCBpbnRlbF9kcCB7Cj4gPiAgCWludCBsaW5rX3JhdGU7Cj4gPiAgCXVp bnQ4X3QgbGFuZV9jb3VudDsKPiA+ICAJdWludDhfdCBzaW5rX2NvdW50Owo+ID4gKwlib29sIGxp bmtfbXN0Owo+ID4gIAlib29sIGhhc19hdWRpbzsKPiA+ICAJYm9vbCBkZXRlY3RfZG9uZTsKPiA+ ICAJZW51bSBoZG1pX2ZvcmNlX2F1ZGlvIGZvcmNlX2F1ZGlvOwo+ID4gLS0gCj4gPiAyLjcuNAo+ ID4gCj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwo+ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngKPiAKPiAtLSAKPiBEYW5pZWwgVmV0dGVyCj4gU29mdHdhcmUgRW5naW5lZXIsIElu dGVsIENvcnBvcmF0aW9uCj4gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKCi0tIApWaWxsZSBTeXJqw6Rs w6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=