From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 03/12] drm/i915: Avoid mixing up SST and MST in DDI setup Date: Tue, 2 Aug 2016 16:20:18 +0200 Message-ID: <20160802142018.GV6232@phenom.ffwll.local> References: <1469717448-4297-1-git-send-email-ville.syrjala@linux.intel.com> <1469717448-4297-4-git-send-email-ville.syrjala@linux.intel.com> <20160729091619.GX6232@phenom.ffwll.local> <20160729095520.GX4329@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 63D7E6E5D0 for ; Tue, 2 Aug 2016 14:20:23 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id i5so31144587wmg.2 for ; Tue, 02 Aug 2016 07:20:23 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160729095520.GX4329@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKdWwgMjksIDIwMTYgYXQgMTI6NTU6MjBQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIEZyaSwgSnVsIDI5LCAyMDE2IGF0IDExOjE2OjE5QU0gKzAyMDAsIERhbmll bCBWZXR0ZXIgd3JvdGU6Cj4gPiBPbiBUaHUsIEp1bCAyOCwgMjAxNiBhdCAwNTo1MDozOVBNICsw MzAwLCB2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToKPiA+ID4gRnJvbTogVmls bGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+ID4gCj4gPiA+ IFRoZSBNU1QgdnMuIFNTVCBzZWxlY3Rpb24gc2hvdWxkIGRlcGVuZCBwdXJlbHkgb24gdGhlIGNo b2ljZSBvZiB0aGUKPiA+ID4gY29ubmVjdG9yL2VuY29kZXIuIFNvIGRvbid0IHRyeSB0byBkZXRl cm1pbmUgdGhlIGNvcnJlY3QgRERJIG1vZGUKPiA+ID4gYmFzZWQgb24gdGhlIGludGVsX2RwLT5p c19tc3QsIHdoaWNoIHNpbXBseSB0ZWxscyB1cyB3aGV0aGVyIHRoZSBzaW5rCj4gPiA+IGlzIGlu IE1TVCBtb2RlIG9yIG5vdC4gSW5zdGVhZCBkZXJpdmUgdGhlIGluZm9ybWF0aW9uIGZyb20gdGhl IGVuY29kZXIKPiA+ID4gdHlwZS4gU2luY2UgdGhlIGxpbmsgdHJhaW5pbmcgY29kZSBkZWFscyBp biBub24tZmFrZSBlbmNvZGVycywgd2UnbGwKPiA+ID4gYWxzbyBuZWVkIHRvIGtlZXAgYSBzZWNv bmQgY29weSBvZiB0aGF0IGluZm9ybWF0aW9uIGFyb3VuZCwgd2hpY2ggd2UnbGwKPiA+ID4gbm93 IGRlc2lnbmF0ZSBhcyAnbGlua19tc3QnLgo+ID4gPiAKPiA+ID4gQ2M6IE1hYXJ0ZW4gTGFua2hv cnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPiA+IFNpZ25lZC1vZmYt Ynk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAK PiA+IEhtLCBJIHRoaW5rIGl0J2QgYmUgbmljZSBpZiB3ZSBjb3VsZCBzaG92ZWwgYWxsIHRoaXMg c3R1ZmYgaW50byB0aGUgY3J0Ywo+ID4gc3RhdGUgSSB0aGluaywgaW5zdGVhZCBvZiBub29kbGlu ZyBpdCBvdXQgb2Ygc29tZXdoZXJlIGVsc2UuCj4gCj4gWW91IG1lYW4gc3R1ZmZpbmcgYSBwcmUt Y29tcHV0ZWQgKHBhcnRpYWw/KSByZWdpc3RlciB2YWx1ZSBpbiB0aGUKPiBjcnRjIHN0YXRlPyBU aGF0IGNvdWxkIHdvcmsgdG9vLgoKWWVhaC4gQnV0IHJlYWRpbmcgYWhlYWQgSSdtIG5vdCBzdXJl IHdoZXJlIGV4YWN0bHkgd2UgbmVlZCB0byBzdG9yZSB0aGF0LApzaW5jZSByZWNvdmVyaW5nIHRo YXQgd2l0aCB5b3VyIHN5bmNfc3RhdGUgcmZjIG1pZ2h0IGdldCB0cmlja3kuCi1EYW5pZWwKCj4g Cj4gPiBCdXQgc2luY2Ugd2UKPiA+IGFsd2F5cyB1cGRhdGUgaXQgaW4gcHJlX2VuYWJsZSBob29r cyBpdCBzaG91bGQgYmUgYWxsIGZpbmUgZXZlbiB3aXRoCj4gPiBURVNUX09OTFkgYXRvbWljLgo+ ID4gCj4gPiBJIGRpZ3Jlc3MsIGNoYW5nZSBsb29rcyBnb29kLgo+ID4gCj4gPiBSZXZpZXdlZC1i eTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiA+IAo+ID4gPiAtLS0K PiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIHwgMjEgKysrLS0tLS0tLS0t LS0tLS0tLS0tCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jICB8ICAxICsK PiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIHwgIDEgKwo+ID4gPiAgMyBm aWxlcyBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDE4IGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+ID4gaW5kZXggZGQxZDZmZTEyMjk3Li4zYjNh MGE4MDg0NzcgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rk aS5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gPiA+IEBA IC0xMTExLDcgKzExMTEsNiBAQCB2b2lkIGludGVsX2RkaV9lbmFibGVfdHJhbnNjb2Rlcl9mdW5j KHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiA+ID4gIHsKPiA+ID4gIAlzdHJ1Y3QgaW50ZWxfY3J0 YyAqaW50ZWxfY3J0YyA9IHRvX2ludGVsX2NydGMoY3J0Yyk7Cj4gPiA+ICAJc3RydWN0IGludGVs X2VuY29kZXIgKmludGVsX2VuY29kZXIgPSBpbnRlbF9kZGlfZ2V0X2NydGNfZW5jb2RlcihjcnRj KTsKPiA+ID4gLQlzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIgPSAmaW50ZWxfZW5jb2Rlci0+ YmFzZTsKPiA+ID4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gY3J0Yy0+ZGV2Owo+ID4gPiAg CXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiA+ID4g IAllbnVtIHBpcGUgcGlwZSA9IGludGVsX2NydGMtPnBpcGU7Cj4gPiA+IEBAIC0xMTc3LDI5ICsx MTc2LDE1IEBAIHZvaWQgaW50ZWxfZGRpX2VuYWJsZV90cmFuc2NvZGVyX2Z1bmMoc3RydWN0IGRy bV9jcnRjICpjcnRjKQo+ID4gPiAgCQkJdGVtcCB8PSBUUkFOU19ERElfTU9ERV9TRUxFQ1RfSERN STsKPiA+ID4gIAkJZWxzZQo+ID4gPiAgCQkJdGVtcCB8PSBUUkFOU19ERElfTU9ERV9TRUxFQ1Rf RFZJOwo+ID4gPiAtCj4gPiA+ICAJfSBlbHNlIGlmICh0eXBlID09IElOVEVMX09VVFBVVF9BTkFM T0cpIHsKPiA+ID4gIAkJdGVtcCB8PSBUUkFOU19ERElfTU9ERV9TRUxFQ1RfRkRJOwo+ID4gPiAg CQl0ZW1wIHw9IChpbnRlbF9jcnRjLT5jb25maWctPmZkaV9sYW5lcyAtIDEpIDw8IDE7Cj4gPiA+ IC0KPiA+ID4gIAl9IGVsc2UgaWYgKHR5cGUgPT0gSU5URUxfT1VUUFVUX0RQIHx8Cj4gPiA+ICAJ CSAgIHR5cGUgPT0gSU5URUxfT1VUUFVUX0VEUCkgewo+ID4gPiAtCQlzdHJ1Y3QgaW50ZWxfZHAg KmludGVsX2RwID0gZW5jX3RvX2ludGVsX2RwKGVuY29kZXIpOwo+ID4gPiAtCj4gPiA+IC0JCWlm IChpbnRlbF9kcC0+aXNfbXN0KSB7Cj4gPiA+IC0JCQl0ZW1wIHw9IFRSQU5TX0RESV9NT0RFX1NF TEVDVF9EUF9NU1Q7Cj4gPiA+IC0JCX0gZWxzZQo+ID4gPiAtCQkJdGVtcCB8PSBUUkFOU19ERElf TU9ERV9TRUxFQ1RfRFBfU1NUOwo+ID4gPiAtCj4gPiA+ICsJCXRlbXAgfD0gVFJBTlNfRERJX01P REVfU0VMRUNUX0RQX1NTVDsKPiA+ID4gIAkJdGVtcCB8PSBERElfUE9SVF9XSURUSChpbnRlbF9j cnRjLT5jb25maWctPmxhbmVfY291bnQpOwo+ID4gPiAgCX0gZWxzZSBpZiAodHlwZSA9PSBJTlRF TF9PVVRQVVRfRFBfTVNUKSB7Cj4gPiA+IC0JCXN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAgPSAm ZW5jX3RvX21zdChlbmNvZGVyKS0+cHJpbWFyeS0+ZHA7Cj4gPiA+IC0KPiA+ID4gLQkJaWYgKGlu dGVsX2RwLT5pc19tc3QpIHsKPiA+ID4gLQkJCXRlbXAgfD0gVFJBTlNfRERJX01PREVfU0VMRUNU X0RQX01TVDsKPiA+ID4gLQkJfSBlbHNlCj4gPiA+IC0JCQl0ZW1wIHw9IFRSQU5TX0RESV9NT0RF X1NFTEVDVF9EUF9TU1Q7Cj4gPiA+IC0KPiA+ID4gKwkJdGVtcCB8PSBUUkFOU19ERElfTU9ERV9T RUxFQ1RfRFBfTVNUOwo+ID4gPiAgCQl0ZW1wIHw9IERESV9QT1JUX1dJRFRIKGludGVsX2NydGMt PmNvbmZpZy0+bGFuZV9jb3VudCk7Cj4gPiA+ICAJfSBlbHNlIHsKPiA+ID4gIAkJV0FSTigxLCAi SW52YWxpZCBlbmNvZGVyIHR5cGUgJWQgZm9yIHBpcGUgJWNcbiIsCj4gPiA+IEBAIC0yMTA1LDcg KzIwOTAsNyBAQCB2b2lkIGludGVsX2RkaV9wcmVwYXJlX2xpbmtfcmV0cmFpbihzdHJ1Y3QgaW50 ZWxfZHAgKmludGVsX2RwKQo+ID4gPiAgCj4gPiA+ICAJdmFsID0gRFBfVFBfQ1RMX0VOQUJMRSB8 Cj4gPiA+ICAJICAgICAgRFBfVFBfQ1RMX0xJTktfVFJBSU5fUEFUMSB8IERQX1RQX0NUTF9TQ1JB TUJMRV9ESVNBQkxFOwo+ID4gPiAtCWlmIChpbnRlbF9kcC0+aXNfbXN0KQo+ID4gPiArCWlmIChp bnRlbF9kcC0+bGlua19tc3QpCj4gPiA+ICAJCXZhbCB8PSBEUF9UUF9DVExfTU9ERV9NU1Q7Cj4g PiA+ICAJZWxzZSB7Cj4gPiA+ICAJCXZhbCB8PSBEUF9UUF9DVExfTU9ERV9TU1Q7Cj4gPiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gPiBpbmRleCA4YzM4ZTM0ODM5ODkuLjAwOTZjNjUxYzIx ZiAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4g PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiA+IEBAIC0xNjUxLDYg KzE2NTEsNyBAQCB2b2lkIGludGVsX2RwX3NldF9saW5rX3BhcmFtcyhzdHJ1Y3QgaW50ZWxfZHAg KmludGVsX2RwLAo+ID4gPiAgewo+ID4gPiAgCWludGVsX2RwLT5saW5rX3JhdGUgPSBwaXBlX2Nv bmZpZy0+cG9ydF9jbG9jazsKPiA+ID4gIAlpbnRlbF9kcC0+bGFuZV9jb3VudCA9IHBpcGVfY29u ZmlnLT5sYW5lX2NvdW50Owo+ID4gPiArCWludGVsX2RwLT5saW5rX21zdCA9IGludGVsX2NydGNf aGFzX3R5cGUocGlwZV9jb25maWcsIElOVEVMX09VVFBVVF9EUF9NU1QpOwo+ID4gPiAgfQo+ID4g PiAgCj4gPiA+ICBzdGF0aWMgdm9pZCBpbnRlbF9kcF9wcmVwYXJlKHN0cnVjdCBpbnRlbF9lbmNv ZGVyICplbmNvZGVyKQo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ID4gPiBpbmRleCBl NzRkODUxODY4YzUuLjcwZDdmMzNkNjc0NyAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHJ2LmgKPiA+ID4gQEAgLTg1Miw2ICs4NTIsNyBAQCBzdHJ1Y3QgaW50ZWxfZHAgewo+ID4g PiAgCWludCBsaW5rX3JhdGU7Cj4gPiA+ICAJdWludDhfdCBsYW5lX2NvdW50Owo+ID4gPiAgCXVp bnQ4X3Qgc2lua19jb3VudDsKPiA+ID4gKwlib29sIGxpbmtfbXN0Owo+ID4gPiAgCWJvb2wgaGFz X2F1ZGlvOwo+ID4gPiAgCWJvb2wgZGV0ZWN0X2RvbmU7Cj4gPiA+ICAJZW51bSBoZG1pX2ZvcmNl X2F1ZGlvIGZvcmNlX2F1ZGlvOwo+ID4gPiAtLSAKPiA+ID4gMi43LjQKPiA+ID4gCj4gPiA+IF9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiA+IEludGVs LWdmeCBtYWlsaW5nIGxpc3QKPiA+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ ID4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo+ID4gCj4gPiAtLSAKPiA+IERhbmllbCBWZXR0ZXIKPiA+IFNvZnR3YXJlIEVuZ2luZWVy LCBJbnRlbCBDb3Jwb3JhdGlvbgo+ID4gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKPiAKPiAtLSAKPiBW aWxsZSBTeXJqw6Rsw6QKPiBJbnRlbCBPVEMKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVu Z2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK