From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Clean up the extra RPM ref on CHV with i915.enable_rc6=0
Date: Wed, 3 Aug 2016 18:44:18 +0300 [thread overview]
Message-ID: <20160803154418.GL4329@intel.com> (raw)
In-Reply-To: <1470136562.23233.2.camel@intel.com>
On Tue, Aug 02, 2016 at 02:16:02PM +0300, Imre Deak wrote:
> On ti, 2016-08-02 at 14:07 +0300, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Remove the CHV early bail out from intel_cleanup_gt_powersave() so that
> > we'll clean up the extra RPM reference held due to i915.enable_rc6=0.
> >
> > Cc: Imre Deak <imre.deak@intel.com>
> > Fixes: b268c699aca5 ("drm/i915: refactor RPM disabling due to RC6 being disabled")
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Thanks for catching it:
> Reviewed-by: Imre Deak <imre.deak@intel.com>
Pushed to dinq. Thanks for the review.
>
> > ---
> > drivers/gpu/drm/i915/intel_pm.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > index 1ac32428d4db..125faac2fb5d 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -6533,9 +6533,7 @@ void intel_init_gt_powersave(struct drm_i915_private *dev_priv)
> >
> > void intel_cleanup_gt_powersave(struct drm_i915_private *dev_priv)
> > {
> > - if (IS_CHERRYVIEW(dev_priv))
> > - return;
> > - else if (IS_VALLEYVIEW(dev_priv))
> > + if (IS_VALLEYVIEW(dev_priv))
> > valleyview_cleanup_gt_powersave(dev_priv);
> >
> > if (!i915.enable_rc6)
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-08-03 15:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 11:07 [PATCH] drm/i915: Clean up the extra RPM ref on CHV with i915.enable_rc6=0 ville.syrjala
2016-08-02 11:16 ` Imre Deak
2016-08-03 15:44 ` Ville Syrjälä [this message]
2016-08-02 11:28 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-08-03 13:53 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160803154418.GL4329@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox