From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Use drm official vblnk_no_hw_counter callback.
Date: Wed, 3 Aug 2016 21:32:51 +0300 [thread overview]
Message-ID: <20160803183251.GM4329@intel.com> (raw)
In-Reply-To: <1470243656-3753-1-git-send-email-rodrigo.vivi@intel.com>
On Wed, Aug 03, 2016 at 10:00:56AM -0700, Rodrigo Vivi wrote:
> No functional change. Instead of defining a new empty function
> let's use what is available on drm.
>
> It gets cleaner, and easy to read, and understand.
>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_irq.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index f5bf4f9..6030797 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -656,12 +656,6 @@ static void i915_enable_asle_pipestat(struct drm_i915_private *dev_priv)
> * of horizontal active on the first line of vertical active
> */
>
> -static u32 i8xx_get_vblank_counter(struct drm_device *dev, unsigned int pipe)
> -{
> - /* Gen2 doesn't have a hardware frame counter */
> - return 0;
> -}
> -
> /* Called from drm generic code, passed a 'crtc', which
> * we use as a pipe index
> */
> @@ -4545,8 +4539,9 @@ void intel_irq_init(struct drm_i915_private *dev_priv)
> i915_hangcheck_elapsed);
>
> if (IS_GEN2(dev_priv)) {
> + /* Gen2 doesn't have a hardware frame counter */
> dev->max_vblank_count = 0;
> - dev->driver->get_vblank_counter = i8xx_get_vblank_counter;
> + dev->driver->get_vblank_counter = drm_vblank_no_hw_counter;
> } else if (IS_G4X(dev_priv) || INTEL_INFO(dev_priv)->gen >= 5) {
> dev->max_vblank_count = 0xffffffff; /* full 32 bit counter */
> dev->driver->get_vblank_counter = g4x_get_vblank_counter;
> --
> 2.5.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-08-03 18:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 17:00 [PATCH] drm/i915: Use drm official vblnk_no_hw_counter callback Rodrigo Vivi
2016-08-03 18:32 ` Ville Syrjälä [this message]
2016-08-04 5:19 ` ✗ Ro.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160803183251.GM4329@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox