[PATCH] drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation entry 2

[PATCH] drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation entry 2

[ville.syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The spec was recently fixed to have the correct iboost setting for the
SKL Y/U DP DDI buffer translation table entry 2. Update our tables
to match.

Cc: David Weinehall <david.weinehall@linux.intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index fc2ef2d76091..c55a2ad50c0d 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -145,7 +145,7 @@ static const struct ddi_buf_trans skl_ddi_translations_dp[] = {
 static const struct ddi_buf_trans skl_u_ddi_translations_dp[] = {
 	{ 0x0000201B, 0x000000A2, 0x0 },
 	{ 0x00005012, 0x00000088, 0x0 },
-	{ 0x80007011, 0x000000CD, 0x0 },
+	{ 0x80007011, 0x000000CD, 0x1 },
 	{ 0x80009010, 0x000000C0, 0x1 },
 	{ 0x0000201B, 0x0000009D, 0x0 },
 	{ 0x80005012, 0x000000C0, 0x1 },
@@ -158,7 +158,7 @@ static const struct ddi_buf_trans skl_u_ddi_translations_dp[] = {
 static const struct ddi_buf_trans skl_y_ddi_translations_dp[] = {
 	{ 0x00000018, 0x000000A2, 0x0 },
 	{ 0x00005012, 0x00000088, 0x0 },
-	{ 0x80007011, 0x000000CD, 0x0 },
+	{ 0x80007011, 0x000000CD, 0x3 },
 	{ 0x80009010, 0x000000C0, 0x3 },
 	{ 0x00000018, 0x0000009D, 0x0 },
 	{ 0x80005012, 0x000000C0, 0x3 },
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation entry 2

[Jani Nikula]

On Tue, 02 Aug 2016, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The spec was recently fixed to have the correct iboost setting for the
> SKL Y/U DP DDI buffer translation table entry 2. Update our tables
> to match.
>
> Cc: David Weinehall <david.weinehall@linux.intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Cc: stable@vger.kernel.org

> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index fc2ef2d76091..c55a2ad50c0d 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -145,7 +145,7 @@ static const struct ddi_buf_trans skl_ddi_translations_dp[] = {
>  static const struct ddi_buf_trans skl_u_ddi_translations_dp[] = {
>  	{ 0x0000201B, 0x000000A2, 0x0 },
>  	{ 0x00005012, 0x00000088, 0x0 },
> -	{ 0x80007011, 0x000000CD, 0x0 },
> +	{ 0x80007011, 0x000000CD, 0x1 },
>  	{ 0x80009010, 0x000000C0, 0x1 },
>  	{ 0x0000201B, 0x0000009D, 0x0 },
>  	{ 0x80005012, 0x000000C0, 0x1 },
> @@ -158,7 +158,7 @@ static const struct ddi_buf_trans skl_u_ddi_translations_dp[] = {
>  static const struct ddi_buf_trans skl_y_ddi_translations_dp[] = {
>  	{ 0x00000018, 0x000000A2, 0x0 },
>  	{ 0x00005012, 0x00000088, 0x0 },
> -	{ 0x80007011, 0x000000CD, 0x0 },
> +	{ 0x80007011, 0x000000CD, 0x3 },
>  	{ 0x80009010, 0x000000C0, 0x3 },
>  	{ 0x00000018, 0x0000009D, 0x0 },
>  	{ 0x80005012, 0x000000C0, 0x3 },

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation entry 2

[Ville Syrjälä]

On Tue, Aug 02, 2016 at 03:37:27PM +0300, Jani Nikula wrote:
> On Tue, 02 Aug 2016, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > The spec was recently fixed to have the correct iboost setting for the
> > SKL Y/U DP DDI buffer translation table entry 2. Update our tables
> > to match.
> >
> > Cc: David Weinehall <david.weinehall@linux.intel.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Cc: stable@vger.kernel.org

Added that and pushed to dinq. 

It looks like've had quite a few updates to these tables slip by w/o
adding the cc:stable :( Hopefully stable maintainers will notice
and perhaps pick them all up when they grab this one.

> 
> > ---
> >  drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> > index fc2ef2d76091..c55a2ad50c0d 100644
> > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > @@ -145,7 +145,7 @@ static const struct ddi_buf_trans skl_ddi_translations_dp[] = {
> >  static const struct ddi_buf_trans skl_u_ddi_translations_dp[] = {
> >  	{ 0x0000201B, 0x000000A2, 0x0 },
> >  	{ 0x00005012, 0x00000088, 0x0 },
> > -	{ 0x80007011, 0x000000CD, 0x0 },
> > +	{ 0x80007011, 0x000000CD, 0x1 },
> >  	{ 0x80009010, 0x000000C0, 0x1 },
> >  	{ 0x0000201B, 0x0000009D, 0x0 },
> >  	{ 0x80005012, 0x000000C0, 0x1 },
> > @@ -158,7 +158,7 @@ static const struct ddi_buf_trans skl_u_ddi_translations_dp[] = {
> >  static const struct ddi_buf_trans skl_y_ddi_translations_dp[] = {
> >  	{ 0x00000018, 0x000000A2, 0x0 },
> >  	{ 0x00005012, 0x00000088, 0x0 },
> > -	{ 0x80007011, 0x000000CD, 0x0 },
> > +	{ 0x80007011, 0x000000CD, 0x3 },
> >  	{ 0x80009010, 0x000000C0, 0x3 },
> >  	{ 0x00000018, 0x0000009D, 0x0 },
> >  	{ 0x80005012, 0x000000C0, 0x3 },
> 
> -- 
> Jani Nikula, Intel Open Source Technology Center

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation entry 2

[Daniel Vetter]

On Fri, Aug 05, 2016 at 09:43:59AM +0300, Ville Syrjälä wrote:
> On Tue, Aug 02, 2016 at 03:37:27PM +0300, Jani Nikula wrote:
> > On Tue, 02 Aug 2016, ville.syrjala@linux.intel.com wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > The spec was recently fixed to have the correct iboost setting for the
> > > SKL Y/U DP DDI buffer translation table entry 2. Update our tables
> > > to match.
> > >
> > > Cc: David Weinehall <david.weinehall@linux.intel.com>
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Cc: stable@vger.kernel.org
> 
> Added that and pushed to dinq. 
> 
> It looks like've had quite a few updates to these tables slip by w/o
> adding the cc:stable :( Hopefully stable maintainers will notice
> and perhaps pick them all up when they grab this one.

For next time around, you can give stable maintainers explicit hints about
additional patches they need to cherry-pick:

     Cc: <stable@vger.kernel.org> # 3.3.x: a1f84a3: sched: Check for idle
     Cc: <stable@vger.kernel.org> # 3.3.x: 1b9508f: sched: Rate-limit newidle
     Cc: <stable@vger.kernel.org> # 3.3.x: fd21073: sched: Fix affinity logic
     Cc: <stable@vger.kernel.org> # 3.3.x
    Signed-off-by: Ingo Molnar <mingo@elte.hu>

Copied directly fromt he docs even ;-)
-Daniel

> 
> > 
> > > ---
> > >  drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> > > index fc2ef2d76091..c55a2ad50c0d 100644
> > > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > > @@ -145,7 +145,7 @@ static const struct ddi_buf_trans skl_ddi_translations_dp[] = {
> > >  static const struct ddi_buf_trans skl_u_ddi_translations_dp[] = {
> > >  	{ 0x0000201B, 0x000000A2, 0x0 },
> > >  	{ 0x00005012, 0x00000088, 0x0 },
> > > -	{ 0x80007011, 0x000000CD, 0x0 },
> > > +	{ 0x80007011, 0x000000CD, 0x1 },
> > >  	{ 0x80009010, 0x000000C0, 0x1 },
> > >  	{ 0x0000201B, 0x0000009D, 0x0 },
> > >  	{ 0x80005012, 0x000000C0, 0x1 },
> > > @@ -158,7 +158,7 @@ static const struct ddi_buf_trans skl_u_ddi_translations_dp[] = {
> > >  static const struct ddi_buf_trans skl_y_ddi_translations_dp[] = {
> > >  	{ 0x00000018, 0x000000A2, 0x0 },
> > >  	{ 0x00005012, 0x00000088, 0x0 },
> > > -	{ 0x80007011, 0x000000CD, 0x0 },
> > > +	{ 0x80007011, 0x000000CD, 0x3 },
> > >  	{ 0x80009010, 0x000000C0, 0x3 },
> > >  	{ 0x00000018, 0x0000009D, 0x0 },
> > >  	{ 0x80005012, 0x000000C0, 0x3 },
> > 
> > -- 
> > Jani Nikula, Intel Open Source Technology Center
> 
> -- 
> Ville Syrjälä
> Intel OTC
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Ro.CI.BAT: failure for drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation entry 2

[Patchwork]

== Series Details ==

Series: drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation entry 2
URL   : https://patchwork.freedesktop.org/series/10511/
State : failure

== Summary ==

Series 10511v1 drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation entry 2
http://patchwork.freedesktop.org/api/1.0/series/10511/revisions/1/mbox

Test drv_module_reload_basic:
                pass       -> SKIP       (ro-skl3-i5-6260u)
Test kms_cursor_legacy:
        Subgroup basic-cursor-vs-flip-legacy:
                pass       -> FAIL       (ro-ilk1-i5-650)
        Subgroup basic-flip-vs-cursor-legacy:
                fail       -> PASS       (ro-bdw-i5-5250u)
                fail       -> PASS       (fi-skl-i7-6700k)
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                incomplete -> PASS       (fi-hsw-i7-4770k)

fi-hsw-i7-4770k  total:240  pass:218  dwarn:0   dfail:0   fail:0   skip:22 
fi-kbl-qkkr      total:240  pass:182  dwarn:30  dfail:0   fail:2   skip:26 
fi-skl-i5-6260u  total:240  pass:224  dwarn:0   dfail:0   fail:2   skip:14 
fi-skl-i7-6700k  total:240  pass:209  dwarn:0   dfail:0   fail:3   skip:28 
fi-snb-i7-2600   total:240  pass:198  dwarn:0   dfail:0   fail:0   skip:42 
ro-bdw-i5-5250u  total:240  pass:219  dwarn:4   dfail:0   fail:1   skip:16 
ro-bdw-i7-5557U  total:240  pass:223  dwarn:0   dfail:0   fail:1   skip:16 
ro-bdw-i7-5600u  total:240  pass:207  dwarn:0   dfail:0   fail:1   skip:32 
ro-bsw-n3050     total:240  pass:195  dwarn:0   dfail:0   fail:3   skip:42 
ro-byt-n2820     total:240  pass:198  dwarn:0   dfail:0   fail:2   skip:40 
ro-hsw-i3-4010u  total:240  pass:214  dwarn:0   dfail:0   fail:0   skip:26 
ro-hsw-i7-4770r  total:240  pass:214  dwarn:0   dfail:0   fail:0   skip:26 
ro-ilk-i7-620lm  total:240  pass:173  dwarn:1   dfail:0   fail:1   skip:65 
ro-ilk1-i5-650   total:235  pass:172  dwarn:0   dfail:0   fail:3   skip:60 
ro-ivb-i7-3770   total:240  pass:205  dwarn:0   dfail:0   fail:0   skip:35 
ro-ivb2-i7-3770  total:240  pass:209  dwarn:0   dfail:0   fail:0   skip:31 
ro-skl3-i5-6260u total:240  pass:221  dwarn:0   dfail:0   fail:4   skip:15 

Results at /archive/results/CI_IGT_test/RO_Patchwork_1667/

862c995 drm-intel-nightly: 2016y-08m-02d-12h-12m-24s UTC integration manifest
012a950 drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation entry 2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✗ Ro.CI.BAT: failure for drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation entry 2

[Ville Syrjälä]

On Tue, Aug 02, 2016 at 12:59:48PM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation entry 2
> URL   : https://patchwork.freedesktop.org/series/10511/
> State : failure
> 
> == Summary ==
> 
> Series 10511v1 drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation entry 2
> http://patchwork.freedesktop.org/api/1.0/series/10511/revisions/1/mbox
> 
> Test drv_module_reload_basic:
>                 pass       -> SKIP       (ro-skl3-i5-6260u)

rmmod: ERROR: Module i915 is in use
rmmod: ERROR: Module i915 is in use
rmmod: ERROR: Module i915 is in use
rmmod: ERROR: Module i915 is in use
rmmod: ERROR: Module i915 is in use

As usual it seems to have unloaded+reloaded once, but no real clue in
dmesg why it fails the subsequent unload.

> Test kms_cursor_legacy:
>         Subgroup basic-cursor-vs-flip-legacy:
>                 pass       -> FAIL       (ro-ilk1-i5-650)

(kms_cursor_legacy:7968) DEBUG: Test requirement passed: target > 1
(kms_cursor_legacy:7968) DEBUG: Using a target of 64 cursor updates per half-vblank
(kms_cursor_legacy:7968) WARNING: page flip 40 was delayed, missed 1 frames
(kms_cursor_legacy:7968) CRITICAL: Test assertion failure function basic_cursor_vs_flip, file kms_cursor_legacy.c:670:
(kms_cursor_legacy:7968) CRITICAL: Failed assertion: vbl.sequence == vblank_start + 60
(kms_cursor_legacy:7968) CRITICAL: error: 11085 != 11084

https://bugs.freedesktop.org/show_bug.cgi?id=96701

>         Subgroup basic-flip-vs-cursor-legacy:
>                 fail       -> PASS       (ro-bdw-i5-5250u)
>                 fail       -> PASS       (fi-skl-i7-6700k)
> Test kms_pipe_crc_basic:
>         Subgroup suspend-read-crc-pipe-b:
>                 incomplete -> PASS       (fi-hsw-i7-4770k)
> 
> fi-hsw-i7-4770k  total:240  pass:218  dwarn:0   dfail:0   fail:0   skip:22 
> fi-kbl-qkkr      total:240  pass:182  dwarn:30  dfail:0   fail:2   skip:26 
> fi-skl-i5-6260u  total:240  pass:224  dwarn:0   dfail:0   fail:2   skip:14 
> fi-skl-i7-6700k  total:240  pass:209  dwarn:0   dfail:0   fail:3   skip:28 
> fi-snb-i7-2600   total:240  pass:198  dwarn:0   dfail:0   fail:0   skip:42 
> ro-bdw-i5-5250u  total:240  pass:219  dwarn:4   dfail:0   fail:1   skip:16 
> ro-bdw-i7-5557U  total:240  pass:223  dwarn:0   dfail:0   fail:1   skip:16 
> ro-bdw-i7-5600u  total:240  pass:207  dwarn:0   dfail:0   fail:1   skip:32 
> ro-bsw-n3050     total:240  pass:195  dwarn:0   dfail:0   fail:3   skip:42 
> ro-byt-n2820     total:240  pass:198  dwarn:0   dfail:0   fail:2   skip:40 
> ro-hsw-i3-4010u  total:240  pass:214  dwarn:0   dfail:0   fail:0   skip:26 
> ro-hsw-i7-4770r  total:240  pass:214  dwarn:0   dfail:0   fail:0   skip:26 
> ro-ilk-i7-620lm  total:240  pass:173  dwarn:1   dfail:0   fail:1   skip:65 
> ro-ilk1-i5-650   total:235  pass:172  dwarn:0   dfail:0   fail:3   skip:60 
> ro-ivb-i7-3770   total:240  pass:205  dwarn:0   dfail:0   fail:0   skip:35 
> ro-ivb2-i7-3770  total:240  pass:209  dwarn:0   dfail:0   fail:0   skip:31 
> ro-skl3-i5-6260u total:240  pass:221  dwarn:0   dfail:0   fail:4   skip:15 
> 
> Results at /archive/results/CI_IGT_test/RO_Patchwork_1667/
> 
> 862c995 drm-intel-nightly: 2016y-08m-02d-12h-12m-24s UTC integration manifest
> 012a950 drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation entry 2

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation entry 2

[David Weinehall]

On Tue, Aug 02, 2016 at 03:21:57PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> The spec was recently fixed to have the correct iboost setting for the
> SKL Y/U DP DDI buffer translation table entry 2. Update our tables
> to match.
> 
> Cc: David Weinehall <david.weinehall@linux.intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: David Weinehall <david.weinehall@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index fc2ef2d76091..c55a2ad50c0d 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -145,7 +145,7 @@ static const struct ddi_buf_trans skl_ddi_translations_dp[] = {
>  static const struct ddi_buf_trans skl_u_ddi_translations_dp[] = {
>  	{ 0x0000201B, 0x000000A2, 0x0 },
>  	{ 0x00005012, 0x00000088, 0x0 },
> -	{ 0x80007011, 0x000000CD, 0x0 },
> +	{ 0x80007011, 0x000000CD, 0x1 },
>  	{ 0x80009010, 0x000000C0, 0x1 },
>  	{ 0x0000201B, 0x0000009D, 0x0 },
>  	{ 0x80005012, 0x000000C0, 0x1 },
> @@ -158,7 +158,7 @@ static const struct ddi_buf_trans skl_u_ddi_translations_dp[] = {
>  static const struct ddi_buf_trans skl_y_ddi_translations_dp[] = {
>  	{ 0x00000018, 0x000000A2, 0x0 },
>  	{ 0x00005012, 0x00000088, 0x0 },
> -	{ 0x80007011, 0x000000CD, 0x0 },
> +	{ 0x80007011, 0x000000CD, 0x3 },
>  	{ 0x80009010, 0x000000C0, 0x3 },
>  	{ 0x00000018, 0x0000009D, 0x0 },
>  	{ 0x80005012, 0x000000C0, 0x3 },
> -- 
> 2.7.4
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx