Re: [PATCH] drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation entry 2

Ville Syrjälä
2016-08-05T06:44:09Z

On Tue, Aug 02, 2016 at 03:37:27PM +0300, Jani Nikula wrote:
> On Tue, 02 Aug 2016, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > The spec was recently fixed to have the correct iboost setting for the
> > SKL Y/U DP DDI buffer translation table entry 2. Update our tables
> > to match.
> >
> > Cc: David Weinehall <david.weinehall@linux.intel.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Cc: stable@vger.kernel.org

Added that and pushed to dinq.

It looks like've had quite a few updates to these tables slip by w/o
adding the cc:stable :( Hopefully stable maintainers will notice
and perhaps pick them all up when they grab this one.

>
> > ---
> > drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> > index fc2ef2d76091..c55a2ad50c0d 100644
> > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > @@ -145,7 +145,7 @@ static const struct ddi_buf_trans skl_ddi_translations_dp[] = {
> > static const struct ddi_buf_trans skl_u_ddi_translations_dp[] = {
> > { 0x0000201B, 0x000000A2, 0x0 },
> > { 0x00005012, 0x00000088, 0x0 },
> > - { 0x80007011, 0x000000CD, 0x0 },
> > + { 0x80007011, 0x000000CD, 0x1 },
> > { 0x80009010, 0x000000C0, 0x1 },
> > { 0x0000201B, 0x0000009D, 0x0 },
> > { 0x80005012, 0x000000C0, 0x1 },
> > @@ -158,7 +158,7 @@ static const struct ddi_buf_trans skl_u_ddi_translations_dp[] = {
> > static const struct ddi_buf_trans skl_y_ddi_translations_dp[] = {
> > { 0x00000018, 0x000000A2, 0x0 },
> > { 0x00005012, 0x00000088, 0x0 },
> > - { 0x80007011, 0x000000CD, 0x0 },
> > + { 0x80007011, 0x000000CD, 0x3 },
> > { 0x80009010, 0x000000C0, 0x3 },
> > { 0x00000018, 0x0000009D, 0x0 },
> > { 0x80005012, 0x000000C0, 0x3 },
>
> --
> Jani Nikula, Intel Open Source Technology Center

--
Ville Syrjälä
Intel OTC