Re: [PATCH v3 2/3] drm/i915: set proper N/MCTS on more platforms

Ville Syrjälä
2016-08-04T08:54:35Z

On Thu, Aug 04, 2016 at 03:58:03PM +0800, libin.yang@linux.intel.com wrote:
> From: Libin Yang <libin.yang@linux.intel.com>
>
> This patch applies setting proper N/M, N/CTS on more platforms.
>
> Signed-off-by: Libin Yang <libin.yang@linux.intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Not that I particularly like this special casing of platforms. We should
really try to unify this across the board, and I thought we already
agreed that that was going to happen?

> ---
> drivers/gpu/drm/i915/intel_audio.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index 04e7358..7aa0203 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -732,11 +732,7 @@ static int i915_audio_component_sync_audio_rate(struct device *dev,
> int n;
> int err = 0;
>
> - /* HSW, BDW, SKL, KBL need this fix */
> - if (!IS_SKYLAKE(dev_priv) &&
> - !IS_KABYLAKE(dev_priv) &&
> - !IS_BROADWELL(dev_priv) &&
> - !IS_HASWELL(dev_priv))
> + if (!HAS_DDI(dev_priv))
> return 0;
>
> mutex_lock(&dev_priv->av_mutex);
> --
> 1.9.1

--
Ville Syrjälä
Intel OTC