From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Do not overwrite the request with
 zero on reallocation
Date: Fri, 5 Aug 2016 18:17:25 +0200
Message-ID: <20160805161725.GE6232@phenom.ffwll.local>
References: <1470410008-9457-1-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com
 [IPv6:2a00:1450:400c:c09::243])
 by gabe.freedesktop.org (Postfix) with ESMTPS id C818B6E015
 for <intel-gfx@lists.freedesktop.org>; Fri,  5 Aug 2016 16:17:29 +0000 (UTC)
Received: by mail-wm0-x243.google.com with SMTP id x83so4401265wma.3
 for <intel-gfx@lists.freedesktop.org>; Fri, 05 Aug 2016 09:17:29 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1470410008-9457-1-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, "Goel, Akash" <akash.goel@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBBdWcgMDUsIDIwMTYgYXQgMDQ6MTM6MjhQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IFdoZW4gdXNpbmcgUkNVIGxvb2t1cCBmb3IgdGhlIHJlcXVlc3QsIGNvbW1pdCAwZWFm
ZWM2ZDMyNDQgKCJkcm0vaTkxNToKPiBFbmFibGUgbG9ja2xlc3MgbG9va3VwIG9mIHJlcXVlc3Qg
dHJhY2tpbmcgdmlhIFJDVSIpLCB3ZSBhY2tub3dsZWRnZSB0aGF0Cj4gd2UgbWF5IHJhY2Ugd2l0
aCBhbm90aGVyIHRocmVhZCB0aGF0IGNvdWxkIGhhdmUgcmVhbGxvY2F0ZWQgdGhlIHJlcXVlc3Qu
Cj4gSW4gb3JkZXIgZm9yIHRoZSBmaXJzdCB0aHJlYWQgbm90IHRvIGJsb3cgdXAsIHRoZSBzZWNv
bmQgdGhyZWFkIG11c3Qgbm90Cj4gY2xlYXIgdGhlIHJlcXVlc3QgY29tcGxldGVkIGJlZm9yZSBv
dmVyd3JpdGluZyBpdC4gSW4gdGhlIFJDVSBsb29rdXAsIHdlCj4gYWxsb3cgZm9yIHRoZSBlbmdp
bmUvc2Vxbm8gdG8gYmUgcmVwbGFjZWQgYnV0IHdlIGRvIG5vdCBhbGxvdyBmb3IgaXQgdG8KPiBi
ZSB6ZXJvZWQuCgpGaXJzdCBmZXcgcmVtYXJrczoKLSBDb21taXQgbWVzc2FnZSBkZWZpbml0ZWx5
IG5lZWRzIHRvIGV4cGxhaW4gdGhlIHRyYWRlb2ZmIGJldHdlZW4gYXZvaWRpbmcKICB0aGUgbWVt
c2V0IGFuZCBqdXN0IG1ha2luZyByZXEtPmVuZ2luZSBsb29rdXAgYSBiaXQgc2FmZXIgZm9yIF9y
Y3UgbGlrZQogIGJlbG93OgoKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1
X2dlbV9yZXF1ZXN0LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0LmgK
aW5kZXggNjAwMmFkYzQzNTIzLi5lNTU0OTJiYTIwZWMgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuaAorKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
OTE1X2dlbV9yZXF1ZXN0LmgKQEAgLTI0NCw2ICsyNDQsMjYgQEAgaTkxNV9nZW1fcmVxdWVzdF9z
dGFydGVkKGNvbnN0IHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxKQogfQogCiBzdGF0
aWMgaW5saW5lIGJvb2wKK2k5MTVfZ2VtX3JlcXVlc3RfY29tcGxldGVkX3JjdShjb25zdCBzdHJ1
Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSkKK3sKKwlzdHJ1Y3QgaW50ZWxfZW5naW5lX2Nz
ICplbmdpbmUgPSBSRUFEX09OQ0UocmVxLT5lbmdpbmUpOworCisJLyogV2hlbiB3ZSBwZWVrIGF0
IGEgcmVxdWVzdCBzb2xlbHkgdW5kZXIgcmN1IHByb3RlY3Rpb24sIHdpdGhvdXQKKwkgKiBob2Rs
aW5nIGEgZnVsbCByZWZlcmVuY2UsIHRoZSByZXF1ZXN0IG1pZ2h0IGJlIGluIHRoZSBwcm9jZXNz
IG9mCisJICogZ2V0dGluZyBmcmVlZCBhbmQgcmVhbGxvY2F0ZWQuIE1ha2Ugc3VyZSB3ZSBkb24n
dCBzdHVtYmxlIG92ZXIgYSBOVUxMCisJICogZW5naW5lIGluIHRoYXQgY2FzZS4KKwkgKgorCSAq
IElmIHdlIGFyZSBoaXR0aW5nIHRoaXMgcmFjZSBpdCBtZWFucyB0aGF0IHRoZSBvbGQgcmVxdWVz
dCBoYXMgYmVlbgorCSAqIHJlbGVhc2VkLCB3aGljaCBvbmx5IGhhcHBlbnMgb25jZSBpdCBoYXMg
Y29tcGxldGVkLgorCSAqLworCWlmICghZW5naW5lKQorCQlyZXR1cm4gdHJ1ZTsKKworCXJldHVy
biBpOTE1X3NlcW5vX3Bhc3NlZChpbnRlbF9lbmdpbmVfZ2V0X3NlcW5vKGVuZ2luZSksCisJCQkJ
IHJlcS0+ZmVuY2Uuc2Vxbm8pOworfQorCitzdGF0aWMgaW5saW5lIGJvb2wKIGk5MTVfZ2VtX3Jl
cXVlc3RfY29tcGxldGVkKGNvbnN0IHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxKQog
ewogCXJldHVybiBpOTE1X3NlcW5vX3Bhc3NlZChpbnRlbF9lbmdpbmVfZ2V0X3NlcW5vKHJlcS0+
ZW5naW5lKSwKQEAgLTM4NCw3ICs0MDQsNyBAQCBpOTE1X2dlbV9hY3RpdmVfcGVla19yY3UoY29u
c3Qgc3RydWN0IGk5MTVfZ2VtX2FjdGl2ZSAqYWN0aXZlKQogCXN0cnVjdCBkcm1faTkxNV9nZW1f
cmVxdWVzdCAqcmVxdWVzdDsKIAogCXJlcXVlc3QgPSByY3VfZGVyZWZlcmVuY2UoYWN0aXZlLT5y
ZXF1ZXN0KTsKLQlpZiAoIXJlcXVlc3QgfHwgaTkxNV9nZW1fcmVxdWVzdF9jb21wbGV0ZWQocmVx
dWVzdCkpCisJaWYgKCFyZXF1ZXN0IHx8IGk5MTVfZ2VtX3JlcXVlc3RfY29tcGxldGVkX3JjdShy
ZXF1ZXN0KSkKIAkJcmV0dXJuIE5VTEw7CiAKIAlyZXR1cm4gcmVxdWVzdDsKQEAgLTQ1OSw3ICs0
NzksNyBAQCBfX2k5MTVfZ2VtX2FjdGl2ZV9nZXRfcmN1KGNvbnN0IHN0cnVjdCBpOTE1X2dlbV9h
Y3RpdmUgKmFjdGl2ZSkKIAkJc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0Owog
CiAJCXJlcXVlc3QgPSByY3VfZGVyZWZlcmVuY2UoYWN0aXZlLT5yZXF1ZXN0KTsKLQkJaWYgKCFy
ZXF1ZXN0IHx8IGk5MTVfZ2VtX3JlcXVlc3RfY29tcGxldGVkKHJlcXVlc3QpKQorCQlpZiAoIXJl
cXVlc3QgfHwgaTkxNV9nZW1fcmVxdWVzdF9jb21wbGV0ZWRfcmN1KHJlcXVlc3QpKQogCQkJcmV0
dXJuIE5VTEw7CiAKIAkJcmVxdWVzdCA9IGk5MTVfZ2VtX3JlcXVlc3RfZ2V0X3JjdShyZXF1ZXN0
KTsKCkknZCBnbyBhcyBmYXIgYXMgcHV0dGluZyB0aGlzIGFzIGFuIGFsdGVybmF0aXZlIGZpeCBp
bnRvIHRoZSBjaGFuZ2Vsb2cuCgotIFdlIG5lZWQgYSBiaWcgaG9vbmtpbmcgY29tbWVudCBzb21l
d2hlcmUgKHByb2JhYmx5IHJpZ2h0IGFib3ZlIHRoZQogIGttZW1fY2FjaGVfYWxsb2MpIHdoeSB0
aGlzIGlzIG5vdCB6YWxsb2MuIFByb3Bvc2FsOgoKCS8qIFJlYWxsb2NhdGlvbiBjYW4gcmFjZSB3
aXRoIHJjdS1wcm90ZWN0ZWQgcmVxdWVzdCBsb29rdXAuIFRoZQoJICogcmVxdWVzdCBsb29rIGNv
ZGUgZG9lcyBldmVudHVhbGx5IGFjcXVpcmUgYSBmdWxsIHJlZmVyZW5jZSwgYnV0CgkgKiBiZWZv
cmUgdGhhdCBpdCBoYXMgYSBmYXN0LXBhdGggdG8gcGVlayBhdCB0aGUgcmVxdWVzdAoJICogY29t
cGxldGlvbi4gV2UgbXVzdCBtYWtlIHN1cmUgdGhhdCB0aGF0IGNvZGUgY2FuJ3QgZmFsbCBvdmVy
CgkgKiBhIHJlcXVlc3QgaW4gdGhlIHByb2Nlc3Mgb2YgZ2V0dGluZyByZWluaXRpYWxpemVkIGhl
cmUuIFNpbmNlCgkgKiBpdCdzIGEgcHVyZSBvcHRpbWl6YXRpb24gZGF0YSBpbnRlZ3JpdHkgaXMg
bm90IGltcG9ydGFudCwgdGhlCgkgKiBvbmx5IHJpc2sgaXMgaW4gY2hhc2luZyBOVUxMIHBvaW50
ZXJzLiBDdXJyZW50bHkgdGhpcyBpcyBvbmx5CgkgKiByZXF1ZXN0LT5lbmdpbmUgd2hpY2ggbXVz
dCBub3QgYmUgY2xlYXJlZC4KCSAqCgkgKiBBbHRlcm5hdGl2ZSBmaXggd291bGQgYmUgdG8gbWFr
ZSB0aGUgcmVxdWVzdCBwZWVraW5nIG1vcmUKCSAqIHJvYnVzdCwgYnV0IHRoYXQncyBvdmVyaGVh
ZC4gQWxzbywgcmVxdWVzdHMgZ2V0IHJlYWxsb2NhdGVkIGEKCSAqIGxvdCwgYXZvaWQgdGhlIG1l
bXNldCBtYWtlcyBzZW5zZS4gSGVuY2UgdGhpcyBpcyBub3QgYWxsb2NhdGVkCgkgKiB3aXRoIGt6
YWxsb2MsIHdoaWNoIGlzIGEgcmFyZSBleGNlcHRpb24gaW4gdGhlIGk5MTUgZHJpdmVyLgoJICoK
CSAqIEJFV0FSRTogRXZlcnl0aGluZyBtdXN0IGJlIGNvcnJlY3RseSBpbml0aWFsaXplZCBvciBz
ZXQgdG8KCSAqIE5VTEwhCgkgKi8KPiAKPiBGaXhlczogMGVhZmVjNmQzMjQ0ICgiZHJtL2k5MTU6
IEVuYWJsZSBsb2NrbGVzcyBsb29rdXAgb2YgcmVxdWVzdC4uLiIpCj4gU2lnbmVkLW9mZi1ieTog
Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6ICJHb2VsLCBBa2Fz
aCIgPGFrYXNoLmdvZWxAaW50ZWwuY29tPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0
dGVyQGZmd2xsLmNoPgo+IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51
eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVl
c3QuYyB8IDYgKysrKystCj4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDEgZGVs
ZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1f
cmVxdWVzdC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5jCj4gaW5k
ZXggYjMxN2E2NzIwNDBmLi43NTI5YjZiNWRlZGEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv
aTkxNV9nZW1fcmVxdWVzdC5jCj4gQEAgLTM1NSw3ICszNTUsNyBAQCBpOTE1X2dlbV9yZXF1ZXN0
X2FsbG9jKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwKPiAgCWlmIChyZXEgJiYgaTkx
NV9nZW1fcmVxdWVzdF9jb21wbGV0ZWQocmVxKSkKPiAgCQlpOTE1X2dlbV9yZXF1ZXN0X3JldGly
ZShyZXEpOwo+ICAKPiAtCXJlcSA9IGttZW1fY2FjaGVfemFsbG9jKGRldl9wcml2LT5yZXF1ZXN0
cywgR0ZQX0tFUk5FTCk7Cj4gKwlyZXEgPSBrbWVtX2NhY2hlX2FsbG9jKGRldl9wcml2LT5yZXF1
ZXN0cywgR0ZQX0tFUk5FTCk7Cj4gIAlpZiAoIXJlcSkKPiAgCQlyZXR1cm4gRVJSX1BUUigtRU5P
TUVNKTsKPiAgCj4gQEAgLTM3NSw2ICszNzUsMTAgQEAgaTkxNV9nZW1fcmVxdWVzdF9hbGxvYyhz
dHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gIAlyZXEtPmVuZ2luZSA9IGVuZ2luZTsK
PiAgCXJlcS0+Y3R4ID0gaTkxNV9nZW1fY29udGV4dF9nZXQoY3R4KTsKPiAgCj4gKwlyZXEtPnNp
Z25hbGluZy53YWl0LnRzayA9IE5VTEw7CgpEbyB3ZSBuZWVkIHRvIHJlaW5pdCB0aGlzPyBUaGUg
aW1wb3J0YW50IGJpdCBpcyB0aGF0IHdlIHJlbW92ZSBvdXJzZWx2ZXMKZnJvbSB0aGUgcmIgdHJl
ZSwgYW5kIHdlIGRvIHRoYXQgaW4gaW50ZWxfZW5naW5lX3JlbW92ZV93YWl0LgoKPiArCXJlcS0+
cHJldmlvdXNfY29udGV4dCA9IE5VTEw7CgpTaG91bGQgd2UgbW92ZSB0aGF0IGludG8gdGhlIHJl
dGlyZSBmdW5jdGlvbiB3aGVyZSB3ZSBjYWxsIHRoZSBscmMgdW5waW4/Cgo+ICsJcmVxLT5maWxl
X3ByaXYgPSBOVUxMOwoKV2UgYWxyZWFkeSBjbGVhciB0aGlzIGluIHJlbW92ZV9mcm9tX2NsaWVu
dC4KCkFkbWl0dGVkbHkgZGlkbid0IGRvIGEgZnVsbCBhdWRpdCB3aGV0aGVyIHRob3NlIGFyZSBh
bGwgd2UgbmVlZCB5ZXQuCi1EYW5pZWwKCj4gKwo+ICAJLyoKPiAgCSAqIFJlc2VydmUgc3BhY2Ug
aW4gdGhlIHJpbmcgYnVmZmVyIGZvciBhbGwgdGhlIGNvbW1hbmRzIHJlcXVpcmVkIHRvCj4gIAkg
KiBldmVudHVhbGx5IGVtaXQgdGhpcyByZXF1ZXN0LiBUaGlzIGlzIHRvIGd1YXJhbnRlZSB0aGF0
IHRoZQo+IC0tIAo+IDIuOC4xCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVl
ciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ
bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au
b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==