From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 06/12] drm/i915: Adjust obj tiling vs. fb modifier rules Date: Wed, 10 Aug 2016 11:43:27 +0200 Message-ID: <20160810094327.GT6232@phenom.ffwll.local> References: <1470821001-25272-1-git-send-email-ville.syrjala@linux.intel.com> <1470821001-25272-7-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 89B526E6F7 for ; Wed, 10 Aug 2016 09:43:32 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id i5so8426156wmg.2 for ; Wed, 10 Aug 2016 02:43:32 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1470821001-25272-7-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBdWcgMTAsIDIwMTYgYXQgMTI6MjM6MTVQTSArMDMwMCwgdmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBDdXJyZW50bHkgd2UgcmVxdWlyZSB0aGUgb2JqZWN0 IHRvIGJlIFggdGlsZWQgaWYgdGhlIGZiIGlzIFgKPiB0aWxlZC4gVGhlIGFyZ3VtZW50IGlzIHN1 cHBvc2VkbHkgRkJDIEdUVCB0cmFja2luZy4gQnV0Cj4gYWN0dWFsbHkgdGhhdCBubyBsb25nZXIg aG9sZHMgd2F0ZXIgc2luY2UgRkJDIHN1cHBvcnRzCj4gWSB0aWxpbmcgYXMgd2VsbCBvbiBTS0wr Lgo+IAo+IEEgYmV0dGVyIHJ1bGUgSU1PIGlzIHRvIHJlcXVpcmUgdGhhdCBpZiB0aGVyZSBpcyBh IGZlbmNlLCB0aGUKPiBmYiBtb2RpZmllciBtYXRjaCB0aGUgb2JqZWN0IHRpbGluZyBtb2RlLiBC dXQgaWYgdGhlIG9iamVjdCBpcyBsaW5lYXIsCj4gd2UgY2FuIGFsbG93IHRoZSBmYiBtb2RpZmll ciB0byBiZSBhbnl0aGluZy4gVGhlIGlkZWEgYmVpbmcgdGhhdAo+IGlmIHRoZSB1c2VyIHNldCB0 aGUgdGlsaW5nIG1vZGUgb24gdGhlIG9iamVjdCwgcHJlc3VtYWJseSB0aGUgaW50ZW50aW9uCj4g aXMgdG8gYWN0dWFsbHkgdXNlIHRoZSBmZW5jZSBmb3IgQ1BVIGFjY2Vzcy4gQnV0IGlmIHRoZSB0 aWxpbmcgbW9kZSBpcwo+IG5vdCBzZXQsIHRoZSB1c2VyIGhhcyBubyBpbnRlbnRpb24gb2YgdXNp bmcgYSBmZW5jZSAoYW5kIGNhbid0IGFjdHVhbGx5Cj4gc2luY2Ugd2UgZGlzYWxsb3cgdGlsaW5n IG1vZGUgY2hhbmdlcyB3aGVuIHRoZXJlIGFyZSBmcmFtZWJ1ZmZlcnMKPiBhc3NvY2lhdGVkIHdp dGggdGhlIG9iamVjdCkuCj4gCj4gT24gZ2VuMi8zIHdlIG11c3Qga2VlcCB0byB0aGUgcnVsZSB0 aGF0IHRoZSBvYmplY3QgYW5kIGZiCj4gbXVzdCBiZSBlaXRoZXIgYm90aCBsaW5lYXIgb3IgYm90 aCBYIHRpbGVkLiBObyBtaXhpbmcgYWxsb3dlZAo+IHNpbmNlIHRoZSBkaXNwbGF5IGVuZ2luZSBp dHNlbGYgd2lsbCB1c2UgdGhlIGZlbmNlIGlmIGl0J3MgcHJlc2VudC4KPiAKPiB2MjogRml4IHR5 cG9zCj4gdjM6IFJlYmFzZSBkdWUgdG8gaTkxNV9nZW1fb2JqZWN0X2dldF90aWxpbmcoKSAmIGNv Lgo+IAo+IFJldmlld2VkLWJ5OiBNYXR0aGV3IEF1bGQgPG1hdHRoZXcuYXVsZEBpbnRlbC5jb20+ Cj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4Lmlu dGVsLmNvbT4KClNvIHRoZSByZWFzb24gd2h5IEkgZGlkbid0IGxpa2UgdGhpcyBpcyB0aGF0IGl0 IG1ha2VzIHRoZSBmYmMgY2hlY2tpbmcKbW9yZSB0cmlja3kuIFNvbWVvbmUgbWlnaHQgdGhpbmsg dGhhdCBjaGVja2luZyBmb3IgWC10aWxpbmcgb24ganVzdCB0aGUKZHJtX2ZyYW1lYnVmZmVyIGlz IGdvb2QgZW5vdWdoIGFuZCB0aGVuIHdlJ2QgaGF2ZSBzb21lIHBvdGVudGlhbGx5IGZ1bm55CmJ1 Z3MuIEJ1dCB0aGUgZmJjIGNvZGUgc3RpbGwgb25seSBsb29rcyBhdCB0aGUgZ2VtIGJvIHRpbGlu Zywgc28gYWxsIGlzCnN0aWxsIGZpbmUuCgpSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFu aWVsLnZldHRlckBmZndsbC5jaD4KCgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kaXNwbGF5LmMgfCAzMSArKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tCj4gIDEgZmls ZSBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCBkODg1NWJhOTY5YmUuLmFkOWY4YjMwM2Zi YyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtMTUxNTAsMjMg KzE1MTUwLDI2IEBAIHN0YXRpYyBpbnQgaW50ZWxfZnJhbWVidWZmZXJfaW5pdChzdHJ1Y3QgZHJt X2RldmljZSAqZGV2LAo+ICAJCQkJICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqKQo+ ICB7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRldik7 Cj4gKwl1bnNpZ25lZCBpbnQgdGlsaW5nID0gaTkxNV9nZW1fb2JqZWN0X2dldF90aWxpbmcob2Jq KTsKPiAgCWludCByZXQ7Cj4gIAl1MzIgcGl0Y2hfbGltaXQsIHN0cmlkZV9hbGlnbm1lbnQ7Cj4g IAo+ICAJV0FSTl9PTighbXV0ZXhfaXNfbG9ja2VkKCZkZXYtPnN0cnVjdF9tdXRleCkpOwo+ICAK PiAgCWlmIChtb2RlX2NtZC0+ZmxhZ3MgJiBEUk1fTU9ERV9GQl9NT0RJRklFUlMpIHsKPiAtCQkv KiBFbmZvcmNlIHRoYXQgZmIgbW9kaWZpZXIgYW5kIHRpbGluZyBtb2RlIG1hdGNoLCBidXQgb25s eSBmb3IKPiAtCQkgKiBYLXRpbGVkLiBUaGlzIGlzIG5lZWRlZCBmb3IgRkJDLiAqLwo+IC0JCWlm ICghIShpOTE1X2dlbV9vYmplY3RfZ2V0X3RpbGluZyhvYmopID09IEk5MTVfVElMSU5HX1gpICE9 Cj4gLQkJICAgICEhKG1vZGVfY21kLT5tb2RpZmllclswXSA9PSBJOTE1X0ZPUk1BVF9NT0RfWF9U SUxFRCkpIHsKPiArCQkvKgo+ICsJCSAqIElmIHRoZXJlJ3MgYSBmZW5jZSwgZW5mb3JjZSB0aGF0 Cj4gKwkJICogdGhlIGZiIG1vZGlmaWVyIGFuZCB0aWxpbmcgbW9kZSBtYXRjaC4KPiArCQkgKi8K PiArCQlpZiAodGlsaW5nICE9IEk5MTVfVElMSU5HX05PTkUgJiYKPiArCQkgICAgdGlsaW5nICE9 IGludGVsX2ZiX21vZGlmaWVyX3RvX3RpbGluZyhtb2RlX2NtZC0+bW9kaWZpZXJbMF0pKSB7Cj4g IAkJCURSTV9ERUJVRygidGlsaW5nX21vZGUgZG9lc24ndCBtYXRjaCBmYiBtb2RpZmllclxuIik7 Cj4gIAkJCXJldHVybiAtRUlOVkFMOwo+ICAJCX0KPiAgCX0gZWxzZSB7Cj4gLQkJaWYgKGk5MTVf Z2VtX29iamVjdF9nZXRfdGlsaW5nKG9iaikgPT0gSTkxNV9USUxJTkdfWCkKPiArCQlpZiAodGls aW5nID09IEk5MTVfVElMSU5HX1gpIHsKPiAgCQkJbW9kZV9jbWQtPm1vZGlmaWVyWzBdID0gSTkx NV9GT1JNQVRfTU9EX1hfVElMRUQ7Cj4gLQkJZWxzZSBpZiAoaTkxNV9nZW1fb2JqZWN0X2dldF90 aWxpbmcob2JqKSA9PSBJOTE1X1RJTElOR19ZKSB7Cj4gKwkJfSBlbHNlIGlmICh0aWxpbmcgPT0g STkxNV9USUxJTkdfWSkgewo+ICAJCQlEUk1fREVCVUcoIk5vIFkgdGlsaW5nIGZvciBsZWdhY3kg YWRkZmJcbiIpOwo+ICAJCQlyZXR1cm4gLUVJTlZBTDsKPiAgCQl9Cj4gQEAgLTE1MTkwLDYgKzE1 MTkzLDE2IEBAIHN0YXRpYyBpbnQgaW50ZWxfZnJhbWVidWZmZXJfaW5pdChzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2LAo+ICAJCXJldHVybiAtRUlOVkFMOwo+ICAJfQo+ICAKPiArCS8qCj4gKwkgKiBn ZW4yLzMgZGlzcGxheSBlbmdpbmUgdXNlcyB0aGUgZmVuY2UgaWYgcHJlc2VudCwKPiArCSAqIHNv IHRoZSB0aWxpbmcgbW9kZSBtdXN0IG1hdGNoIHRoZSBmYiBtb2RpZmllciBleGFjdGx5Lgo+ICsJ ICovCj4gKwlpZiAoSU5URUxfSU5GTyhkZXZfcHJpdiktPmdlbiA8IDQgJiYKPiArCSAgICB0aWxp bmcgIT0gaW50ZWxfZmJfbW9kaWZpZXJfdG9fdGlsaW5nKG1vZGVfY21kLT5tb2RpZmllclswXSkp IHsKPiArCQlEUk1fREVCVUcoInRpbGluZ19tb2RlIG11c3QgbWF0Y2ggZmIgbW9kaWZpZXIgZXhh Y3RseSBvbiBnZW4yLzNcbiIpOwo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsJfQo+ICsKPiAgCXN0 cmlkZV9hbGlnbm1lbnQgPSBpbnRlbF9mYl9zdHJpZGVfYWxpZ25tZW50KGRldl9wcml2LAo+ICAJ CQkJCQkgICAgIG1vZGVfY21kLT5tb2RpZmllclswXSwKPiAgCQkJCQkJICAgICBtb2RlX2NtZC0+ cGl4ZWxfZm9ybWF0KTsKPiBAQCAtMTUyMDksNyArMTUyMjIsMTEgQEAgc3RhdGljIGludCBpbnRl bF9mcmFtZWJ1ZmZlcl9pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkJcmV0dXJuIC1F SU5WQUw7Cj4gIAl9Cj4gIAo+IC0JaWYgKG1vZGVfY21kLT5tb2RpZmllclswXSA9PSBJOTE1X0ZP Uk1BVF9NT0RfWF9USUxFRCAmJgo+ICsJLyoKPiArCSAqIElmIHRoZXJlJ3MgYSBmZW5jZSwgZW5m b3JjZSB0aGF0Cj4gKwkgKiB0aGUgZmIgcGl0Y2ggYW5kIGZlbmNlIHN0cmlkZSBtYXRjaC4KPiAr CSAqLwo+ICsJaWYgKHRpbGluZyAhPSBJOTE1X1RJTElOR19OT05FICYmCj4gIAkgICAgbW9kZV9j bWQtPnBpdGNoZXNbMF0gIT0gaTkxNV9nZW1fb2JqZWN0X2dldF9zdHJpZGUob2JqKSkgewo+ICAJ CURSTV9ERUJVRygicGl0Y2ggKCVkKSBtdXN0IG1hdGNoIHRpbGluZyBzdHJpZGUgKCVkKVxuIiwK PiAgCQkJICBtb2RlX2NtZC0+cGl0Y2hlc1swXSwKPiAtLSAKPiAyLjcuNAo+IAo+IF9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gCkRhbmllbCBW ZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZm d2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=