From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v2 11/12] drm/i915: Deal with NV12 CbCr
 plane AUX surface on SKL+
Date: Wed, 10 Aug 2016 12:03:08 +0200
Message-ID: <20160810100308.GW6232@phenom.ffwll.local>
References: <1470821001-25272-1-git-send-email-ville.syrjala@linux.intel.com>
 <1470821001-25272-12-git-send-email-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com
 [IPv6:2a00:1450:400c:c09::243])
 by gabe.freedesktop.org (Postfix) with ESMTPS id D6E0F6E70B
 for <intel-gfx@lists.freedesktop.org>; Wed, 10 Aug 2016 10:03:12 +0000 (UTC)
Received: by mail-wm0-x243.google.com with SMTP id o80so8524071wme.0
 for <intel-gfx@lists.freedesktop.org>; Wed, 10 Aug 2016 03:03:12 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1470821001-25272-12-git-send-email-ville.syrjala@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCBBdWcgMTAsIDIwMTYgYXQgMTI6MjM6MjBQTSArMDMwMCwgdmlsbGUuc3lyamFsYUBs
aW51eC5pbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq
YWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBXaXRoIE5WMTIgd2UgaGF2ZSB0d28gY29sb3IgcGxh
bmVzIHRvIGRlYWwgd2l0aCBzbyB3ZSBtdXN0IGNvbXB1dGUgdGhlCj4gc3VyZmFjZSBhbmQgeC95
IG9mZnNldHMgZm9yIHRoZSBzZWNvbmQgcGxhbmUgYXMgd2VsbC4KPiAKPiBXaGF0IG1ha2VzIHRo
aXMgYSBiaXQgbmFzdHkgaXMgdGhhdCB0aGUgaGFyZHdhcmUgZXhwZWN0cyB0aGUgc3VyZmFjZQo+
IG9mZnNldCB0byBiZSBzcGVjaWZpZWQgYXMgYSBkaXN0YW5jZSBmcm9tIHRoZSBtYWluIHN1cmZh
Y2Ugb2Zmc2V0Lgo+IFdoYXQncyB3b3JzZSwgdGhlIGRpc3RhbmNlIG11c3QgYmUgbm9uLW5lZ2F0
aXZlIChubyBuZWF0IHdyYXBhcm91bmQgb3IKPiBhbnl0aGluZykuIFNvIHdlIG11c3QgbWFrZSBz
dXJlIHRoYXQgdGhlIG1haW4gc3VyZmFjZSBvZmZzZXQgaXMgYWx3YXlzCj4gbGVzcyBvciBlcXVh
bCB0byB0aGUgQVVYIHN1cmZhY2Ugb2Zmc2V0LiBXZSBkbyB0aGF0IGJ5IGNvbXB1dGluZyB0aGUg
QVVYCj4gb2Zmc2V0IGZpcnN0IGFuZCB0aGUgbWFpbiBzdXJmYWNlIG9mZnNldCBzZWNvbmQuIElm
IHRoZSBtYWluIHN1cmZhY2UKPiBvZmZzZXQgZW5kcyB1cCBiZWluZyBhYm92ZSB0aGUgQVVYIG9m
ZnNldCwgd2UganVzdCBwdXNoIGl0IGRvd24gYXMgZmFyCj4gYXMgaXMgcmVxdWlyZWQgd2hpbGUg
c3RpbGwgbWFpbnRhaW5pbmcgdGhlIHJlcXVpcmVkIGFsaWdubWVudCBldGMuCj4gCj4gRm9ydHVu
YXRlbHkgdGhlIEFVWCBvZmZzZXQgb25seSByZXVxaXJlcyA0SyBhbGlnbm1lbnQsIHNvIHdlIGRv
bid0IG5lZWQKPiB0byBkbyBhbnkgb2YgdGhlIGJhY2t3YXJkcyBzZWFyY2hpbmcgZm9yIGFuIGFj
Y2VwdGFibGUgb2Zmc2V0IHRoYXQgd2UKPiBtdXN0IGRvIGZvciB0aGUgbWFpbiBzdXJmYWNlLiBB
bmQgWCB0aWxlZCArIE5WMTIgaXNuJ3QgYSBzdXBwb3J0ZWQKPiBjb21iaW5hdGlvbiBhbnl3YXku
Cj4gCj4gTm90ZSB0aGF0IHRoaXMganVzdCBjb21wdXRlcyBhdXggc3VyZmFjZSBvZmZzZXRzLCB3
ZSBkbyBub3QgeWV0IHByb2dyYW0KPiB0aGVtIGludG8gdGhlIGFjdHVhbCBoYXJkd2FyZSByZWdp
c3RlcnMsIGFuZCBoZW5jZSB3ZSBjYW4ndCB5ZXQgZXhwb3NlCj4gTlYxMi4KPiAKPiB2MjogUmVi
YXNlIGR1ZSB0byBkcm1fcGxhbmVfc3RhdGUgc3JjL2RzdCByZWN0cwo+ICAgICBzL1RPRE8uLi4v
c29tZXRoaW5nIGVsc2UvIGluIHRoZSBjb21taXQgbWVzc2FnZS8gKERhbmllbCkKPiAKPiBTaWdu
ZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t
Pgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA2MiArKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv
aW50ZWxfZHJ2LmggICAgIHwgIDQgKysrCj4gIDIgZmlsZXMgY2hhbmdlZCwgNjQgaW5zZXJ0aW9u
cygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j
Cj4gaW5kZXggYjcxOWMwNzU5OWZkLi5mODQ4N2JjZGIyNzEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTI0NjMsOCArMjQ2MywxNCBAQCB1MzIgaW50ZWxfY29t
cHV0ZV90aWxlX29mZnNldChpbnQgKngsIGludCAqeSwKPiAgCWNvbnN0IHN0cnVjdCBkcm1faTkx
NV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoc3RhdGUtPmJhc2UucGxhbmUtPmRldik7Cj4g
IAljb25zdCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9IHN0YXRlLT5iYXNlLmZiOwo+ICAJ
dW5zaWduZWQgaW50IHJvdGF0aW9uID0gc3RhdGUtPmJhc2Uucm90YXRpb247Cj4gLQl1MzIgYWxp
Z25tZW50ID0gaW50ZWxfc3VyZl9hbGlnbm1lbnQoZGV2X3ByaXYsIGZiLT5tb2RpZmllcltwbGFu
ZV0pOwo+ICAJaW50IHBpdGNoID0gaW50ZWxfZmJfcGl0Y2goZmIsIHBsYW5lLCByb3RhdGlvbik7
Cj4gKwl1MzIgYWxpZ25tZW50Owo+ICsKPiArCS8qIEFVWF9ESVNUIG5lZWRzIG9ubHkgNEsgYWxp
Z25tZW50ICovCj4gKwlpZiAoZmItPnBpeGVsX2Zvcm1hdCA9PSBEUk1fRk9STUFUX05WMTIgJiYg
cGxhbmUgPT0gMSkKPiArCQlhbGlnbm1lbnQgPSA0MDk2Owo+ICsJZWxzZQo+ICsJCWFsaWdubWVu
dCA9IGludGVsX3N1cmZfYWxpZ25tZW50KGRldl9wcml2LCBmYi0+bW9kaWZpZXJbcGxhbmVdKTsK
PiAgCj4gIAlyZXR1cm4gX2ludGVsX2NvbXB1dGVfdGlsZV9vZmZzZXQoZGV2X3ByaXYsIHgsIHks
IGZiLCBwbGFuZSwgcGl0Y2gsCj4gIAkJCQkJICByb3RhdGlvbiwgYWxpZ25tZW50KTsKPiBAQCAt
Mjg5NSw3ICsyOTAxLDcgQEAgc3RhdGljIGludCBza2xfY2hlY2tfbWFpbl9zdXJmYWNlKHN0cnVj
dCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUpCj4gIAlpbnQgaCA9IGRybV9yZWN0X2hl
aWdodCgmcGxhbmVfc3RhdGUtPmJhc2Uuc3JjKSA+PiAxNjsKPiAgCWludCBtYXhfd2lkdGggPSBz
a2xfbWF4X3BsYW5lX3dpZHRoKGZiLCAwLCByb3RhdGlvbik7Cj4gIAlpbnQgbWF4X2hlaWdodCA9
IDQwOTY7Cj4gLQl1MzIgYWxpZ25tZW50LCBvZmZzZXQ7Cj4gKwl1MzIgYWxpZ25tZW50LCBvZmZz
ZXQsIGF1eF9vZmZzZXQgPSBwbGFuZV9zdGF0ZS0+YXV4Lm9mZnNldDsKPiAgCj4gIAlpZiAodyA+
IG1heF93aWR0aCB8fCBoID4gbWF4X2hlaWdodCkgewo+ICAJCURSTV9ERUJVR19LTVMoInJlcXVl
c3RlZCBZL1JHQiBzb3VyY2Ugc2l6ZSAlZHglZCB0b28gYmlnIChsaW1pdCAlZHglZClcbiIsCj4g
QEAgLTI5MDksNiArMjkxNSwxNSBAQCBzdGF0aWMgaW50IHNrbF9jaGVja19tYWluX3N1cmZhY2Uo
c3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSkKPiAgCWFsaWdubWVudCA9IGlu
dGVsX3N1cmZfYWxpZ25tZW50KGRldl9wcml2LCBmYi0+bW9kaWZpZXJbMF0pOwo+ICAKPiAgCS8q
Cj4gKwkgKiBBVVggc3VyZmFjZSBvZmZzZXQgaXMgc3BlY2lmaWVkIGFzIHRoZSBkaXN0YW5jZSBm
cm9tIHRoZQo+ICsJICogbWFpbiBzdXJmYWNlIG9mZnNldCwgYW5kIGl0IG11c3QgYmUgbm9uLW5l
Z2F0aXZlLiBNYWtlCj4gKwkgKiBzdXJlIHRoYXQgaXMgd2hhdCB3ZSB3aWxsIGdldC4KPiArCSAq
Lwo+ICsJaWYgKG9mZnNldCA+IGF1eF9vZmZzZXQpCj4gKwkJb2Zmc2V0ID0gaW50ZWxfYWRqdXN0
X3RpbGVfb2Zmc2V0KCZ4LCAmeSwgcGxhbmVfc3RhdGUsIDAsCj4gKwkJCQkJCSAgb2Zmc2V0LCBh
dXhfb2Zmc2V0ICYgfihhbGlnbm1lbnQgLSAxKSk7CgpOb3RlIHRvIHNlbGY6IE5lZWQgdG8gbWFr
ZSBzdXJlIHRoYXQgbXVsdGlwbGFuYXIgZmJzIGFsbCByZWZlcmVuY2UgdGhlCnNhbWUgdW5kZXJs
eWluZyBiby4gQnV0IHRoYXQgY29kZSBpc24ndCB5ZXQgYWRkZWQgdG8KaW50ZWxfZnJhbWVidWZm
ZXJfaW5pdCgpLgoKPiArCj4gKwkvKgo+ICAJICogV2hlbiB1c2luZyBhbiBYLXRpbGVkIHN1cmZh
Y2UsIHRoZSBwbGFuZSBibG93cyB1cAo+ICAJICogaWYgdGhlIHggb2Zmc2V0ICsgd2lkdGggZXhj
ZWVkIHRoZSBzdHJpZGUuCj4gIAkgKgo+IEBAIC0yOTM1LDYgKzI5NTAsMzUgQEAgc3RhdGljIGlu
dCBza2xfY2hlY2tfbWFpbl9zdXJmYWNlKHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVf
c3RhdGUpCj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiArc3RhdGljIGludCBza2xfY2hlY2tfbnYx
Ml9hdXhfc3VyZmFjZShzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlKQo+ICt7
Cj4gKwljb25zdCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9IHBsYW5lX3N0YXRlLT5iYXNl
LmZiOwo+ICsJdW5zaWduZWQgaW50IHJvdGF0aW9uID0gcGxhbmVfc3RhdGUtPmJhc2Uucm90YXRp
b247Cj4gKwlpbnQgbWF4X3dpZHRoID0gc2tsX21heF9wbGFuZV93aWR0aChmYiwgMSwgcm90YXRp
b24pOwo+ICsJaW50IG1heF9oZWlnaHQgPSA0MDk2Owo+ICsJaW50IHggPSBwbGFuZV9zdGF0ZS0+
YmFzZS5zcmMueDEgPj4gMTc7Cj4gKwlpbnQgeSA9IHBsYW5lX3N0YXRlLT5iYXNlLnNyYy55MSA+
PiAxNzsKPiArCWludCB3ID0gZHJtX3JlY3Rfd2lkdGgoJnBsYW5lX3N0YXRlLT5iYXNlLnNyYykg
Pj4gMTc7Cj4gKwlpbnQgaCA9IGRybV9yZWN0X2hlaWdodCgmcGxhbmVfc3RhdGUtPmJhc2Uuc3Jj
KSA+PiAxNzsKPiArCXUzMiBvZmZzZXQ7Cj4gKwo+ICsJaW50ZWxfYWRkX2ZiX29mZnNldHMoJngs
ICZ5LCBwbGFuZV9zdGF0ZSwgMSk7Cj4gKwlvZmZzZXQgPSBpbnRlbF9jb21wdXRlX3RpbGVfb2Zm
c2V0KCZ4LCAmeSwgcGxhbmVfc3RhdGUsIDEpOwo+ICsKPiArCS8qIEZJWE1FIG5vdCBxdWl0ZSBz
dXJlIGhvdy9pZiB0aGVzZSBhcHBseSB0byB0aGUgY2hyb21hIHBsYW5lICovCj4gKwlpZiAodyA+
IG1heF93aWR0aCB8fCBoID4gbWF4X2hlaWdodCkgewo+ICsJCURSTV9ERUJVR19LTVMoIkNiQ3Ig
c291cmNlIHNpemUgJWR4JWQgdG9vIGJpZyAobGltaXQgJWR4JWQpXG4iLAo+ICsJCQkgICAgICB3
LCBoLCBtYXhfd2lkdGgsIG1heF9oZWlnaHQpOwo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsJfQoK
V2UgYWxzbyBuZWVkIHRvIGNoZWNrIHBpdGNoIG9mIHRoZSAybmQgcGxhbmUsIGJ1dCBJIGd1ZXNz
IHRoYXQncyBkb25lIGF0CmZiX2luaXQgdGltZSwgbm90IGF0IGF0b21pY19jaGVjayB0aW1lLiBM
b29rcyBhbGwgcmVhc29uYWJsZSBhcy1pcy4KClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxk
YW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKCj4gKwo+ICsJcGxhbmVfc3RhdGUtPmF1eC5vZmZzZXQg
PSBvZmZzZXQ7Cj4gKwlwbGFuZV9zdGF0ZS0+YXV4LnggPSB4Owo+ICsJcGxhbmVfc3RhdGUtPmF1
eC55ID0geTsKPiArCj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiAgaW50IHNrbF9jaGVja19wbGFu
ZV9zdXJmYWNlKHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUpCj4gIHsKPiAg
CWNvbnN0IHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiID0gcGxhbmVfc3RhdGUtPmJhc2UuZmI7
Cj4gQEAgLTI5NDYsNiArMjk5MCwyMCBAQCBpbnQgc2tsX2NoZWNrX3BsYW5lX3N1cmZhY2Uoc3Ry
dWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSkKPiAgCQlkcm1fcmVjdF9yb3RhdGUo
JnBsYW5lX3N0YXRlLT5iYXNlLnNyYywKPiAgCQkJCWZiLT53aWR0aCwgZmItPmhlaWdodCwgQklU
KERSTV9ST1RBVEVfMjcwKSk7Cj4gIAo+ICsJLyoKPiArCSAqIEhhbmRsZSB0aGUgQVVYIHN1cmZh
Y2UgZmlyc3Qgc2luY2UKPiArCSAqIHRoZSBtYWluIHN1cmZhY2Ugc2V0dXAgZGVwZW5kcyBvbiBp
dC4KPiArCSAqLwo+ICsJaWYgKGZiLT5waXhlbF9mb3JtYXQgPT0gRFJNX0ZPUk1BVF9OVjEyKSB7
Cj4gKwkJcmV0ID0gc2tsX2NoZWNrX252MTJfYXV4X3N1cmZhY2UocGxhbmVfc3RhdGUpOwo+ICsJ
CWlmIChyZXQpCj4gKwkJCXJldHVybiByZXQ7Cj4gKwl9IGVsc2Ugewo+ICsJCXBsYW5lX3N0YXRl
LT5hdXgub2Zmc2V0ID0gfjB4ZmZmOwo+ICsJCXBsYW5lX3N0YXRlLT5hdXgueCA9IDA7Cj4gKwkJ
cGxhbmVfc3RhdGUtPmF1eC55ID0gMDsKPiArCX0KPiArCj4gIAlyZXQgPSBza2xfY2hlY2tfbWFp
bl9zdXJmYWNlKHBsYW5lX3N0YXRlKTsKPiAgCWlmIChyZXQpCj4gIAkJcmV0dXJuIHJldDsKPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggYi9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IGluZGV4IDJmZGUxMzgzM2ZjYi4uZGY4ZTc1MTRjMDhj
IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gKysrIGIv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBAQCAtMzU0LDYgKzM1NCwxMCBAQCBz
dHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgewo+ICAJCXUzMiBvZmZzZXQ7Cj4gIAkJaW50IHgsIHk7
Cj4gIAl9IG1haW47Cj4gKwlzdHJ1Y3Qgewo+ICsJCXUzMiBvZmZzZXQ7Cj4gKwkJaW50IHgsIHk7
Cj4gKwl9IGF1eDsKPiAgCj4gIAkvKgo+ICAJICogc2NhbGVyX2lkCj4gLS0gCj4gMi43LjQKPiAK
PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVs
LWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0
cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0t
IApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRw
Oi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv
cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl
bC1nZngK