From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 12/12] drm/i915: Make sure fb offset is (macro)pixel aligned Date: Wed, 10 Aug 2016 12:04:32 +0200 Message-ID: <20160810100432.GX6232@phenom.ffwll.local> References: <1470821001-25272-1-git-send-email-ville.syrjala@linux.intel.com> <1470821001-25272-13-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 588376E70D for ; Wed, 10 Aug 2016 10:04:36 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id i138so8499926wmf.3 for ; Wed, 10 Aug 2016 03:04:36 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1470821001-25272-13-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBdWcgMTAsIDIwMTYgYXQgMTI6MjM6MjFQTSArMDMwMCwgdmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBXZSBjb252ZXJ0IHRoZSBmYi0+b2Zmc2V0c1tdIGlu dG8geC95IG9mZnNldHMsIHNvIHRoZXkgbXVzdCBiZQo+IChtYWNybylwaXhlbCBhbGlnbmVkLiBD aGVjayBmb3IgdGhpcywgYW5kIGlmIHRoaW5ncyBsb29rIGdvb2QKPiBhbGxvdyBmYi0+b2Zmc2V0 c1tdICE9IDAgd2hlbiBjcmVhdGluZyBmYnMgc2luY2Ugd2Ugbm93IGhhbmRsZQo+IHRoZW0gY29y cmVjdGx5Lgo+IAo+IHYyOiBNb3ZlIHRvIGxhc3QgcGxhY2UgaW4gdGhlIHNlcmllcyBhbmQgaW1w cm92ZSB0aGUgY29tbWl0IG1lc3NhZ2UKPiAKPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rs w6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IFJldmlld2VkLWJ5OiBEYW5pZWwg VmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPiAodjEpCj4gLS0tCj4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDM3ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKy0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlv bnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggZjg0ODdi Y2RiMjcxLi5kM2RlNTZmMGU3NjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jCj4gQEAgLTE1MzcwLDYgKzE1MzcwLDM3IEBAIHUzMiBpbnRlbF9mYl9waXRjaF9saW1pdChz dHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1aW50NjRfdCBmYl9tb2RpZmllciwKPiAgCX0KPiAgfQo+ ICAKPiArc3RhdGljIGludCBpbnRlbF9mYl9jaGVja19vZmZzZXRzKGNvbnN0IHN0cnVjdCBkcm1f bW9kZV9mYl9jbWQyICptb2RlX2NtZCkKPiArewo+ICsJdWludDMyX3QgZm9ybWF0ID0gbW9kZV9j bWQtPnBpeGVsX2Zvcm1hdDsKPiArCWludCBudW1fcGxhbmVzID0gZHJtX2Zvcm1hdF9udW1fcGxh bmVzKGZvcm1hdCk7Cj4gKwlpbnQgaTsKPiArCj4gKwlmb3IgKGkgPSAwOyBpIDwgbnVtX3BsYW5l czsgaSsrKSB7Cj4gKwkJdW5zaWduZWQgaW50IGNwcDsKPiArCj4gKwkJc3dpdGNoIChmb3JtYXQp IHsKPiArCQljYXNlIERSTV9GT1JNQVRfWVVZVjoKPiArCQljYXNlIERSTV9GT1JNQVRfVVlWWToK PiArCQljYXNlIERSTV9GT1JNQVRfWVZZVToKPiArCQljYXNlIERSTV9GT1JNQVRfVllVWToKPiAr CQkJY3BwID0gNDsKPiArCQkJYnJlYWs7Cj4gKwkJZGVmYXVsdDoKPiArCQkJY3BwID0gZHJtX2Zv cm1hdF9wbGFuZV9jcHAoZm9ybWF0LCBpKTsKCkkgZGlkbid0IGFzayBmb3IgYSBoZWxwZXIgaW4g ZHJtX2ZvdXJjYy5jIGZvciBtYWNyb3BpeGVsIGJsb2Nrc2l6ZT8gU2hhbWUKb24gbWUhIEFueXdh eSwgbG9va3MgYWxsIGdvb2QgYW5kIEkgZGlkbid0IHNwb3QgYW55dGhpbmcgZWxzZSBhbWlzcyB3 aGlsZQpyZS1yZWFkaW5nIHRoZSBzZXJpZXMuCgpBbm90aGVyIHdpc2hsaXN0IGl0ZW06IEV4dHJh Y3RpbmcgaW50ZWxfZnJhbWVidWZmZXIuYyBtaWdodCBiZSBhIGdvb2QKaWRlYS4KLURhbmllbAoK PiArCQkJYnJlYWs7Cj4gKwkJfQo+ICsKPiArCQlpZiAobW9kZV9jbWQtPm9mZnNldHNbaV0gJSBj cHApIHsKPiArCQkJRFJNX0RFQlVHKCJmYiBwbGFuZSAlZCBvZmZzZXQgMHglMDh4IG5vdCAobWFj cm8pcGl4ZWwgYWxpZ25lZFxuIiwKPiArCQkJCSAgaSwgbW9kZV9jbWQtPm9mZnNldHNbaV0pOwo+ ICsJCQlyZXR1cm4gLUVJTlZBTDsKPiArCQl9Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30K PiArCj4gIHN0YXRpYyBpbnQgaW50ZWxfZnJhbWVidWZmZXJfaW5pdChzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2LAo+ICAJCQkJICBzdHJ1Y3QgaW50ZWxfZnJhbWVidWZmZXIgKmludGVsX2ZiLAo+ICAJ CQkJICBzdHJ1Y3QgZHJtX21vZGVfZmJfY21kMiAqbW9kZV9jbWQsCj4gQEAgLTE1NTE0LDkgKzE1 NTQ1LDkgQEAgc3RhdGljIGludCBpbnRlbF9mcmFtZWJ1ZmZlcl9pbml0KHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYsCj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gIAl9Cj4gIAo+IC0JLyogRklYTUUgbmVl ZCB0byBhZGp1c3QgTElOT0ZGL1RJTEVPRkYgYWNjb3JkaW5nbHkuICovCj4gLQlpZiAobW9kZV9j bWQtPm9mZnNldHNbMF0gIT0gMCkKPiAtCQlyZXR1cm4gLUVJTlZBTDsKPiArCXJldCA9IGludGVs X2ZiX2NoZWNrX29mZnNldHMobW9kZV9jbWQpOwo+ICsJaWYgKHJldCkKPiArCQlyZXR1cm4gcmV0 Owo+ICAKPiAgCWRybV9oZWxwZXJfbW9kZV9maWxsX2ZiX3N0cnVjdCgmaW50ZWxfZmItPmJhc2Us IG1vZGVfY21kKTsKPiAgCWludGVsX2ZiLT5vYmogPSBvYmo7Cj4gLS0gCj4gMi43LjQKPiAKPiBf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdm eCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApE YW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8v YmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK