From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 11/12] drm/i915: Deal with NV12 CbCr plane AUX surface on SKL+ Date: Wed, 10 Aug 2016 14:26:14 +0300 Message-ID: <20160810112614.GM4329@intel.com> References: <1470821001-25272-1-git-send-email-ville.syrjala@linux.intel.com> <1470821001-25272-12-git-send-email-ville.syrjala@linux.intel.com> <20160810100308.GW6232@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id F207A6E734 for ; Wed, 10 Aug 2016 11:26:16 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160810100308.GW6232@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBdWcgMTAsIDIwMTYgYXQgMTI6MDM6MDhQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBXZWQsIEF1ZyAxMCwgMjAxNiBhdCAxMjoyMzoyMFBNICswMzAwLCB2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToKPiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8 dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAKPiA+IFdpdGggTlYxMiB3ZSBoYXZl IHR3byBjb2xvciBwbGFuZXMgdG8gZGVhbCB3aXRoIHNvIHdlIG11c3QgY29tcHV0ZSB0aGUKPiA+ IHN1cmZhY2UgYW5kIHgveSBvZmZzZXRzIGZvciB0aGUgc2Vjb25kIHBsYW5lIGFzIHdlbGwuCj4g PiAKPiA+IFdoYXQgbWFrZXMgdGhpcyBhIGJpdCBuYXN0eSBpcyB0aGF0IHRoZSBoYXJkd2FyZSBl eHBlY3RzIHRoZSBzdXJmYWNlCj4gPiBvZmZzZXQgdG8gYmUgc3BlY2lmaWVkIGFzIGEgZGlzdGFu Y2UgZnJvbSB0aGUgbWFpbiBzdXJmYWNlIG9mZnNldC4KPiA+IFdoYXQncyB3b3JzZSwgdGhlIGRp c3RhbmNlIG11c3QgYmUgbm9uLW5lZ2F0aXZlIChubyBuZWF0IHdyYXBhcm91bmQgb3IKPiA+IGFu eXRoaW5nKS4gU28gd2UgbXVzdCBtYWtlIHN1cmUgdGhhdCB0aGUgbWFpbiBzdXJmYWNlIG9mZnNl dCBpcyBhbHdheXMKPiA+IGxlc3Mgb3IgZXF1YWwgdG8gdGhlIEFVWCBzdXJmYWNlIG9mZnNldC4g V2UgZG8gdGhhdCBieSBjb21wdXRpbmcgdGhlIEFVWAo+ID4gb2Zmc2V0IGZpcnN0IGFuZCB0aGUg bWFpbiBzdXJmYWNlIG9mZnNldCBzZWNvbmQuIElmIHRoZSBtYWluIHN1cmZhY2UKPiA+IG9mZnNl dCBlbmRzIHVwIGJlaW5nIGFib3ZlIHRoZSBBVVggb2Zmc2V0LCB3ZSBqdXN0IHB1c2ggaXQgZG93 biBhcyBmYXIKPiA+IGFzIGlzIHJlcXVpcmVkIHdoaWxlIHN0aWxsIG1haW50YWluaW5nIHRoZSBy ZXF1aXJlZCBhbGlnbm1lbnQgZXRjLgo+ID4gCj4gPiBGb3J0dW5hdGVseSB0aGUgQVVYIG9mZnNl dCBvbmx5IHJldXFpcmVzIDRLIGFsaWdubWVudCwgc28gd2UgZG9uJ3QgbmVlZAo+ID4gdG8gZG8g YW55IG9mIHRoZSBiYWNrd2FyZHMgc2VhcmNoaW5nIGZvciBhbiBhY2NlcHRhYmxlIG9mZnNldCB0 aGF0IHdlCj4gPiBtdXN0IGRvIGZvciB0aGUgbWFpbiBzdXJmYWNlLiBBbmQgWCB0aWxlZCArIE5W MTIgaXNuJ3QgYSBzdXBwb3J0ZWQKPiA+IGNvbWJpbmF0aW9uIGFueXdheS4KPiA+IAo+ID4gTm90 ZSB0aGF0IHRoaXMganVzdCBjb21wdXRlcyBhdXggc3VyZmFjZSBvZmZzZXRzLCB3ZSBkbyBub3Qg eWV0IHByb2dyYW0KPiA+IHRoZW0gaW50byB0aGUgYWN0dWFsIGhhcmR3YXJlIHJlZ2lzdGVycywg YW5kIGhlbmNlIHdlIGNhbid0IHlldCBleHBvc2UKPiA+IE5WMTIuCj4gPiAKPiA+IHYyOiBSZWJh c2UgZHVlIHRvIGRybV9wbGFuZV9zdGF0ZSBzcmMvZHN0IHJlY3RzCj4gPiAgICAgcy9UT0RPLi4u L3NvbWV0aGluZyBlbHNlLyBpbiB0aGUgY29tbWl0IG1lc3NhZ2UvIChEYW5pZWwpCj4gPiAKPiA+ IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl bC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMg fCA2MiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0KPiA+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcnYuaCAgICAgfCAgNCArKysKPiA+ICAyIGZpbGVzIGNoYW5nZWQs IDY0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMKPiA+IGluZGV4IGI3MTljMDc1OTlmZC4uZjg0ODdiY2RiMjcxIDEw MDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IEBAIC0yNDYzLDgg KzI0NjMsMTQgQEAgdTMyIGludGVsX2NvbXB1dGVfdGlsZV9vZmZzZXQoaW50ICp4LCBpbnQgKnks Cj4gPiAgCWNvbnN0IHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUo c3RhdGUtPmJhc2UucGxhbmUtPmRldik7Cj4gPiAgCWNvbnN0IHN0cnVjdCBkcm1fZnJhbWVidWZm ZXIgKmZiID0gc3RhdGUtPmJhc2UuZmI7Cj4gPiAgCXVuc2lnbmVkIGludCByb3RhdGlvbiA9IHN0 YXRlLT5iYXNlLnJvdGF0aW9uOwo+ID4gLQl1MzIgYWxpZ25tZW50ID0gaW50ZWxfc3VyZl9hbGln bm1lbnQoZGV2X3ByaXYsIGZiLT5tb2RpZmllcltwbGFuZV0pOwo+ID4gIAlpbnQgcGl0Y2ggPSBp bnRlbF9mYl9waXRjaChmYiwgcGxhbmUsIHJvdGF0aW9uKTsKPiA+ICsJdTMyIGFsaWdubWVudDsK PiA+ICsKPiA+ICsJLyogQVVYX0RJU1QgbmVlZHMgb25seSA0SyBhbGlnbm1lbnQgKi8KPiA+ICsJ aWYgKGZiLT5waXhlbF9mb3JtYXQgPT0gRFJNX0ZPUk1BVF9OVjEyICYmIHBsYW5lID09IDEpCj4g PiArCQlhbGlnbm1lbnQgPSA0MDk2Owo+ID4gKwllbHNlCj4gPiArCQlhbGlnbm1lbnQgPSBpbnRl bF9zdXJmX2FsaWdubWVudChkZXZfcHJpdiwgZmItPm1vZGlmaWVyW3BsYW5lXSk7Cj4gPiAgCj4g PiAgCXJldHVybiBfaW50ZWxfY29tcHV0ZV90aWxlX29mZnNldChkZXZfcHJpdiwgeCwgeSwgZmIs IHBsYW5lLCBwaXRjaCwKPiA+ICAJCQkJCSAgcm90YXRpb24sIGFsaWdubWVudCk7Cj4gPiBAQCAt Mjg5NSw3ICsyOTAxLDcgQEAgc3RhdGljIGludCBza2xfY2hlY2tfbWFpbl9zdXJmYWNlKHN0cnVj dCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUpCj4gPiAgCWludCBoID0gZHJtX3JlY3Rf aGVpZ2h0KCZwbGFuZV9zdGF0ZS0+YmFzZS5zcmMpID4+IDE2Owo+ID4gIAlpbnQgbWF4X3dpZHRo ID0gc2tsX21heF9wbGFuZV93aWR0aChmYiwgMCwgcm90YXRpb24pOwo+ID4gIAlpbnQgbWF4X2hl aWdodCA9IDQwOTY7Cj4gPiAtCXUzMiBhbGlnbm1lbnQsIG9mZnNldDsKPiA+ICsJdTMyIGFsaWdu bWVudCwgb2Zmc2V0LCBhdXhfb2Zmc2V0ID0gcGxhbmVfc3RhdGUtPmF1eC5vZmZzZXQ7Cj4gPiAg Cj4gPiAgCWlmICh3ID4gbWF4X3dpZHRoIHx8IGggPiBtYXhfaGVpZ2h0KSB7Cj4gPiAgCQlEUk1f REVCVUdfS01TKCJyZXF1ZXN0ZWQgWS9SR0Igc291cmNlIHNpemUgJWR4JWQgdG9vIGJpZyAobGlt aXQgJWR4JWQpXG4iLAo+ID4gQEAgLTI5MDksNiArMjkxNSwxNSBAQCBzdGF0aWMgaW50IHNrbF9j aGVja19tYWluX3N1cmZhY2Uoc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSkK PiA+ICAJYWxpZ25tZW50ID0gaW50ZWxfc3VyZl9hbGlnbm1lbnQoZGV2X3ByaXYsIGZiLT5tb2Rp ZmllclswXSk7Cj4gPiAgCj4gPiAgCS8qCj4gPiArCSAqIEFVWCBzdXJmYWNlIG9mZnNldCBpcyBz cGVjaWZpZWQgYXMgdGhlIGRpc3RhbmNlIGZyb20gdGhlCj4gPiArCSAqIG1haW4gc3VyZmFjZSBv ZmZzZXQsIGFuZCBpdCBtdXN0IGJlIG5vbi1uZWdhdGl2ZS4gTWFrZQo+ID4gKwkgKiBzdXJlIHRo YXQgaXMgd2hhdCB3ZSB3aWxsIGdldC4KPiA+ICsJICovCj4gPiArCWlmIChvZmZzZXQgPiBhdXhf b2Zmc2V0KQo+ID4gKwkJb2Zmc2V0ID0gaW50ZWxfYWRqdXN0X3RpbGVfb2Zmc2V0KCZ4LCAmeSwg cGxhbmVfc3RhdGUsIDAsCj4gPiArCQkJCQkJICBvZmZzZXQsIGF1eF9vZmZzZXQgJiB+KGFsaWdu bWVudCAtIDEpKTsKPiAKPiBOb3RlIHRvIHNlbGY6IE5lZWQgdG8gbWFrZSBzdXJlIHRoYXQgbXVs dGlwbGFuYXIgZmJzIGFsbCByZWZlcmVuY2UgdGhlCj4gc2FtZSB1bmRlcmx5aW5nIGJvLiBCdXQg dGhhdCBjb2RlIGlzbid0IHlldCBhZGRlZCB0bwo+IGludGVsX2ZyYW1lYnVmZmVyX2luaXQoKS4K ClllcC4gSXQgd291bGQgYmUgYSBsb3QgbW9yZSB3b3JrIHRvIHN1cHBvcnQgZGlmZmVyZW50IGhh bmRsZXMgZm9yIHRoZQpwbGFuZXMsIHNvIEkgZmlndXJlIHdlIHNob3VsZG4ndCBib3RoZXIuIEZy YW5rbHkgSSBkb24ndCB1bmRlcnN0YW5kCndoeSB0aGUgaHcgZG9lc24ndCBqdXN0IHRha2UgdHdv IGluZGVwZW5kZW50IG9mZnNldHMsIHNpbmNlIGl0IHdvdWxkCnJlcXVpcmUgZXhhY3RseSB0aGUg c2FtZSBudW1iZXIgb2YgYml0cyBpbiB0aGUgcmVnaXN0ZXJzIGFueXdheS4gQnV0CnllYWgsIHdl IGhhdmUgdGhlIGh3IHdlIGhhdmUsIHNvIHdlIG11c3QgbGl2ZSB3aXRoIGl0LgoKPiAKPiA+ICsK PiA+ICsJLyoKPiA+ICAJICogV2hlbiB1c2luZyBhbiBYLXRpbGVkIHN1cmZhY2UsIHRoZSBwbGFu ZSBibG93cyB1cAo+ID4gIAkgKiBpZiB0aGUgeCBvZmZzZXQgKyB3aWR0aCBleGNlZWQgdGhlIHN0 cmlkZS4KPiA+ICAJICoKPiA+IEBAIC0yOTM1LDYgKzI5NTAsMzUgQEAgc3RhdGljIGludCBza2xf Y2hlY2tfbWFpbl9zdXJmYWNlKHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUp Cj4gPiAgCXJldHVybiAwOwo+ID4gIH0KPiA+ICAKPiA+ICtzdGF0aWMgaW50IHNrbF9jaGVja19u djEyX2F1eF9zdXJmYWNlKHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUpCj4g PiArewo+ID4gKwljb25zdCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9IHBsYW5lX3N0YXRl LT5iYXNlLmZiOwo+ID4gKwl1bnNpZ25lZCBpbnQgcm90YXRpb24gPSBwbGFuZV9zdGF0ZS0+YmFz ZS5yb3RhdGlvbjsKPiA+ICsJaW50IG1heF93aWR0aCA9IHNrbF9tYXhfcGxhbmVfd2lkdGgoZmIs IDEsIHJvdGF0aW9uKTsKPiA+ICsJaW50IG1heF9oZWlnaHQgPSA0MDk2Owo+ID4gKwlpbnQgeCA9 IHBsYW5lX3N0YXRlLT5iYXNlLnNyYy54MSA+PiAxNzsKPiA+ICsJaW50IHkgPSBwbGFuZV9zdGF0 ZS0+YmFzZS5zcmMueTEgPj4gMTc7Cj4gPiArCWludCB3ID0gZHJtX3JlY3Rfd2lkdGgoJnBsYW5l X3N0YXRlLT5iYXNlLnNyYykgPj4gMTc7Cj4gPiArCWludCBoID0gZHJtX3JlY3RfaGVpZ2h0KCZw bGFuZV9zdGF0ZS0+YmFzZS5zcmMpID4+IDE3Owo+ID4gKwl1MzIgb2Zmc2V0Owo+ID4gKwo+ID4g KwlpbnRlbF9hZGRfZmJfb2Zmc2V0cygmeCwgJnksIHBsYW5lX3N0YXRlLCAxKTsKPiA+ICsJb2Zm c2V0ID0gaW50ZWxfY29tcHV0ZV90aWxlX29mZnNldCgmeCwgJnksIHBsYW5lX3N0YXRlLCAxKTsK PiA+ICsKPiA+ICsJLyogRklYTUUgbm90IHF1aXRlIHN1cmUgaG93L2lmIHRoZXNlIGFwcGx5IHRv IHRoZSBjaHJvbWEgcGxhbmUgKi8KPiA+ICsJaWYgKHcgPiBtYXhfd2lkdGggfHwgaCA+IG1heF9o ZWlnaHQpIHsKPiA+ICsJCURSTV9ERUJVR19LTVMoIkNiQ3Igc291cmNlIHNpemUgJWR4JWQgdG9v IGJpZyAobGltaXQgJWR4JWQpXG4iLAo+ID4gKwkJCSAgICAgIHcsIGgsIG1heF93aWR0aCwgbWF4 X2hlaWdodCk7Cj4gPiArCQlyZXR1cm4gLUVJTlZBTDsKPiA+ICsJfQo+IAo+IFdlIGFsc28gbmVl ZCB0byBjaGVjayBwaXRjaCBvZiB0aGUgMm5kIHBsYW5lLCBidXQgSSBndWVzcyB0aGF0J3MgZG9u ZSBhdAo+IGZiX2luaXQgdGltZSwgbm90IGF0IGF0b21pY19jaGVjayB0aW1lLiBMb29rcyBhbGwg cmVhc29uYWJsZSBhcy1pcy4KPiAKPiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVs LnZldHRlckBmZndsbC5jaD4KPiAKPiAKPiA+ICsKPiA+ICsJcGxhbmVfc3RhdGUtPmF1eC5vZmZz ZXQgPSBvZmZzZXQ7Cj4gPiArCXBsYW5lX3N0YXRlLT5hdXgueCA9IHg7Cj4gPiArCXBsYW5lX3N0 YXRlLT5hdXgueSA9IHk7Cj4gPiArCj4gPiArCXJldHVybiAwOwo+ID4gK30KPiA+ICsKPiA+ICBp bnQgc2tsX2NoZWNrX3BsYW5lX3N1cmZhY2Uoc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFu ZV9zdGF0ZSkKPiA+ICB7Cj4gPiAgCWNvbnN0IHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiID0g cGxhbmVfc3RhdGUtPmJhc2UuZmI7Cj4gPiBAQCAtMjk0Niw2ICsyOTkwLDIwIEBAIGludCBza2xf Y2hlY2tfcGxhbmVfc3VyZmFjZShzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRl KQo+ID4gIAkJZHJtX3JlY3Rfcm90YXRlKCZwbGFuZV9zdGF0ZS0+YmFzZS5zcmMsCj4gPiAgCQkJ CWZiLT53aWR0aCwgZmItPmhlaWdodCwgQklUKERSTV9ST1RBVEVfMjcwKSk7Cj4gPiAgCj4gPiAr CS8qCj4gPiArCSAqIEhhbmRsZSB0aGUgQVVYIHN1cmZhY2UgZmlyc3Qgc2luY2UKPiA+ICsJICog dGhlIG1haW4gc3VyZmFjZSBzZXR1cCBkZXBlbmRzIG9uIGl0Lgo+ID4gKwkgKi8KPiA+ICsJaWYg KGZiLT5waXhlbF9mb3JtYXQgPT0gRFJNX0ZPUk1BVF9OVjEyKSB7Cj4gPiArCQlyZXQgPSBza2xf Y2hlY2tfbnYxMl9hdXhfc3VyZmFjZShwbGFuZV9zdGF0ZSk7Cj4gPiArCQlpZiAocmV0KQo+ID4g KwkJCXJldHVybiByZXQ7Cj4gPiArCX0gZWxzZSB7Cj4gPiArCQlwbGFuZV9zdGF0ZS0+YXV4Lm9m ZnNldCA9IH4weGZmZjsKPiA+ICsJCXBsYW5lX3N0YXRlLT5hdXgueCA9IDA7Cj4gPiArCQlwbGFu ZV9zdGF0ZS0+YXV4LnkgPSAwOwo+ID4gKwl9Cj4gPiArCj4gPiAgCXJldCA9IHNrbF9jaGVja19t YWluX3N1cmZhY2UocGxhbmVfc3RhdGUpOwo+ID4gIAlpZiAocmV0KQo+ID4gIAkJcmV0dXJuIHJl dDsKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gPiBpbmRleCAyZmRlMTM4MzNmY2IuLmRm OGU3NTE0YzA4YyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Ry di5oCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ID4gQEAgLTM1 NCw2ICszNTQsMTAgQEAgc3RydWN0IGludGVsX3BsYW5lX3N0YXRlIHsKPiA+ICAJCXUzMiBvZmZz ZXQ7Cj4gPiAgCQlpbnQgeCwgeTsKPiA+ICAJfSBtYWluOwo+ID4gKwlzdHJ1Y3Qgewo+ID4gKwkJ dTMyIG9mZnNldDsKPiA+ICsJCWludCB4LCB5Owo+ID4gKwl9IGF1eDsKPiA+ICAKPiA+ICAJLyoK PiA+ICAJICogc2NhbGVyX2lkCj4gPiAtLSAKPiA+IDIuNy40Cj4gPiAKPiA+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiBJbnRlbC1nZnggbWFpbGlu ZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+IAo+IC0tIAo+ IERhbmllbCBWZXR0ZXIKPiBTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KPiBo dHRwOi8vYmxvZy5mZndsbC5jaAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==