From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 12/12] drm/i915: Make sure fb offset is (macro)pixel aligned Date: Wed, 10 Aug 2016 14:33:53 +0300 Message-ID: <20160810113353.GN4329@intel.com> References: <1470821001-25272-1-git-send-email-ville.syrjala@linux.intel.com> <1470821001-25272-13-git-send-email-ville.syrjala@linux.intel.com> <20160810100432.GX6232@phenom.ffwll.local> <20160810110243.GK4329@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 4DD5C6E738 for ; Wed, 10 Aug 2016 11:33:57 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160810110243.GK4329@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBdWcgMTAsIDIwMTYgYXQgMDI6MDI6NDNQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFdlZCwgQXVnIDEwLCAyMDE2IGF0IDEyOjA0OjMyUE0gKzAyMDAsIERhbmll bCBWZXR0ZXIgd3JvdGU6Cj4gPiBPbiBXZWQsIEF1ZyAxMCwgMjAxNiBhdCAxMjoyMzoyMVBNICsw MzAwLCB2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToKPiA+ID4gRnJvbTogVmls bGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+ID4gCj4gPiA+ IFdlIGNvbnZlcnQgdGhlIGZiLT5vZmZzZXRzW10gaW50byB4L3kgb2Zmc2V0cywgc28gdGhleSBt dXN0IGJlCj4gPiA+IChtYWNybylwaXhlbCBhbGlnbmVkLiBDaGVjayBmb3IgdGhpcywgYW5kIGlm IHRoaW5ncyBsb29rIGdvb2QKPiA+ID4gYWxsb3cgZmItPm9mZnNldHNbXSAhPSAwIHdoZW4gY3Jl YXRpbmcgZmJzIHNpbmNlIHdlIG5vdyBoYW5kbGUKPiA+ID4gdGhlbSBjb3JyZWN0bHkuCj4gPiA+ IAo+ID4gPiB2MjogTW92ZSB0byBsYXN0IHBsYWNlIGluIHRoZSBzZXJpZXMgYW5kIGltcHJvdmUg dGhlIGNvbW1pdCBtZXNzYWdlCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJq w6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gPiBSZXZpZXdlZC1ieTog RGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4gKHYxKQo+ID4gPiAtLS0KPiA+ ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDM3ICsrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKy0tLQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDM0IGluc2Vy dGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jCj4gPiA+IGluZGV4IGY4NDg3YmNkYjI3MS4uZDNkZTU2ZjBlNzY0IDEwMDY0 NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+ID4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiA+IEBAIC0xNTM3 MCw2ICsxNTM3MCwzNyBAQCB1MzIgaW50ZWxfZmJfcGl0Y2hfbGltaXQoc3RydWN0IGRybV9kZXZp Y2UgKmRldiwgdWludDY0X3QgZmJfbW9kaWZpZXIsCj4gPiA+ICAJfQo+ID4gPiAgfQo+ID4gPiAg Cj4gPiA+ICtzdGF0aWMgaW50IGludGVsX2ZiX2NoZWNrX29mZnNldHMoY29uc3Qgc3RydWN0IGRy bV9tb2RlX2ZiX2NtZDIgKm1vZGVfY21kKQo+ID4gPiArewo+ID4gPiArCXVpbnQzMl90IGZvcm1h dCA9IG1vZGVfY21kLT5waXhlbF9mb3JtYXQ7Cj4gPiA+ICsJaW50IG51bV9wbGFuZXMgPSBkcm1f Zm9ybWF0X251bV9wbGFuZXMoZm9ybWF0KTsKPiA+ID4gKwlpbnQgaTsKPiA+ID4gKwo+ID4gPiAr CWZvciAoaSA9IDA7IGkgPCBudW1fcGxhbmVzOyBpKyspIHsKPiA+ID4gKwkJdW5zaWduZWQgaW50 IGNwcDsKPiA+ID4gKwo+ID4gPiArCQlzd2l0Y2ggKGZvcm1hdCkgewo+ID4gPiArCQljYXNlIERS TV9GT1JNQVRfWVVZVjoKPiA+ID4gKwkJY2FzZSBEUk1fRk9STUFUX1VZVlk6Cj4gPiA+ICsJCWNh c2UgRFJNX0ZPUk1BVF9ZVllVOgo+ID4gPiArCQljYXNlIERSTV9GT1JNQVRfVllVWToKPiA+ID4g KwkJCWNwcCA9IDQ7Cj4gPiA+ICsJCQlicmVhazsKPiA+ID4gKwkJZGVmYXVsdDoKPiA+ID4gKwkJ CWNwcCA9IGRybV9mb3JtYXRfcGxhbmVfY3BwKGZvcm1hdCwgaSk7Cj4gPiAKPiA+IEkgZGlkbid0 IGFzayBmb3IgYSBoZWxwZXIgaW4gZHJtX2ZvdXJjYy5jIGZvciBtYWNyb3BpeGVsIGJsb2Nrc2l6 ZT8gU2hhbWUKPiA+IG9uIG1lIQo+IAo+IFlvdSBkaWQsIGxvbmcgYWdvLiBJIGp1c3QgY291bGRu J3QgYmUgYm90aGVyZWQgdG8gZ28gYW5kIHNlZSB3aGF0IHdlCj4gbmVlZCB0byBkbyB0aGVyZS4g Tm93IHRoYXQgSSBkbywgaXQgZG9lc24ndCBsb29rIGxpa2Ugd2UndmUgZ2FpbmVkCj4gYW55IG5l dyBmb3JtYXRzIHRoYXQgd291bGQgbmVlZCBzcGVjaWFsIHRyZWF0bWVudCwgc28gSSBzdXBwb3Nl IEkKPiBjb3VsZCBqdXN0IHJldXNlIHRoaXMgZ3V5IGFzIGlzLgoKQW55IGlkZWFzIGZvciB0aGUg bmFtZT8gQW55dGhpbmcgSSBjYW4gY29tZSB1cCB3aXRoIHNvdW5kcyBzdHVwaWQuClRoZSBfY3Bw KCkgcHJlY2VkZW50IG1ha2VzIG1lIHdhbnQgdG8gZG8gX2NwbSgpLCBidXQgdGhhdCBsb29rcwp0 b3RhbGx5IHN0dXBpZC4gX21hY3JvcGl4ZWxfc2l6ZSgpIHBlcmhhcHM/IERvZXNuJ3QgbWF0Y2gg dGhlIF9jcHAoKQpNYXliZSByZW5hbWUgdGhlIF9jcHAoKSB0byBfcGl4ZWxfc2l6ZSgpIHRvIG1h dGNoPyBEdW5uby4gSWRlYXM/Cgo+IAo+ID4gQW55d2F5LCBsb29rcyBhbGwgZ29vZCBhbmQgSSBk aWRuJ3Qgc3BvdCBhbnl0aGluZyBlbHNlIGFtaXNzIHdoaWxlCj4gPiByZS1yZWFkaW5nIHRoZSBz ZXJpZXMuCj4gPiAKPiA+IEFub3RoZXIgd2lzaGxpc3QgaXRlbTogRXh0cmFjdGluZyBpbnRlbF9m cmFtZWJ1ZmZlci5jIG1pZ2h0IGJlIGEgZ29vZAo+ID4gaWRlYS4KPiA+IC1EYW5pZWwKPiA+IAo+ ID4gPiArCQkJYnJlYWs7Cj4gPiA+ICsJCX0KPiA+ID4gKwo+ID4gPiArCQlpZiAobW9kZV9jbWQt Pm9mZnNldHNbaV0gJSBjcHApIHsKPiA+ID4gKwkJCURSTV9ERUJVRygiZmIgcGxhbmUgJWQgb2Zm c2V0IDB4JTA4eCBub3QgKG1hY3JvKXBpeGVsIGFsaWduZWRcbiIsCj4gPiA+ICsJCQkJICBpLCBt b2RlX2NtZC0+b2Zmc2V0c1tpXSk7Cj4gPiA+ICsJCQlyZXR1cm4gLUVJTlZBTDsKPiA+ID4gKwkJ fQo+ID4gPiArCX0KPiA+ID4gKwo+ID4gPiArCXJldHVybiAwOwo+ID4gPiArfQo+ID4gPiArCj4g PiA+ICBzdGF0aWMgaW50IGludGVsX2ZyYW1lYnVmZmVyX2luaXQoc3RydWN0IGRybV9kZXZpY2Ug KmRldiwKPiA+ID4gIAkJCQkgIHN0cnVjdCBpbnRlbF9mcmFtZWJ1ZmZlciAqaW50ZWxfZmIsCj4g PiA+ICAJCQkJICBzdHJ1Y3QgZHJtX21vZGVfZmJfY21kMiAqbW9kZV9jbWQsCj4gPiA+IEBAIC0x NTUxNCw5ICsxNTU0NSw5IEBAIHN0YXRpYyBpbnQgaW50ZWxfZnJhbWVidWZmZXJfaW5pdChzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4gPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiA+ID4gIAl9Cj4g PiA+ICAKPiA+ID4gLQkvKiBGSVhNRSBuZWVkIHRvIGFkanVzdCBMSU5PRkYvVElMRU9GRiBhY2Nv cmRpbmdseS4gKi8KPiA+ID4gLQlpZiAobW9kZV9jbWQtPm9mZnNldHNbMF0gIT0gMCkKPiA+ID4g LQkJcmV0dXJuIC1FSU5WQUw7Cj4gPiA+ICsJcmV0ID0gaW50ZWxfZmJfY2hlY2tfb2Zmc2V0cyht b2RlX2NtZCk7Cj4gPiA+ICsJaWYgKHJldCkKPiA+ID4gKwkJcmV0dXJuIHJldDsKPiA+ID4gIAo+ ID4gPiAgCWRybV9oZWxwZXJfbW9kZV9maWxsX2ZiX3N0cnVjdCgmaW50ZWxfZmItPmJhc2UsIG1v ZGVfY21kKTsKPiA+ID4gIAlpbnRlbF9mYi0+b2JqID0gb2JqOwo+ID4gPiAtLSAKPiA+ID4gMi43 LjQKPiA+ID4gCj4gPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCj4gPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+ID4gSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwo+ID4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+ID4gCj4gPiAtLSAKPiA+IERhbmllbCBWZXR0ZXIKPiA+ IFNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgo+ID4gaHR0cDovL2Jsb2cuZmZ3 bGwuY2gKPiAKPiAtLSAKPiBWaWxsZSBTeXJqw6Rsw6QKPiBJbnRlbCBPVEMKPiBfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5n IGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApWaWxsZSBTeXJq w6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=