From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 12/12] drm/i915: Make sure fb offset is (macro)pixel aligned Date: Thu, 11 Aug 2016 19:37:13 +0300 Message-ID: <20160811163713.GQ4329@intel.com> References: <1470821001-25272-1-git-send-email-ville.syrjala@linux.intel.com> <1470821001-25272-13-git-send-email-ville.syrjala@linux.intel.com> <20160810100432.GX6232@phenom.ffwll.local> <20160810110243.GK4329@intel.com> <20160810113353.GN4329@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 7E2586E974 for ; Thu, 11 Aug 2016 16:37:16 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160810113353.GN4329@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBdWcgMTAsIDIwMTYgYXQgMDI6MzM6NTNQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFdlZCwgQXVnIDEwLCAyMDE2IGF0IDAyOjAyOjQzUE0gKzAzMDAsIFZpbGxl IFN5cmrDpGzDpCB3cm90ZToKPiA+IE9uIFdlZCwgQXVnIDEwLCAyMDE2IGF0IDEyOjA0OjMyUE0g KzAyMDAsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPiA+IE9uIFdlZCwgQXVnIDEwLCAyMDE2IGF0 IDEyOjIzOjIxUE0gKzAzMDAsIHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tIHdyb3RlOgo+ ID4gPiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5j b20+Cj4gPiA+ID4gCj4gPiA+ID4gV2UgY29udmVydCB0aGUgZmItPm9mZnNldHNbXSBpbnRvIHgv eSBvZmZzZXRzLCBzbyB0aGV5IG11c3QgYmUKPiA+ID4gPiAobWFjcm8pcGl4ZWwgYWxpZ25lZC4g Q2hlY2sgZm9yIHRoaXMsIGFuZCBpZiB0aGluZ3MgbG9vayBnb29kCj4gPiA+ID4gYWxsb3cgZmIt Pm9mZnNldHNbXSAhPSAwIHdoZW4gY3JlYXRpbmcgZmJzIHNpbmNlIHdlIG5vdyBoYW5kbGUKPiA+ ID4gPiB0aGVtIGNvcnJlY3RseS4KPiA+ID4gPiAKPiA+ID4gPiB2MjogTW92ZSB0byBsYXN0IHBs YWNlIGluIHRoZSBzZXJpZXMgYW5kIGltcHJvdmUgdGhlIGNvbW1pdCBtZXNzYWdlCj4gPiA+ID4g Cj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiA+ID4gPiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVs LnZldHRlckBmZndsbC5jaD4gKHYxKQo+ID4gPiA+IC0tLQo+ID4gPiA+ICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAzNyArKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKystLS0KPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDM0IGluc2VydGlvbnMoKyksIDMgZGVs ZXRpb25zKC0pCj4gPiA+ID4gCj4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku Ywo+ID4gPiA+IGluZGV4IGY4NDg3YmNkYjI3MS4uZDNkZTU2ZjBlNzY0IDEwMDY0NAo+ID4gPiA+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gPiA+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gPiA+IEBAIC0xNTM3MCw2 ICsxNTM3MCwzNyBAQCB1MzIgaW50ZWxfZmJfcGl0Y2hfbGltaXQoc3RydWN0IGRybV9kZXZpY2Ug KmRldiwgdWludDY0X3QgZmJfbW9kaWZpZXIsCj4gPiA+ID4gIAl9Cj4gPiA+ID4gIH0KPiA+ID4g PiAgCj4gPiA+ID4gK3N0YXRpYyBpbnQgaW50ZWxfZmJfY2hlY2tfb2Zmc2V0cyhjb25zdCBzdHJ1 Y3QgZHJtX21vZGVfZmJfY21kMiAqbW9kZV9jbWQpCj4gPiA+ID4gK3sKPiA+ID4gPiArCXVpbnQz Ml90IGZvcm1hdCA9IG1vZGVfY21kLT5waXhlbF9mb3JtYXQ7Cj4gPiA+ID4gKwlpbnQgbnVtX3Bs YW5lcyA9IGRybV9mb3JtYXRfbnVtX3BsYW5lcyhmb3JtYXQpOwo+ID4gPiA+ICsJaW50IGk7Cj4g PiA+ID4gKwo+ID4gPiA+ICsJZm9yIChpID0gMDsgaSA8IG51bV9wbGFuZXM7IGkrKykgewo+ID4g PiA+ICsJCXVuc2lnbmVkIGludCBjcHA7Cj4gPiA+ID4gKwo+ID4gPiA+ICsJCXN3aXRjaCAoZm9y bWF0KSB7Cj4gPiA+ID4gKwkJY2FzZSBEUk1fRk9STUFUX1lVWVY6Cj4gPiA+ID4gKwkJY2FzZSBE Uk1fRk9STUFUX1VZVlk6Cj4gPiA+ID4gKwkJY2FzZSBEUk1fRk9STUFUX1lWWVU6Cj4gPiA+ID4g KwkJY2FzZSBEUk1fRk9STUFUX1ZZVVk6Cj4gPiA+ID4gKwkJCWNwcCA9IDQ7Cj4gPiA+ID4gKwkJ CWJyZWFrOwo+ID4gPiA+ICsJCWRlZmF1bHQ6Cj4gPiA+ID4gKwkJCWNwcCA9IGRybV9mb3JtYXRf cGxhbmVfY3BwKGZvcm1hdCwgaSk7Cj4gPiA+IAo+ID4gPiBJIGRpZG4ndCBhc2sgZm9yIGEgaGVs cGVyIGluIGRybV9mb3VyY2MuYyBmb3IgbWFjcm9waXhlbCBibG9ja3NpemU/IFNoYW1lCj4gPiA+ IG9uIG1lIQo+ID4gCj4gPiBZb3UgZGlkLCBsb25nIGFnby4gSSBqdXN0IGNvdWxkbid0IGJlIGJv dGhlcmVkIHRvIGdvIGFuZCBzZWUgd2hhdCB3ZQo+ID4gbmVlZCB0byBkbyB0aGVyZS4gTm93IHRo YXQgSSBkbywgaXQgZG9lc24ndCBsb29rIGxpa2Ugd2UndmUgZ2FpbmVkCj4gPiBhbnkgbmV3IGZv cm1hdHMgdGhhdCB3b3VsZCBuZWVkIHNwZWNpYWwgdHJlYXRtZW50LCBzbyBJIHN1cHBvc2UgSQo+ ID4gY291bGQganVzdCByZXVzZSB0aGlzIGd1eSBhcyBpcy4KPiAKPiBBbnkgaWRlYXMgZm9yIHRo ZSBuYW1lPyBBbnl0aGluZyBJIGNhbiBjb21lIHVwIHdpdGggc291bmRzIHN0dXBpZC4KPiBUaGUg X2NwcCgpIHByZWNlZGVudCBtYWtlcyBtZSB3YW50IHRvIGRvIF9jcG0oKSwgYnV0IHRoYXQgbG9v a3MKPiB0b3RhbGx5IHN0dXBpZC4gX21hY3JvcGl4ZWxfc2l6ZSgpIHBlcmhhcHM/IERvZXNuJ3Qg bWF0Y2ggdGhlIF9jcHAoKQo+IE1heWJlIHJlbmFtZSB0aGUgX2NwcCgpIHRvIF9waXhlbF9zaXpl KCkgdG8gbWF0Y2g/IER1bm5vLiBJZGVhcz8KCkkndmUgcHVzaGVkIGV2ZXJ5dGhpbmcgYnV0IHRo aXMgbGFzdCBwYXRjaCB0byBkaW5xLiBUaGFua3MgZm9yIHRoZQpyZXZpZXdzLgoKVGhlcmUgYXJl IHR3byBvcGVuIHF1ZXN0aW9ucyB3aXRoIHRoaXMgcGF0Y2g6IGZpcnN0IG9uZSBpcyBhYm91dApt b3ZpbmcgdGhlIGhlbHBlciB0byB0aGUgY29yZSwgYW5kIHRoZSBzZWNvbmQgb25lIGhhcyB0byBk byB3aXRoCnRlc3RzLiBOYW1lbHksIEkgY2FuJ3QgcmVjYWxsIHdoZXJlIEkgcHV0IHRoZSBvbmVz IEkgaGFkIHdyaXR0ZW4sCnNvIEkgbmVlZCB0byB0cnkgYW5kIGRpZyB0aGVtIHVwLgoKPiAKPiA+ IAo+ID4gPiBBbnl3YXksIGxvb2tzIGFsbCBnb29kIGFuZCBJIGRpZG4ndCBzcG90IGFueXRoaW5n IGVsc2UgYW1pc3Mgd2hpbGUKPiA+ID4gcmUtcmVhZGluZyB0aGUgc2VyaWVzLgo+ID4gPiAKPiA+ ID4gQW5vdGhlciB3aXNobGlzdCBpdGVtOiBFeHRyYWN0aW5nIGludGVsX2ZyYW1lYnVmZmVyLmMg bWlnaHQgYmUgYSBnb29kCj4gPiA+IGlkZWEuCj4gPiA+IC1EYW5pZWwKPiA+ID4gCj4gPiA+ID4g KwkJCWJyZWFrOwo+ID4gPiA+ICsJCX0KPiA+ID4gPiArCj4gPiA+ID4gKwkJaWYgKG1vZGVfY21k LT5vZmZzZXRzW2ldICUgY3BwKSB7Cj4gPiA+ID4gKwkJCURSTV9ERUJVRygiZmIgcGxhbmUgJWQg b2Zmc2V0IDB4JTA4eCBub3QgKG1hY3JvKXBpeGVsIGFsaWduZWRcbiIsCj4gPiA+ID4gKwkJCQkg IGksIG1vZGVfY21kLT5vZmZzZXRzW2ldKTsKPiA+ID4gPiArCQkJcmV0dXJuIC1FSU5WQUw7Cj4g PiA+ID4gKwkJfQo+ID4gPiA+ICsJfQo+ID4gPiA+ICsKPiA+ID4gPiArCXJldHVybiAwOwo+ID4g PiA+ICt9Cj4gPiA+ID4gKwo+ID4gPiA+ICBzdGF0aWMgaW50IGludGVsX2ZyYW1lYnVmZmVyX2lu aXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ID4gPiAgCQkJCSAgc3RydWN0IGludGVsX2Zy YW1lYnVmZmVyICppbnRlbF9mYiwKPiA+ID4gPiAgCQkJCSAgc3RydWN0IGRybV9tb2RlX2ZiX2Nt ZDIgKm1vZGVfY21kLAo+ID4gPiA+IEBAIC0xNTUxNCw5ICsxNTU0NSw5IEBAIHN0YXRpYyBpbnQg aW50ZWxfZnJhbWVidWZmZXJfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4gPiA+ICAJ CXJldHVybiAtRUlOVkFMOwo+ID4gPiA+ICAJfQo+ID4gPiA+ICAKPiA+ID4gPiAtCS8qIEZJWE1F IG5lZWQgdG8gYWRqdXN0IExJTk9GRi9USUxFT0ZGIGFjY29yZGluZ2x5LiAqLwo+ID4gPiA+IC0J aWYgKG1vZGVfY21kLT5vZmZzZXRzWzBdICE9IDApCj4gPiA+ID4gLQkJcmV0dXJuIC1FSU5WQUw7 Cj4gPiA+ID4gKwlyZXQgPSBpbnRlbF9mYl9jaGVja19vZmZzZXRzKG1vZGVfY21kKTsKPiA+ID4g PiArCWlmIChyZXQpCj4gPiA+ID4gKwkJcmV0dXJuIHJldDsKPiA+ID4gPiAgCj4gPiA+ID4gIAlk cm1faGVscGVyX21vZGVfZmlsbF9mYl9zdHJ1Y3QoJmludGVsX2ZiLT5iYXNlLCBtb2RlX2NtZCk7 CiA+ID4gPiAgCWludGVsX2ZiLT5vYmogPSBvYmo7Cj4gPiA+ID4gLS0gCj4gPiA+ID4gMi43LjQK PiA+ID4gPiAKPiA+ID4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+ID4gPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+ID4gPiBJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiA+ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKPiA+ID4gCj4gPiA+IC0tIAo+ID4gPiBEYW5p ZWwgVmV0dGVyCj4gPiA+IFNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgo+ID4g PiBodHRwOi8vYmxvZy5mZndsbC5jaAo+ID4gCj4gPiAtLSAKPiA+IFZpbGxlIFN5cmrDpGzDpAo+ ID4gSW50ZWwgT1RDCj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngKPiAKPiAtLSAKPiBWaWxsZSBTeXJqw6Rsw6QKPiBJbnRlbCBPVEMK PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVs LWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0t IApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=