From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 11/15] drm/i915: Convert intel_sdvo to use atomic state Date: Thu, 18 Aug 2016 15:44:05 +0200 Message-ID: <20160818134405.GM6232@phenom.ffwll.local> References: <1470755054-32699-1-git-send-email-maarten.lankhorst@linux.intel.com> <1470755054-32699-12-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2F7466EA42 for ; Thu, 18 Aug 2016 13:44:10 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id i138so5643630wmf.3 for ; Thu, 18 Aug 2016 06:44:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1470755054-32699-12-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBdWcgMDksIDIwMTYgYXQgMDU6MDQ6MTBQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFu a2hvcnN0QGxpbnV4LmludGVsLmNvbT4KClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5p ZWwudmV0dGVyQGZmd2xsLmNoPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf c2R2by5jIHwgMjcgKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2Vk LCAxMSBpbnNlcnRpb25zKCspLCAxNiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc2R2by5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfc2R2by5jCj4gaW5kZXggN2MwOGQ1NTVmMzVkLi43NGE3YzZjOWI5NzQgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc2R2by5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfc2R2by5jCj4gQEAgLTEwMDMsMjQgKzEwMDMsMjIgQEAgc3RhdGljIGJv b2wgaW50ZWxfc2R2b193cml0ZV9pbmZvZnJhbWUoc3RydWN0IGludGVsX3Nkdm8gKmludGVsX3Nk dm8sCj4gIH0KPiAgCj4gIHN0YXRpYyBib29sIGludGVsX3Nkdm9fc2V0X2F2aV9pbmZvZnJhbWUo c3RydWN0IGludGVsX3Nkdm8gKmludGVsX3Nkdm8sCj4gLQkJCQkJIGNvbnN0IHN0cnVjdCBkcm1f ZGlzcGxheV9tb2RlICphZGp1c3RlZF9tb2RlKQo+ICsJCQkJCSBzdHJ1Y3QgaW50ZWxfY3J0Y19z dGF0ZSAqcGlwZV9jb25maWcpCj4gIHsKPiAgCXVpbnQ4X3Qgc2R2b19kYXRhW0hETUlfSU5GT0ZS QU1FX1NJWkUoQVZJKV07Cj4gLQlzdHJ1Y3QgZHJtX2NydGMgKmNydGMgPSBpbnRlbF9zZHZvLT5i YXNlLmJhc2UuY3J0YzsKPiAtCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0gdG9faW50 ZWxfY3J0YyhjcnRjKTsKPiAgCXVuaW9uIGhkbWlfaW5mb2ZyYW1lIGZyYW1lOwo+ICAJaW50IHJl dDsKPiAgCXNzaXplX3QgbGVuOwo+ICAKPiAgCXJldCA9IGRybV9oZG1pX2F2aV9pbmZvZnJhbWVf ZnJvbV9kaXNwbGF5X21vZGUoJmZyYW1lLmF2aSwKPiAtCQkJCQkJICAgICAgIGFkanVzdGVkX21v ZGUpOwo+ICsJCQkJCQkgICAgICAgJnBpcGVfY29uZmlnLT5iYXNlLmFkanVzdGVkX21vZGUpOwo+ ICAJaWYgKHJldCA8IDApIHsKPiAgCQlEUk1fRVJST1IoImNvdWxkbid0IGZpbGwgQVZJIGluZm9m cmFtZVxuIik7Cj4gIAkJcmV0dXJuIGZhbHNlOwo+ICAJfQo+ICAKPiAgCWlmIChpbnRlbF9zZHZv LT5yZ2JfcXVhbnRfcmFuZ2Vfc2VsZWN0YWJsZSkgewo+IC0JCWlmIChpbnRlbF9jcnRjLT5jb25m aWctPmxpbWl0ZWRfY29sb3JfcmFuZ2UpCj4gKwkJaWYgKHBpcGVfY29uZmlnLT5saW1pdGVkX2Nv bG9yX3JhbmdlKQo+ICAJCQlmcmFtZS5hdmkucXVhbnRpemF0aW9uX3JhbmdlID0KPiAgCQkJCUhE TUlfUVVBTlRJWkFUSU9OX1JBTkdFX0xJTUlURUQ7Cj4gIAkJZWxzZQo+IEBAIC0xMTk5LDE4ICsx MTk3LDE1IEBAIHN0YXRpYyB2b2lkIGludGVsX3Nkdm9fcHJlX2VuYWJsZShzdHJ1Y3QgaW50ZWxf ZW5jb2RlciAqaW50ZWxfZW5jb2RlciwKPiAgewo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9 IGludGVsX2VuY29kZXItPmJhc2UuZGV2Owo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2ID0gdG9faTkxNShkZXYpOwo+IC0Jc3RydWN0IGludGVsX2NydGMgKmNydGMgPSB0b19p bnRlbF9jcnRjKGludGVsX2VuY29kZXItPmJhc2UuY3J0Yyk7Cj4gLQljb25zdCBzdHJ1Y3QgZHJt X2Rpc3BsYXlfbW9kZSAqYWRqdXN0ZWRfbW9kZSA9ICZjcnRjLT5jb25maWctPmJhc2UuYWRqdXN0 ZWRfbW9kZTsKPiAtCXN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlID0gJmNydGMtPmNvbmZp Zy0+YmFzZS5tb2RlOwo+ICsJc3RydWN0IGludGVsX2NydGMgKmNydGMgPSB0b19pbnRlbF9jcnRj KGNydGNfc3RhdGUtPmJhc2UuY3J0Yyk7Cj4gKwljb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9k ZSAqYWRqdXN0ZWRfbW9kZSA9ICZjcnRjX3N0YXRlLT5iYXNlLmFkanVzdGVkX21vZGU7Cj4gKwlz dHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSA9ICZjcnRjX3N0YXRlLT5iYXNlLm1vZGU7Cj4g IAlzdHJ1Y3QgaW50ZWxfc2R2byAqaW50ZWxfc2R2byA9IHRvX3Nkdm8oaW50ZWxfZW5jb2Rlcik7 Cj4gIAl1MzIgc2R2b3g7Cj4gIAlzdHJ1Y3QgaW50ZWxfc2R2b19pbl9vdXRfbWFwIGluX291dDsK PiAgCXN0cnVjdCBpbnRlbF9zZHZvX2R0ZCBpbnB1dF9kdGQsIG91dHB1dF9kdGQ7Cj4gIAlpbnQg cmF0ZTsKPiAgCj4gLQlpZiAoIW1vZGUpCj4gLQkJcmV0dXJuOwo+IC0KPiAgCS8qIEZpcnN0LCBz ZXQgdGhlIGlucHV0IG1hcHBpbmcgZm9yIHRoZSBmaXJzdCBpbnB1dCB0byBvdXIgY29udHJvbGxl ZAo+ICAJICogb3V0cHV0LiBUaGlzIGlzIG9ubHkgY29ycmVjdCBpZiB3ZSdyZSBhIHNpbmdsZS1p bnB1dCBkZXZpY2UsIGluCj4gIAkgKiB3aGljaCBjYXNlIHRoZSBmaXJzdCBpbnB1dCBpcyB0aGUg b3V0cHV0IGZyb20gdGhlIGFwcHJvcHJpYXRlIFNEVk8KPiBAQCAtMTI0MywxMSArMTIzOCwxMSBA QCBzdGF0aWMgdm9pZCBpbnRlbF9zZHZvX3ByZV9lbmFibGUoc3RydWN0IGludGVsX2VuY29kZXIg KmludGVsX2VuY29kZXIsCj4gIAlpZiAoIWludGVsX3Nkdm9fc2V0X3RhcmdldF9pbnB1dChpbnRl bF9zZHZvKSkKPiAgCQlyZXR1cm47Cj4gIAo+IC0JaWYgKGNydGMtPmNvbmZpZy0+aGFzX2hkbWlf c2luaykgewo+ICsJaWYgKGNydGNfc3RhdGUtPmhhc19oZG1pX3NpbmspIHsKPiAgCQlpbnRlbF9z ZHZvX3NldF9lbmNvZGUoaW50ZWxfc2R2bywgU0RWT19FTkNPREVfSERNSSk7Cj4gIAkJaW50ZWxf c2R2b19zZXRfY29sb3JpbWV0cnkoaW50ZWxfc2R2bywKPiAgCQkJCQkgICBTRFZPX0NPTE9SSU1F VFJZX1JHQjI1Nik7Cj4gLQkJaW50ZWxfc2R2b19zZXRfYXZpX2luZm9mcmFtZShpbnRlbF9zZHZv LCBhZGp1c3RlZF9tb2RlKTsKPiArCQlpbnRlbF9zZHZvX3NldF9hdmlfaW5mb2ZyYW1lKGludGVs X3Nkdm8sIGNydGNfc3RhdGUpOwo+ICAJfSBlbHNlCj4gIAkJaW50ZWxfc2R2b19zZXRfZW5jb2Rl KGludGVsX3Nkdm8sIFNEVk9fRU5DT0RFX0RWSSk7Cj4gIAo+IEBAIC0xMjYzLDcgKzEyNTgsNyBA QCBzdGF0aWMgdm9pZCBpbnRlbF9zZHZvX3ByZV9lbmFibGUoc3RydWN0IGludGVsX2VuY29kZXIg KmludGVsX2VuY29kZXIsCj4gIAkJRFJNX0lORk8oIlNldHRpbmcgaW5wdXQgdGltaW5ncyBvbiAl cyBmYWlsZWRcbiIsCj4gIAkJCSBTRFZPX05BTUUoaW50ZWxfc2R2bykpOwo+ICAKPiAtCXN3aXRj aCAoY3J0Yy0+Y29uZmlnLT5waXhlbF9tdWx0aXBsaWVyKSB7Cj4gKwlzd2l0Y2ggKGNydGNfc3Rh dGUtPnBpeGVsX211bHRpcGxpZXIpIHsKPiAgCWRlZmF1bHQ6Cj4gIAkJV0FSTigxLCAidW5rbm93 biBwaXhlbCBtdWx0aXBsaWVyIHNwZWNpZmllZFxuIik7Cj4gIAljYXNlIDE6IHJhdGUgPSBTRFZP X0NMT0NLX1JBVEVfTVVMVF8xWDsgYnJlYWs7Cj4gQEAgLTEyNzgsNyArMTI3Myw3IEBAIHN0YXRp YyB2b2lkIGludGVsX3Nkdm9fcHJlX2VuYWJsZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqaW50ZWxf ZW5jb2RlciwKPiAgCQkvKiBUaGUgcmVhbCBtb2RlIHBvbGFyaXR5IGlzIHNldCBieSB0aGUgU0RW TyBjb21tYW5kcywgdXNpbmcKPiAgCQkgKiBzdHJ1Y3QgaW50ZWxfc2R2b19kdGQuICovCj4gIAkJ c2R2b3ggPSBTRFZPX1ZTWU5DX0FDVElWRV9ISUdIIHwgU0RWT19IU1lOQ19BQ1RJVkVfSElHSDsK PiAtCQlpZiAoIUhBU19QQ0hfU1BMSVQoZGV2KSAmJiBjcnRjLT5jb25maWctPmxpbWl0ZWRfY29s b3JfcmFuZ2UpCj4gKwkJaWYgKCFIQVNfUENIX1NQTElUKGRldikgJiYgY3J0Y19zdGF0ZS0+bGlt aXRlZF9jb2xvcl9yYW5nZSkKPiAgCQkJc2R2b3ggfD0gSERNSV9DT0xPUl9SQU5HRV8xNl8yMzU7 Cj4gIAkJaWYgKElOVEVMX0lORk8oZGV2KS0+Z2VuIDwgNSkKPiAgCQkJc2R2b3ggfD0gU0RWT19C T1JERVJfRU5BQkxFOwo+IEBAIC0xMzA0LDcgKzEyOTksNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9z ZHZvX3ByZV9lbmFibGUoc3RydWN0IGludGVsX2VuY29kZXIgKmludGVsX2VuY29kZXIsCj4gIAl9 IGVsc2UgaWYgKElTX0k5NDVHKGRldikgfHwgSVNfSTk0NUdNKGRldikgfHwgSVNfRzMzKGRldikp IHsKPiAgCQkvKiBkb25lIGluIGNydGNfbW9kZV9zZXQgYXMgaXQgbGl2ZXMgaW5zaWRlIHRoZSBk cGxsIHJlZ2lzdGVyICovCj4gIAl9IGVsc2Ugewo+IC0JCXNkdm94IHw9IChjcnRjLT5jb25maWct PnBpeGVsX211bHRpcGxpZXIgLSAxKQo+ICsJCXNkdm94IHw9IChjcnRjX3N0YXRlLT5waXhlbF9t dWx0aXBsaWVyIC0gMSkKPiAgCQkJPDwgU0RWT19QT1JUX01VTFRJUExZX1NISUZUOwo+ICAJfQo+ ICAKPiAtLSAKPiAyLjcuNAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIElu dGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=