From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 15/15] drm/i915: Use more atomic state in intel_color.c Date: Thu, 18 Aug 2016 16:02:38 +0200 Message-ID: <20160818140238.GQ6232@phenom.ffwll.local> References: <1470755054-32699-1-git-send-email-maarten.lankhorst@linux.intel.com> <1470755054-32699-16-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6DF516EA59 for ; Thu, 18 Aug 2016 14:02:42 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id q128so5750169wma.1 for ; Thu, 18 Aug 2016 07:02:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1470755054-32699-16-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBdWcgMDksIDIwMTYgYXQgMDU6MDQ6MTRQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gY3J0Y19zdGF0ZSBpcyBhbHJlYWR5IHBhc3NlZCBhcm91bmQsIHVzZSBpdCBp bnN0ZWFkIG9mIGNydGMtPmNvbmZpZy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmto b3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IERh bmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jIHwgMjQgKysrKysrKysrKysrKystLS0tLS0tLS0tCj4g IDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29sb3IuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMKPiBpbmRleCBiYzBmZWYzZDMzMzUuLjk1YTcyNzcx ZWVhNiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29sb3IuYwo+IEBAIC0xMDAsMTMgKzEw MCwxNCBAQCBzdGF0aWMgdm9pZCBpOXh4X2xvYWRfY3NjX21hdHJpeChzdHJ1Y3QgZHJtX2NydGNf c3RhdGUgKmNydGNfc3RhdGUpCj4gIAlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YyA9IHRv X2ludGVsX2NydGMoY3J0Yyk7Cj4gIAlpbnQgaSwgcGlwZSA9IGludGVsX2NydGMtPnBpcGU7Cj4g IAl1aW50MTZfdCBjb2VmZnNbOV0gPSB7IDAsIH07Cj4gKwlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0 ZSAqaW50ZWxfY3J0Y19zdGF0ZSA9IHRvX2ludGVsX2NydGNfc3RhdGUoY3J0Y19zdGF0ZSk7Cj4g IAo+ICAJaWYgKGNydGNfc3RhdGUtPmN0bSkgewo+ICAJCXN0cnVjdCBkcm1fY29sb3JfY3RtICpj dG0gPQo+ICAJCQkoc3RydWN0IGRybV9jb2xvcl9jdG0gKiljcnRjX3N0YXRlLT5jdG0tPmRhdGE7 Cj4gIAkJdWludDY0X3QgaW5wdXRbOV0gPSB7IDAsIH07Cj4gIAo+IC0JCWlmIChpbnRlbF9jcnRj LT5jb25maWctPmxpbWl0ZWRfY29sb3JfcmFuZ2UpIHsKPiArCQlpZiAoaW50ZWxfY3J0Y19zdGF0 ZS0+bGltaXRlZF9jb2xvcl9yYW5nZSkgewo+ICAJCQljdG1fbXVsdF9ieV9saW1pdGVkKGlucHV0 LCBjdG0tPm1hdHJpeCk7Cj4gIAkJfSBlbHNlIHsKPiAgCQkJZm9yIChpID0gMDsgaSA8IEFSUkFZ X1NJWkUoaW5wdXQpOyBpKyspCj4gQEAgLTE1OCw3ICsxNTksNyBAQCBzdGF0aWMgdm9pZCBpOXh4 X2xvYWRfY3NjX21hdHJpeChzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gIAkJ ICogaW50byBjb25zaWRlcmF0aW9uLgo+ICAJCSAqLwo+ICAJCWZvciAoaSA9IDA7IGkgPCAzOyBp KyspIHsKPiAtCQkJaWYgKGludGVsX2NydGMtPmNvbmZpZy0+bGltaXRlZF9jb2xvcl9yYW5nZSkK PiArCQkJaWYgKGludGVsX2NydGNfc3RhdGUtPmxpbWl0ZWRfY29sb3JfcmFuZ2UpCj4gIAkJCQlj b2VmZnNbaSAqIDMgKyBpXSA9Cj4gIAkJCQkJSTlYWF9DU0NfQ09FRkZfTElNSVRFRF9SQU5HRTsK PiAgCQkJZWxzZQo+IEBAIC0xODIsNyArMTgzLDcgQEAgc3RhdGljIHZvaWQgaTl4eF9sb2FkX2Nz Y19tYXRyaXgoc3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICAJaWYgKElOVEVM X0lORk8oZGV2KS0+Z2VuID4gNikgewo+ICAJCXVpbnQxNl90IHBvc3RvZmYgPSAwOwo+ICAKPiAt CQlpZiAoaW50ZWxfY3J0Yy0+Y29uZmlnLT5saW1pdGVkX2NvbG9yX3JhbmdlKQo+ICsJCWlmIChp bnRlbF9jcnRjX3N0YXRlLT5saW1pdGVkX2NvbG9yX3JhbmdlKQo+ICAJCQlwb3N0b2ZmID0gKDE2 ICogKDEgPDwgMTIpIC8gMjU1KSAmIDB4MWZmZjsKPiAgCj4gIAkJSTkxNV9XUklURShQSVBFX0NT Q19QT1NUT0ZGX0hJKHBpcGUpLCBwb3N0b2ZmKTsKPiBAQCAtMTkzLDcgKzE5NCw3IEBAIHN0YXRp YyB2b2lkIGk5eHhfbG9hZF9jc2NfbWF0cml4KHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19z dGF0ZSkKPiAgCX0gZWxzZSB7Cj4gIAkJdWludDMyX3QgbW9kZSA9IENTQ19NT0RFX1lVVl9UT19S R0I7Cj4gIAo+IC0JCWlmIChpbnRlbF9jcnRjLT5jb25maWctPmxpbWl0ZWRfY29sb3JfcmFuZ2Up Cj4gKwkJaWYgKGludGVsX2NydGNfc3RhdGUtPmxpbWl0ZWRfY29sb3JfcmFuZ2UpCj4gIAkJCW1v ZGUgfD0gQ1NDX0JMQUNLX1NDUkVFTl9PRkZTRVQ7Cj4gIAo+ICAJCUk5MTVfV1JJVEUoUElQRV9D U0NfTU9ERShwaXBlKSwgbW9kZSk7Cj4gQEAgLTI2Myw3ICsyNjQsOCBAQCB2b2lkIGludGVsX2Nv bG9yX3NldF9jc2Moc3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICAKPiAgLyog TG9hZHMgdGhlIGxlZ2FjeSBwYWxldHRlL2dhbW1hIHVuaXQgZm9yIHRoZSBDUlRDLiAqLwo+ICBz dGF0aWMgdm9pZCBpOXh4X2xvYWRfbHV0c19pbnRlcm5hbChzdHJ1Y3QgZHJtX2NydGMgKmNydGMs Cj4gLQkJCQkgICAgc3RydWN0IGRybV9wcm9wZXJ0eV9ibG9iICpibG9iKQo+ICsJCQkJICAgIHN0 cnVjdCBkcm1fcHJvcGVydHlfYmxvYiAqYmxvYiwKPiArCQkJCSAgICBzdHJ1Y3QgaW50ZWxfY3J0 Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiAgewo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNy dGMtPmRldjsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUo ZGV2KTsKPiBAQCAtMjcyLDcgKzI3NCw3IEBAIHN0YXRpYyB2b2lkIGk5eHhfbG9hZF9sdXRzX2lu dGVybmFsKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCWludCBpOwo+ICAKPiAgCWlmIChIQVNf R01DSF9ESVNQTEFZKGRldikpIHsKPiAtCQlpZiAoaW50ZWxfY3J0Y19oYXNfdHlwZShpbnRlbF9j cnRjLT5jb25maWcsIElOVEVMX09VVFBVVF9EU0kpKQo+ICsJCWlmIChpbnRlbF9jcnRjX2hhc190 eXBlKGNydGNfc3RhdGUsIElOVEVMX09VVFBVVF9EU0kpKQo+ICAJCQlhc3NlcnRfZHNpX3BsbF9l bmFibGVkKGRldl9wcml2KTsKPiAgCQllbHNlCj4gIAkJCWFzc2VydF9wbGxfZW5hYmxlZChkZXZf cHJpdiwgcGlwZSk7Cj4gQEAgLTMwNSw3ICszMDcsOCBAQCBzdGF0aWMgdm9pZCBpOXh4X2xvYWRf bHV0c19pbnRlcm5hbChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAo+ICBzdGF0aWMgdm9pZCBp OXh4X2xvYWRfbHV0cyhzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gIHsKPiAt CWk5eHhfbG9hZF9sdXRzX2ludGVybmFsKGNydGNfc3RhdGUtPmNydGMsIGNydGNfc3RhdGUtPmdh bW1hX2x1dCk7Cj4gKwlpOXh4X2xvYWRfbHV0c19pbnRlcm5hbChjcnRjX3N0YXRlLT5jcnRjLCBj cnRjX3N0YXRlLT5nYW1tYV9sdXQsCj4gKwkJCQl0b19pbnRlbF9jcnRjX3N0YXRlKGNydGNfc3Rh dGUpKTsKPiAgfQo+ICAKPiAgLyogTG9hZHMgdGhlIGxlZ2FjeSBwYWxldHRlL2dhbW1hIHVuaXQg Zm9yIHRoZSBDUlRDIG9uIEhhc3dlbGwuICovCj4gQEAgLTMyMyw3ICszMjYsNyBAQCBzdGF0aWMg dm9pZCBoYXN3ZWxsX2xvYWRfbHV0cyhzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGUp Cj4gIAkgKiBXb3JrYXJvdW5kIDogRG8gbm90IHJlYWQgb3Igd3JpdGUgdGhlIHBpcGUgcGFsZXR0 ZS9nYW1tYSBkYXRhIHdoaWxlCj4gIAkgKiBHQU1NQV9NT0RFIGlzIGNvbmZpZ3VyZWQgZm9yIHNw bGl0IGdhbW1hIGFuZCBJUFNfQ1RMIGhhcyBJUFMgZW5hYmxlZC4KPiAgCSAqLwo+IC0JaWYgKElT X0hBU1dFTEwoZGV2KSAmJiBpbnRlbF9jcnRjLT5jb25maWctPmlwc19lbmFibGVkICYmCj4gKwlp ZiAoSVNfSEFTV0VMTChkZXYpICYmIGludGVsX2NydGNfc3RhdGUtPmlwc19lbmFibGVkICYmCj4g IAkgICAgKGludGVsX2NydGNfc3RhdGUtPmdhbW1hX21vZGUgPT0gR0FNTUFfTU9ERV9NT0RFX1NQ TElUKSkgewo+ICAJCWhzd19kaXNhYmxlX2lwcyhpbnRlbF9jcnRjKTsKPiAgCQlyZWVuYWJsZV9p cHMgPSB0cnVlOwo+IEBAIC00MzYsNyArNDM5LDggQEAgc3RhdGljIHZvaWQgY2hlcnJ5dmlld19s b2FkX2x1dHMoc3RydWN0IGRybV9jcnRjX3N0YXRlICpzdGF0ZSkKPiAgCQkvKiBUdXJuIG9mZiBk ZWdhbW1hL2dhbW1hIG9uIENHTSBibG9jay4gKi8KPiAgCQlJOTE1X1dSSVRFKENHTV9QSVBFX01P REUocGlwZSksCj4gIAkJCSAgIChzdGF0ZS0+Y3RtID8gQ0dNX1BJUEVfTU9ERV9DU0MgOiAwKSk7 Cj4gLQkJaTl4eF9sb2FkX2x1dHNfaW50ZXJuYWwoY3J0Yywgc3RhdGUtPmdhbW1hX2x1dCk7Cj4g KwkJaTl4eF9sb2FkX2x1dHNfaW50ZXJuYWwoY3J0Yywgc3RhdGUtPmdhbW1hX2x1dCwKPiArCQkJ CQl0b19pbnRlbF9jcnRjX3N0YXRlKHN0YXRlKSk7Cj4gIAkJcmV0dXJuOwo+ICAJfQo+ICAKPiBA QCAtNDc5LDcgKzQ4Myw3IEBAIHN0YXRpYyB2b2lkIGNoZXJyeXZpZXdfbG9hZF9sdXRzKHN0cnVj dCBkcm1fY3J0Y19zdGF0ZSAqc3RhdGUpCj4gIAkgKiBBbHNvIHByb2dyYW0gYSBsaW5lYXIgTFVU IGluIHRoZSBsZWdhY3kgYmxvY2sgKGJlaGluZCB0aGUKPiAgCSAqIENHTSBibG9jaykuCj4gIAkg Ki8KPiAtCWk5eHhfbG9hZF9sdXRzX2ludGVybmFsKGNydGMsIE5VTEwpOwo+ICsJaTl4eF9sb2Fk X2x1dHNfaW50ZXJuYWwoY3J0YywgTlVMTCwgdG9faW50ZWxfY3J0Y19zdGF0ZShzdGF0ZSkpOwo+ ICB9Cj4gIAo+ICB2b2lkIGludGVsX2NvbG9yX2xvYWRfbHV0cyhzdHJ1Y3QgZHJtX2NydGNfc3Rh dGUgKmNydGNfc3RhdGUpCj4gLS0gCj4gMi43LjQKPiAKPiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJl IEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK