Re: [REBASED PATCH RESEND 0/5 v2] Various cleanup

Chris Wilson
2016-08-22T10:38:06Z

On Mon, Aug 22, 2016 at 01:32:40PM +0300, David Weinehall wrote:
> This patch series aims to do some cleanup of our driver.
> Patch 1, 2, and 4 should be fairly non-controversial.
> Patch 3 and 5 does major cleanups of i915_sysfs and i915_debugfs,
> respectively. Due to the nature of these patches they are rather
> big, but that's mainly because they change the parameter passed
> to macros that are used a lot.
>
> While the secondary benefits of this patch series (the primary
> of course being slightly cleaner code) might be a bit opaque,
> a move to always passing dev_priv to our feature macros
> (and thus allowing us to make those macros non-polymorphic)
> will save more than 30kB.
>
> That's still a bit down the road though, but I've got a full
> patch series to accomplish this in a fairly straightforward
> manner.
>
> Resend: mailing list issues
>
> David Weinehall (5):
> drm/i915: cosmetic fixes to i915_drv.h
> drm/i915: consistent struct device naming
> drm/i915: i915_sysfs.c cleanup
> drm/i915: pdev cleanup
> drm/i915: debugfs spring cleaning

I'm happy with this set. Being debugfs/sysfs should be unlikely to upset
too many people due to conflicts (and what there are should be trivial).

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

--
Chris Wilson, Intel Open Source Technology Centre