From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 9/9] drm/i915/gen9: fail the modeset instead of WARNing on unsuported config
Date: Thu, 15 Sep 2016 15:15:16 +0300 [thread overview]
Message-ID: <20160915121516.GR4329@intel.com> (raw)
In-Reply-To: <1473813502-16844-10-git-send-email-paulo.r.zanoni@intel.com>
On Tue, Sep 13, 2016 at 09:38:22PM -0300, Paulo Zanoni wrote:
> Now that this code is part of the compute stage we can return -EINVAL
> to prevent the modeset instead of giving a WARN and trying anyway.
>
> Reported-by: Lyude <cpaul@redhat.com>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 9edc8ce..6394db7 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3589,11 +3589,11 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv,
> case 2:
> y_min_scanlines = 8;
> break;
> - default:
> - WARN(1, "Unsupported pixel depth for rotation");
> case 4:
> y_min_scanlines = 4;
> break;
> + default:
> + return -EINVAL;
Considering this should never happen, MISSING_CASE() would be the
appropriate choice here.
> }
> } else {
> y_min_scanlines = 4;
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-09-15 12:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 0:38 [PATCH 0/9] SKL/KBL watermark fixes, v2 Paulo Zanoni
2016-09-14 0:38 ` [PATCH 1/9] drm/i915: SAGV is not SKL-only, so rename a few things Paulo Zanoni
2016-09-14 0:38 ` [PATCH 2/9] drm/i915: introduce intel_has_sagv() Paulo Zanoni
2016-09-14 0:38 ` [PATCH 3/9] drm/i915/kbl: KBL also needs to run the SAGV code Paulo Zanoni
2016-09-14 0:38 ` [PATCH 4/9] drm/i915/gen9: fix the WaWmMemoryReadLatency implementation Paulo Zanoni
2016-09-14 0:38 ` [PATCH 5/9] drm/i915/gen9: minimum scanlines for Y tile is not always 4 Paulo Zanoni
2016-09-15 12:37 ` Maarten Lankhorst
2016-09-14 0:38 ` [PATCH 6/9] drm/i915/gen9: fix plane_blocks_per_line on watermarks calculations Paulo Zanoni
2016-09-14 0:38 ` [PATCH 7/9] drm/i915/gen9: fix the watermark res_blocks value Paulo Zanoni
2016-09-14 0:38 ` [PATCH 8/9] drm/i915/gen9: implement missing case for SKL watermarks calculation Paulo Zanoni
2016-09-14 0:38 ` [PATCH 9/9] drm/i915/gen9: fail the modeset instead of WARNing on unsuported config Paulo Zanoni
2016-09-15 12:15 ` Ville Syrjälä [this message]
2016-09-14 5:38 ` ✗ Fi.CI.BAT: failure for SKL/KBL watermark fixes (rev2) Patchwork
2016-09-14 9:34 ` [PATCH 0/9] SKL/KBL watermark fixes, v2 Jani Nikula
2016-09-14 13:25 ` Zanoni, Paulo R
2016-09-15 9:29 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160915121516.GR4329@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).