intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: robert.foss@collabora.com
To: intel-gfx@lists.freedesktop.org,
	Gustavo Padovan <gustavo.padovan@collabora.com>,
	Daniel Stone <daniels@collabora.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	Marius Vlad <marius.c.vlad@intel.com>,
	Eric Engestrom <eric@engestrom.ch>,
	Chris Wilson <chris@chris-wilson.co.uk>
Subject: [PATCH i-g-t v5 08/13] tests/sw_sync: Add subtest test_sync_merge_same
Date: Thu, 15 Sep 2016 14:40:13 -0400	[thread overview]
Message-ID: <20160915184018.9218-9-robert.foss@collabora.com> (raw)
In-Reply-To: <20160915184018.9218-1-robert.foss@collabora.com>

From: Robert Foss <robert.foss@collabora.com>

This subtest verifies merging a fence with itself does not fail.

Signed-off-by: Robert Foss <robert.foss@collabora.com>
Reviewed-by: Eric Engestrom <eric@engestrom.ch>
---
 tests/sw_sync.c | 37 ++++++++++++++++++++++++++++++++-----
 1 file changed, 32 insertions(+), 5 deletions(-)

diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index 26226bd..ff87cfe 100644
--- a/tests/sw_sync.c
+++ b/tests/sw_sync.c
@@ -173,11 +173,35 @@ static void test_sync_merge(void)
 	igt_assert_f(active == 0 && signaled == 1,
 		     "fence_merge did not signal\n");
 
-	sw_sync_fence_destroy(in_fence[0]);
-	sw_sync_fence_destroy(in_fence[1]);
-	sw_sync_fence_destroy(in_fence[2]);
-	sw_sync_fence_destroy(fence_merge);
-	sw_sync_timeline_destroy(timeline);
+	close(in_fence[0]);
+	close(in_fence[1]);
+	close(in_fence[2]);
+	close(fence_merge);
+	close(timeline);
+}
+
+static void test_sync_merge_same(void)
+{
+	int in_fence[2];
+	int timeline;
+	int signaled;
+
+	timeline = sw_sync_timeline_create();
+	in_fence[0] = sw_sync_fence_create(timeline, 1);
+	in_fence[1] = sw_sync_merge(in_fence[0], in_fence[0]);
+
+	signaled = sw_sync_fence_count_status(in_fence[0],
+					      SW_SYNC_FENCE_STATUS_SIGNALED);
+	igt_assert_f(signaled == 0, "fence signaled too early\n");
+
+	sw_sync_timeline_inc(timeline, 1);
+	signaled = sw_sync_fence_count_status(in_fence[0],
+					      SW_SYNC_FENCE_STATUS_SIGNALED);
+	igt_assert_f(signaled == 1, "fence did not signal\n");
+
+	close(in_fence[0]);
+	close(in_fence[1]);
+	close(timeline);
 }
 
 igt_main
@@ -199,5 +223,8 @@ igt_main
 
 	igt_subtest("sync_merge")
 		test_sync_merge();
+
+	igt_subtest("sync_merge_same")
+		test_sync_merge_same();
 }
 
-- 
2.9.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2016-09-15 18:40 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15 18:40 [PATCH i-g-t v5 00/13] Implement sw_sync test robert.foss
2016-09-15 18:40 ` [PATCH i-g-t v5 01/13] lib/sw_sync: Add helper functions for managing synchronization primitives robert.foss
2016-09-15 20:12   ` Chris Wilson
2016-09-15 18:40 ` [PATCH i-g-t v5 02/13] tests/sw_sync: Add sw_sync test robert.foss
2016-09-15 20:22   ` Chris Wilson
2016-09-15 21:05     ` Robert Foss
2016-09-16 10:47       ` Chris Wilson
2016-09-15 18:40 ` [PATCH i-g-t v5 03/13] tests/sw_sync: Add subtest test_alloc_fence robert.foss
2016-09-15 18:40 ` [PATCH i-g-t v5 04/13] tests/sw_sync: Add subtest test_alloc_fence_invalid_timeline robert.foss
2016-09-15 18:40 ` [PATCH i-g-t v5 05/13] tests/sw_sync: Add subtest test_alloc_merge_fence robert.foss
2016-09-15 18:40 ` [PATCH i-g-t v5 06/13] tests/sw_sync: Add subtest test_sync_wait robert.foss
2016-09-15 20:32   ` Chris Wilson
2016-09-15 22:25     ` Robert Foss
2016-09-16 10:36       ` Chris Wilson
2016-09-15 20:45   ` Chris Wilson
2016-09-15 18:40 ` [PATCH i-g-t v5 07/13] tests/sw_sync: Add subtest test_sync_merge robert.foss
2016-09-15 20:41   ` Chris Wilson
2016-09-16  0:27     ` Robert Foss
2016-09-16  8:21       ` Chris Wilson
2016-09-15 18:40 ` robert.foss [this message]
2016-09-15 18:40 ` [PATCH i-g-t v5 09/13] tests/sw_sync: Add subtest test_sync_multi_consumer robert.foss
2016-09-15 18:40 ` [PATCH i-g-t v5 10/13] tests/sw_sync: Add subtest test_sync_multi_consumer_producer robert.foss
2016-09-15 18:40 ` [PATCH i-g-t v5 11/13] tests/sw_sync: Add subtest test_sync_random_merge robert.foss
2016-09-15 18:40 ` [PATCH i-g-t v5 12/13] tests/sw_sync: Add subtest test_sync_multi_timeline_wait robert.foss
2016-09-15 18:40 ` [PATCH i-g-t v5 13/13] tests/sw_sync: Add subtest test_sync_multi_producer_single_consumer robert.foss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160915184018.9218-9-robert.foss@collabora.com \
    --to=robert.foss@collabora.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel@ffwll.ch \
    --cc=daniels@collabora.com \
    --cc=eric@engestrom.ch \
    --cc=gustavo.padovan@collabora.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=marius.c.vlad@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).