From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 3/3] drm/vgem: Keep a reference to the dmabuf when mmaped Date: Wed, 5 Oct 2016 15:11:00 +0200 Message-ID: <20161005131100.GA20761@phenom.ffwll.local> References: <20160930135959.9159-1-chris@chris-wilson.co.uk> <20160930135959.9159-3-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 330FC6E85B for ; Wed, 5 Oct 2016 13:11:04 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id b201so19365375wmb.1 for ; Wed, 05 Oct 2016 06:11:04 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160930135959.9159-3-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBTZXAgMzAsIDIwMTYgYXQgMDI6NTk6NTlQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IEluIG9yZGVyIHRvIGtlZXAgdGhlIGRtYWJ1ZiBhbGl2ZSB3aGlsc3QgdGhlIG1tYXAg aXMsIHdlIG5lZWQgdG8gaG9sZCBhCj4gcmVmZXJlbmNlIHRvIHRoZSBkbWFidWYgYW5kIG5vdCB0 aGUgYmFja2luZyBvYmplY3QuIFRoaXMgaXMgaW1wb3J0YW50IGFzCj4gdGhlIGRtYWJ1ZiBub3Qg b25seSBrZWVwcyB0aGUgb2JqZWN0IGFsaXZlLCBidXQgYWxzbyB0aGUgZGV2aWNlIHNvIHRoYXQK PiAKPiAJZG1hYnVmID0gdmdlbV9jcmVhdGVfZG1hYnVmKCk7Cj4gCXB0ciA9IG1tYXAoLi4uIGRt YWJ1ZiAuLi4pOwo+IAljbG9zZShkbWFidWYpOwo+IAo+IHBlcnNpc3RzIGFjcm9zcyBtb2R1bGUt dW5sb2FkIGFzIHdlbGwgYXMgZGV2aWNlIGNsb3N1cmUuCgpJIGRvbid0IHNlZSB3aGVyZSB3ZSBn cmFiIHRoZSByZWYgdG8gdGhlIGRtYS1idWYgaGVyZSBpbnN0ZWFkIG9mIHRoZQpiYWNraW5nIHN0 b3JhZ2UuIEFuZCBkb2Vzbid0IHRoZSBleGFjdCBzYW1lIGlzc3VlIGhhcHBlbiB3aGVuIHlvdSB1 c2UgZHVtYgptbWFwPyBPciBtYXliZSBJJ20ganVzdCBhIGJpdCBjb25mdXNlZCBhYm91dCB3aGF0 J3MgZ29pbmcgb24gaGVyZSAuLi4KLURhbmllbAoKPiAKPiBUZXN0Y2FzZTogaWd0L3ZnZW1fYmFz aWMvdW5sb2FkCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxz b24uY28udWs+Cj4gQ2M6IFBldHJpIExhdHZhbGEgPHBldHJpLmxhdHZhbGFAaW50ZWwuY29tPgo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vdmdlbS92Z2VtX2Rydi5jIHwgMTcgKysrLS0tLS0tLS0t LS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS92Z2VtL3ZnZW1fZHJ2LmMgYi9kcml2 ZXJzL2dwdS9kcm0vdmdlbS92Z2VtX2Rydi5jCj4gaW5kZXggZjM2YzE0NzI5YjU1Li43NGE4M2U0 MWVmYTkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3ZnZW0vdmdlbV9kcnYuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS92Z2VtL3ZnZW1fZHJ2LmMKPiBAQCAtMTk4LDcgKzE5OCw2IEBA IHN0YXRpYyBzdHJ1Y3QgZHJtX2lvY3RsX2Rlc2MgdmdlbV9pb2N0bHNbXSA9IHsKPiAgCj4gIHN0 YXRpYyBpbnQgdmdlbV9tbWFwKHN0cnVjdCBmaWxlICpmaWxwLCBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1 Y3QgKnZtYSkKPiAgewo+IC0JdW5zaWduZWQgbG9uZyBmbGFncyA9IHZtYS0+dm1fZmxhZ3M7Cj4g IAlpbnQgcmV0Owo+ICAKPiAgCXJldCA9IGRybV9nZW1fbW1hcChmaWxwLCB2bWEpOwo+IEBAIC0y MDgsNyArMjA3LDcgQEAgc3RhdGljIGludCB2Z2VtX21tYXAoc3RydWN0IGZpbGUgKmZpbHAsIHN0 cnVjdCB2bV9hcmVhX3N0cnVjdCAqdm1hKQo+ICAJLyogS2VlcCB0aGUgV0MgbW1hcGluZyBzZXQg YnkgZHJtX2dlbV9tbWFwKCkgYnV0IG91ciBwYWdlcwo+ICAJICogYXJlIG9yZGluYXJ5IGFuZCBu b3Qgc3BlY2lhbC4KPiAgCSAqLwo+IC0Jdm1hLT52bV9mbGFncyA9IGZsYWdzIHwgVk1fRE9OVEVY UEFORCB8IFZNX0RPTlREVU1QOwo+ICsJdm1hLT52bV9mbGFncyAmPSB+KFZNX0lPIHwgVk1fUEZO TUFQKTsKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+IEBAIC0yODEsMjEgKzI4MCwxMSBAQCBzdGF0 aWMgaW50IHZnZW1fcHJpbWVfbW1hcChzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iaiwKPiAgewo+ ICAJaW50IHJldDsKPiAgCj4gLQlpZiAob2JqLT5zaXplIDwgdm1hLT52bV9lbmQgLSB2bWEtPnZt X3N0YXJ0KQo+IC0JCXJldHVybiAtRUlOVkFMOwo+IC0KPiAtCWlmICghb2JqLT5maWxwKQo+IC0J CXJldHVybiAtRU5PREVWOwo+IC0KPiAtCXJldCA9IG9iai0+ZmlscC0+Zl9vcC0+bW1hcChvYmot PmZpbHAsIHZtYSk7Cj4gKwlyZXQgPSBkcm1fZ2VtX21tYXBfb2JqKG9iaiwgb2JqLT5zaXplLCB2 bWEpOwo+ICAJaWYgKHJldCkKPiAgCQlyZXR1cm4gcmV0Owo+ICAKPiAtCWZwdXQodm1hLT52bV9m aWxlKTsKPiAtCXZtYS0+dm1fZmlsZSA9IGdldF9maWxlKG9iai0+ZmlscCk7Cj4gLQl2bWEtPnZt X2ZsYWdzIHw9IFZNX0RPTlRFWFBBTkQgfCBWTV9ET05URFVNUDsKPiAtCXZtYS0+dm1fcGFnZV9w cm90ID0gcGdwcm90X3dyaXRlY29tYmluZSh2bV9nZXRfcGFnZV9wcm90KHZtYS0+dm1fZmxhZ3Mp KTsKPiAtCj4gKwl2bWEtPnZtX2ZsYWdzICY9IH4oVk1fSU8gfCBWTV9QRk5NQVApOwo+ICAJcmV0 dXJuIDA7Cj4gIH0KPiAgCj4gLS0gCj4gMi45LjMKPiAKPiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJl IEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK