From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 2/5] tests: Leave basic breadcrumbs in dmesg for shell script based tests
Date: Fri, 7 Oct 2016 13:06:08 +0300 [thread overview]
Message-ID: <20161007100608.GU4329@intel.com> (raw)
In-Reply-To: <87wphkwrig.fsf@intel.com>
On Fri, Oct 07, 2016 at 10:24:39AM +0300, Jani Nikula wrote:
> On Thu, 06 Oct 2016, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Leave the normal "executing" and "exiting" breadcrumbs into dmesg when
> > running the test.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > tests/drm_lib.sh | 24 ++++++++++++++++++++++++
> > 1 file changed, 24 insertions(+)
> >
> > diff --git a/tests/drm_lib.sh b/tests/drm_lib.sh
> > index 0eeab1c183c9..456040e1971f 100755
> > --- a/tests/drm_lib.sh
> > +++ b/tests/drm_lib.sh
> > @@ -3,6 +3,30 @@
> > SOURCE_DIR="$( dirname "${BASH_SOURCE[0]}" )"
> > . $SOURCE_DIR/drm_getopt.sh
> >
> > +NAME=$(basename "$0")
> > +
> > +KERN_EMER="<0>"
> > +KERN_ALERT="<1>"
> > +KERN_CRIT="<2>"
> > +KERN_ERR="<3>"
> > +KERN_WARNING="<4>"
> > +KERN_NOTICE="<5>"
> > +KERN_INFO="<6>"
> > +KERN_DEBUG="<7>"
> > +
> > +kmsg() {
> > + echo "$1" > /dev/kmsg
>
> If you make that echo "$@", it'll all end up in kmsg even if someone
> accidentally uses more than one parameter. But no big deal.
Changed it, and pushed the lot.
>
> BR,
> Jani.
>
> > +}
> > +
> > +finish() {
> > + exitcode=$?
> > + kmsg "$KERN_INFO$NAME: exiting, ret=$exitcode"
> > + exit $exitcode
> > +}
> > +trap finish EXIT
> > +
> > +kmsg "$KERN_INFO$NAME: executing"
> > +
> > skip() {
> > echo "$@"
> > exit $IGT_EXIT_SKIP
>
> --
> Jani Nikula, Intel Open Source Technology Center
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-07 10:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 13:36 [PATCH i-g-t 1/5] tests: Use bash for debugfs_wedged and drm_lib.sh ville.syrjala
2016-10-06 13:36 ` [PATCH i-g-t 2/5] tests: Leave basic breadcrumbs in dmesg for shell script based tests ville.syrjala
2016-10-07 7:24 ` Jani Nikula
2016-10-07 10:06 ` Ville Syrjälä [this message]
2016-10-06 13:36 ` [PATCH i-g-t 3/5] tests/vgem_reload_basic: Leave breadcrumbs in dmesg ville.syrjala
2016-10-06 13:36 ` [PATCH i-g-t 4/5] tests/tools_test: Fix it up for intel_reg ville.syrjala
2016-10-06 13:36 ` [PATCH i-g-t 5/5] tools/intel_reg: Return SUCCESS after a succesful dump ville.syrjala
2016-10-07 7:15 ` [PATCH i-g-t 1/5] tests: Use bash for debugfs_wedged and drm_lib.sh Joonas Lahtinen
2016-10-07 7:38 ` Jani Nikula
2016-10-07 9:54 ` Joonas Lahtinen
2016-10-12 10:12 ` David Weinehall
2016-10-12 11:05 ` Joonas Lahtinen
2016-10-12 11:16 ` Jani Nikula
2016-10-12 11:29 ` Joonas Lahtinen
2016-10-12 13:04 ` Jani Nikula
2016-10-12 13:17 ` David Weinehall
2016-10-13 14:05 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161007100608.GU4329@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox